918f987a19
* feat(#2982): extend no-source-grep lint to catch var-binding readFileSync.includes() The base lint (scripts/lint-no-source-grep.cjs) only catches readFileSync(...).<text-method>() chained directly. The much more common var-binding form escapes it: const src = fs.readFileSync(p, 'utf8'); // 50 lines later if (src.includes('foo')) {} // ← still grep, lint missed it Scan of the test suite found ~141 files using this pattern. Implementation built TDD per #2982 with structured-IR assertions: scripts/lint-no-source-grep-extras.cjs - detectVarBindingViolations(src) — pure detector, two passes: pass 1 collects vars bound from readFileSync, pass 2 finds any <var>.<includes|startsWith|endsWith|match|search>( on those vars. - detectWrappedAssertOkMatch(src) — flags assert.ok(<expr>.match(...)) which escapes the assert.match rule. - VIOLATION enum exposes stable codes for tests to assert on. scripts/lint-no-source-grep.cjs - Wires the new detectors into the existing per-file check; one additional violation row per file with the first 3 sample tokens. tests/bug-2982-lint-var-binding.test.cjs - 13 tests, all assertions on typed VIOLATION enum / structured records. Covers all 5 text-match methods, multi-var, no-bind, string literal (must NOT trigger), wrapped assert.ok(.match), and assert.match (must NOT double-flag). Migration backlog (#2974 expanded scope): - 42 files annotated `// allow-test-rule: source-text-is-the-product` (legitimate — they read .md/.json/.yml files whose deployed text IS the product) - 3 files annotated `// allow-test-rule: pending-migration-to-typed-ir [#2974]` (read .cjs/.js source — clear migration debt) - 95 files annotated `pending-migration-to-typed-ir [#2974]` with `Per-file review may reclassify as source-text-is-the-product during migration` (mixed — manual review under #2974) After this lands the lint reports 0 violations on main; new violations in PRs surface immediately. Closes #2982 Refs #2974 * test(#2982): fix truncated test name per CR The label ended with a bare '(' from a copy-paste mishap. Now reads 'does NOT flag .matchAll(...) — matchAll is not match, so assert.ok(.matchAll(...)) is not flagged'. * chore(#2982): add changeset fragment for PR #2985 * chore(#2982): add changeset fragment for PR #2985
66 lines
2.5 KiB
JavaScript
66 lines
2.5 KiB
JavaScript
// allow-test-rule: pending-migration-to-typed-ir [#2974]
|
|
// Tracked in #2974 for migration to typed-IR assertions per CONTRIBUTING.md
|
|
// "Prohibited: Raw Text Matching on Test Outputs". Per-file review may
|
|
// reclassify some entries as source-text-is-the-product during migration.
|
|
|
|
/**
|
|
* GSD Tools Tests - Seed Scan in New Milestone (#2169)
|
|
*
|
|
* Structural tests verifying that new-milestone.md includes seed scanning
|
|
* instructions (step 2.5) and that plant-seed.md still promises auto-surfacing.
|
|
*/
|
|
|
|
const { describe, test } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('node:fs');
|
|
const path = require('node:path');
|
|
|
|
const ROOT = path.join(__dirname, '..');
|
|
const NEW_MILESTONE_PATH = path.join(ROOT, 'get-shit-done', 'workflows', 'new-milestone.md');
|
|
const PLANT_SEED_PATH = path.join(ROOT, 'get-shit-done', 'workflows', 'plant-seed.md');
|
|
|
|
const newMilestone = fs.readFileSync(NEW_MILESTONE_PATH, 'utf-8');
|
|
const plantSeed = fs.readFileSync(PLANT_SEED_PATH, 'utf-8');
|
|
|
|
describe('seed scanning in new-milestone workflow (#2169)', () => {
|
|
test('new-milestone.md mentions seed scanning', () => {
|
|
assert.ok(
|
|
newMilestone.includes('.planning/seeds/'),
|
|
'new-milestone.md should contain instructions about scanning .planning/seeds/'
|
|
);
|
|
assert.ok(
|
|
newMilestone.includes('SEED-*.md'),
|
|
'new-milestone.md should reference the SEED-*.md file pattern'
|
|
);
|
|
});
|
|
|
|
test('new-milestone.md handles no-seeds case', () => {
|
|
assert.ok(
|
|
/no seed files exist.*skip/i.test(newMilestone),
|
|
'new-milestone.md should mention skipping when no seed files exist'
|
|
);
|
|
});
|
|
|
|
test('new-milestone.md handles auto-mode for seeds', () => {
|
|
assert.ok(
|
|
newMilestone.includes('--auto'),
|
|
'new-milestone.md should mention --auto mode in the seed scanning step'
|
|
);
|
|
assert.ok(
|
|
/auto.*select.*all.*matching.*seed/i.test(newMilestone),
|
|
'new-milestone.md should instruct auto-selecting all matching seeds in --auto mode'
|
|
);
|
|
});
|
|
|
|
test('plant-seed.md still promises auto-surfacing during new-milestone', () => {
|
|
assert.ok(
|
|
plantSeed.includes('new-milestone'),
|
|
'plant-seed.md should reference new-milestone as the surfacing mechanism for seeds'
|
|
);
|
|
assert.ok(
|
|
/auto.surface/i.test(plantSeed) || /auto-surface/i.test(plantSeed) || /auto.present/i.test(plantSeed) || /auto-present/i.test(plantSeed),
|
|
'plant-seed.md should describe seeds as auto-surfacing or auto-presenting'
|
|
);
|
|
});
|
|
});
|