8a5166598c
* fix(#4830): re-land #4768's letter-suffix phase-id fix and its lint-phase-id-drift ratchets on current next Commit740ba0d8a(#4781) removed every change #4768 had merged for #4748: the first-non-digit split at execute-phase.md's two arithmetic sites, the init-emitted `padded_phase` the REVIEW.md lookup binds instead of `printf "%02d"`, the canonical-grammar extractions in autonomous.md and plan-review-convergence.md, the `.changeset/zesty-wolves-tumble.md` fragment, and the three lint-phase-id-drift ratchets with their tests. The guard and the code it guarded left together, so nothing went red. This is a cherry-pick of092d9256bonto current `next`, resolved against the #4683 threat-id fields on execute-phase.md's Parse-JSON line, with the changeset `pr:` reset to the placeholder and the compact-content benchmark baseline regenerated against the current base. (cherry picked from commit092d9256b8) Emitted-Drift-Ack-Growth: autonomous.md — restores #4768's canonical-grammar extraction and its explanatory comment for --from/--to/--only Emitted-Drift-Ack-Growth: execute-phase.md — restores #4768's first-non-digit split at two arithmetic sites and the padded_phase binding for the REVIEW.md lookup Emitted-Drift-Ack-Growth: plan-review-convergence.md — restores #4768's canonical-grammar phase extraction and its comment Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AX7LXxc3uAkGki6iaYiAMP * chore(#4830): set changeset fragment pr to 4873 --------- Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com> Co-authored-by: Tom Boucher <trekkie@nomorestars.com>
967 B
type, pr
| type | pr |
|---|---|
| Fixed | 4873 |
/gsd-execute-phase, /gsd-autonomous --from|--to|--only, /gsd-plan-review-convergence and the TDD plan path now handle letter-variant phase ids (12A, 3A, 23A.1.2) — seven shell sites outside #4660's six still assumed a phase number was digits-and-dots: the post-#4619 $((10#$PHASE_INT)) split aborted bash on 03A, the review-file lookup's printf "%02d" printed the wrong file (and read an already-padded 08 as octal), and the --from/--to/--only and plan-review-convergence extractions silently truncated 12A to 12 (and 23.1.2 to 23.1). The split now stops at the first non-digit, init execute-phase emits padded_phase for the lookup, the extractions use the canonical grammar, the legacy normalizer pads a letter id, a parity test drives every site's live shell against a letter-suffixed fixture, and lint-phase-id-drift gains three ratchets so none of the shapes can return silently. (#4748)