918f987a19
* feat(#2982): extend no-source-grep lint to catch var-binding readFileSync.includes() The base lint (scripts/lint-no-source-grep.cjs) only catches readFileSync(...).<text-method>() chained directly. The much more common var-binding form escapes it: const src = fs.readFileSync(p, 'utf8'); // 50 lines later if (src.includes('foo')) {} // ← still grep, lint missed it Scan of the test suite found ~141 files using this pattern. Implementation built TDD per #2982 with structured-IR assertions: scripts/lint-no-source-grep-extras.cjs - detectVarBindingViolations(src) — pure detector, two passes: pass 1 collects vars bound from readFileSync, pass 2 finds any <var>.<includes|startsWith|endsWith|match|search>( on those vars. - detectWrappedAssertOkMatch(src) — flags assert.ok(<expr>.match(...)) which escapes the assert.match rule. - VIOLATION enum exposes stable codes for tests to assert on. scripts/lint-no-source-grep.cjs - Wires the new detectors into the existing per-file check; one additional violation row per file with the first 3 sample tokens. tests/bug-2982-lint-var-binding.test.cjs - 13 tests, all assertions on typed VIOLATION enum / structured records. Covers all 5 text-match methods, multi-var, no-bind, string literal (must NOT trigger), wrapped assert.ok(.match), and assert.match (must NOT double-flag). Migration backlog (#2974 expanded scope): - 42 files annotated `// allow-test-rule: source-text-is-the-product` (legitimate — they read .md/.json/.yml files whose deployed text IS the product) - 3 files annotated `// allow-test-rule: pending-migration-to-typed-ir [#2974]` (read .cjs/.js source — clear migration debt) - 95 files annotated `pending-migration-to-typed-ir [#2974]` with `Per-file review may reclassify as source-text-is-the-product during migration` (mixed — manual review under #2974) After this lands the lint reports 0 violations on main; new violations in PRs surface immediately. Closes #2982 Refs #2974 * test(#2982): fix truncated test name per CR The label ended with a bare '(' from a copy-paste mishap. Now reads 'does NOT flag .matchAll(...) — matchAll is not match, so assert.ok(.matchAll(...)) is not flagged'. * chore(#2982): add changeset fragment for PR #2985 * chore(#2982): add changeset fragment for PR #2985
68 lines
2.7 KiB
JavaScript
68 lines
2.7 KiB
JavaScript
// allow-test-rule: pending-migration-to-typed-ir [#2974]
|
|
// Tracked in #2974 for migration to typed-IR assertions per CONTRIBUTING.md
|
|
// "Prohibited: Raw Text Matching on Test Outputs". Per-file review may
|
|
// reclassify some entries as source-text-is-the-product during migration.
|
|
|
|
/**
|
|
* Regression test for #2502: insert-phase does not update STATE.md's
|
|
* next-phase recommendation after inserting a decimal phase.
|
|
*
|
|
* Root cause: insert-phase.md's update_project_state step only added a
|
|
* "Roadmap Evolution" note to STATE.md, but never updated the "Current Phase"
|
|
* / next-run recommendation to point at the newly inserted phase.
|
|
*
|
|
* Fix: insert-phase.md must include a step that updates STATE.md's next-phase
|
|
* pointer (current_phase / next recommended run) to the newly inserted phase.
|
|
*/
|
|
|
|
'use strict';
|
|
|
|
const { describe, test } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
|
|
const INSERT_PHASE_PATH = path.join(
|
|
__dirname, '..', 'get-shit-done', 'workflows', 'insert-phase.md'
|
|
);
|
|
|
|
describe('bug-2502: insert-phase must update STATE.md next-phase recommendation', () => {
|
|
test('insert-phase.md exists', () => {
|
|
assert.ok(fs.existsSync(INSERT_PHASE_PATH), 'insert-phase.md should exist');
|
|
});
|
|
|
|
test('insert-phase.md contains a STATE.md next-phase update instruction', () => {
|
|
const content = fs.readFileSync(INSERT_PHASE_PATH, 'utf-8');
|
|
|
|
// Must reference STATE.md and the concept of updating the next/current phase pointer
|
|
const mentionsStateUpdate = (
|
|
/STATE\.md.{0,200}(next.phase|current.phase|next.run|recommendation)/is.test(content) ||
|
|
/(next.phase|current.phase|next.run|recommendation).{0,200}STATE\.md/is.test(content)
|
|
);
|
|
|
|
assert.ok(
|
|
mentionsStateUpdate,
|
|
'insert-phase.md must instruct updating STATE.md\'s next-phase recommendation to point to the newly inserted phase'
|
|
);
|
|
});
|
|
|
|
test('insert-phase.md update_project_state step covers next-phase pointer', () => {
|
|
const content = fs.readFileSync(INSERT_PHASE_PATH, 'utf-8');
|
|
|
|
const stepMatch = content.match(/<step name="update_project_state">([\s\S]*?)<\/step>/i);
|
|
assert.ok(stepMatch, 'insert-phase.md must contain update_project_state step');
|
|
const stepContent = stepMatch[1];
|
|
|
|
const hasNextPhasePointerUpdate = (
|
|
/\bcurrent[_ -]?phase\b/i.test(stepContent) ||
|
|
/\bnext[_ -]?phase\b/i.test(stepContent) ||
|
|
/\bnext recommended run\b/i.test(stepContent)
|
|
);
|
|
|
|
assert.ok(
|
|
hasNextPhasePointerUpdate,
|
|
'insert-phase.md update_project_state step must update STATE.md\'s next-phase pointer (current_phase) to the inserted decimal phase'
|
|
);
|
|
});
|
|
});
|