* test(#3338): fold the verify/validate & workflow-text issue-* cluster — Wave 6
Folds 10 legacy issue-*.test.cjs regression files (75 test() blocks) into
their module's main suite, per H3 (#3315) of the test-hygiene epic (#3053).
Third of 4 issue-* waves.
- issue-2701-nul-corrupted-validators.test.cjs (9) + issue-429-comment-
text-gate.test.cjs (31, incl. fast-check property tests): both target
verify.cjs/validate.cjs via different calling styles (CLI vs direct-
require) — merged jointly into verify.test.cjs, 0 dropped.
- issue-2762-plan-reviews-chunked.test.cjs (3) merged into
plan-phase-drift-guard.test.cjs.
- issue-2771-advisor-subagent-type.test.cjs (1) + issue-2772-discuss-
phase-text-inconsistencies.test.cjs (6) merged jointly into
discuss-phase-power.test.cjs.
- issue-498-update-backup-runtime-dir.test.cjs (3, rename basis) +
issue-815-update-next-channel.test.cjs (7, merged in): both concern
update.md workflow-text contracts, now update-workflow.test.cjs.
- issue-498-update-context.test.cjs (13): pure rename to
update-context.test.cjs, sole comprehensive suite for its module.
- issue-2765-brace-expansion-lockfile.test.cjs (1, rename basis) +
issue-3238-js-yaml-lockfile.test.cjs (1, merged in): two distinct CVE
regression pins against package-lock.json, now lockfile-cve-audit.test.cjs,
shared ROOT/npmLs helpers deduped instead of double-declared.
Ratchet upkeep to keep this wave's own gates green: pruned 3 stale
allow-test-rule allowlist entries, cited 2 previously-uncited comments
that surfaced in the folded content (#3338), tightened the exemption-file
ceiling 305 -> 297. Fixed one stale filename reference in production code
(src/init.cts) plus one in docs/reference/workflow-fragments.md.
Zero net test-coverage loss. No production code BEHAVIOR changed.
* test(#3338): fix orthogonal-review findings — Wave 6 fold
Standards-axis review found a real structural defect in two files, both
the same root cause and both fixed here:
- tests/update-workflow.test.cjs: the folded:issue-815-update-next-channel
wrapper's closing brace was placed after the file's pre-existing tail
instead of before it, making the already-established folded:bug-2470
and folded:bug-3130 wrappers CHILDREN of issue-815's block in the test
hierarchy instead of independent siblings — confirmed via an actual
node --test run showing the mislabeled TAP nesting. Moved the closing
brace to the correct position; all three fold wrappers are now
top-level siblings again (verified via node --test, TAP hierarchy
correct, 10/10 tests, 5 suites, identical count before and after).
- tests/plan-phase-drift-guard.test.cjs: same mistake in the other
direction — folded:issue-2762-plan-reviews-chunked was spliced inside
the pre-existing folded:bug-2492-context-coverage-gate wrapper instead
of after it. Fixed the same way (227/227 tests, 38 suites, identical
count before and after).
- Reverted unnecessary 815-suffixed local renames (assert815/fs815/etc.)
introduced by the fold — the wrapper is genuinely block-scoped once
correctly closed, so no collision existed (same class as Wave 4's
__foldSetNested finding).
No test() count changed in either file. No production code touched.
---------
Co-authored-by: sim <sim@local>
4a0b5e26b4