* enhancement(#537): migrate code-review-flags to TS source of truth Collapse the hand-written get-shit-done/bin/lib/code-review-flags.cjs to a TypeScript source of truth (src/code-review-flags.cts), compiled by tsc to a gitignored .cjs build artifact at the same path, per ADR-457 (build-at-publish). Second module after the semver-compare pilot (#541). Behaviour is preserved byte-for-behaviour (characterization test added in tests/code-review-flags.test.cjs locks the parser quirks). Adds compile-time type checking: CodeReviewFlags interface + CodeReviewWorkflow literal union. The require() path is unchanged, so code-review.md and the bug-3727 test keep working. The emitted .cjs is gitignored and eslint-ignored, mirroring the pilot. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * enhancement(#537): migrate 9 leaf bin/lib modules to TS source of truth ADR-457 build-at-publish, batch 1 (pure leaf modules, 0 sibling-deps): 001-legacy-orphan-files, context-utilization, redaction, artifacts, command-arg-projection, clock, ui-safety-gate, review-reviewer-selection, clusters. Each moves to src/*.cts (strict TS, typed), compiled by tsc to a gitignored .cjs at the same require() path; behaviour preserved byte-for- behaviour. Adds src/node-globals.d.ts (minimal ambient shim; "types":[]). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * chore(#537): add @types/node, drop hand-rolled node-globals shim ADR-457 migration infra: replace the temporary src/node-globals.d.ts ambient shim with @types/node@22 + "types":["node"] in tsconfig.build.json. Unblocks migrating the ~49 remaining bin/lib modules that use node:fs/path/os/ child_process. Build + full suite (3030 pass) + lint all green; no .cts type changes were needed (real Node types matched the shim). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * enhancement(#537): migrate 9 more bin/lib modules to TS (batch 2) ADR-457 build-at-publish. Clean leaves: installer-migration-report, prompt-budget. Type-error-prone leaves (were tsconfig.lint-excluded; now strict-typed and removed from that exclude list): secrets, phase-lifecycle, workstream-name-policy, decisions, validate, schema-detect. Plus runtime-name-policy. Strict type fixes narrow unknown->concrete domain types (no any/ts-ignore); behaviour preserved. Full suite green, lint 0 errors. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * enhancement(#537): migrate runtime-slash to TS (cross-import proof) ADR-457. First cross-module TS->TS import: src/runtime-slash.cts imports ./runtime-name-policy.cjs and tsc resolves the sibling .cts types under strict (no declaration files; NodeNext .cjs->.cts mapping), emitting a correct require("./runtime-name-policy.cjs"). Confirms the recipe for coupled modules, which must be migrated in dependency order (leaves-up). Suite green, lint clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * enhancement(#537): migrate 10 more bin/lib modules to TS (batch 3) ADR-457 build-at-publish, Wave-1 leaves: event, workstream-inventory-builder, plan-scan, fallow-runner, project-root, installer-migration-authoring, update-context, 000-first-time-baseline, runtime-homes, model-catalog. Strict typing fixed real issues (narrowing unknown, qualified fs/path calls, removed unnecessary casts); plan-scan/project-root/workstream-inventory-builder dropped from tsconfig.lint exclude. Behaviour preserved; suite green, lint 0 errors. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * enhancement(#537): migrate 5 large Wave-1 leaves to TS (batch 4) ADR-457 build-at-publish: configuration, state-document, shell-command- projection (42 dependents), security, command-aliases. shell-command- projection keeps a namespace child_process import for mock-intercept testability. loadConfig/migrateOnDisk emit synchronously (every caller uses them sync; the one awaited migrateOnDisk caller tolerates a non-Promise) — full suite (3030 pass) confirms behaviour preserved. configuration/ state-document/command-aliases dropped from tsconfig.lint exclude. Also fixes the malformed batch-3 changeset frontmatter (type/pr) that failed lint:docs. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * enhancement(#537): migrate 6 Wave-2 modules to TS (batch 5) ADR-457 build-at-publish: config-schema, model-profiles, 002-codex-legacy-hooks-json, logger, active-workstream-store, adr-parser. First batch importing already-migrated siblings (configuration, model-catalog, shell-command-projection, redaction, security) via ./sibling.cjs specifiers. Strict type narrowing (typeof guards over String(unknown)); behaviour preserved; suite 3030 pass, lint 0 errors. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * enhancement(#537): migrate 5 large Wave-2 modules to TS (batch 6) ADR-457 build-at-publish: graphify, install-profiles, intel, installer-migrations, worktree-safety. installer-migrations preserves its dynamic require() loader for numbered migration modules (scoped lint suppressions). Strict typing (typeof guards over String(unknown)); behaviour preserved; suite 3030 pass, lint 0 errors. Wave 2 complete. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * enhancement(#537): migrate Wave-3 modules to TS (batch 7) ADR-457 build-at-publish: planning-workspace, runtime-artifact-layout, command-routing-hub, drift. Uses `import x = require()` for export= siblings; drift's lazy require of runtime-slash hoisted to a top-level import (verified non-circular). Behaviour preserved; suite 3030 pass, lint 0 errors. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * enhancement(#537): migrate small Wave-4 modules to TS (batch 8) ADR-457 build-at-publish: cjs-command-router-adapter, phase-command-router, surface, roadmap-upgrade. Typed the hub router handler results as the HubResult discriminated union; surface drops 4 genuinely-unused imports. Behaviour preserved; suite 3030 pass, lint 0 errors. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * enhancement(#537): migrate core hub (2.5k LOC, 68 dependents) to TS (batch 9) ADR-457 build-at-publish: get-shit-done/bin/lib/core.cjs -> src/core.cts, preserving all 63 exports via export=. All sibling deps already migrated (shell-command-projection, model-profiles, model-catalog, worktree-safety, planning-workspace, project-root, configuration, config-schema). Strict types, no any/ts-ignore; config-schema lazy require hoisted (non-circular). Behaviour preserved (independently verified: core's shard 3030 pass / 0 fail). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * test(#537): make ESLint-coverage + test-sprawl checks migration-aware #551 test hardcoded 12 now-migrated modules as "hand-written, must be linted"; that invariant is obsoleted by the ADR-457 migration. Rewrite it to a filesystem-driven invariant that holds at every stage: a bin/lib/*.cjs must be eslint-ignored IFF it has a src/*.cts source (tsc-generated), else linted (covers package-identity, which has no TS source). Also eslint-ignore config-types.cjs (has a src counterpart) and drop the redundant tests/clock.test.cjs (clock already covered by clock-seam + bug-474 tests), which tripped the lint-test-file-count ratchet. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * enhancement(#537): migrate 9 Wave-5 router/inventory modules to TS (batch 10) ADR-457 build-at-publish: phases/verify/init/agent/task/validate/roadmap/state command routers + workstream-inventory. Router handler results typed against core's exported shapes; behaviour preserved (caught+fixed a --verify boolean flag regression mid-migration). Full suite green across all shards (only the 4 local gpg-env changeset-notes failures remain; CI passes them). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * enhancement(#537): migrate 7 Wave-5 modules to TS (batch 11) ADR-457 build-at-publish: gap-checker, docs, check-command-router, frontmatter, learnings, gsd2-import, profile-pipeline. Behaviour preserved; full suite green across all shards (only the 4 local gpg-env failures remain). Also broadens atomic-write-coverage.test.cjs to accept the tsc-compiled namespace-import form while still asserting platformWriteSync is called (safety guard intact). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * enhancement(#537): migrate config + profile-output to TS (batch 12) ADR-457 build-at-publish: config (729 LOC), profile-output (1142 LOC). All exports preserved; cmdMigrateConfig de-asynced (migrateOnDisk is sync, awaited caller tolerates it). Behaviour preserved; suite green across all shards (only the 4 local gpg-env failures). Wave 5 complete. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * enhancement(#537): migrate 5 Wave-6 modules to TS (batch 13) ADR-457 build-at-publish: template, uat, workstream, roadmap, audit. Behaviour preserved (dead toPosixPath import dropped from audit; inline requires hoisted). Suite green across all shards (only the 4 local gpg-env failures). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * enhancement(#537): migrate commands + state hubs to TS (batch 14) ADR-457 build-at-publish: commands (1305 LOC), state (2074 LOC, 17 dependents). All exports preserved; inner requires kept non-hoisted where load-order matters (install.js, per-call security); acquireStateLock cast inlined to preserve the err.code source token a structural test inspects. Behaviour preserved; suite green across all shards (only the 4 local gpg-env failures). Wave 6 complete. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * enhancement(#537): migrate milestone to TS (batch 15a, hand-authored) ADR-457 build-at-publish: milestone -> src/milestone.cts. Authored directly (subagent capacity was unavailable). Also relaxes core.output()'s 3rd param to optional, matching its real always-optional call contract (unblocks remaining 2-arg output callers). Behaviour preserved; suite green across all shards (only the 4 local gpg-env failures). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * enhancement(#537): migrate phase, verify, init to TS (batch 15, final modules) ADR-457 build-at-publish, Wave 7 (the last hubs): phase (1608 LOC), verify (1615), init (2113). Adds src/package-identity.d.cts so verify can import the permanently value-baked package-identity.cjs under strict TS. Fixes two regressions the migration introduced in verify: restore cmdValidateHealth's `return result` (callers/tests read result.warnings — it is NOT side-effect-only), and make the bug-3384 source-pattern test tolerant of the tsc-compiled bracket-notation form of the git_list_failed->W020 branch (behaviour intact). Full suite green across all shards (only the 4 local gpg-env failures); lint 0 errors. All 86 migratable bin/lib modules are now TypeScript sources. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * chore(#537): finalize ADR-457 migration — retire tsconfig.lint.json All hand-written bin/lib/*.cjs are now src/*.cts sources, so the checkJs stopgap tsconfig.lint.json (unused; not wired into eslint, scripts, or CI) is deleted per ADR-457's final step. Also gitignore the tsc-generated config-types.cjs (was still committed) for consistency with every other emitted artifact. package-identity.cjs stays value-baked (declared via src/package-identity.d.cts). Suite green; #551 ESLint-coverage test green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#537): add prepare script so unpacked/git installs build bin/lib artifacts ADR-457 build-at-publish: bin/lib/*.cjs are now gitignored, built by tsc. The prepack/prepublishOnly hooks cover `npm pack`/publish, but `npm install -g <dir>` and git installs run the `prepare` lifecycle — which was missing — so the unpacked install shipped without the compiled .cjs and failed at startup with "Cannot find module './lib/core.cjs'" (caught by the smoke-unpacked CI job). Add `prepare` mirroring prepublishOnly (build:lib + build:hooks). prepare does NOT run for registry consumers (they get the pre-built tarball), only for source/local/pack installs. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#537): make CI build/lockfile checks work with gitignored bin/lib artifacts ADR-457 build-at-publish exposed two CI assumptions that bin/lib/*.cjs are always present on disk: - check:env's lockfile-sync ran `npm ci --dry-run`, which now triggers the `prepare` build (tsc) — but it runs before deps are installed, so tsc is absent and it misreported the lockfile as out of sync. Add --ignore-scripts (a lockfile check must not build). - the lint-tests job installs with --ignore-scripts (no prepare build), but lint:skill-deps require()s the built install-profiles.cjs. Add an explicit `npm run build:lib` step after install. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#537): narrow prepare to build:lib only (unbreak packed-smoke pack step) prepare running build:hooks emitted "✓ Copying ..." stdout during `npm pack`, which the install-smoke "Pack root tarball" step captures into $GITHUB_OUTPUT — breaking it with "Invalid format". build:lib (tsc) is silent on success and is all the unpacked/source install needs (the smoke-unpacked assertions exercise gsd-tools, i.e. bin/lib, and tolerate hook setup with `|| true`). Matches prepack. build:hooks still runs on prepublishOnly for real publishes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#537): wire Stryker mutation gate to build-at-publish layout The gate scored 0.00 because it mutated changed bin/lib/*.cjs that (a) were generated artifacts and (b) included modules with no coverage in the command's test set. Rework: mutation.yml now derives changed COVERED modules from src/*.cts and maps them to their built bin/lib/*.cjs; Stryker mutates those built artifacts with a no-rebuild command (mutating src/*.cts + per-mutant tsc was ~3x over the 30-min CI budget). NOTE: with the gate now correctly measuring the covered modules, their actual mutation score is 42.94% (< break 50) — a pre-existing test-coverage gap (adr-parser/prompt-budget/etc.), not introduced by this behaviour-preserving migration. Reaching 50 needs more tests, a threshold/scope change, or a waiver — a maintainer decision. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * test(#537): raise mutation coverage of covered modules above the 50 gate Adds focused example-based unit tests that kill surviving mutants in the two lowest-scoring covered modules: - tests/prompt-budget.unit.test.cjs (112 tests): 17.9% -> 97.9% - tests/adr-parser.unit.test.cjs (205 tests): 44.7% -> 89.4% Both wired into stryker.config.mjs's command. Fresh full run over the 6 covered modules now scores 82.25% (>= break 50); every covered module is >= 68%. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * enhancement(#537,#609): parallelize mutation gate via dynamic per-module matrix The serial Stryker run timed out at 30 min once the migration's added tests made every mutant re-run ~300 tests. Replace it with a dynamic matrix so the gate completes well under budget — folded into this PR (was tracked as #609) because it's a prerequisite for this PR's mutation gate to pass. - scripts/mutation-matrix.cjs: single source of truth (covered-module -> test files) computing changed covered modules from git diff -> {has_work, matrix}. - mutation.yml: detect -> dynamic `matrix: fromJSON(...)` mutate job (one parallel shard per changed module, scoped via MUTATION_TEST_CMD to only that module's tests, 15-min/shard) -> summary job that KEEPS the legacy check name "Stryker mutation score (changed files only)" so branch protection is unchanged. Per-shard jobs report as "Stryker (<module>)". - stryker.config.mjs: commandRunner.command reads MUTATION_TEST_CMD (falls back to the full command locally). Closes #609. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * test(#537,#609): give each mutation shard ≥50% on its own tests; drop blacksmith note Per-module sharding revealed that active-workstream-store (46.5%) and frontmatter (7.4%) only cleared 50% in the old serial run via timeout-noise from the bloated 300-test command; on their own tests they were below the gate. Add focused unit tests: - tests/active-workstream-store.unit.test.cjs (115 tests): 46.5% -> 81.9% - tests/frontmatter.unit.test.cjs (165 tests): 7.4% -> 63.4% Both wired into scripts/mutation-matrix.cjs (per-module test map) and stryker.config.mjs DEFAULT_TEST_CMD. All 6 covered modules now clear break:50 with only their own tests (config-schema/context-utilization/prompt-budget/ adr-parser already did). Also removes the leftover blacksmith TODO comment — GitHub-hosted runners only; speed comes from parallel per-module shards. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * test(#537,#609): strengthen prompt-budget tests to clear the gate on its own tests prompt-budget scored 39.58% when mutation-tested with ONLY its own tests (the way the per-module CI shard runs it) — an earlier ~98% reading was inflated by accidentally running the full multi-module command. Add 96 targeted tests to tests/prompt-budget.unit.test.cjs (exact note-template text, plan-truncation arithmetic/percentages, drop-block strings, noteInjected/hardFailed booleans): scoped score 39.58% -> 68.75% (>= break 50). All 6 covered modules now clear the gate on their own tests. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
340 lines
11 KiB
TypeScript
340 lines
11 KiB
TypeScript
/**
|
|
* Learnings — Global knowledge store with CRUD operations
|
|
*
|
|
* Provides a cross-project learnings store at ~/.gsd/knowledge/.
|
|
* Each learning is stored as an individual JSON file with content-hash
|
|
* deduplication. Supports write, read, list, query, delete, copy-from-project,
|
|
* and prune operations.
|
|
*
|
|
* Storage format: { id, source_project, date, context, learning, tags, content_hash }
|
|
* File naming: {id}.json
|
|
* Deduplication: SHA-256 of learning text + source_project
|
|
*
|
|
* ADR-457 build-at-publish: the hand-written bin/lib/learnings.cjs collapsed
|
|
* to a TypeScript source of truth. Behaviour is preserved byte-for-behaviour
|
|
* from the prior hand-written .cjs; only strict types are added.
|
|
*/
|
|
|
|
import fs from 'node:fs';
|
|
import path from 'node:path';
|
|
import crypto from 'node:crypto';
|
|
import os from 'node:os';
|
|
// eslint-disable-next-line @typescript-eslint/no-require-imports
|
|
import core = require('./core.cjs');
|
|
const { output, error: coreError } = core;
|
|
import { platformWriteSync } from './shell-command-projection.cjs';
|
|
|
|
// ─── Types ───────────────────────────────────────────────────────────────────
|
|
|
|
interface LearningRecord {
|
|
id: string;
|
|
source_project: string;
|
|
date: string;
|
|
context: string;
|
|
learning: string;
|
|
tags: string[];
|
|
content_hash: string;
|
|
}
|
|
|
|
interface WriteEntry {
|
|
source_project: string;
|
|
learning: string;
|
|
context?: string;
|
|
tags?: string[];
|
|
}
|
|
|
|
interface WriteOpts {
|
|
storeDir?: string;
|
|
dedupeIndex?: Map<string, string>;
|
|
}
|
|
|
|
interface WriteResult {
|
|
id: string;
|
|
created: boolean;
|
|
content_hash: string;
|
|
}
|
|
|
|
interface CopyResult {
|
|
total: number;
|
|
created: number;
|
|
skipped: number;
|
|
}
|
|
|
|
interface PruneResult {
|
|
removed: number;
|
|
kept: number;
|
|
}
|
|
|
|
// ─── Constants ───────────────────────────────────────────────────────────────
|
|
|
|
const DEFAULT_STORE_DIR = path.join(os.homedir(), '.gsd', 'knowledge');
|
|
|
|
// ─── Helpers ─────────────────────────────────────────────────────────────────
|
|
|
|
function getStoreDir(opts?: WriteOpts | { storeDir?: string }): string {
|
|
return (opts && opts.storeDir) || DEFAULT_STORE_DIR;
|
|
}
|
|
|
|
function ensureStoreDir(dir: string): void {
|
|
if (!fs.existsSync(dir)) {
|
|
fs.mkdirSync(dir, { recursive: true });
|
|
}
|
|
}
|
|
|
|
function contentHash(learning: string, sourceProject: string): string {
|
|
return crypto.createHash('sha256')
|
|
.update(learning + '\n' + sourceProject)
|
|
.digest('hex');
|
|
}
|
|
|
|
function generateId(): string {
|
|
const ts = Date.now().toString(36);
|
|
const rand = crypto.randomBytes(4).toString('hex');
|
|
return `${ts}-${rand}`;
|
|
}
|
|
|
|
function readLearningFile(filePath: string): LearningRecord | null {
|
|
try {
|
|
const content = fs.readFileSync(filePath, 'utf-8');
|
|
return JSON.parse(content) as LearningRecord;
|
|
} catch (err) {
|
|
process.stderr.write(`Warning: skipping malformed file ${filePath}: ${(err as Error).message}\n`);
|
|
return null;
|
|
}
|
|
}
|
|
|
|
// ─── CRUD Operations ─────────────────────────────────────────────────────────
|
|
|
|
function learningsWrite(entry: WriteEntry, opts?: WriteOpts): WriteResult {
|
|
const dir = getStoreDir(opts);
|
|
ensureStoreDir(dir);
|
|
|
|
const hash = contentHash(entry.learning, entry.source_project);
|
|
|
|
// #306: In bulk-import paths, callers may supply a pre-built dedupeIndex
|
|
// (Map<content_hash, id>) to avoid the per-write O(N) store scan.
|
|
if (opts && opts.dedupeIndex) {
|
|
const dedupeIndex = opts.dedupeIndex;
|
|
if (dedupeIndex.has(hash)) {
|
|
return { id: dedupeIndex.get(hash) as string, created: false, content_hash: hash };
|
|
}
|
|
const id = generateId();
|
|
const record: LearningRecord = {
|
|
id,
|
|
source_project: entry.source_project,
|
|
date: new Date().toISOString(),
|
|
context: entry.context || '',
|
|
learning: entry.learning,
|
|
tags: entry.tags || [],
|
|
content_hash: hash,
|
|
};
|
|
platformWriteSync(path.join(dir, `${id}.json`), JSON.stringify(record, null, 2));
|
|
dedupeIndex.set(hash, id);
|
|
return { id, created: true, content_hash: hash };
|
|
}
|
|
|
|
// Check for duplicate by scanning existing files (single-write path, unchanged)
|
|
const files = fs.readdirSync(dir).filter(f => f.endsWith('.json'));
|
|
for (const file of files) {
|
|
const existing = readLearningFile(path.join(dir, file));
|
|
if (existing && existing.content_hash === hash) {
|
|
return { id: existing.id, created: false, content_hash: hash };
|
|
}
|
|
}
|
|
|
|
const id = generateId();
|
|
const record: LearningRecord = {
|
|
id,
|
|
source_project: entry.source_project,
|
|
date: new Date().toISOString(),
|
|
context: entry.context || '',
|
|
learning: entry.learning,
|
|
tags: entry.tags || [],
|
|
content_hash: hash,
|
|
};
|
|
|
|
platformWriteSync(path.join(dir, `${id}.json`), JSON.stringify(record, null, 2));
|
|
return { id, created: true, content_hash: hash };
|
|
}
|
|
|
|
function learningsRead(id: string, opts?: { storeDir?: string }): LearningRecord | null {
|
|
if (!/^[a-z0-9]+-[a-f0-9]+$/.test(id)) return null;
|
|
const dir = getStoreDir(opts);
|
|
const filePath = path.join(dir, `${id}.json`);
|
|
if (!fs.existsSync(filePath)) return null;
|
|
return readLearningFile(filePath);
|
|
}
|
|
|
|
function learningsList(opts?: { storeDir?: string }): LearningRecord[] {
|
|
const dir = getStoreDir(opts);
|
|
if (!fs.existsSync(dir)) return [];
|
|
|
|
const files = fs.readdirSync(dir).filter(f => f.endsWith('.json'));
|
|
const results: LearningRecord[] = [];
|
|
for (const file of files) {
|
|
const record = readLearningFile(path.join(dir, file));
|
|
if (record) results.push(record);
|
|
}
|
|
|
|
// Sort by date descending (newest first)
|
|
results.sort((a, b) => new Date(b.date).getTime() - new Date(a.date).getTime());
|
|
return results;
|
|
}
|
|
|
|
function learningsQuery(query: { tag?: string }, opts?: { storeDir?: string }): LearningRecord[] {
|
|
const all = learningsList(opts);
|
|
if (query && query.tag) {
|
|
return all.filter(r => r.tags && r.tags.includes(query.tag as string));
|
|
}
|
|
return all;
|
|
}
|
|
|
|
function learningsDelete(id: string, opts?: { storeDir?: string }): boolean {
|
|
if (!/^[a-z0-9]+-[a-f0-9]+$/.test(id)) return false;
|
|
const dir = getStoreDir(opts);
|
|
const filePath = path.join(dir, `${id}.json`);
|
|
if (!fs.existsSync(filePath)) return false;
|
|
fs.unlinkSync(filePath);
|
|
return true;
|
|
}
|
|
|
|
function learningsCopyFromProject(planningDir: string, opts?: WriteOpts & { sourceProject?: string }): CopyResult {
|
|
const learningsPath = path.join(planningDir, 'LEARNINGS.md');
|
|
if (!fs.existsSync(learningsPath)) {
|
|
return { total: 0, created: 0, skipped: 0 };
|
|
}
|
|
|
|
const content = fs.readFileSync(learningsPath, 'utf-8');
|
|
const sourceProject = (opts && opts.sourceProject) || path.basename(path.resolve(planningDir, '..'));
|
|
|
|
// #306: Build the content_hash -> id dedupe index once before the loop so
|
|
// that learningsWrite does not re-scan the entire store on every call —
|
|
// O(K*N) -> O(N+K).
|
|
const dir = getStoreDir(opts);
|
|
ensureStoreDir(dir);
|
|
const dedupeIndex = new Map<string, string>();
|
|
for (const file of fs.readdirSync(dir).filter(f => f.endsWith('.json'))) {
|
|
const existing = readLearningFile(path.join(dir, file));
|
|
// First-seen-wins, matching the legacy scan path's first-match return so the
|
|
// dedupe-hit `id` is identical on both paths even if the store already holds
|
|
// duplicate content_hashes. (#306)
|
|
if (existing && existing.content_hash && !dedupeIndex.has(existing.content_hash)) {
|
|
dedupeIndex.set(existing.content_hash, existing.id);
|
|
}
|
|
}
|
|
|
|
// Parse markdown: split on ## headings
|
|
const sections = content.split(/^## /m).slice(1); // skip preamble before first ##
|
|
let created = 0;
|
|
let skipped = 0;
|
|
|
|
for (const section of sections) {
|
|
const lines = section.trim().split('\n');
|
|
const title = lines[0].trim();
|
|
const body = lines.slice(1).join('\n').trim();
|
|
if (!body) continue;
|
|
|
|
// Extract tags from title (simple: use words as tags)
|
|
const tags = title.toLowerCase().split(/\s+/).filter(w => w.length > 2);
|
|
|
|
const result = learningsWrite({
|
|
source_project: sourceProject,
|
|
learning: body,
|
|
context: title,
|
|
tags,
|
|
}, { ...opts, dedupeIndex });
|
|
|
|
if (result.created) {
|
|
created++;
|
|
} else {
|
|
skipped++;
|
|
}
|
|
}
|
|
|
|
return { total: created + skipped, created, skipped };
|
|
}
|
|
|
|
function learningsPrune(olderThan: string, opts?: { storeDir?: string }): PruneResult {
|
|
const match = /^(\d+)d$/.exec(olderThan);
|
|
if (!match) {
|
|
throw new Error(`Invalid duration format: "${olderThan}" — expected format like "90d"`);
|
|
}
|
|
|
|
const days = parseInt(match[1], 10);
|
|
const cutoff = new Date(Date.now() - days * 24 * 60 * 60 * 1000);
|
|
const dir = getStoreDir(opts);
|
|
|
|
if (!fs.existsSync(dir)) return { removed: 0, kept: 0 };
|
|
|
|
const files = fs.readdirSync(dir).filter(f => f.endsWith('.json'));
|
|
let removed = 0;
|
|
let kept = 0;
|
|
|
|
for (const file of files) {
|
|
const filePath = path.join(dir, file);
|
|
const record = readLearningFile(filePath);
|
|
if (!record) continue;
|
|
|
|
const recordDate = new Date(record.date);
|
|
if (recordDate < cutoff) {
|
|
fs.unlinkSync(filePath);
|
|
removed++;
|
|
} else {
|
|
kept++;
|
|
}
|
|
}
|
|
|
|
return { removed, kept };
|
|
}
|
|
|
|
// ─── CLI Command Handlers ────────────────────────────────────────────────────
|
|
|
|
function cmdLearningsList(raw: boolean): void {
|
|
const results = learningsList();
|
|
output({ learnings: results, count: results.length }, raw, undefined);
|
|
}
|
|
|
|
function cmdLearningsQuery(tag: string, raw: boolean): void {
|
|
const results = learningsQuery({ tag });
|
|
output({ learnings: results, count: results.length, tag }, raw, undefined);
|
|
}
|
|
|
|
function cmdLearningsCopy(cwd: string, raw: boolean): void {
|
|
const planDir = path.join(cwd, '.planning');
|
|
const result = learningsCopyFromProject(planDir);
|
|
output(result, raw, undefined);
|
|
}
|
|
|
|
function cmdLearningsPrune(olderThan: string, raw: boolean): void {
|
|
try {
|
|
const result = learningsPrune(olderThan);
|
|
output(result, raw, undefined);
|
|
} catch (err) {
|
|
coreError((err as Error).message);
|
|
}
|
|
}
|
|
|
|
function cmdLearningsDelete(id: string, raw: boolean): void {
|
|
if (!/^[a-z0-9]+-[a-f0-9]+$/.test(id)) {
|
|
coreError(`Invalid learning ID: "${id}"`);
|
|
}
|
|
const deleted = learningsDelete(id);
|
|
output({ id, deleted }, raw, undefined);
|
|
}
|
|
|
|
export = {
|
|
learningsWrite,
|
|
learningsRead,
|
|
learningsList,
|
|
learningsQuery,
|
|
learningsDelete,
|
|
learningsCopyFromProject,
|
|
learningsPrune,
|
|
cmdLearningsList,
|
|
cmdLearningsQuery,
|
|
cmdLearningsCopy,
|
|
cmdLearningsPrune,
|
|
cmdLearningsDelete,
|
|
DEFAULT_STORE_DIR,
|
|
};
|