23254ca5a7
* fix(#1936): reconstruct OpenCode review from JSON events; diagnosable empty-output stub On a large review prompt, OpenCode's default `build` agent runs a few read tool calls then ends its turn with zero output tokens (reason:"stop", output:0), so `opencode run --format default` emits empty stdout. The reviewer block redirected stderr to /dev/null and wrote a generic "failed or returned empty output" stub — so the phase silently lost its second independent reviewer with no diagnostic and no timeout. Rewrite the OpenCode reviewer block to invoke `--format json` as the primary call and reconstruct the review from the assistant `text` parts (jq). Capture stderr to a `.err` sidecar (mirrors the Codex block). When the agent emits no text, surface the stop reason, output-token count, and stderr so the failure is diagnosable. Gate the stub on the extracted CONTENT, not the output file size — an empty jq extraction still prints a lone newline that a `[ -s file ]` check would treat as populated. Document the wall-clock timeout as a Bash-tool param (macOS lacks GNU timeout; opencode has no native timeout flag). review.md was already at the DEFAULT size-tier ceiling (40956/40960), so the fix cannot fit without reclassifying it into the LARGE tier (it is a multi-reviewer orchestration file that outgrew "focused single-purpose"; 43.4 KB sits well under the LARGE high-water mark). Recapture the 16 golden-install fixtures — the diff is exactly one review.md hash per runtime. Regression block folded into review-default-reviewers-workflow.test.cjs (new bug-NNNN test files are not accepted). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * chore(#1936): add changeset * test(#1936): property-test the OpenCode review jq reconstruction Address the re-review's one actionable finding: the jq JSON-event → text reconstruction had no fast-check property test. Add tests/opencode-review-reconstruction.property.test.cjs. It extracts the two shipped jq programs (OPENCODE_REVIEW, OPENCODE_DIAG) verbatim from gsd-core/workflows/review.md and runs the real jq — not a reimplementation — so the shipped logic is what gets tested. Properties: the reconstructed review equals the newline-join of every assistant text part (order preserved); a stream with no text part reconstructs to empty (drives the #1936 stub); null/absent text parts are dropped, never rendered as "null". Plus example-based coverage of the diagnostic edges the reviewer cited: missing .tokens.output and no step_finish degrade to "?"; non-JSON stdout makes jq fail rather than masquerade as a review. Verified the invariant has teeth (a comma-join jq fails the property). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * test(#1936): skip jq reconstruction property test when jq is absent The property test shells out to `jq`, which GitHub's windows-latest runners do not ship (macOS/Linux runners do). `execFileSync('jq')` therefore ENOENT-failed the whole file on `test (windows-latest, *)`. Probe `jq --version` at load and skip the suite when jq is not on PATH — the reconstruction logic is platform-independent, so the assertions still run in full on every jq-present runner (mirrors how golden-install-parity skips on win32). Verified: jq present → 7 pass; jq removed from PATH → 7 skipped, 0 fail. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * test(#1936): skip jq reconstruction property test on Windows, not just when jq is absent The prior guard skipped only when `jq` was absent from PATH — but the windows-latest runners DO ship jq, so the suite still ran there and failed with `jq: parse error: Invalid numeric literal` (confirmed from the CI job log). Root cause is Node's child_process argument quoting mangling the jq program (it embeds double quotes) on Windows, not the shipped review.md logic — the macOS/Linux legs pass. Gate the suite on `process.platform === 'win32'` (still also skipping when jq is absent), mirroring golden-install-parity's win32 skip. Logic is platform-independent and fully asserted on every macOS/Linux CI leg. Verified: macOS → 7 pass; simulated win32 → skips. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
93 lines
2.4 KiB
JSON
93 lines
2.4 KiB
JSON
{
|
|
"add-backlog.md": 7132,
|
|
"add-phase.md": 7203,
|
|
"add-tests.md": 16901,
|
|
"add-todo.md": 8952,
|
|
"ai-integration-phase.md": 14761,
|
|
"analyze-dependencies.md": 3887,
|
|
"audit-fix.md": 10988,
|
|
"audit-milestone.md": 17637,
|
|
"audit-uat.md": 7425,
|
|
"autonomous.md": 42430,
|
|
"check-todos.md": 9431,
|
|
"cleanup.md": 9897,
|
|
"code-review-fix.md": 23890,
|
|
"code-review.md": 31602,
|
|
"complete-milestone.md": 31027,
|
|
"debug.md": 13505,
|
|
"diagnose-issues.md": 12820,
|
|
"discovery-phase.md": 8651,
|
|
"discuss-phase-assumptions.md": 26984,
|
|
"discuss-phase-power.md": 11273,
|
|
"discuss-phase.md": 31990,
|
|
"do.md": 10068,
|
|
"docs-update.md": 55662,
|
|
"edit-phase.md": 12883,
|
|
"eval-review.md": 9923,
|
|
"execute-phase.md": 93484,
|
|
"execute-plan.md": 32611,
|
|
"explore.md": 10497,
|
|
"extract-learnings.md": 12849,
|
|
"fast.md": 4149,
|
|
"forensics.md": 12487,
|
|
"graduation.md": 11578,
|
|
"health.md": 11824,
|
|
"help.md": 1722,
|
|
"import.md": 14604,
|
|
"inbox.md": 14407,
|
|
"ingest-docs.md": 18336,
|
|
"insert-phase.md": 8943,
|
|
"list-phase-assumptions.md": 4305,
|
|
"list-seeds.md": 6943,
|
|
"list-workspaces.md": 5655,
|
|
"manager.md": 27258,
|
|
"map-codebase.md": 20789,
|
|
"milestone-summary.md": 11798,
|
|
"mvp-phase.md": 13582,
|
|
"new-milestone.md": 32844,
|
|
"new-project.md": 66138,
|
|
"new-workspace.md": 11254,
|
|
"next.md": 20094,
|
|
"node-repair.md": 4173,
|
|
"note.md": 6563,
|
|
"pause-work.md": 14397,
|
|
"plan-milestone-gaps.md": 11765,
|
|
"plan-phase.md": 90411,
|
|
"plan-review-convergence.md": 23468,
|
|
"plant-seed.md": 11741,
|
|
"pr-branch.md": 15919,
|
|
"profile-user.md": 21202,
|
|
"progress.md": 30555,
|
|
"quick.md": 49139,
|
|
"reapply-patches.md": 20393,
|
|
"remove-phase.md": 8469,
|
|
"remove-workspace.md": 7507,
|
|
"resume-project.md": 17226,
|
|
"review.md": 43406,
|
|
"scan.md": 7688,
|
|
"secure-phase.md": 13476,
|
|
"session-report.md": 4044,
|
|
"settings-advanced.md": 39646,
|
|
"settings-integrations.md": 15848,
|
|
"settings.md": 33413,
|
|
"ship.md": 24647,
|
|
"sketch-wrap-up.md": 14223,
|
|
"sketch.md": 19960,
|
|
"smart-entry.md": 11080,
|
|
"spec-phase.md": 31901,
|
|
"spike-wrap-up.md": 15092,
|
|
"spike.md": 24517,
|
|
"stats.md": 6718,
|
|
"sync-skills.md": 6125,
|
|
"thread.md": 12464,
|
|
"transition.md": 22016,
|
|
"ui-phase.md": 15477,
|
|
"ui-review.md": 11172,
|
|
"ultraplan-phase.md": 10468,
|
|
"undo.md": 10431,
|
|
"update.md": 20914,
|
|
"validate-phase.md": 10745,
|
|
"verify-phase.md": 40728,
|
|
"verify-work.md": 35171
|
|
}
|