2de2d185fa
Phase 2 of the CJS↔SDK hard-seam migration (parent #3524). Eliminates the structural drift surface that produced bug class After this phase, neither bin/lib/ nor sdk/src/ defines CONFIG_DEFAULTS, VALID_CONFIG_KEYS, DYNAMIC_KEY_PATTERNS, or the four legacy-key normalizations inline. All come from one canonical source: the Configuration Module (sdk/src/configuration/index.ts) + two JSON manifests (sdk/shared/config-{defaults,schema}.manifest.json). The CJS mirror is generator-emitted (get-shit-done/bin/lib/configuration.generated.cjs) with a CI freshness check (sdk/scripts/check-configuration-fresh.mjs). - sdk/shared/config-defaults.manifest.json — canonical nested defaults, union of CJS + SDK keys (includes security_*, post_planning_gaps, agent_skills, mode, every git/workflow/hooks sub-section). - sdk/shared/config-schema.manifest.json — VALID_CONFIG_KEYS array, RUNTIME_STATE_KEYS array, DYNAMIC_KEY_PATTERNS array with source strings (regex reconstructed at runtime). - sdk/src/configuration/index.ts — source of truth. Exports loadConfig (pure read), normalizeLegacyKeys (pure, idempotent, returns Normalization[]), mergeDefaults (deep-merge), migrateOnDisk (explicit opt-in disk writeback), plus CONFIG_DEFAULTS, VALID_CONFIG_KEYS, RUNTIME_STATE_KEYS, DYNAMIC_KEY_PATTERNS. - sdk/src/configuration/index.test.ts — 29 vitest pinning tests. - sdk/scripts/gen-configuration.mjs — generator (Function.prototype.toString() inspection of compiled SDK dist, plus brace-balanced text scan for internal helpers, matching the Phase 1 pattern). - sdk/scripts/check-configuration-fresh.mjs — CI freshness gate. - tests/configuration-generator.test.cjs — 27 parity assertions (CJS-generated == SDK source). - tests/configuration-migrate-config.test.cjs — 3 cases for the new gsd-tools migrate-config subcommand. - bin/lib/core.cjs: CONFIG_DEFAULTS literal now sources values from CANONICAL_CONFIG_DEFAULTS (the manifest), with a thin flat projection at the load boundary to preserve the existing flat-shape return contract for the ~21 CJS test files and 100+ consumers. All four legacy-key migration blocks (branching_strategy, sub_repos, multiRepo, depth — historically lines 351-358, 388-397, 401-408, 416-423) collapse to a single normalizeLegacyKeys call in each code path. The inline platformWriteSync writeback stays for now to preserve sync loadConfig semantics; the new async migrateOnDisk is reachable via gsd-tools migrate-config. - bin/lib/config-schema.cjs: 135 → 31 lines. Re-exports from the generated Module. - bin/lib/config.cjs: adds cmdMigrateConfig handler (calls migrateOnDisk on the explicit user-driven path). - bin/gsd-tools.cjs: wires migrate-config into command dispatch. - sdk/src/config.ts: re-exports CONFIG_DEFAULTS and mergeDefaults from the Module. loadConfig now calls normalizeLegacyKeys before mergeDefaults (replaces the inline branching_strategy graft). - sdk/src/query/config-schema.ts: 160 → 36 lines. Re-exports from the Module. - tests/config-schema-sdk-parity.test.cjs: refactored from "CJS Set equals SDK Set" (trivially true post-migration) to "both sides source from the manifest" — structural plus runtime invariant. - Four other tests that text-grepped source files for valid keys (plan-review-convergence, bug-3212, bug-2492, feat-3210) are updated to use runtime VALID_CONFIG_KEYS.has() or manifest JSON lookups. - CONTEXT.md: new Configuration Module entry with full Interface contract. - Root package.json: check:configuration-fresh proxy script. - sdk/package.json: gen:configuration + check:configuration-fresh. - .githooks/pre-commit: configuration drift block. - .github/workflows/test.yml: configuration drift step after the alias drift check. - 9201 CJS tests pass (baseline pre-cycle: 9195; +6 net new tests across migrate-config + parity refactor) - 1872 SDK vitest tests pass - 29 Configuration Module vitest fixtures - 27 CJS/SDK parity fixtures - Net diff: +388 / −519 = 131-line reduction across the seven cycles, despite adding the new Module, manifests, generator, freshness check, and two new test files. 1. SDK CONFIG_DEFAULTS now includes manifest-canonical keys (resolve_model_ids: false, context_window: 200000, phase_naming, claude_md_path, git.create_tag, workflow.security_*, workflow.code_review_*, planning.*, hooks.workflow_guard, ship.*). Consumers accessing via [key: string]: unknown index get the manifest default instead of undefined. 2. SDK mergeDefaults is now proper recursive deep-merge instead of spread-per-section. Overlay { workflow: { research: false } } now preserves sibling workflow keys; previously it replaced the entire workflow section with only research + the section's defaults. Semantically identical for the common case; strictly better for partial nested overrides. 3. New gsd-tools migrate-config CLI subcommand for the explicit, opt-in on-disk migration path. Closes #3536.
339 lines
8.5 KiB
JSON
339 lines
8.5 KiB
JSON
{
|
|
"generated": "2026-05-15",
|
|
"families": {
|
|
"agents": [
|
|
"gsd-advisor-researcher",
|
|
"gsd-ai-researcher",
|
|
"gsd-assumptions-analyzer",
|
|
"gsd-code-fixer",
|
|
"gsd-code-reviewer",
|
|
"gsd-codebase-mapper",
|
|
"gsd-debug-session-manager",
|
|
"gsd-debugger",
|
|
"gsd-doc-classifier",
|
|
"gsd-doc-synthesizer",
|
|
"gsd-doc-verifier",
|
|
"gsd-doc-writer",
|
|
"gsd-domain-researcher",
|
|
"gsd-eval-auditor",
|
|
"gsd-eval-planner",
|
|
"gsd-executor",
|
|
"gsd-framework-selector",
|
|
"gsd-integration-checker",
|
|
"gsd-intel-updater",
|
|
"gsd-nyquist-auditor",
|
|
"gsd-pattern-mapper",
|
|
"gsd-phase-researcher",
|
|
"gsd-plan-checker",
|
|
"gsd-planner",
|
|
"gsd-project-researcher",
|
|
"gsd-research-synthesizer",
|
|
"gsd-roadmapper",
|
|
"gsd-security-auditor",
|
|
"gsd-ui-auditor",
|
|
"gsd-ui-checker",
|
|
"gsd-ui-researcher",
|
|
"gsd-user-profiler",
|
|
"gsd-verifier"
|
|
],
|
|
"commands": [
|
|
"/gsd-add-tests",
|
|
"/gsd-ai-integration-phase",
|
|
"/gsd-audit-fix",
|
|
"/gsd-audit-milestone",
|
|
"/gsd-audit-uat",
|
|
"/gsd-autonomous",
|
|
"/gsd-capture",
|
|
"/gsd-cleanup",
|
|
"/gsd-code-review",
|
|
"/gsd-complete-milestone",
|
|
"/gsd-config",
|
|
"/gsd-debug",
|
|
"/gsd-discuss-phase",
|
|
"/gsd-docs-update",
|
|
"/gsd-eval-review",
|
|
"/gsd-execute-phase",
|
|
"/gsd-explore",
|
|
"/gsd-extract-learnings",
|
|
"/gsd-fast",
|
|
"/gsd-forensics",
|
|
"/gsd-graphify",
|
|
"/gsd-health",
|
|
"/gsd-help",
|
|
"/gsd-import",
|
|
"/gsd-inbox",
|
|
"/gsd-ingest-docs",
|
|
"/gsd-manager",
|
|
"/gsd-map-codebase",
|
|
"/gsd-milestone-summary",
|
|
"/gsd-mvp-phase",
|
|
"/gsd-new-milestone",
|
|
"/gsd-new-project",
|
|
"/gsd-ns-context",
|
|
"/gsd-ns-ideate",
|
|
"/gsd-ns-manage",
|
|
"/gsd-ns-project",
|
|
"/gsd-ns-review",
|
|
"/gsd-ns-workflow",
|
|
"/gsd-pause-work",
|
|
"/gsd-phase",
|
|
"/gsd-plan-phase",
|
|
"/gsd-plan-review-convergence",
|
|
"/gsd-pr-branch",
|
|
"/gsd-profile-user",
|
|
"/gsd-progress",
|
|
"/gsd-quick",
|
|
"/gsd-resume-work",
|
|
"/gsd-review",
|
|
"/gsd-review-backlog",
|
|
"/gsd-secure-phase",
|
|
"/gsd-settings",
|
|
"/gsd-ship",
|
|
"/gsd-sketch",
|
|
"/gsd-spec-phase",
|
|
"/gsd-spike",
|
|
"/gsd-stats",
|
|
"/gsd-surface",
|
|
"/gsd-thread",
|
|
"/gsd-ui-phase",
|
|
"/gsd-ui-review",
|
|
"/gsd-ultraplan-phase",
|
|
"/gsd-undo",
|
|
"/gsd-update",
|
|
"/gsd-validate-phase",
|
|
"/gsd-verify-work",
|
|
"/gsd-workspace",
|
|
"/gsd-workstreams"
|
|
],
|
|
"workflows": [
|
|
"add-backlog.md",
|
|
"add-phase.md",
|
|
"add-tests.md",
|
|
"add-todo.md",
|
|
"ai-integration-phase.md",
|
|
"analyze-dependencies.md",
|
|
"audit-fix.md",
|
|
"audit-milestone.md",
|
|
"audit-uat.md",
|
|
"autonomous.md",
|
|
"check-todos.md",
|
|
"cleanup.md",
|
|
"code-review-fix.md",
|
|
"code-review.md",
|
|
"complete-milestone.md",
|
|
"debug.md",
|
|
"diagnose-issues.md",
|
|
"discovery-phase.md",
|
|
"discuss-phase-assumptions.md",
|
|
"discuss-phase-power.md",
|
|
"discuss-phase.md",
|
|
"do.md",
|
|
"docs-update.md",
|
|
"edit-phase.md",
|
|
"eval-review.md",
|
|
"execute-phase.md",
|
|
"execute-plan.md",
|
|
"explore.md",
|
|
"extract-learnings.md",
|
|
"fast.md",
|
|
"forensics.md",
|
|
"graduation.md",
|
|
"health.md",
|
|
"help.md",
|
|
"import.md",
|
|
"inbox.md",
|
|
"ingest-docs.md",
|
|
"insert-phase.md",
|
|
"list-phase-assumptions.md",
|
|
"list-workspaces.md",
|
|
"manager.md",
|
|
"map-codebase.md",
|
|
"milestone-summary.md",
|
|
"mvp-phase.md",
|
|
"new-milestone.md",
|
|
"new-project.md",
|
|
"new-workspace.md",
|
|
"next.md",
|
|
"node-repair.md",
|
|
"note.md",
|
|
"pause-work.md",
|
|
"plan-milestone-gaps.md",
|
|
"plan-phase.md",
|
|
"plan-review-convergence.md",
|
|
"plant-seed.md",
|
|
"pr-branch.md",
|
|
"profile-user.md",
|
|
"progress.md",
|
|
"quick.md",
|
|
"reapply-patches.md",
|
|
"remove-phase.md",
|
|
"remove-workspace.md",
|
|
"resume-project.md",
|
|
"review.md",
|
|
"scan.md",
|
|
"secure-phase.md",
|
|
"session-report.md",
|
|
"settings-advanced.md",
|
|
"settings-integrations.md",
|
|
"settings.md",
|
|
"ship.md",
|
|
"sketch-wrap-up.md",
|
|
"sketch.md",
|
|
"spec-phase.md",
|
|
"spike-wrap-up.md",
|
|
"spike.md",
|
|
"stats.md",
|
|
"sync-skills.md",
|
|
"thread.md",
|
|
"transition.md",
|
|
"ui-phase.md",
|
|
"ui-review.md",
|
|
"ultraplan-phase.md",
|
|
"undo.md",
|
|
"update.md",
|
|
"validate-phase.md",
|
|
"verify-phase.md",
|
|
"verify-work.md"
|
|
],
|
|
"references": [
|
|
"agent-contracts.md",
|
|
"ai-evals.md",
|
|
"ai-frameworks.md",
|
|
"artifact-types.md",
|
|
"autonomous-smart-discuss.md",
|
|
"checkpoints.md",
|
|
"common-bug-patterns.md",
|
|
"context-budget.md",
|
|
"continuation-format.md",
|
|
"debugger-philosophy.md",
|
|
"decimal-phase-calculation.md",
|
|
"doc-conflict-engine.md",
|
|
"domain-probes.md",
|
|
"execute-mvp-tdd.md",
|
|
"executor-examples.md",
|
|
"gate-prompts.md",
|
|
"gates.md",
|
|
"git-integration.md",
|
|
"git-planning-commit.md",
|
|
"ios-scaffold.md",
|
|
"mandatory-initial-read.md",
|
|
"model-profile-resolution.md",
|
|
"model-profiles.md",
|
|
"mvp-concepts.md",
|
|
"phase-argument-parsing.md",
|
|
"planner-antipatterns.md",
|
|
"planner-chunked.md",
|
|
"planner-gap-closure.md",
|
|
"planner-human-verify-mode.md",
|
|
"planner-mvp-mode.md",
|
|
"planner-reviews.md",
|
|
"planner-revision.md",
|
|
"planner-source-audit.md",
|
|
"planning-config.md",
|
|
"project-skills-discovery.md",
|
|
"questioning.md",
|
|
"revision-loop.md",
|
|
"scout-codebase.md",
|
|
"skeleton-template.md",
|
|
"sketch-interactivity.md",
|
|
"sketch-theme-system.md",
|
|
"sketch-tooling.md",
|
|
"sketch-variant-patterns.md",
|
|
"spidr-splitting.md",
|
|
"tdd.md",
|
|
"thinking-models-debug.md",
|
|
"thinking-models-execution.md",
|
|
"thinking-models-planning.md",
|
|
"thinking-models-research.md",
|
|
"thinking-models-verification.md",
|
|
"thinking-partner.md",
|
|
"ui-brand.md",
|
|
"universal-anti-patterns.md",
|
|
"user-profiling.md",
|
|
"user-story-template.md",
|
|
"verification-overrides.md",
|
|
"verification-patterns.md",
|
|
"verify-mvp-mode.md",
|
|
"workstream-flag.md",
|
|
"worktree-path-safety.md"
|
|
],
|
|
"cli_modules": [
|
|
"active-workstream-store.cjs",
|
|
"adr-parser.cjs",
|
|
"artifacts.cjs",
|
|
"audit.cjs",
|
|
"cjs-command-router-adapter.cjs",
|
|
"clusters.cjs",
|
|
"command-aliases.generated.cjs",
|
|
"commands.cjs",
|
|
"config-schema.cjs",
|
|
"config.cjs",
|
|
"configuration.generated.cjs",
|
|
"context-utilization.cjs",
|
|
"core.cjs",
|
|
"decisions.cjs",
|
|
"docs.cjs",
|
|
"drift.cjs",
|
|
"fallow-runner.cjs",
|
|
"frontmatter.cjs",
|
|
"gap-checker.cjs",
|
|
"graphify.cjs",
|
|
"gsd2-import.cjs",
|
|
"init-command-router.cjs",
|
|
"init.cjs",
|
|
"install-profiles.cjs",
|
|
"installer-migration-authoring.cjs",
|
|
"installer-migration-report.cjs",
|
|
"installer-migrations.cjs",
|
|
"intel.cjs",
|
|
"learnings.cjs",
|
|
"milestone.cjs",
|
|
"model-catalog.cjs",
|
|
"model-profiles.cjs",
|
|
"phase-command-router.cjs",
|
|
"phase.cjs",
|
|
"phases-command-router.cjs",
|
|
"plan-scan.cjs",
|
|
"planning-workspace.cjs",
|
|
"profile-output.cjs",
|
|
"profile-pipeline.cjs",
|
|
"review-reviewer-selection.cjs",
|
|
"roadmap-command-router.cjs",
|
|
"roadmap.cjs",
|
|
"runtime-homes.cjs",
|
|
"schema-detect.cjs",
|
|
"secrets.cjs",
|
|
"security.cjs",
|
|
"shell-command-projection.cjs",
|
|
"state-command-router.cjs",
|
|
"state-document.cjs",
|
|
"state-document.generated.cjs",
|
|
"state.cjs",
|
|
"surface.cjs",
|
|
"template.cjs",
|
|
"uat.cjs",
|
|
"validate-command-router.cjs",
|
|
"verify-command-router.cjs",
|
|
"verify.cjs",
|
|
"workstream-inventory.cjs",
|
|
"workstream-name-policy.cjs",
|
|
"workstream.cjs",
|
|
"worktree-safety.cjs"
|
|
],
|
|
"hooks": [
|
|
"gsd-check-update-worker.js",
|
|
"gsd-check-update.js",
|
|
"gsd-context-monitor.js",
|
|
"gsd-phase-boundary.sh",
|
|
"gsd-prompt-guard.js",
|
|
"gsd-read-guard.js",
|
|
"gsd-read-injection-scanner.js",
|
|
"gsd-session-state.sh",
|
|
"gsd-statusline.js",
|
|
"gsd-update-banner.js",
|
|
"gsd-validate-commit.sh",
|
|
"gsd-workflow-guard.js"
|
|
]
|
|
}
|
|
}
|