918f987a19
* feat(#2982): extend no-source-grep lint to catch var-binding readFileSync.includes() The base lint (scripts/lint-no-source-grep.cjs) only catches readFileSync(...).<text-method>() chained directly. The much more common var-binding form escapes it: const src = fs.readFileSync(p, 'utf8'); // 50 lines later if (src.includes('foo')) {} // ← still grep, lint missed it Scan of the test suite found ~141 files using this pattern. Implementation built TDD per #2982 with structured-IR assertions: scripts/lint-no-source-grep-extras.cjs - detectVarBindingViolations(src) — pure detector, two passes: pass 1 collects vars bound from readFileSync, pass 2 finds any <var>.<includes|startsWith|endsWith|match|search>( on those vars. - detectWrappedAssertOkMatch(src) — flags assert.ok(<expr>.match(...)) which escapes the assert.match rule. - VIOLATION enum exposes stable codes for tests to assert on. scripts/lint-no-source-grep.cjs - Wires the new detectors into the existing per-file check; one additional violation row per file with the first 3 sample tokens. tests/bug-2982-lint-var-binding.test.cjs - 13 tests, all assertions on typed VIOLATION enum / structured records. Covers all 5 text-match methods, multi-var, no-bind, string literal (must NOT trigger), wrapped assert.ok(.match), and assert.match (must NOT double-flag). Migration backlog (#2974 expanded scope): - 42 files annotated `// allow-test-rule: source-text-is-the-product` (legitimate — they read .md/.json/.yml files whose deployed text IS the product) - 3 files annotated `// allow-test-rule: pending-migration-to-typed-ir [#2974]` (read .cjs/.js source — clear migration debt) - 95 files annotated `pending-migration-to-typed-ir [#2974]` with `Per-file review may reclassify as source-text-is-the-product during migration` (mixed — manual review under #2974) After this lands the lint reports 0 violations on main; new violations in PRs surface immediately. Closes #2982 Refs #2974 * test(#2982): fix truncated test name per CR The label ended with a bare '(' from a copy-paste mishap. Now reads 'does NOT flag .matchAll(...) — matchAll is not match, so assert.ok(.matchAll(...)) is not flagged'. * chore(#2982): add changeset fragment for PR #2985 * chore(#2982): add changeset fragment for PR #2985
67 lines
2.6 KiB
JavaScript
67 lines
2.6 KiB
JavaScript
// allow-test-rule: pending-migration-to-typed-ir [#2974]
|
|
// Tracked in #2974 for migration to typed-IR assertions per CONTRIBUTING.md
|
|
// "Prohibited: Raw Text Matching on Test Outputs". Per-file review may
|
|
// reclassify some entries as source-text-is-the-product during migration.
|
|
|
|
/**
|
|
* GSD Tests — /gsd-sketch --wrap-up silently no-ops (#2949)
|
|
*
|
|
* The --wrap-up flag was documented in commands/gsd/sketch.md but never dispatched.
|
|
* The sketch-wrap-up.md micro-skill entry point was deleted in #2790 and the dispatch
|
|
* wiring was never added to the command or workflow.
|
|
*/
|
|
|
|
'use strict';
|
|
|
|
const { describe, test } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
|
|
const ROOT = path.resolve(__dirname, '..');
|
|
const SKETCH_COMMAND = path.join(ROOT, 'commands/gsd/sketch.md');
|
|
const SKETCH_WORKFLOW = path.join(ROOT, 'get-shit-done/workflows/sketch.md');
|
|
|
|
describe('bug-2949: sketch --wrap-up dispatch wiring', () => {
|
|
test('commands/gsd/sketch.md contains --wrap-up dispatch logic', () => {
|
|
const content = fs.readFileSync(SKETCH_COMMAND, 'utf8');
|
|
assert.ok(
|
|
content.includes('--wrap-up'),
|
|
'sketch.md should contain --wrap-up dispatch logic'
|
|
);
|
|
// The dispatch should route to sketch-wrap-up workflow
|
|
assert.ok(
|
|
content.includes('sketch-wrap-up'),
|
|
'sketch.md should reference sketch-wrap-up in dispatch logic'
|
|
);
|
|
});
|
|
|
|
test('commands/gsd/sketch.md has sketch-wrap-up in execution_context section', () => {
|
|
const content = fs.readFileSync(SKETCH_COMMAND, 'utf8');
|
|
// Find execution_context block
|
|
const execCtxMatch = content.match(/<execution_context>([\s\S]*?)<\/execution_context>/);
|
|
assert.ok(execCtxMatch, 'sketch.md must have an <execution_context> block');
|
|
const execCtx = execCtxMatch[1];
|
|
assert.ok(
|
|
execCtx.includes('sketch-wrap-up'),
|
|
`execution_context block should include sketch-wrap-up workflow; got: ${execCtx}`
|
|
);
|
|
});
|
|
|
|
test('workflows/sketch.md does NOT contain old /gsd-sketch-wrap-up form', () => {
|
|
const content = fs.readFileSync(SKETCH_WORKFLOW, 'utf8');
|
|
assert.ok(
|
|
!content.includes('/gsd-sketch-wrap-up'),
|
|
'workflows/sketch.md must not reference the old /gsd-sketch-wrap-up command'
|
|
);
|
|
});
|
|
|
|
test('workflows/sketch.md DOES contain new /gsd-sketch --wrap-up form', () => {
|
|
const content = fs.readFileSync(SKETCH_WORKFLOW, 'utf8');
|
|
assert.ok(
|
|
content.includes('/gsd-sketch --wrap-up'),
|
|
'workflows/sketch.md should reference /gsd-sketch --wrap-up (the new form)'
|
|
);
|
|
});
|
|
});
|