Files
msd-core/tests/context-enrichment.test.cjs
Tom Boucher 918f987a19 feat(#2982): extend no-source-grep lint to catch var-binding readFileSync.includes() (#2985)
* feat(#2982): extend no-source-grep lint to catch var-binding readFileSync.includes()

The base lint (scripts/lint-no-source-grep.cjs) only catches
readFileSync(...).<text-method>() chained directly. The much more
common var-binding form escapes it:

  const src = fs.readFileSync(p, 'utf8');
  // 50 lines later
  if (src.includes('foo')) {}        // ← still grep, lint missed it

Scan of the test suite found ~141 files using this pattern.

Implementation built TDD per #2982 with structured-IR assertions:

  scripts/lint-no-source-grep-extras.cjs
    - detectVarBindingViolations(src) — pure detector, two passes:
      pass 1 collects vars bound from readFileSync, pass 2 finds any
      <var>.<includes|startsWith|endsWith|match|search>( on those vars.
    - detectWrappedAssertOkMatch(src) — flags
      assert.ok(<expr>.match(...)) which escapes the assert.match rule.
    - VIOLATION enum exposes stable codes for tests to assert on.

  scripts/lint-no-source-grep.cjs
    - Wires the new detectors into the existing per-file check; one
      additional violation row per file with the first 3 sample tokens.

  tests/bug-2982-lint-var-binding.test.cjs
    - 13 tests, all assertions on typed VIOLATION enum / structured
      records. Covers all 5 text-match methods, multi-var, no-bind,
      string literal (must NOT trigger), wrapped assert.ok(.match),
      and assert.match (must NOT double-flag).

Migration backlog (#2974 expanded scope):

  - 42 files annotated `// allow-test-rule: source-text-is-the-product`
    (legitimate — they read .md/.json/.yml files whose deployed text
    IS the product)
  - 3 files annotated `// allow-test-rule: pending-migration-to-typed-ir [#2974]`
    (read .cjs/.js source — clear migration debt)
  - 95 files annotated `pending-migration-to-typed-ir [#2974]` with
    `Per-file review may reclassify as source-text-is-the-product
    during migration` (mixed — manual review under #2974)

After this lands the lint reports 0 violations on main; new
violations in PRs surface immediately.

Closes #2982
Refs #2974

* test(#2982): fix truncated test name per CR

The label ended with a bare '(' from a copy-paste mishap. Now reads
'does NOT flag .matchAll(...) — matchAll is not match, so
assert.ok(.matchAll(...)) is not flagged'.

* chore(#2982): add changeset fragment for PR #2985

* chore(#2982): add changeset fragment for PR #2985
2026-05-01 19:50:10 -04:00

151 lines
5.8 KiB
JavaScript

// allow-test-rule: pending-migration-to-typed-ir [#2974]
// Tracked in #2974 for migration to typed-IR assertions per CONTRIBUTING.md
// "Prohibited: Raw Text Matching on Test Outputs". Per-file review may
// reclassify some entries as source-text-is-the-product during migration.
/**
* GSD Tools Tests - Adaptive Context Enrichment for 1M Models
*
* Tests for feat/1m-context-enrichment-1473b:
* - Workflow template syntax validation (CONTEXT_WINDOW conditionals)
* - execute-phase.md enrichment blocks (executor + verifier)
* - plan-phase.md cross-phase context gating
*/
const { test, describe } = require('node:test');
const assert = require('node:assert/strict');
const fs = require('fs');
const path = require('path');
// ─────────────────────────────────────────────────────────────────────────────
// Workflow template syntax validation
// ─────────────────────────────────────────────────────────────────────────────
describe('execute-phase.md context enrichment', () => {
const EXECUTE_WORKFLOW_PATH = path.join(__dirname, '..', 'get-shit-done', 'workflows', 'execute-phase.md');
test('contains CONTEXT_WINDOW config-get command', () => {
const content = fs.readFileSync(EXECUTE_WORKFLOW_PATH, 'utf-8');
assert.ok(
content.includes('CONTEXT_WINDOW'),
'execute-phase.md should reference CONTEXT_WINDOW variable'
);
assert.ok(
content.includes('config-get context_window'),
'execute-phase.md should read context_window via config-get'
);
assert.ok(
content.includes('|| echo "200000"'),
'execute-phase.md should default CONTEXT_WINDOW to 200000'
);
});
test('contains conditional prior_wave_summaries in executor prompt', () => {
const content = fs.readFileSync(EXECUTE_WORKFLOW_PATH, 'utf-8');
assert.ok(
content.includes('CONTEXT_WINDOW >= 500000'),
'execute-phase.md should gate enrichment on CONTEXT_WINDOW >= 500000'
);
assert.ok(
content.includes('prior_wave_summaries'),
'execute-phase.md should include prior_wave_summaries in enrichment block'
);
assert.ok(
content.includes('CONTEXT.md'),
'execute-phase.md should reference CONTEXT.md in conditional enrichment'
);
assert.ok(
content.includes('RESEARCH.md'),
'execute-phase.md should reference RESEARCH.md in conditional enrichment'
);
});
test('verifier prompt includes files_to_read block', () => {
const content = fs.readFileSync(EXECUTE_WORKFLOW_PATH, 'utf-8');
assert.ok(
content.includes('<files_to_read>'),
'execute-phase.md should contain <files_to_read> opening tag'
);
assert.ok(
content.includes('</files_to_read>'),
'execute-phase.md should contain </files_to_read> closing tag'
);
const verifierSection = content.substring(content.lastIndexOf('<files_to_read>'));
assert.ok(
verifierSection.includes('PLAN.md'),
'verifier files_to_read should reference PLAN.md'
);
assert.ok(
verifierSection.includes('SUMMARY.md'),
'verifier files_to_read should reference SUMMARY.md'
);
assert.ok(
verifierSection.includes('REQUIREMENTS.md'),
'verifier files_to_read should reference REQUIREMENTS.md'
);
});
test('executor enrichment block includes CONTEXT.md and RESEARCH.md for 1M models', () => {
const content = fs.readFileSync(EXECUTE_WORKFLOW_PATH, 'utf-8');
// Find the executor section's enrichment block
const executorIdx = content.indexOf('CONTEXT_WINDOW >= 500000');
assert.ok(executorIdx > -1, 'Should find CONTEXT_WINDOW >= 500000 conditional');
// Extract ~500 chars after the conditional to check what's included
const enrichmentBlock = content.substring(executorIdx, executorIdx + 500);
assert.ok(
enrichmentBlock.includes('CONTEXT.md'),
'executor enrichment should include CONTEXT.md'
);
assert.ok(
enrichmentBlock.includes('RESEARCH.md'),
'executor enrichment should include RESEARCH.md'
);
});
});
describe('plan-phase.md context enrichment', () => {
const PLAN_WORKFLOW_PATH = path.join(__dirname, '..', 'get-shit-done', 'workflows', 'plan-phase.md');
test('contains CONTEXT_WINDOW conditional for prior CONTEXT.md', () => {
const content = fs.readFileSync(PLAN_WORKFLOW_PATH, 'utf-8');
assert.ok(
content.includes('CONTEXT_WINDOW'),
'plan-phase.md should reference CONTEXT_WINDOW variable'
);
assert.ok(
content.includes('config-get context_window'),
'plan-phase.md should read context_window via config-get'
);
assert.ok(
content.includes('CONTEXT_WINDOW >= 500000'),
'plan-phase.md should gate cross-phase context on CONTEXT_WINDOW >= 500000'
);
assert.ok(
content.includes('CONTEXT.md'),
'plan-phase.md should reference CONTEXT.md in cross-phase enrichment'
);
});
test('enrichment block mentions cross-phase decision consistency', () => {
const content = fs.readFileSync(PLAN_WORKFLOW_PATH, 'utf-8');
// The enrichment should explain why prior context matters
assert.ok(
content.includes('cross-phase') || content.includes('Cross-phase'),
'plan-phase.md should mention cross-phase context'
);
assert.ok(
content.includes('SUMMARY.md'),
'plan-phase.md should reference prior SUMMARY.md files'
);
});
test('default CONTEXT_WINDOW fallback is 200000', () => {
const content = fs.readFileSync(PLAN_WORKFLOW_PATH, 'utf-8');
assert.ok(
content.includes('|| echo "200000"'),
'plan-phase.md should default CONTEXT_WINDOW to 200000'
);
});
});