Files
msd-core/docs/explanation/security-model.md
Tom Boucher bbdf7e8e84 chore(#4654): add local/no-unconfined-path-join and drain it to zero — Phase 4 of #4636 (#4674)
* chore(#4654): add local/no-unconfined-path-join and drain it to zero

Phase 4 of epic #4636 — the ratchet, and the phase that makes the epic hold.

THE MEASUREMENT THAT RESHAPED THE PHASE. An AST census (the repo's own parser,
not grep) found what the epic never enumerated: ADR-4650 named seven containment
implementations; `src/` alone held roughly 24 more hand-rolled gates across ~13
files, several guarding a write or an `fs.rmSync`. Two verified by reading rather
than pattern-matching — `research-store.cts` comments its own as "ensure the
resolved file path stays inside the store dir" immediately before a write, and
`capability-lifecycle.cts` gates `fs.rmSync` with one.

So the epic's Done-when "one containment predicate, used at every site" was FALSE
when Phase 3 reported it satisfied. It is true now: the rule is clean across
src/, scripts/, gsd-core/bin/ and hooks/ with an EMPTY allowlist.

WHY NOT THE RULE THE ISSUE PROPOSED. #4654 proposed flagging `path.join` whose
first argument is a managed root and whose later arguments derive from argv. That
is a taint analysis over 2046 call sites, in ESLint, without type information;
"derives from argv" is not locally decidable. Any approximation either floods or
is trivially evaded, and a rule that fires on hundreds of correct sites earns an
allowlist of hundreds — the opposite of a ratchet. What is actually duplicated is
the COMPARISON, not the join, and that has one recognizable shape.

  Arm 1  X.startsWith(Y + sep)            the hand-rolled containment idiom
  Arm 2  a containment predicate called as a bare statement, answer discarded

Arm 2 is the issue's "asserts the result was narrowed, not merely that a helper
was called". Its example `validatePath(x, root).resolved` is already
structurally impossible — Phase 3 un-exported `validatePath` — so the remaining
expressible failure is ignoring the answer, which is the defect that recurred
five times in this epic. The census found exactly one live instance
(`milestone.cts:1643`); it now returns the proven `ContainedPath` so consumers
stop re-deriving the path the comment above it was extracted to stop them
re-deriving.

The rule deliberately does NOT try to catch validate-one-path-use-another where
the answer is used but a different variable flows onward. That needs flow
analysis; the branded `ContainedPath` from Phase 3 is the defense there, and the
two are complementary.

PER-SITE FAMILY CHOICE, NOT A DEFAULT. Phase 3's lesson binds: collapsing a
lexical site onto the realpath family broke four tests and was caught only by the
matrix. Every migrated site was triaged individually. The six
installer-migrations tree-walks and the six capability-lifecycle gates take the
LEXICAL family because their operands are already realpath-resolved and they
deliberately treat the final component as a link; boundary sites take realpath.

TWO SITES WITH AN INVERTED CONTRACT, which a mechanical swap would have broken.
`installer-migrations.cts:127` and `runtime-artifact-install-plan.cts:144` REJECT
`target === root` by contract, while the canonical comparison ACCEPTS it. Swapped
naively, a migration could `rmdir` the user's config root and a third-party
descriptor could write at configHome itself. Both keep `=== root` as an explicit
additional arm alongside the predicate call — the predicate decides containment,
the call site keeps its own extra condition (ADR-4650 decision 6).

ONE DUPLICATE DELETED OUTRIGHT: `planning-inspect.cts`'s `isWithinRoot` was
byte-identical to `isContainedIn` and said so in its own docstring.
`isContainedIn` is now exported for callers that have already resolved both
operands and need only the comparison, with a doc note that a caller which has
NOT resolved them must use a full predicate instead.

THE MARKER, AND WHY IT IS NOT THE ALLOWLIST. Nine sites are justified holdouts and
carry `// allow-handrolled-containment: <reason>` with a mandatory, reviewable
reason. Two justifications: (a) not a containment decision — an ancestor-walk loop
condition, sub-repo grouping, worktree identity matching, declared-path coverage;
(b) it IS containment but the canonical predicate is unreachable —
`capability-validator.cjs` is a committed pre-build `.cjs` and the compiled
`security.cjs` is untracked build output, so requiring it would break a fresh
clone. `scripts/lib/drift-scan.cjs` runs under `lint:ci` with the same exposure.
The marker was renamed from `allow-lexical-prefix-match` mid-phase because that
name asserted only (a) and would have stated something false at the (b) sites.

A marker suppresses BEFORE the violation counter increments, so a file whose
every occurrence is marked still reports `staleAllowlistEntry` — otherwise a
drained entry lingers and silently re-permits the site later.

DEMONSTRATED RED, per #4654: a hand-rolled copy reintroduced into a real `src/`
file made `npm run lint` fail with the rule's full guidance message; removing it
returned the tree to clean. Both halves recorded — red alone proves nothing,
since a rule red for an unrelated reason looks identical.

DISCLOSED: `defaultRequireFromInstallRoot` (gsd-tools.cjs) previously carried two
distinct rejection messages and two manual realpath calls; routing it through
`tryWithinRoot` collapses them to one message, and a missing module now surfaces
as MODULE_NOT_FOUND rather than ENOENT. No test asserts either message. The
security property is preserved and slightly strengthened — the candidate is
realpathed and containment re-checked, and the dangling-symlink oracle closure
comes along with it.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* docs(#4654): record the containment ratchet in CONTEXT.md and the security model

Both entries previously described the seam without the thing that keeps it a
seam. They now state what the rule bans, and — more usefully for whoever reads
this next — what it deliberately does NOT attempt: deciding per path.join call
whether an argument came from user input. That question is not locally
decidable, and an approximation across ~2000 join sites would earn an exemption
list of hundreds, which is the opposite of a ratchet.

Also records the marker's two legitimate justifications and that its reason is
mandatory, so the escape stays reviewable rather than becoming a mute button.

Glossary gate 270 refs exit 0; install-tree goldens and CONTEXT-INDEX.json
regenerated and confirmed byte-identical rather than assumed — which also
confirms eslint-rules/ is not a shipped path.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* fix(#4654): close review findings and the two matrix failures

MATRIX FAILURE 1 — a collapsed message broke a negative-proof test, and my
evidence for collapsing it was wrong. I searched tests/ for the literal string
"resolves outside its install root", found nothing, and reported that no test
asserted it. The test matches a REGEX SUBSTRING, /outside its install root/, so
the literal search missed it. What broke was "NEGATIVE PROOF: a symlinked module
pointing OUTSIDE the install root is not loaded" — the test guarding the exact
property I claimed was preserved. defaultRequireFromInstallRoot now does both
checks again with both messages byte-identical, each routed through the
canonical predicate, which is better than the original since that hand-rolled
both comparisons.

MATRIX FAILURE 2 — shipped migrations are checksum-locked, and a marker cannot
serve there. migrationChecksum hashes plan.toString(), which INCLUDES comments,
so a suppression marker inside a plan body drifts the baseline exactly as an
edit does. Measured: with markers in place, two of the four still differed from
their committed checksums. The four shipped bodies are now byte-identical to
next, and the rule's config excludes those four paths BY NAME rather than by a
directory wildcard, so a NEW migration is still covered. Six containment
comparisons stay un-ratcheted there; that gap is recorded in the rule's Known
gaps, in CONTEXT.md and in the security model rather than left implicit.
Justification (c) is removed from the marker's documented reasons, because a
marker was proven unable to express it.

ADVERSARIAL REVIEW — the sharpest finding was that the rule banned the CORRECT
shape while permitting the incorrect one: startsWith(root) with no separator is
the genuinely unsafe form, since it accepts a sibling such as root-evil, and my
own test blessed it as valid. Flagging every bare startsWith would swamp the
rule, so that stays a STATED gap rather than a silent one. Closed for real: the
template-literal spelling, which the census never saw because it only inspected
plus-concatenation — that surfaced TWELVE more sites, now triaged and migrated.
A separator reached through a const alias is now resolved via scope analysis.
And isContainedIn, exported in Phase 3, was missing from the discarded-result
set, so a bare no-op call went unflagged on the one function the epic funnels
through.

SECURITY REVIEW — the marker could over-suppress two ways: a block comment
worked identically to a line comment, and one marker silently covered every
violation sharing its line. It now requires a Line comment positioned after the
flagged node ends, so it anchors to the node it trails. Four sites had dropped
an unreachable-but-deliberate equality rejection against the root; each is
restored as the call site's own arm. eslint.config.mjs still documented the OLD
marker token, which my rename missed — it would have sent the next author in
circles.

A FALSE GREEN, recorded because it nearly stuck: lint:ci reported exit 0 from a
stale eslint cache while twelve real violations existed. Every lint check here
now clears the cache first.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* fix(#4654): anchor a suppression marker to the violation it actually trails

The matrix caught this; my own test caught it, on its first execution. The case
"two violations on one line: trailing marker suppresses only the one it trails"
expected 1 error and got 0 — both were suppressed.

ROOT CAUSE: the anchoring accepted any Line comment on the node's line whose
range started at or after the node's end. A trailing marker at the END of a line
sits after EVERY node on that line, so that condition held for all of them.
"After the node" does not identify WHICH node the marker trails. The fix reads
as correct and is not.

FIX: deferred reporting. Violations accumulate during traversal instead of being
reported immediately; at Program:exit each marker claims exactly ONE pending
violation — the one on its line whose end is nearest before the marker begins —
and every unclaimed violation is then counted and reported. One marker, one
suppression. An earlier violation sharing the line is still reported, which is
the property the security review asked for and the previous attempt only
appeared to deliver.

The counter now increments at flush time rather than during traversal, so a
suppressed occurrence still does not keep an allowlist entry alive.

AND A TOOL THAT SHOULD HAVE EXISTED BEFORE THE FIRST MATRIX RUN. `node --test`
is hard-blocked here, so this rule's test file could only ever be executed on
the remote matrix — which is why a broken anchoring shipped into a run. ESLint's
programmatic Linter API is not a test runner, and exercising the rule through it
verifies every case locally in seconds. All 24 now pass locally, including the
two-on-one-line case that failed remotely. That loop should have been built
before the rule was first sent to the matrix rather than after it failed twice.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* chore(#4654): backfill PR 4674 into the changeset and complete 70-docs.json

The phase gate requires enablementSequence and the Diataxis quadrants; 70-docs
now carries both, with the how-to quadrant skipped for a stated reason rather
than an empty field. The audience for this deliverable is a contributor who
trips the rule, and the task-oriented guidance reaches them in the ESLint
message itself — which names the correct predicate, says how to choose between
the realpath and lexical families, cites the Phase 3 regression caused by
choosing wrong, and gives the marker syntax. A docs/how-to page would be a
second, driftable copy read by nobody at the moment of failure.

enablementSequence is recorded as what it actually is: a VERIFICATION sequence,
not an enablement one. The rule is never off, so there is no off-to-on
transition to describe.

scripts/lint-docs-required.cjs now passes (ok_docs_updated) — it could not
evaluate against the mandated pr:0 placeholder.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

---------

Co-authored-by: sim <sim@local>
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
2026-09-12 22:17:46 -04:00

25 KiB

GSD Core security model

Explanation — This document describes why GSD Core has the security posture it does and how the layers fit together. It is not a reference for every hook parameter. For the /gsd-secure-phase command and its options, see Commands. For the implementation-level hook architecture, see Architecture § Hook System. For the org-wide security baseline (scanner controls, incident checklists, ownership model), see SECURITY.md.


Why AI-driven development needs a dedicated security posture

A conventional code editor does not execute arbitrary packages on your behalf. GSD Core does. The research → plan → execute pipeline automates the full path from "name a package" to "run npm install <package>", from "write a planning artifact" to "use that artifact as an LLM system prompt". Each automation step removes a human from the loop — and each removal is a potential attack surface.

GSD Core's security model is built around one organising principle: defence in depth. No single control is assumed to be perfect. Several overlapping layers each reduce a distinct class of risk, and together they make the attack surface substantially harder to exploit without eliminating it entirely. The honest summary at the end of this document explains what the system cannot protect against.


Layer 1 — Supply-chain protection: the Package Legitimacy Gate

The threat

AI models hallucinate package names. This is not a fringe failure mode: 2025 research documents roughly 20 % of AI-generated package references as hallucinated names that do not correspond to legitimate packages. A subset of those hallucinated names — approximately 43 % in the same research — recur consistently across prompts, meaning an attacker can observe which names AI tools commonly produce and pre-register those names on npm, PyPI, or crates.io with malicious post-install scripts. The technique is called slopsquatting.

The insidious quality of slopsquatting is that a hallucinated name that passes npm view looks legitimate. The registry entry proves only that someone registered the name — not that the package does what the AI said it does, not that it has any legitimate users, and not that its install scripts are safe. Without a gate, a hallucinated name would flow undetected through GSD's researcher → planner → executor pipeline and eventually run as npm install <attacker-package> on your machine.

How the gate works

The gate operates across three pipeline stages:

Research stage. When gsd-phase-researcher recommends external packages, it runs gsd-tools query package-legitimacy check --ecosystem <npm|pypi|crates> <pkgs> against each one. Verdicts (OK|SUS|SLOP) are computed from live registry APIs against thresholds { minAgeDays: 30, minWeeklyDownloads: 1000, requireRepo: true }, plus terminal short-circuits for non-existence and suspicious postinstall scripts. The results are written to a ## Package Legitimacy Audit table in RESEARCH.md. Packages tagged [SLOP] (high-confidence hallucination or attacker-registered) are stripped from RESEARCH.md entirely before the file is saved. They never reach the planner.

Planning stage. gsd-planner reads the Audit table. For any package tagged [SUS] (suspicious: newly registered, low download count, no source repository, or naming pattern close to a popular package) or [ASSUMED] (sourced from WebSearch rather than direct registry verification), the planner inserts a checkpoint:human-verify task before the install step. The checkpoint includes a direct link to the registry page and specific things to look for: maintainer history, issue-tracker activity, absence of suspicious install scripts.

Execution stage. If an install fails, gsd-executor surfaces a checkpoint and stops. It does not silently try an alternative package name — which could itself be malicious. This is an explicit rule in the executor's behaviour (RULE 3 in the executor agent definition).

Why WebSearch packages are always [ASSUMED]

Package names discovered through WebSearch are tagged [ASSUMED] regardless of whether npm view succeeds. A package that exists on the registry is not the same as a package that is safe to install. npm view proves registration, not legitimacy. The [ASSUMED] tag triggers the same human-verify checkpoint as [SUS], ensuring that any unverified web-discovered recommendation always gets a human review before installation.

Ecosystem coverage

The gate resolves signals directly from each ecosystem's registry API rather than a single generic check:

  • Node.js: registry.npmjs.org (age, repository URL, postinstall script) plus api.npmjs.org/downloads (weekly downloads)
  • Python: pypi.org/pypi/<pkg>/json (age, repository URL)
  • Rust: the crates.io API (age, weekly downloads, repository URL)

This covers cross-ecosystem hallucination, which occurs at roughly 9 % according to 2025 USENIX research — cases where an AI recommends a package that exists in one ecosystem but not the one actually in use.

Graceful degradation

Each registry adapter has a 5-second timeout and returns degraded (all-null) signals on a failed lookup rather than throwing. Missing signals surface as unknown-age / unknown-downloads reasons, which push a package to [SUS] — and [SUS] is gated behind the same checkpoint:human-verify task as [ASSUMED]. The gate fails toward human review, not silence, and research and planning proceed normally: nothing here hard-fails on a network or tool outage.

slopcheck is an optional adapter that can only escalate a verdict, never lower it, and is not the install-or-degrade gate. No shipped configuration wires it; its absence leaves registry-API verdicts intact rather than downgrading everything to [ASSUMED].


Layer 2 — Prompt injection defences

The threat

GSD Core generates Markdown files that become LLM system prompts. The research pipeline reads external web content; the planning pipeline incorporates user-supplied text (--text-file, --prd); the execution pipeline writes planning artifacts that are later re-read as agent context. Any user-controlled text flowing into these artifacts is a potential indirect prompt injection vector — an attacker-controlled string that, once inside a system prompt, attempts to override the agent's instructions or exfiltrate information.

How the defences work

GSD Core addresses prompt injection at three levels.

Input validation (security.cjs). The gsd-core/bin/lib/security.cjs module is the central security utility. It provides:

  • Path containment: user-supplied file paths and directories are validated to resolve within a declared root before any filesystem access. One predicate answers this for the whole tree (epic #4636, ADR-4650). The resolution engine is module-internal and resolves symlinks, closes a dangling-symlink existence oracle, and canonicalizes ancestors so a not-yet-created path under a non-canonical base (macOS /var → /private/var) still resolves. The exported surface is assertWithinRoot (throws), tryWithinRoot (returns null), and requireSafePath (a preserved alias of the throwing form). All three return a branded ContainedPath: a plain string is not assignable to it, so validating one path and then handing a different one to the filesystem is a type error rather than a silent bug. Whether an absolute candidate is considered at all is a named policy — PathAcceptance.RelativeOnly or PathAcceptance.AbsoluteInsideRoot — and neither relaxes containment: an absolute path resolving outside the root is rejected exactly as a traversal is. A caller may decide how to degrade on rejection, never whether a path is contained.
  • Prompt injection detection: known injection patterns (role overrides, instruction bypasses, system tag injections) are scanned in user-supplied text before it enters any planning artifact
  • Safe JSON parsing: a wrapper that prevents prototype-pollution attacks via crafted JSON payloads
  • Shell argument validation: arguments passed to subshell commands are validated before use

Containment is decided in exactly one place, but resolved two ways. The comparison itself — separator-aware, so a sibling merely sharing a prefix is never accepted — is internal to security.cjs and is the single decision. Two exported families sit on it and differ only in how a candidate is resolved before that decision: assertWithinRoot / tryWithinRoot resolve symlinks, and assertWithinRootLexical / tryWithinRootLexical use string resolution alone and never touch the filesystem.

The lexical form exists because a realpath-based predicate is the wrong tool wherever a symlink must be preserved rather than resolved, or where the target legitimately does not exist yet. A lexical check cannot see a symlink, so a caller relying on one for a write-confinement guarantee must pair it with its own symlink refusal. Three call sites use it, each for a stated reason.

The backup-restore gate in gsd-core/bin/gsd-tools.cjs rejects symlinks outright: the canonical predicate accepts a link whose target resolves inside the root, but for a restore that is still wrong, because writing through the link overwrites whatever it points at instead of materializing a regular file at the backed-up path. isPathConfined in src/external-descriptor-trust.cts is lexical by design, because two install callers must validate a destination before the mkdirSync that creates it, where realpath cannot resolve. And ensureInsideConfig in src/installer-migrations.cts is lexical because that module's contract is that a symlinked managed path is snapshotted, restored and backed up as a link and never dereferenced — resolving it would dereference precisely the links the module exists to preserve, and then reject them for escaping the config directory.

A lexical check cannot see a symlink, so callers that rely on one for a write-confinement guarantee must pair it with their own symlink refusal. Three install call sites did not, and now do: a link planted at a capability skill's destination made mkdirSync succeed silently and redirected the write outside the install root, and a link planted at a capability's own SKILL.md was followed by statSync, so an outside file's contents were installed as a skill body.

The ratchet. A convention saying "remember to use the predicate" is exactly what produced the unvalidated sites in the first place, so the rule local/no-unconfined-path-join enforces it under npm run lint with an empty allowlist. It bans the hand-rolled comparison X.startsWith(Y + separator) and a containment predicate called as a bare statement with its answer discarded. It deliberately does not try to decide, for each of the repository's ~2000 path.join calls, whether an argument came from user input — that question is not answerable locally, and a rule that fires on hundreds of correct sites earns an exemption list of hundreds. What actually gets copied is the comparison.

A site that legitimately cannot use the predicate carries a comment // allow-handrolled-containment: <reason> naming why: either the comparison is not a containment decision (an ancestor-walk loop, identity matching), or the predicate is unreachable — two files run before the compiled module they would need to import exists. The reason is mandatory and reviewable; the rule does not accept an empty one.

A marker cannot cover a shipped, checksum-locked artifact whose body must not change: the four src/installer-migrations/*.cts bodies hashed against EXPECTED_CHECKSUMS (#670) hash plan.toString(), the function's source text INCLUDING comments, so a marker placed inside the body drifts the checksum exactly as an edit would — verified directly against the committed baseline. These four files are instead excluded from the rule entirely, by exact path in eslint.config.mjs's ignores (not a directory wildcard, so a new migration file is still linted), leaving their hand-rolled comparisons permanently un-ratcheted; the only remedy is a fix-forward migration, never an edit to a shipped body.

Runtime hook: gsd-prompt-guard.js. This hook fires on every Write or Edit call that targets .planning/ files. It scans the content being written for injection patterns shared with gsd-read-injection-scanner.js through hooks/lib/injection-patterns.js — one module both hooks require(), so the two surfaces cannot drift apart (#3504). The set is deliberately a subset of security.cjs's patterns: the hooks stay loadable standalone, without the compiled lib tree. Detection is advisory-only: the hook logs the finding but does not block the write. The rationale is that a false-positive block on a legitimate planning write would be more disruptive than a missed injection in a secondary scan layer.

Runtime hook: gsd-read-injection-scanner.js. This hook fires on the output of every Read, WebFetch, and WebSearch tool call. It scans the content that was just read or fetched for injected instructions in untrusted content — catching cases where an attacker has embedded instructions in a file or remote resource that GSD is about to incorporate into an agent's context. The 10 research and doc-ingest agents additionally carry a shared <security_context> data/instruction boundary (defined in gsd-core/references/untrusted-input-boundary.md): gsd-project-researcher, gsd-phase-researcher, gsd-ui-researcher, gsd-assumptions-analyzer, gsd-advisor-researcher, gsd-doc-classifier, gsd-doc-synthesizer, gsd-research-synthesizer, gsd-ai-researcher, and gsd-domain-researcher. Any content fetched or read by those agents is treated as data, never as instructions, regardless of what the content claims to be.

Opt-in blocking (security.injection_blocking). By default all injection detections are advisory-only (logged, not blocked). Setting security.injection_blocking = true in .planning/config.json (a registered config key — gsd config-set security.injection_blocking true) upgrades HIGH-confidence detections to blocking. Be precise about what this does: the scanner is a PostToolUse hook, so it runs after the Read/WebFetch/WebSearch has already executed and the fetched content is already in the model's transcript. Blocking does not retroactively redact that content — it emits decision: "block", which halts the agent's next step and feeds the detection back as the reason, so the agent is stopped from acting further on the flagged result instead of silently continuing. LOW detections remain advisory under this setting. This flag is opt-in; the default (advisory-only) is preserved to avoid breaking existing workflows. The prompt-level boundary above (treat fetched text as data, never instructions) is the layer that keeps an injection from being followed even while it sits in context; the hook is a coarse pattern pre-filter and circuit-breaker, not a redactor.

CI scanner. prompt-injection-scan.security.test.cjs scans all agent, workflow, and command files for embedded injection vectors as part of the test suite. This catches injection attempts in the GSD source itself — for example, a supply-chain attack that modified a workflow file to add a role-override instruction.

Read Injection Scanner vs Prompt Guard

The two hooks cover complementary surfaces. gsd-prompt-guard.js watches writes to planning artifacts — it catches injection being planted. gsd-read-injection-scanner.js watches reads and remote fetches — it catches injection being ingested from external content (a dependency's README, a third-party config file, a user-provided document, or any URL fetched via WebFetch or WebSearch). The in-prompt <security_context> boundary in research agents provides an additional containment layer: even if an injected string reaches an agent, it is structurally separated from the instruction region. Together these controls bracket the ingest → store → re-read lifecycle.

Runtime hook: gsd-workflow-guard.js — advisory vs. blocking posture. This hook has two legs with two deliberately different failure postures. The edit leg is advisory: when hooks.workflow_guard is enabled it warns on edits made outside a GSD workflow, and on any internal error it fails open (exit 0) — a broken advisory must never wedge a session's tool calls. The Bash leg carries the hook's one hard block: git add -f / git add --force on an agent-* or worktree-agent-* branch is blocked outright (WORKTREE_AGENT_FORCE_ADD_FORBIDDEN, exit 2), enforcing the skipped-gitignored contract. When the guard is enabled, this block leg fails closed (#3504): if an internal error strikes before the block decision and the blocking context can be re-derived from the payload (a Bash tool call, the guard enabled, the branch determinably an agent branch), the hook exits 2 rather than silently allowing. What it cannot establish — an unparseable payload, a non-Bash tool, the guard disabled, or a branch it cannot determine — still fails open. The known trade-off: on an agent branch with the guard enabled, a Bash call that trips an internal error is blocked even when it was not a force-add; that is the conservative direction for the one hard block this hook owns.


Layer 3 — Repository and dependency integrity

Upstream of GSD's runtime behaviour, the open-gsd organisation enforces controls at the repository and package level. These are documented in full in docs/security/baseline.md and are summarised here for completeness.

Dependency integrity. All third-party dependencies are pinned via package-lock.json and verified against published checksums before install. A scripts/check-npm-integrity.cjs gate detects invalid versions, missing packages, and extraneous packages at CI time. This mitigates dependency confusion and typosquatting attacks against GSD's own dependencies.

Secret scanning. Every commit and PR is scanned for hardcoded secrets. Intentional test fixtures must be annotated with the project-standard exclusion grammar (see SECURITY.md for the annotation format). Un-annotated suppressions fail CI.

Locale-safe text scanning. Output and user-facing strings are scanned for Unicode homoglyphs, bidirectional override characters, and invisible Unicode — the class of attacks documented in CVE-2021-42574 ("Trojan Source") that can hide malicious content in diffs.


Layer 4 — Subprocess execution

GSD starts external programs constantly: git, npm, reviewer CLIs declared by capabilities, and whatever a gate predicate names. Every one of those is a place where an argument could become a command. One module owns the whole question — src/shell-command-projection.cts, the single platform seam.

No shell: true for binary invocation. Passing shell: true on Windows is the mechanism behind CVE-2024-27980: the shell re-parses the argument list, so a value containing & or | stops being data and becomes a second command. Node 26 additionally deprecates shell: true alongside an argument array (DEP0190), because arguments are concatenated rather than escaped. GSD resolves binaries explicitly instead.

Explicit resolution, not shell lookup. resolveExecutableBinary scans PATH and, on Windows, the PATHEXT extensions, and returns the resolved path. It never tries the bare name on Windows: npm global installs drop an extensionless POSIX sh shim beside foo.CMD, and resolving to that shim is how the reviewer lanes failed with spawn ENOENT (#3275). On macOS and Linux the bare name goes to spawnSync unchanged, so the operating system's own lookup keeps doing the work.

Mediating .cmd and .bat safely. Windows CreateProcess cannot execute a batch file at all, so one must be run through cmd.exe. That is where the injection risk actually lives, and it is not solved by resolution alone. projectSpawnInvocation builds the command line itself and passes it through verbatim: one outer quote pair that cmd /c strips, every token inside force-quoted, embedded quotes doubled. Force-quoting is the point — an unquoted a&calc is split by cmd into two commands, while a quoted "a&calc" is one literal argument. This is the shape Rust's standard library adopted for the sibling CVE-2024-24576.

Relying on the default argument escaping would not be enough. Node's own CVE-2024-27980 protection fires only when the program being started is itself the .bat or .cmd; once the program is cmd.exe, that check no longer applies, and the underlying quoting only quotes arguments containing spaces, tabs, or quotes — never one containing a bare &.

An argument containing a carriage return or newline is refused rather than mediated. A newline cannot be represented in a Windows command line, so mediating it would silently truncate the argument; failing visibly is the safer outcome.


Trade-offs and limits

The security model described here meaningfully reduces the attack surface for AI-driven development. It does not eliminate supply-chain risk.

What the Package Legitimacy Gate reduces: The probability that a hallucinated or attacker-registered package reaches npm install without a human checkpoint. The [SLOP] gate removes high-confidence bad packages entirely; the [SUS] / [ASSUMED] gates require human review before execution. This substantially raises the cost of a successful slopsquatting attack.

What the Package Legitimacy Gate does not eliminate: A legitimate package that is later compromised (account takeover, dependency confusion in its own tree) is not caught by the registry-API gate, which checks registration signals at research time. Lock files and npm audit at the dependency-integrity layer are the controls for that class of attack.

What the prompt injection defences reduce: The probability that user-controlled text in planning artifacts successfully overrides agent instructions. Pattern-matching on known injection forms catches the common cases; novel jailbreaks or low-signal injections may pass undetected. The advisory-only posture means detection is logged but not blocked — a deliberate choice that preserves workflow continuity at the cost of not hard-stopping on a detection.

What the prompt injection defences do not eliminate: A sufficiently creative injection that does not match known patterns, or an injection that arrives through a channel the hooks do not cover. The previously uncovered channel of content injected into a dependency's published README and read by a subagent browsing documentation is now scanned at ingress by gsd-read-injection-scanner.js (which covers WebFetch and WebSearch output) and structurally isolated in-prompt by the <security_context> boundary in research agents — but novel jailbreaks and low-signal injections may still pass undetected. Defence in depth means each layer makes the attack harder, not that any single layer makes it impossible.

What the UI-SPEC provenance rule does not eliminate: gsd-ui-checker Dimension 7 requires a component inventory to record the command that enumerated it, and instructs the checker never to run that command — it is text from a document, not an instruction to the agent. That barrier is prompt-level only. The checker holds a Bash grant it genuinely needs (the agent-skills bootstrap shells out through gsd_run), and tool grants here are not command-scoped, so nothing structurally prevents execution of a command string lifted out of a UI-SPEC. No shipped instruction does so, and the spec is written by gsd-ui-researcher, which carries the <security_context> untrusted-input boundary for its web and MCP ingress — but this is defense by instruction, not by capability. The same shape is older and wider in Dimension 6, where the researcher is told to run npx shadcn view {block} --registry {url} with a registry URL taken from the spec; there the execution is the vetting gate's purpose rather than something to suppress.

Note also what a provenance line is worth: it makes an inventory's origin falsifiable, not verified. A fabricated line passes the dimension. Its value is that the recorded command can be re-run by a reader, which was not possible before the field existed.

What subprocess execution does not eliminate: cmd.exe expands %VAR% inside a /c string, and there is no escape for % outside a batch file. An argument containing %FOO% is therefore substituted with the environment value before the target program sees it. That is information disclosure, not arbitrary execution — the force-quoting still prevents an argument from becoming a second command — and it is the same residual limit Rust's standard library documents for its own batch-file handling. Callers that pass untrusted text as an argument to a Windows .cmd or .bat should not assume the value arrives byte-identical.

Reporting vulnerabilities. Report via private GitHub security advisory at https://github.com/open-gsd/gsd-core/security/advisories/new. Do not open public issues. See SECURITY.md for the response timeline and disclosure policy.


  • Commands — includes /gsd-secure-phase and /gsd-code-review with security-relevant flags
  • Architecture § Hook System — implementation detail on every hook, its event trigger, and safety properties
  • SECURITY.md — vulnerability reporting, org-wide security baseline, secret-scan exclusion governance, and dependency integrity verification
  • Docs index