* feat: add unified post-planning gap checker (closes #2493) Adds a unified post-planning gap checker as Step 13e of plan-phase.md. After all plans are generated and committed, scans REQUIREMENTS.md and CONTEXT.md <decisions> against every PLAN.md in the phase directory and emits a single Source | Item | Status table. Why - The existing Requirements Coverage Gate (§13) blocks/re-plans on REQ gaps but emits two separate per-source signals. Issue #2493 asks for one unified report after planning so that requirements AND discuss-phase decisions slipping through are surfaced in one place before execution starts. What - New workflow.post_planning_gaps boolean config key, default true, added to VALID_CONFIG_KEYS, CONFIG_DEFAULTS, hardcoded.workflow, and cmdConfigSet (boolean validation). - New get-shit-done/bin/lib/decisions.cjs — shared parser for CONTEXT.md <decisions> blocks (D-NN entries). Designed for reuse by the related #2492 plan/verify decision gates. - New get-shit-done/bin/lib/gap-checker.cjs — parses REQUIREMENTS.md (checkbox + traceability table forms), reads CONTEXT.md decisions, walks PHASE_DIR/*-PLAN.md, runs word-boundary coverage detection (REQ-1 must not match REQ-10), formats a sorted report. - New gsd-tools gap-analysis CLI command wired through gsd-tools.cjs. - workflows/plan-phase.md gains §13e between §13d (commit plans) and §14 (Present Final Status). Existing §13 gate preserved — §13e is additive and non-blocking. - sdk/prompts/workflows/plan-phase.md gets an equivalent post_planning_gaps step for headless mode. - Docs: CONFIGURATION.md, references/planning-config.md, INVENTORY.md, INVENTORY-MANIFEST.json all updated. Tests - tests/post-planning-gaps-2493.test.cjs: 30 test cases covering step insertion position, decisions parser, gap detector behavior (covered/not-covered, false-positive guard, missing-file resilience, malformed-input resilience, gate on/off, deterministic natural sort), and full config integration. - Full suite: 5234 / 5234 pass. Design decisions - Numbered §13e (sub-step), not §14 — §14 already exists (Present Final Status); inserting before it preserves downstream auto-advance step numbers. - Existing §13 gate kept, not replaced — §13 blocks/re-plans on REQ gaps; §13e is the unified post-hoc report. Per spec: "default behavior MUST be backward compatible." - Word-boundary ID matching avoids REQ-1 matching REQ-10 and avoids brittle semantic/substring matching. - Shared decisions.cjs parser so #2492 can reuse the same regex. - Natural-sort keys (REQ-02 before REQ-10) for deterministic output. - Boolean validation in cmdConfigSet rejects non-boolean values matches the precedent set by drift_threshold/drift_action. Closes #2493 * fix(#2493): expose post_planning_gaps in loadConfig() + sync schema example Address CodeRabbit review on PR #2610: - core.cjs loadConfig(): return post_planning_gaps from both the config.json branch and the global ~/.gsd/defaults.json fallback so callers can rely on config.post_planning_gaps regardless of whether the key is present (comment 3127977404, Major). - docs/CONFIGURATION.md: add workflow.post_planning_gaps to the Full Schema JSON example so copy/paste users see the new toggle alongside security_block_on (comment 3127977392, Minor). - tests/post-planning-gaps-2493.test.cjs: regression coverage for loadConfig() — default true when key absent, honors explicit true/false from workflow.post_planning_gaps.
184 lines
5.5 KiB
JavaScript
184 lines
5.5 KiB
JavaScript
'use strict';
|
|
|
|
/**
|
|
* Post-planning gap analysis (#2493).
|
|
*
|
|
* Reads REQUIREMENTS.md (planning-root) and CONTEXT.md (per-phase) and compares
|
|
* each REQ-ID and D-ID against the concatenated text of all PLAN.md files in
|
|
* the phase directory. Emits a unified `Source | Item | Status` report.
|
|
*
|
|
* Gated on workflow.post_planning_gaps (default true). When false, returns
|
|
* { enabled: false } and does not scan.
|
|
*
|
|
* Coverage detection uses word-boundary regex matching to avoid false positives
|
|
* (REQ-1 must not match REQ-10).
|
|
*/
|
|
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
const { planningPaths, planningDir, escapeRegex, output, error } = require('./core.cjs');
|
|
const { parseDecisions } = require('./decisions.cjs');
|
|
|
|
/**
|
|
* Parse REQ-IDs from REQUIREMENTS.md content.
|
|
*
|
|
* Supports both checkbox (`- [ ] **REQ-NN** ...`) and traceability table
|
|
* (`| REQ-NN | ... |`) formats.
|
|
*/
|
|
function parseRequirements(reqMd) {
|
|
if (!reqMd || typeof reqMd !== 'string') return [];
|
|
const out = [];
|
|
const seen = new Set();
|
|
|
|
const checkboxRe = /^\s*-\s*\[[x ]\]\s*\*\*(REQ-[A-Za-z0-9_-]+)\*\*\s*(.*)$/gm;
|
|
let cm = checkboxRe.exec(reqMd);
|
|
while (cm !== null) {
|
|
const id = cm[1];
|
|
if (!seen.has(id)) {
|
|
seen.add(id);
|
|
out.push({ id, text: (cm[2] || '').trim() });
|
|
}
|
|
cm = checkboxRe.exec(reqMd);
|
|
}
|
|
|
|
const tableRe = /\|\s*(REQ-[A-Za-z0-9_-]+)\s*\|/g;
|
|
let tm = tableRe.exec(reqMd);
|
|
while (tm !== null) {
|
|
const id = tm[1];
|
|
if (!seen.has(id)) {
|
|
seen.add(id);
|
|
out.push({ id, text: '' });
|
|
}
|
|
tm = tableRe.exec(reqMd);
|
|
}
|
|
|
|
return out;
|
|
}
|
|
|
|
function detectCoverage(items, planText) {
|
|
return items.map(it => {
|
|
const re = new RegExp('\\b' + escapeRegex(it.id) + '\\b');
|
|
return {
|
|
source: it.source,
|
|
item: it.id,
|
|
status: re.test(planText) ? 'Covered' : 'Not covered',
|
|
};
|
|
});
|
|
}
|
|
|
|
function naturalKey(s) {
|
|
return String(s).replace(/(\d+)/g, (_, n) => n.padStart(8, '0'));
|
|
}
|
|
|
|
function sortRows(rows) {
|
|
const sourceOrder = { 'REQUIREMENTS.md': 0, 'CONTEXT.md': 1 };
|
|
return rows.slice().sort((a, b) => {
|
|
const so = (sourceOrder[a.source] ?? 99) - (sourceOrder[b.source] ?? 99);
|
|
if (so !== 0) return so;
|
|
return naturalKey(a.item).localeCompare(naturalKey(b.item));
|
|
});
|
|
}
|
|
|
|
function formatGapTable(rows) {
|
|
if (rows.length === 0) {
|
|
return '## Post-Planning Gap Analysis\n\nNo requirements or decisions to check.\n';
|
|
}
|
|
const header = '| Source | Item | Status |\n|--------|------|--------|';
|
|
const body = rows.map(r => {
|
|
const tick = r.status === 'Covered' ? '\u2713 Covered' : '\u2717 Not covered';
|
|
return `| ${r.source} | ${r.item} | ${tick} |`;
|
|
}).join('\n');
|
|
return `## Post-Planning Gap Analysis\n\n${header}\n${body}\n`;
|
|
}
|
|
|
|
function readGate(cwd) {
|
|
const cfgPath = path.join(planningDir(cwd), 'config.json');
|
|
try {
|
|
const raw = JSON.parse(fs.readFileSync(cfgPath, 'utf-8'));
|
|
if (raw && raw.workflow && typeof raw.workflow.post_planning_gaps === 'boolean') {
|
|
return raw.workflow.post_planning_gaps;
|
|
}
|
|
} catch { /* fall through */ }
|
|
return true;
|
|
}
|
|
|
|
function runGapAnalysis(cwd, phaseDir) {
|
|
if (!readGate(cwd)) {
|
|
return {
|
|
enabled: false,
|
|
rows: [],
|
|
table: '',
|
|
summary: 'workflow.post_planning_gaps disabled — skipping post-planning gap analysis',
|
|
counts: { total: 0, covered: 0, uncovered: 0 },
|
|
};
|
|
}
|
|
|
|
const absPhaseDir = path.isAbsolute(phaseDir) ? phaseDir : path.join(cwd, phaseDir);
|
|
|
|
const reqPath = planningPaths(cwd).requirements;
|
|
const reqMd = fs.existsSync(reqPath) ? fs.readFileSync(reqPath, 'utf-8') : '';
|
|
const reqItems = parseRequirements(reqMd).map(r => ({ ...r, source: 'REQUIREMENTS.md' }));
|
|
|
|
const ctxPath = path.join(absPhaseDir, 'CONTEXT.md');
|
|
const ctxMd = fs.existsSync(ctxPath) ? fs.readFileSync(ctxPath, 'utf-8') : '';
|
|
const dItems = parseDecisions(ctxMd).map(d => ({ ...d, source: 'CONTEXT.md' }));
|
|
|
|
const items = [...reqItems, ...dItems];
|
|
|
|
let planText = '';
|
|
try {
|
|
if (fs.existsSync(absPhaseDir)) {
|
|
const files = fs.readdirSync(absPhaseDir).filter(f => /-PLAN\.md$/.test(f));
|
|
planText = files.map(f => {
|
|
try { return fs.readFileSync(path.join(absPhaseDir, f), 'utf-8'); }
|
|
catch { return ''; }
|
|
}).join('\n');
|
|
}
|
|
} catch { /* unreadable */ }
|
|
|
|
if (items.length === 0) {
|
|
return {
|
|
enabled: true,
|
|
rows: [],
|
|
table: '## Post-Planning Gap Analysis\n\nNo requirements or decisions to check.\n',
|
|
summary: 'no requirements or decisions to check',
|
|
counts: { total: 0, covered: 0, uncovered: 0 },
|
|
};
|
|
}
|
|
|
|
const rows = sortRows(detectCoverage(items, planText));
|
|
const uncovered = rows.filter(r => r.status === 'Not covered').length;
|
|
const covered = rows.length - uncovered;
|
|
|
|
const summary = uncovered === 0
|
|
? `\u2713 All ${rows.length} items covered by plans`
|
|
: `\u26A0 ${uncovered} of ${rows.length} items not covered by any plan`;
|
|
|
|
return {
|
|
enabled: true,
|
|
rows,
|
|
table: formatGapTable(rows) + '\n' + summary + '\n',
|
|
summary,
|
|
counts: { total: rows.length, covered, uncovered },
|
|
};
|
|
}
|
|
|
|
function cmdGapAnalysis(cwd, args, raw) {
|
|
const idx = args.indexOf('--phase-dir');
|
|
if (idx === -1 || !args[idx + 1]) {
|
|
error('Usage: gap-analysis --phase-dir <path-to-phase-directory>');
|
|
}
|
|
const phaseDir = args[idx + 1];
|
|
const result = runGapAnalysis(cwd, phaseDir);
|
|
output(result, raw, result.table || result.summary);
|
|
}
|
|
|
|
module.exports = {
|
|
parseRequirements,
|
|
detectCoverage,
|
|
formatGapTable,
|
|
sortRows,
|
|
runGapAnalysis,
|
|
cmdGapAnalysis,
|
|
};
|