* feat(sdk): golden parity harness and query handler CJS alignment (#2302 Track A) Golden/read-only parity tests and registry alignment, query handler fixes (check-completion, state-mutation, commit, validate, summary, etc.), and WAITING.json dual-write for .gsd/.planning readers. Refs gsd-build/get-shit-done#2341 * fix(sdk): getMilestoneInfo matches GSD ROADMAP (🟡, last bold, STATE fallback) - Recognize in-flight 🟡 milestone bullets like 🚧. - Derive from last **vX.Y Title** before ## Phases when emoji absent. - Fall back to STATE.md milestone when ROADMAP is missing; use last bare vX.Y in cleaned text instead of first (avoids v1.0 from shipped list). - Fixes init.execute-phase milestone_version and buildStateFrontmatter after state.begin-phase (syncStateFrontmatter). * feat(sdk): phase list, plan task structure, requirements extract handlers - Register phase.list-plans, phase.list-artifacts, plan.task-structure, requirements.extract-from-plans (SDK-only; golden-policy exceptions). - Add unit tests; document in QUERY-HANDLERS.md. - writeProfile: honor --output, render dimensions, return profile_path and dimensions_scored. * feat(sdk): centralize getGsdAgentsDir in query helpers Extract agent directory resolution to helpers (GSD_AGENTS_DIR, primary ~/.claude/agents, legacy path). Use from init and docs-init init bundles. docs(15): add 15-CONTEXT for autonomous phase-15 run. * feat(sdk): query CLI CJS fallback and session correlation - createRegistry(eventStream, sessionId) threads correlation into mutation events - gsd-sdk query falls back to gsd-tools.cjs when no native handler matches (disable with GSD_QUERY_FALLBACK=off); stderr bridge warnings - Export createRegistry from @gsd-build/sdk; add sdk/README.md - Update QUERY-HANDLERS.md and registry module docs for fallback + sessionId - Agents: prefer node dist/cli.js query over cat/grep for STATE and plans * fix(sdk): init phase_found parity, docs-init agents path, state field extract - Normalize findPhase not-found to null before roadmap fallback (matches findPhaseInternal) - docs-init: use detectRuntime + resolveAgentsDir for checkAgentsInstalled - state.cjs stateExtractField: horizontal whitespace only after colon (YAML progress guard) - Tests: commit_docs default true; config-get golden uses temp config; golden integration green Refs: #2302 * refactor(sdk): share SessionJsonlRecord in profile-extract-messages CodeRabbit nit: dedupe JSONL record shape for isGenuineUserMessage and streamExtractMessages. * fix(sdk): address CodeRabbit major threads (paths, gates, audit, verify) - Resolve @file: and CLI JSON indirection relative to projectDir; guard empty normalized query command - plan.task-structure + intel extract/patch-meta: resolvePathUnderProject containment - check.config-gates: safe string booleans; plan_checker alias precedence over plan_check default - state.validate/sync: phaseTokenMatches + comparePhaseNum ordering - verify.schema-drift: token match phase dirs; files_modified from parsed frontmatter - audit-open: has_scan_errors, unreadable rows, human report when scans fail - requirements PLANNED key PLAN for root PLAN.md; gsd-tools timeout note - ingest-docs: repo-root path containment; classifier output slug-hash Golden parity test strips has_scan_errors until CJS adds field. * fix: Resolve CodeRabbit security and quality findings - Secure intel.ts and cli.ts against path traversal - Catch and validate git add status in commit.ts - Expand roadmap milestone marker extraction - Fix parsing array-of-objects in frontmatter YAML - Fix unhandled config evaluations - Improve coverage test parity mapping * test: raise planner character extraction limit to 48K * fix(sdk): resolve TS build error in docs-init passing config
104 lines
3.8 KiB
TypeScript
104 lines
3.8 KiB
TypeScript
/**
|
|
* Unit tests for `check.gates` (decision-routing audit §3.2).
|
|
*/
|
|
|
|
import { describe, it, expect, beforeEach, afterEach } from 'vitest';
|
|
import { mkdir, writeFile, rm } from 'node:fs/promises';
|
|
import { join } from 'node:path';
|
|
import { tmpdir } from 'node:os';
|
|
import { checkGates } from './check-gates.js';
|
|
|
|
describe('checkGates', () => {
|
|
let projectDir: string;
|
|
|
|
beforeEach(async () => {
|
|
projectDir = join(tmpdir(), `gsd-check-gates-${Date.now()}-${Math.random().toString(36).slice(2)}`);
|
|
await mkdir(join(projectDir, '.planning', 'phases'), { recursive: true });
|
|
// Write a clean STATE.md
|
|
await writeFile(
|
|
join(projectDir, '.planning', 'STATE.md'),
|
|
'---\nstatus: active\n---\n\n# Project State\n\nStatus: active\n',
|
|
'utf-8',
|
|
);
|
|
});
|
|
|
|
afterEach(async () => {
|
|
await rm(projectDir, { recursive: true, force: true });
|
|
});
|
|
|
|
it('throws when workflow name arg is missing', async () => {
|
|
await expect(checkGates([], projectDir)).rejects.toThrow();
|
|
});
|
|
|
|
it('returns passed true when no blockers exist', async () => {
|
|
const { data } = await checkGates(['execute-phase'], projectDir);
|
|
const d = data as Record<string, unknown>;
|
|
expect(d.passed).toBe(true);
|
|
expect(d.blockers).toEqual([]);
|
|
});
|
|
|
|
it('returns blocker when .continue-here.md is present in root', async () => {
|
|
await writeFile(join(projectDir, '.continue-here.md'), '# Continue here', 'utf-8');
|
|
|
|
const { data } = await checkGates(['execute-phase'], projectDir);
|
|
const d = data as Record<string, unknown>;
|
|
expect(d.passed).toBe(false);
|
|
const blockers = d.blockers as Array<Record<string, unknown>>;
|
|
expect(blockers.length).toBeGreaterThan(0);
|
|
expect(blockers[0].gate).toBe('continue-here');
|
|
expect(blockers[0].severity).toBe('blocking');
|
|
});
|
|
|
|
it('returns blocker when STATE.md has status: failed', async () => {
|
|
await writeFile(
|
|
join(projectDir, '.planning', 'STATE.md'),
|
|
'---\nstatus: failed\n---\n\n# Project State\n',
|
|
'utf-8',
|
|
);
|
|
|
|
const { data } = await checkGates(['execute-phase'], projectDir);
|
|
const d = data as Record<string, unknown>;
|
|
expect(d.passed).toBe(false);
|
|
const blockers = d.blockers as Array<Record<string, unknown>>;
|
|
const stateBlocker = blockers.find(b => b.gate === 'state-error');
|
|
expect(stateBlocker).toBeDefined();
|
|
});
|
|
|
|
it('returns blocker when STATE.md has status: error', async () => {
|
|
await writeFile(
|
|
join(projectDir, '.planning', 'STATE.md'),
|
|
'---\nstatus: error\n---\n\n# Project State\n',
|
|
'utf-8',
|
|
);
|
|
|
|
const { data } = await checkGates(['execute-phase'], projectDir);
|
|
const d = data as Record<string, unknown>;
|
|
expect(d.passed).toBe(false);
|
|
const blockers = d.blockers as Array<Record<string, unknown>>;
|
|
const stateBlocker = blockers.find(b => b.gate === 'state-error');
|
|
expect(stateBlocker).toBeDefined();
|
|
});
|
|
|
|
it('includes warnings shape in result', async () => {
|
|
const { data } = await checkGates(['execute-phase'], projectDir);
|
|
const d = data as Record<string, unknown>;
|
|
expect(Array.isArray(d.warnings)).toBe(true);
|
|
});
|
|
|
|
it('returns verification-debt warning when phase VERIFICATION.md has FAIL rows', async () => {
|
|
const phaseDir = join(projectDir, '.planning', 'phases', '01-foundation');
|
|
await mkdir(phaseDir, { recursive: true });
|
|
await writeFile(
|
|
join(phaseDir, 'VERIFICATION.md'),
|
|
'| T-01 | Auth works | FAIL |\n| T-02 | User model | PASS |\n',
|
|
'utf-8',
|
|
);
|
|
|
|
const { data } = await checkGates(['execute-phase', '--phase', '1'], projectDir);
|
|
const d = data as Record<string, unknown>;
|
|
const warnings = d.warnings as Array<Record<string, unknown>>;
|
|
const debtWarning = warnings.find(w => w.gate === 'verification-debt');
|
|
expect(debtWarning).toBeDefined();
|
|
});
|
|
});
|