Files
msd-core/.changeset
Tom Boucher 2bc53baa03 fix(#2947): preserve preamble phase details when milestone section has none (#3084)
* test(#2947): milestone anchor must prefer heading with Phase details

Row 1 of the test matrix: the failing-first regression test. When the
phase-listing heading (## Phases) is NOT version-bearing but a later
version-bearing progress heading (### v9.0 phase progress) exists,
extractCurrentMilestone latches onto the progress heading and silently drops
the phases (phase_count: 0, exit 0). Five cases: the regression, the
version-bearing control (must keep working), the no-phase-details fallback,
the closed-vs-open preference, and an end-to-end roadmap.analyze check.

Reproduced locally against built lib + confirmed by maintainer triage (trek-e).
The one-word control (## Phases -> ## v9.0 Phases) restores phase_count: 2.

* fix(#2947): preserve preamble phase details when the milestone section has none

Root cause was one layer deeper than the issue title: the anchor selection
(selected = first non-closed version-bearing heading) is fine — the real
drop happens in the preamble strip. When the phase list lives under a
non-version-bearing ## Phases heading (the shipped greenfield template's own
shape) and the selected version-bearing heading is a LATER progress/notes
sub-heading with no ### Phase N: details of its own, the preamble strip
removed every phase-detail heading from the pre-milestone region (intended
to avoid duplication with a Phase Details section that does not exist here)
— silently dropping all phases (phase_count: 0, exit 0, empty stderr).

Fix: only strip preamble ### Phase N: headings when the selected milestone
section (currentSection) actually contains its own phase details. When it
does not, the preamble phases ARE this milestone's phases and must be
preserved. Falls back to today's behavior (strip) whenever the selected
section has phase details, so multi-milestone roadmaps with a dedicated
Phase Details section (#730) are unaffected.

Surgical: one conditional on the existing strip, no signature change, no
change to computeSectionEnd or the #730 Phase Details append. Blast radius
CRITICAL (84 upstream symbols) — the change is gated on currentSection's
content so every existing roadmap that currently resolves phases correctly
keeps doing so byte-identically.

* chore(#2947): add changeset fragment

* chore(#2947): backfill changeset PR number 3084

---------

Co-authored-by: sim <sim@local>
2026-08-05 13:10:52 -04:00
..

Changeset Fragments

This directory holds per-PR CHANGELOG fragments. Every PR with user-facing changes drops one (or more) <random-name>.md files here describing its CHANGELOG entry. Fragments are consolidated into the top-level CHANGELOG.md at release time.

Why

Two PRs that both edit the ### Fixed block of CHANGELOG.md always conflict on merge — git can't pick a serialization order without human input. Two PRs that each add a fresh .changeset/<unique-name>.md never conflict because they don't share lines.

See #2975 for the full rationale.

Adding a fragment

node scripts/changeset/new.cjs \
  --type Fixed \
  --pr 1234 \
  --body "fix the thing — explain the user-visible change in one sentence"

This writes .changeset/<adjective>-<noun>-<noun>.md with frontmatter and a body. Three random words → concurrent PRs don't collide.

Format

---
type: Fixed
pr: 1234
---
**`/gsd-foo` no longer drops trailing slashes** — explain the user-visible change.

Allowed type: values follow Keep a Changelog: Added, Changed, Deprecated, Removed, Fixed, Security.

Opting out

PRs that legitimately have no user-facing impact can add the no-changelog label. CI honors it. When unsure, add the fragment.

At release time

Promotion is automatic. The release workflow's finalize job runs:

node scripts/changeset/cli.cjs render --version vX.Y.Z --date YYYY-MM-DD --allow-empty

This reads every fragment, groups bullets by type:, replaces ## [Unreleased] with a new ## [vX.Y.Z] - YYYY-MM-DD block, opens a fresh ## [Unreleased] above, and deletes consumed fragments. The --allow-empty flag ensures a no-change release still gets a dated heading (with a _No notable changes._ placeholder). A subsequent verify step confirms the promotion landed correctly. Maintainers do not run this by hand.

Archived fragments

.changeset/archived/ holds fragments for already-shipped releases (≤ 1.3.1), retained for provenance. Their content was hand-curated into the dated ## [1.x.y] sections of CHANGELOG.md during the #690 backfill — they were never consumed by render. All changeset tooling enumerates .changeset/ non-recursively, so archived fragments are never picked up or rendered. Do not move them back to the top level.