* feat(#3411): one canonical Windows binary resolver in the platform seam CONTEXT.md declares src/shell-command-projection.cts the single OS-facing seam, but Windows binary resolution had grown four divergent implementations outside it. #3445 folded two of them together — inside gsd-core/bin/gsd-tools.cjs, not the seam — so the declaration stayed untrue and execTool still had no handling at all. Lift the resolver into the seam as resolveExecutableBinary, and export the half that actually executes as projectSpawnInvocation: CreateProcess cannot run a .cmd/.bat, so the cmd.exe mediation is inseparable from the lookup and splitting them is how the copies accumulated. cmd.exe is invoked with an explicit argv array, never shell:true — CVE-2024-27980's vector and Node 26's DEP0190. execTool now resolves on win32. POSIX is a strict no-op by construction, which matters: execTool rates CRITICAL blast radius (167 symbols, 53 files). gsd-tools.cjs deletes its private scan and its private mediation and delegates. Two semantics grown beyond #3445's resolver, both additive: a name already carrying a PATHEXT-listed extension is tried as-is before the append loop, and a suffix outside PATHEXT is not treated as an extension. Refs #3411 * fix(#3411): keep mediating a declared .cmd that PATH resolution misses Standards review caught a narrowing against the code this replaces. gsd-tools.cjs computed `target = resolveSpawnBinary(binary) || binary` and keyed the shim test on `target`, so a declared .cmd mediated whether or not PATH resolution found it. That is load-bearing: resolveExecutableBinary scans PATH only, while `cmd.exe /c` also finds a batch file in the current directory. Mediation now keys on the target — resolved path, else declared name. The ENOENT contract still holds for BARE unresolved names, which is the case it was written for. P9/P10 pin both halves. Spec review found E1/E2/E3/E5 promised by 50-test-matrix.md but never written; added. E3 is the integration proof that the CVE-relevant mediation fires through execTool, not only through projectSpawnInvocation in isolation. Also adds the CONTEXT.md glossary entry for the seam's new resolution ownership (a PR gate) and the changeset fragment. Refs #3411 * fix(#3617): pass mediated cmd.exe arguments verbatim so metacharacters cannot inject The isolated security pass found the mediation shape carried an argument-injection surface. libuv's quote_cmd_arg force-quotes an argv element only when it contains a space, tab, or quote — never for a cmd metacharacter — and cmd.exe re-parses everything after /c. So an arg of a&calc arrived unquoted and cmd ran calc. Node's own CVE-2024-27980 escaping cannot help: it fires only when the spawned FILE is the .bat/.cmd, and here the file is cmd.exe. Caret-escaping is not a fix. It is correct only when libuv does not quote, and libuv quotes whenever the arg also contains a space — no per-arg transform is right in both cases. So build the command line and pass it through verbatim, the shape Rust's std adopted for the sibling CVE-2024-24576: one outer quote pair that cmd /c strips, every token inside force-quoted, embedded quotes doubled. An argument containing CR or LF is refused rather than mediated — a newline cannot be represented in a Windows command line, so mediating would silently truncate. Failing visibly is correct. Known limit, documented at the seam: %VAR% still expands inside a /c string and has no escape outside a batch file. That is information disclosure, not arbitrary execution, and is the same limit Rust's std documents. This was byte-for-byte the shape #3445 shipped, so the fix closes it for the reviewer-lane spawn path too, not only for execTool's newly reachable route. Refs #3411 * docs(#3617): document the subprocess-execution security posture Adds Layer 4 to the security model: why GSD never uses shell:true for binary invocation (CVE-2024-27980, Node 26 DEP0190), why resolution is explicit and never tries the bare name on Windows (the npm extensionless-shim trap behind #3275), and why .cmd/.bat mediation builds a verbatim force-quoted command line rather than relying on default escaping — Node's own CVE protection cannot fire once the started program is cmd.exe. The residual %VAR% expansion limit is stated plainly under Trade-offs rather than left implicit: it is information disclosure, not arbitrary execution, and callers passing untrusted text to a Windows .cmd should not assume the value arrives byte-identical. Docs-only; no code change. Refs #3411 * chore(#3617): backfill changeset pr number 3621 * fix(#3617): read PATH, PATHEXT and ComSpec case-insensitively The Windows CI lane on #3621 failed E5, and the root cause was a defect in the implementation, not the assertion. Windows names the variable Path, not PATH. process.env is a case-insensitive proxy, so process.env.PATH works — but execTool builds { ...process.env, ...opts.env } whenever a caller supplies opts.env, and spreading discards the proxy while keeping the OS's actual casing. The exact-case env['PATH'] lookup then returned undefined, the PATH scan saw zero segments, resolution returned null, and the change degraded to precisely the spawn ENOENT it exists to fix. ComSpec and PATHEXT had the same exposure. #3445's tests never caught it because they pass uppercase keys explicitly, and neither did the Linux remote runner — this is a defect only the Windows lane could see. _envGet resolves a variable by exact match first (so a canonical caller pays no scan) and falls back to a case-insensitive sweep. R23 and P16 pin it and were proven RED by execution: with the fix stashed and build:lib re-run, R23 returned null and P16 returned the cmd.exe default. R24 was rewritten because the first version was vacuous — it staged foo.CMD, so the default PATHEXT already contained .CMD and it passed against the broken code for the wrong reason. It now stages foo.XYZ, an extension absent from the default, and carries a negative control asserting that dropping the Pathext key yields null. Re-proven RED the same way. E5's assertion was corrected alongside the fix: 'PATH' in options.env expressed the wrong contract. It now checks case-insensitively for the key. Refs #3411 * fix(#3617): execTool spawns the declared name unless mediation is required The Windows full-test lane on #3621 failed tests/graphify.test.cjs — the python3 identity check asserted 'python3' and got the absolute resolved path C:\hostedtoolcache\windows\Python\3.12.10\x64\python3.EXE instead. Those tests are correct and the change was wrong. They pin a long-standing contract — execTool spawns the program name it was given — by spying on spawnSync's first argument, and routing every win32 call through the projected invocation broke it. Resolving a .exe buys nothing. libuv's CreateProcess path already performs PATH + PATHEXT search, which is why spawning a bare 'node' has always worked on Windows. The only case the OS genuinely cannot spawn is a .cmd/.bat. So execTool now adopts the projection only when mediation actually happened — windowsVerbatimArguments is exactly that flag — and otherwise passes the declared program and args through untouched. 40-design.md already rejected gratuitous change for this reason: symmetry is not worth a behavior change to 53 files that fixes nothing. That reasoning was applied to POSIX and missed the win32 non-batch case. Rows 5 and 20 now record it, and the CONTEXT.md glossary states the caller-choice rule. deps.spawn deliberately still adopts the resolved path: its hasBinary probe answers from the same resolver, so probe and spawn must agree on the exact file (#3445). The asymmetry is now documented at both call sites rather than latent. E7 pins the restored contract and was verified by executing execTool against a monkeypatched spawnSync: python3 in, python3 spawned. Refs #3411 --------- Co-authored-by: sim <sim@local>
19 KiB
GSD Core security model
Explanation — This document describes why GSD Core has the security posture it does and how the layers fit together. It is not a reference for every hook parameter. For the
/gsd-secure-phasecommand and its options, see Commands. For the implementation-level hook architecture, see Architecture § Hook System. For the org-wide security baseline (scanner controls, incident checklists, ownership model), see SECURITY.md.
Why AI-driven development needs a dedicated security posture
A conventional code editor does not execute arbitrary packages on your behalf.
GSD Core does. The research → plan → execute pipeline automates the full path
from "name a package" to "run npm install <package>", from "write a
planning artifact" to "use that artifact as an LLM system prompt". Each
automation step removes a human from the loop — and each removal is a
potential attack surface.
GSD Core's security model is built around one organising principle: defence in depth. No single control is assumed to be perfect. Several overlapping layers each reduce a distinct class of risk, and together they make the attack surface substantially harder to exploit without eliminating it entirely. The honest summary at the end of this document explains what the system cannot protect against.
Layer 1 — Supply-chain protection: the Package Legitimacy Gate
The threat
AI models hallucinate package names. This is not a fringe failure mode: 2025 research documents roughly 20 % of AI-generated package references as hallucinated names that do not correspond to legitimate packages. A subset of those hallucinated names — approximately 43 % in the same research — recur consistently across prompts, meaning an attacker can observe which names AI tools commonly produce and pre-register those names on npm, PyPI, or crates.io with malicious post-install scripts. The technique is called slopsquatting.
The insidious quality of slopsquatting is that a hallucinated name that passes
npm view looks legitimate. The registry entry proves only that someone
registered the name — not that the package does what the AI said it does, not
that it has any legitimate users, and not that its install scripts are safe.
Without a gate, a hallucinated name would flow undetected through GSD's
researcher → planner → executor pipeline and eventually run as
npm install <attacker-package> on your machine.
How the gate works
The gate operates across three pipeline stages:
Research stage. When gsd-phase-researcher recommends external packages,
it runs gsd-tools query package-legitimacy check --ecosystem <npm|pypi|crates> <pkgs> against each one. Verdicts (OK|SUS|SLOP) are computed from live
registry APIs against thresholds { minAgeDays: 30, minWeeklyDownloads: 1000, requireRepo: true }, plus terminal short-circuits for non-existence and
suspicious postinstall scripts. The results are written to a ## Package Legitimacy Audit table in RESEARCH.md. Packages tagged [SLOP]
(high-confidence hallucination or attacker-registered) are stripped from
RESEARCH.md entirely before the file is saved. They never reach the
planner.
Planning stage. gsd-planner reads the Audit table. For any package
tagged [SUS] (suspicious: newly registered, low download count, no source
repository, or naming pattern close to a popular package) or [ASSUMED]
(sourced from WebSearch rather than direct registry verification), the planner
inserts a checkpoint:human-verify task before the install step. The
checkpoint includes a direct link to the registry page and specific things to
look for: maintainer history, issue-tracker activity, absence of suspicious
install scripts.
Execution stage. If an install fails, gsd-executor surfaces a
checkpoint and stops. It does not silently try an alternative package name —
which could itself be malicious. This is an explicit rule in the executor's
behaviour (RULE 3 in the executor agent definition).
Why WebSearch packages are always [ASSUMED]
Package names discovered through WebSearch are tagged [ASSUMED] regardless
of whether npm view succeeds. A package that exists on the registry is not
the same as a package that is safe to install. npm view proves registration,
not legitimacy. The [ASSUMED] tag triggers the same human-verify checkpoint
as [SUS], ensuring that any unverified web-discovered recommendation always
gets a human review before installation.
Ecosystem coverage
The gate resolves signals directly from each ecosystem's registry API rather than a single generic check:
- Node.js:
registry.npmjs.org(age, repository URL,postinstallscript) plusapi.npmjs.org/downloads(weekly downloads) - Python:
pypi.org/pypi/<pkg>/json(age, repository URL) - Rust: the crates.io API (age, weekly downloads, repository URL)
This covers cross-ecosystem hallucination, which occurs at roughly 9 % according to 2025 USENIX research — cases where an AI recommends a package that exists in one ecosystem but not the one actually in use.
Graceful degradation
Each registry adapter has a 5-second timeout and returns degraded (all-null)
signals on a failed lookup rather than throwing. Missing signals surface as
unknown-age / unknown-downloads reasons, which push a package to [SUS]
— and [SUS] is gated behind the same checkpoint:human-verify task as
[ASSUMED]. The gate fails toward human review, not silence, and research
and planning proceed normally: nothing here hard-fails on a network or tool
outage.
slopcheck is an optional adapter that can only escalate a verdict, never
lower it, and is not the install-or-degrade gate. No shipped configuration
wires it; its absence leaves registry-API verdicts intact rather than
downgrading everything to [ASSUMED].
Layer 2 — Prompt injection defences
The threat
GSD Core generates Markdown files that become LLM system prompts. The
research pipeline reads external web content; the planning pipeline
incorporates user-supplied text (--text-file, --prd); the execution
pipeline writes planning artifacts that are later re-read as agent context.
Any user-controlled text flowing into these artifacts is a potential
indirect prompt injection vector — an attacker-controlled string that,
once inside a system prompt, attempts to override the agent's instructions or
exfiltrate information.
How the defences work
GSD Core addresses prompt injection at three levels.
Input validation (security.cjs). The gsd-core/bin/lib/security.cjs
module is the central security utility. It provides:
- Path traversal prevention: user-supplied file paths (
--text-file,--prd) are validated to resolve within the project directory, with macOS/var→/private/varsymlink resolution handled explicitly - Prompt injection detection: known injection patterns (role overrides, instruction bypasses, system tag injections) are scanned in user-supplied text before it enters any planning artifact
- Safe JSON parsing: a wrapper that prevents prototype-pollution attacks via crafted JSON payloads
- Shell argument validation: arguments passed to subshell commands are validated before use
Runtime hook: gsd-prompt-guard.js. This hook fires on every Write or
Edit call that targets .planning/ files. It scans the content being written
for injection patterns shared with gsd-read-injection-scanner.js through
hooks/lib/injection-patterns.js — one module both hooks require(), so the
two surfaces cannot drift apart (#3504). The set is deliberately a subset of
security.cjs's patterns: the hooks stay loadable standalone, without the
compiled lib tree. Detection is advisory-only: the hook logs the finding
but does not block the write. The rationale is that a false-positive block on
a legitimate planning write would be more disruptive than a missed injection
in a secondary scan layer.
Runtime hook: gsd-read-injection-scanner.js. This hook fires on the
output of every Read, WebFetch, and WebSearch tool call. It scans the content
that was just read or fetched for injected instructions in untrusted content —
catching cases where an attacker has embedded instructions in a file or remote
resource that GSD is about to incorporate into an agent's context. The 10
research and doc-ingest agents additionally carry a shared <security_context>
data/instruction boundary (defined in
gsd-core/references/untrusted-input-boundary.md): gsd-project-researcher,
gsd-phase-researcher, gsd-ui-researcher, gsd-assumptions-analyzer,
gsd-advisor-researcher, gsd-doc-classifier, gsd-doc-synthesizer,
gsd-research-synthesizer, gsd-ai-researcher, and gsd-domain-researcher.
Any content fetched or read by those agents is treated as data, never as
instructions, regardless of what the content claims to be.
Opt-in blocking (security.injection_blocking). By default all injection
detections are advisory-only (logged, not blocked). Setting
security.injection_blocking = true in .planning/config.json (a registered
config key — gsd config-set security.injection_blocking true) upgrades
HIGH-confidence detections to blocking. Be precise about what this does: the
scanner is a PostToolUse hook, so it runs after the Read/WebFetch/WebSearch
has already executed and the fetched content is already in the model's transcript.
Blocking does not retroactively redact that content — it emits
decision: "block", which halts the agent's next step and feeds the detection back
as the reason, so the agent is stopped from acting further on the flagged result
instead of silently continuing. LOW detections remain advisory under this setting.
This flag is opt-in; the default (advisory-only) is preserved to avoid breaking
existing workflows. The prompt-level boundary above (treat fetched text as data,
never instructions) is the layer that keeps an injection from being followed even
while it sits in context; the hook is a coarse pattern pre-filter and circuit-breaker,
not a redactor.
CI scanner. prompt-injection-scan.security.test.cjs scans all agent, workflow,
and command files for embedded injection vectors as part of the test suite.
This catches injection attempts in the GSD source itself — for example, a
supply-chain attack that modified a workflow file to add a role-override
instruction.
Read Injection Scanner vs Prompt Guard
The two hooks cover complementary surfaces. gsd-prompt-guard.js watches
writes to planning artifacts — it catches injection being planted.
gsd-read-injection-scanner.js watches reads and remote fetches — it catches
injection being ingested from external content (a dependency's README, a
third-party config file, a user-provided document, or any URL fetched via
WebFetch or WebSearch). The in-prompt <security_context> boundary in research
agents provides an additional containment layer: even if an injected string
reaches an agent, it is structurally separated from the instruction region.
Together these controls bracket the ingest → store → re-read lifecycle.
Runtime hook: gsd-workflow-guard.js — advisory vs. blocking posture.
This hook has two legs with two deliberately different failure postures. The
edit leg is advisory: when hooks.workflow_guard is enabled it warns on
edits made outside a GSD workflow, and on any internal error it fails open
(exit 0) — a broken advisory must never wedge a session's tool calls. The
Bash leg carries the hook's one hard block: git add -f / git add --force on an agent-* or worktree-agent-* branch is blocked outright
(WORKTREE_AGENT_FORCE_ADD_FORBIDDEN, exit 2), enforcing the
skipped-gitignored contract. When the guard is enabled, this block leg
fails closed (#3504): if an internal error strikes before the block
decision and the blocking context can be re-derived from the payload (a Bash
tool call, the guard enabled, the branch determinably an agent branch), the
hook exits 2 rather than silently allowing. What it cannot establish — an
unparseable payload, a non-Bash tool, the guard disabled, or a branch it
cannot determine — still fails open. The known trade-off: on an agent branch
with the guard enabled, a Bash call that trips an internal error is blocked
even when it was not a force-add; that is the conservative direction for the
one hard block this hook owns.
Layer 3 — Repository and dependency integrity
Upstream of GSD's runtime behaviour, the open-gsd organisation enforces
controls at the repository and package level. These are documented in full in
docs/security/baseline.md and are summarised
here for completeness.
Dependency integrity. All third-party dependencies are pinned via
package-lock.json and verified against published checksums before install.
A scripts/check-npm-integrity.cjs gate detects invalid versions, missing
packages, and extraneous packages at CI time. This mitigates dependency
confusion and typosquatting attacks against GSD's own dependencies.
Secret scanning. Every commit and PR is scanned for hardcoded secrets.
Intentional test fixtures must be annotated with the project-standard
exclusion grammar (see SECURITY.md for the annotation format). Un-annotated
suppressions fail CI.
Locale-safe text scanning. Output and user-facing strings are scanned for Unicode homoglyphs, bidirectional override characters, and invisible Unicode — the class of attacks documented in CVE-2021-42574 ("Trojan Source") that can hide malicious content in diffs.
Layer 4 — Subprocess execution
GSD starts external programs constantly: git, npm, reviewer CLIs declared by
capabilities, and whatever a gate predicate names. Every one of those is a
place where an argument could become a command. One module owns the whole
question — src/shell-command-projection.cts, the single platform seam.
No shell: true for binary invocation. Passing shell: true on Windows is
the mechanism behind CVE-2024-27980: the shell re-parses the argument list, so
a value containing & or | stops being data and becomes a second command.
Node 26 additionally deprecates shell: true alongside an argument array
(DEP0190), because arguments are concatenated rather than escaped. GSD resolves
binaries explicitly instead.
Explicit resolution, not shell lookup. resolveExecutableBinary scans
PATH and, on Windows, the PATHEXT extensions, and returns the resolved
path. It never tries the bare name on Windows: npm global installs drop an
extensionless POSIX sh shim beside foo.CMD, and resolving to that shim is
how the reviewer lanes failed with spawn ENOENT (#3275). On macOS and Linux
the bare name goes to spawnSync unchanged, so the operating system's own
lookup keeps doing the work.
Mediating .cmd and .bat safely. Windows CreateProcess cannot execute a
batch file at all, so one must be run through cmd.exe. That is where the
injection risk actually lives, and it is not solved by resolution alone.
projectSpawnInvocation builds the command line itself and passes it through
verbatim: one outer quote pair that cmd /c strips, every token inside
force-quoted, embedded quotes doubled. Force-quoting is the point — an unquoted
a&calc is split by cmd into two commands, while a quoted "a&calc" is one
literal argument. This is the shape Rust's standard library adopted for the
sibling CVE-2024-24576.
Relying on the default argument escaping would not be enough. Node's own
CVE-2024-27980 protection fires only when the program being started is itself
the .bat or .cmd; once the program is cmd.exe, that check no longer
applies, and the underlying quoting only quotes arguments containing spaces,
tabs, or quotes — never one containing a bare &.
An argument containing a carriage return or newline is refused rather than mediated. A newline cannot be represented in a Windows command line, so mediating it would silently truncate the argument; failing visibly is the safer outcome.
Trade-offs and limits
The security model described here meaningfully reduces the attack surface for AI-driven development. It does not eliminate supply-chain risk.
What the Package Legitimacy Gate reduces: The probability that a
hallucinated or attacker-registered package reaches npm install without
a human checkpoint. The [SLOP] gate removes high-confidence bad packages
entirely; the [SUS] / [ASSUMED] gates require human review before
execution. This substantially raises the cost of a successful slopsquatting
attack.
What the Package Legitimacy Gate does not eliminate: A legitimate package
that is later compromised (account takeover, dependency confusion in its own
tree) is not caught by the registry-API gate, which checks registration
signals at research time. Lock files and npm audit at the
dependency-integrity layer are the controls for that class of attack.
What the prompt injection defences reduce: The probability that user-controlled text in planning artifacts successfully overrides agent instructions. Pattern-matching on known injection forms catches the common cases; novel jailbreaks or low-signal injections may pass undetected. The advisory-only posture means detection is logged but not blocked — a deliberate choice that preserves workflow continuity at the cost of not hard-stopping on a detection.
What the prompt injection defences do not eliminate: A sufficiently
creative injection that does not match known patterns, or an injection that
arrives through a channel the hooks do not cover. The previously uncovered
channel of content injected into a dependency's published README and read by a
subagent browsing documentation is now scanned at ingress by
gsd-read-injection-scanner.js (which covers WebFetch and WebSearch output)
and structurally isolated in-prompt by the <security_context> boundary in
research agents — but novel jailbreaks and low-signal injections may still pass
undetected. Defence in depth means each layer makes the attack harder, not that
any single layer makes it impossible.
What subprocess execution does not eliminate: cmd.exe expands %VAR%
inside a /c string, and there is no escape for % outside a batch file. An
argument containing %FOO% is therefore substituted with the environment
value before the target program sees it. That is information disclosure, not
arbitrary execution — the force-quoting still prevents an argument from
becoming a second command — and it is the same residual limit Rust's standard
library documents for its own batch-file handling. Callers that pass untrusted
text as an argument to a Windows .cmd or .bat should not assume the value
arrives byte-identical.
Reporting vulnerabilities. Report via private GitHub security advisory at
https://github.com/open-gsd/gsd-core/security/advisories/new. Do not open
public issues. See SECURITY.md for the response timeline
and disclosure policy.
Related
- Commands — includes
/gsd-secure-phaseand/gsd-code-reviewwith security-relevant flags - Architecture § Hook System — implementation detail on every hook, its event trigger, and safety properties
- SECURITY.md — vulnerability reporting, org-wide security baseline, secret-scan exclusion governance, and dependency integrity verification
- Docs index