* fix(#2308): make new-milestone workstream-aware; stop clobbering shared PROJECT.md
Step 4 rewrote the `## Current Milestone` heading in the shared root PROJECT.md
unconditionally. references/workstream-flag.md marks PROJECT.md `# Shared`, and
per-workstream milestone state already lives in the workstream's own STATE.md /
ROADMAP.md / REQUIREMENTS.md. With parallel milestones — the sanctioned design —
whichever workstream ran new-milestone last silently won the shared heading.
Step 4 is now skipped when a workstream is active; step 6 no longer stages
PROJECT.md in that mode (cmdCommit returns nothing_to_commit rather than failing
when a staged path is unchanged).
Also fixes a second defect found while diagnosing this, same root cause (the
workflow was workstream-unaware): step 1 parsed only --reset-phase-numbers and
the milestone name, so GSD_WS was never set — yet ${GSD_WS} was interpolated at
the routing lines. It always expanded to empty, so `/gsd:new-milestone --ws x`
suggested `/gsd:discuss-phase [N]` with the workstream scope silently dropped,
violating the routing-propagation contract. Step 1 now parses --ws using the
established idiom from verify-work.md.
Guard is keyed on GSD_WS, not $GSD_WORKSTREAM: the runtime launcher does not
export the latter and it is only priority 2 of 5 in resolution, so it would miss
the --ws flag case that is the actual repro.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SLufH5sDuqA1AiEGu45cuA
* test(#2308): regenerate install goldens for the new-milestone workflow change
gsd-core/workflows/ ships as an installed artifact, so new-milestone.md's content
hash is pinned in all 18 runtime golden fixtures. Only that hash changed.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SLufH5sDuqA1AiEGu45cuA
* fix(#2308): address review — inert step-6 guard, dropped Evolution repair, tautological tests
Independent review found the first pass was partly cosmetic:
1. The step-6 `if [ -n "$GSD_WS" ]` branch was INERT. GSD_WS is assigned in
step 1's shell and each step's bash block runs in its own shell — this file
already proves it, since step 5 round-trips OUTGOING_MILESTONE through a file
for exactly that reason (#2288). The guard read an unset variable, always took
the flat branch, and staged PROJECT.md anyway. Rather than re-deriving GSD_WS
in step 6, the branch is removed entirely: step 4 Part A's guard is what
protects the shared heading, so post-guard the only content PROJECT.md can
carry is Part B's idempotent Evolution backfill — which must be staged, not
stranded. A regression test now asserts no cross-step GSD_WS branch returns.
2. Skipping ALL of step 4 also dropped the `## Evolution` structural repair — a
shared, idempotent backfill that is not workstream state. A pre-Evolution
project running only `--ws` would never get the section that transition and
complete-milestone expect. Step 4 is now split: Part A (milestone-state write)
is workstream-guarded; Part B (Evolution) always runs.
3. The tests were tautological prose-pinning — including one asserting a comment
mentions "#2308". The step-6 test asserted the guard's TEXT was present, so it
passed on the inert guard it existed to catch. Replaced with executable tests
that extract the step-1 and step-6 fences and run them under bash with stubbed
gsd_run, asserting real parse and --files behavior.
4. --ws is now stripped from the milestone name (step 1 previously left
"--ws search" in the remaining text), and documented in argument-hint,
help/modes/full.md, and docs/COMMANDS.md.
5. Changeset no longer overstates: --ws reaches the prose guard and routing hints
only, not the SDK calls (state.milestone-switch/phases.clear/init.new-milestone
still take no ${GSD_WS} — out of scope here).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SLufH5sDuqA1AiEGu45cuA
* chore(#2308): regenerate SKILL.md, goldens, and size baseline for the argument-hint change
skills/gsd-new-milestone/SKILL.md is generated from commands/gsd/new-milestone.md,
so documenting --ws in the argument-hint made it stale (caught by lint:ci's
gen-plugin-skills --check). Regenerated it plus the install goldens and workflow
size baseline, since commands/, skills/, and gsd-core/workflows/ all ship.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SLufH5sDuqA1AiEGu45cuA
* docs(#2308): backfill PR number 2338 into changeset
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SLufH5sDuqA1AiEGu45cuA
---------
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ada79bee97