* refactor(#455): implement typed surfaces to retire grep tests Production surfaces added: - hooks/managed-hooks-registry.cjs: new CJS module exporting MANAGED_HOOKS as a typed array; gsd-check-update-worker.js now requires it instead of declaring an inline array - bin/install.js: elevate inline gsdHooks to module-level GSD_UNINSTALL_HOOKS, export it alongside runtimeMap/allRuntimes (already exported) - scripts/build-hooks.js: export HOOKS_TO_COPY; guard build() behind require.main===module so tests can require the file without triggering a build - get-shit-done/bin/lib/init.cjs: add --json mode to agent-skills command, emitting typed IR { agent_type, block, skills_count } for test assertions - get-shit-done/bin/gsd-tools.cjs: wire --json flag for agent-skills dispatch Category-B source-grep migrations: - tests/managed-hooks.test.cjs: require MANAGED_HOOKS from registry, drop fs.readFileSync+regex - tests/orphaned-hooks.test.cjs: require MANAGED_HOOKS+HOOKS_TO_COPY as typed exports - tests/hooks-opt-in.test.cjs: replace gsdHooks regex-parse with GSD_UNINSTALL_HOOKS import - tests/install-minimal-hooks.test.cjs: replace gsdHooks regex-parse with GSD_UNINSTALL_HOOKS - tests/copilot-install.test.cjs: replace src.includes() checks with typed assertions on runtimeMap, allRuntimes, parseRuntimeInput, buildRuntimePromptText - tests/agent-skills.test.cjs: migrate to --json typed IR assertions pending-migration-to-typed-ir token cleared (87 of 87 files): - 78 files already had source-text-is-the-product; removed duplicate token - 5 files already used typed assertions; reclassified or annotated - 4 files required individual reclassification to source-text-is-the-product or architectural-invariant Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(#455): update workflow-guard test to typed GSD_UNINSTALL_HOOKS import; isolate HOME in runtime-launcher (D) test Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(#455): guard install.js main() behind require.main===module so the typed export is require-safe Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * docs(#455): document --json typed surfaces for agent-skills, progress, validate context Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * docs(#455): add changeset fragment for new --json surfaces Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(#455): complete grep migration for files flagged by lint-tests The branch commit 4e630d99 stripped `allow-test-rule: pending-migration-to-typed-ir` from ~80 test files without replacing their assertions or adding the correct exemption annotation. The files were NOT source-grep tests — they read .md workflow/agent/command/reference files (source-text-is-the-product) or hook source files for structural invariants (structural-regression-guard). No assertion logic was changed; only the correct allow-test-rule annotation was added to each file per CONTRIBUTING.md exception matrix. 73 files: `source-text-is-the-product` — workflow/agent/command/reference .md 7 files: `structural-regression-guard` — hook .js / bin/install.js structural checks Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: CI Rebase Check <ci@gsd-redux> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
67 lines
2.5 KiB
JavaScript
67 lines
2.5 KiB
JavaScript
// allow-test-rule: source-text-is-the-product
|
|
// Workflow .md / agent .md / command .md / reference .md files — their text
|
|
// IS what the runtime loads. Testing text content tests the deployed contract.
|
|
// Per CONTRIBUTING.md exception matrix.
|
|
|
|
/**
|
|
* GSD Tests — /gsd:sketch --wrap-up silently no-ops (#2949)
|
|
*
|
|
* The --wrap-up flag was documented in commands/gsd/sketch.md but never dispatched.
|
|
* The sketch-wrap-up.md micro-skill entry point was deleted in #2790 and the dispatch
|
|
* wiring was never added to the command or workflow.
|
|
*/
|
|
|
|
'use strict';
|
|
|
|
const { describe, test } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
|
|
const ROOT = path.resolve(__dirname, '..');
|
|
const SKETCH_COMMAND = path.join(ROOT, 'commands/gsd/sketch.md');
|
|
const SKETCH_WORKFLOW = path.join(ROOT, 'get-shit-done/workflows/sketch.md');
|
|
|
|
describe('bug-2949: sketch --wrap-up dispatch wiring', () => {
|
|
test('commands/gsd/sketch.md contains --wrap-up dispatch logic', () => {
|
|
const content = fs.readFileSync(SKETCH_COMMAND, 'utf8');
|
|
assert.ok(
|
|
content.includes('--wrap-up'),
|
|
'sketch.md should contain --wrap-up dispatch logic'
|
|
);
|
|
// The dispatch should route to sketch-wrap-up workflow
|
|
assert.ok(
|
|
content.includes('sketch-wrap-up'),
|
|
'sketch.md should reference sketch-wrap-up in dispatch logic'
|
|
);
|
|
});
|
|
|
|
test('commands/gsd/sketch.md has sketch-wrap-up in execution_context section', () => {
|
|
const content = fs.readFileSync(SKETCH_COMMAND, 'utf8');
|
|
// Find execution_context block
|
|
const execCtxMatch = content.match(/<execution_context>([\s\S]*?)<\/execution_context>/);
|
|
assert.ok(execCtxMatch, 'sketch.md must have an <execution_context> block');
|
|
const execCtx = execCtxMatch[1];
|
|
assert.ok(
|
|
execCtx.includes('sketch-wrap-up'),
|
|
`execution_context block should include sketch-wrap-up workflow; got: ${execCtx}`
|
|
);
|
|
});
|
|
|
|
test('workflows/sketch.md does NOT contain old /gsd-sketch-wrap-up form', () => {
|
|
const content = fs.readFileSync(SKETCH_WORKFLOW, 'utf8');
|
|
assert.ok(
|
|
!content.includes('/gsd-sketch-wrap-up'),
|
|
'workflows/sketch.md must not reference the old /gsd-sketch-wrap-up command'
|
|
);
|
|
});
|
|
|
|
test('workflows/sketch.md DOES contain new /gsd:sketch --wrap-up form', () => {
|
|
const content = fs.readFileSync(SKETCH_WORKFLOW, 'utf8');
|
|
assert.ok(
|
|
content.includes('/gsd:sketch --wrap-up'),
|
|
'workflows/sketch.md should reference /gsd:sketch --wrap-up (the new form)'
|
|
);
|
|
});
|
|
});
|