* feat(#41): extract per-commit gate_status into ship PR body TDD Audit /gsd:ship's generate_pr_body now reconstructs the TDD gate trail that a squash-merge would otherwise discard. A new TDD Audit section walks the merge-base..HEAD commit range (merges excluded), reads each commit's gate_status: trailer via Git's native trailer machinery, pairs each test: commit with its following feat:/fix: implementation commit, and counts commits lacking a recognized trailer as missing. A single aggregate `gate_status: skill=N, fallback=N, exempt=N, missing=N` trailer is emitted as the final line of the PR body so a GitHub squash-merge carries the audit footprint into the base branch. Hardening (per adversarial review): impl pairing is restricted to feat:/fix: (refactor/docs/chore are skipped, never mistaken for GREEN); the gate_status cell is normalized to a known token and never rendered raw; commits with multiple gate_status trailers are treated as missing; every table cell escapes pipes and strips CR/LF; records guard against delimiter-injection from adversarial commit messages. Scoped additively: no changes to commands, agents, templates, or SDK. Closes #41 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * docs(#41): add changeset for ship TDD Audit enhancement Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
99 lines
3.5 KiB
JavaScript
99 lines
3.5 KiB
JavaScript
'use strict';
|
|
|
|
// feat(#41): /gsd-ship generate_pr_body emits a TDD Audit table + an aggregate
|
|
// `gate_status:` trailer so the per-commit TDD gate trail survives squash-merge.
|
|
// These assertions pin the shipped workflow prose in get-shit-done/workflows/ship.md.
|
|
|
|
const fs = require('node:fs');
|
|
const path = require('node:path');
|
|
const assert = require('node:assert/strict');
|
|
const { describe, test } = require('node:test');
|
|
|
|
const repoRoot = path.resolve(__dirname, '..');
|
|
function readRepoFile(relativePath) {
|
|
return fs.readFileSync(path.join(repoRoot, relativePath), 'utf8');
|
|
}
|
|
|
|
describe('feat-41: ship.md TDD Audit gate_status extraction', () => {
|
|
const workflow = readRepoFile('get-shit-done/workflows/ship.md');
|
|
|
|
test('adds a "## TDD Audit" section to the generated PR body', () => {
|
|
assert.match(workflow, /## TDD Audit/);
|
|
});
|
|
|
|
test('extracts gate_status via Git native trailer machinery, not a raw body grep', () => {
|
|
assert.match(workflow, /trailers:key=gate_status/);
|
|
});
|
|
|
|
test('scopes the scan to the merge-base..HEAD range', () => {
|
|
assert.match(workflow, /merge-base/);
|
|
assert.match(workflow, /\.\.HEAD/);
|
|
assert.match(workflow, /BASE_BRANCH/);
|
|
});
|
|
|
|
test('excludes merge commits from the audit', () => {
|
|
assert.match(workflow, /--no-merges/);
|
|
});
|
|
|
|
test('renders a Test commit / Impl commit / gate_status table', () => {
|
|
assert.match(workflow, /Test commit[\s\S]*Impl commit[\s\S]*gate_status/);
|
|
});
|
|
|
|
test('pairs conventional-commit test: rows with their impl commit', () => {
|
|
assert.match(workflow, /test:/);
|
|
assert.match(workflow, /pair/i);
|
|
});
|
|
|
|
test('escapes pipe characters in commit subjects so the table is not broken', () => {
|
|
assert.match(workflow, /[Ee]scape[\s\S]{0,60}\|/);
|
|
});
|
|
|
|
test('counts commits lacking a recognized gate_status trailer as missing', () => {
|
|
assert.match(workflow, /missing/);
|
|
});
|
|
|
|
test('is informational and never blocks the ship', () => {
|
|
assert.match(workflow, /informational|never block|non-blocking/i);
|
|
});
|
|
|
|
test('emits the aggregate trailer in the exact, stable key order', () => {
|
|
assert.match(
|
|
workflow,
|
|
/gate_status:\s*skill=[^,]*,\s*fallback=[^,]*,\s*exempt=[^,]*,\s*missing=/,
|
|
);
|
|
});
|
|
|
|
test('places the aggregate trailer on the final line so squash-merge carries it', () => {
|
|
assert.match(workflow, /squash/i);
|
|
assert.match(workflow, /final line|last line/i);
|
|
});
|
|
|
|
test('does not disturb the frozen #3167 core section order (Key Decisions precedes the new section)', () => {
|
|
assert.match(workflow, /## Key Decisions[\s\S]*## TDD Audit/);
|
|
});
|
|
|
|
// Hardening assertions added after adversarial review.
|
|
|
|
test('pairs test: rows only with feat:/fix: impl commits, skipping refactor/docs/chore', () => {
|
|
assert.match(workflow, /feat:[\s\S]{0,20}fix:/);
|
|
assert.match(workflow, /skipping[\s\S]{0,80}(refactor|docs|chore)/i);
|
|
});
|
|
|
|
test('normalizes the gate_status cell to a known token, never raw trailer text', () => {
|
|
assert.match(workflow, /normaliz[a-z]*[\s\S]{0,120}missing/i);
|
|
assert.match(workflow, /never the raw/i);
|
|
});
|
|
|
|
test('treats a commit with multiple gate_status trailers as missing', () => {
|
|
assert.match(workflow, /more than one[\s\S]{0,40}gate_status/i);
|
|
});
|
|
|
|
test('hardens every table cell against pipe/newline injection', () => {
|
|
assert.match(workflow, /strip[\s\S]{0,20}\\r/);
|
|
});
|
|
|
|
test('guards record/field delimiters against adversarial commit messages', () => {
|
|
assert.match(workflow, /NUL|%x00|delimiter/i);
|
|
});
|
|
});
|