Files
msd-core/tests/import-command.test.cjs
Tom Boucher b8c33647d8 refactor(tests): retire output-grep & source-grep via typed surfaces (finish #2974) (#462)
* refactor(#455): implement typed surfaces to retire grep tests

Production surfaces added:
- hooks/managed-hooks-registry.cjs: new CJS module exporting MANAGED_HOOKS
  as a typed array; gsd-check-update-worker.js now requires it instead of
  declaring an inline array
- bin/install.js: elevate inline gsdHooks to module-level GSD_UNINSTALL_HOOKS,
  export it alongside runtimeMap/allRuntimes (already exported)
- scripts/build-hooks.js: export HOOKS_TO_COPY; guard build() behind
  require.main===module so tests can require the file without triggering a build
- get-shit-done/bin/lib/init.cjs: add --json mode to agent-skills command,
  emitting typed IR { agent_type, block, skills_count } for test assertions
- get-shit-done/bin/gsd-tools.cjs: wire --json flag for agent-skills dispatch

Category-B source-grep migrations:
- tests/managed-hooks.test.cjs: require MANAGED_HOOKS from registry, drop fs.readFileSync+regex
- tests/orphaned-hooks.test.cjs: require MANAGED_HOOKS+HOOKS_TO_COPY as typed exports
- tests/hooks-opt-in.test.cjs: replace gsdHooks regex-parse with GSD_UNINSTALL_HOOKS import
- tests/install-minimal-hooks.test.cjs: replace gsdHooks regex-parse with GSD_UNINSTALL_HOOKS
- tests/copilot-install.test.cjs: replace src.includes() checks with typed
  assertions on runtimeMap, allRuntimes, parseRuntimeInput, buildRuntimePromptText
- tests/agent-skills.test.cjs: migrate to --json typed IR assertions

pending-migration-to-typed-ir token cleared (87 of 87 files):
- 78 files already had source-text-is-the-product; removed duplicate token
- 5 files already used typed assertions; reclassified or annotated
- 4 files required individual reclassification to source-text-is-the-product
  or architectural-invariant

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(#455): update workflow-guard test to typed GSD_UNINSTALL_HOOKS import; isolate HOME in runtime-launcher (D) test

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(#455): guard install.js main() behind require.main===module so the typed export is require-safe

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* docs(#455): document --json typed surfaces for agent-skills, progress, validate context

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* docs(#455): add changeset fragment for new --json surfaces

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(#455): complete grep migration for files flagged by lint-tests

The branch commit 4e630d99 stripped `allow-test-rule: pending-migration-to-typed-ir`
from ~80 test files without replacing their assertions or adding the correct
exemption annotation. The files were NOT source-grep tests — they read .md
workflow/agent/command/reference files (source-text-is-the-product) or hook
source files for structural invariants (structural-regression-guard). No
assertion logic was changed; only the correct allow-test-rule annotation was
added to each file per CONTRIBUTING.md exception matrix.

73 files: `source-text-is-the-product` — workflow/agent/command/reference .md
7 files:  `structural-regression-guard` — hook .js / bin/install.js structural checks

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: CI Rebase Check <ci@gsd-redux>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-05-29 11:39:52 -04:00

127 lines
4.7 KiB
JavaScript

// allow-test-rule: source-text-is-the-product
// Workflow .md / agent .md / command .md / reference .md files — their text
// IS what the runtime loads. Testing text content tests the deployed contract.
// Per CONTRIBUTING.md exception matrix.
/**
* Import Command Tests — import-command.test.cjs
*
* Structural assertions for the /gsd-import command and workflow files.
*/
const { describe, test } = require('node:test');
const assert = require('node:assert/strict');
const fs = require('fs');
const path = require('path');
const CMD_PATH = path.join(__dirname, '..', 'commands', 'gsd', 'import.md');
const WF_PATH = path.join(__dirname, '..', 'get-shit-done', 'workflows', 'import.md');
// ─── File Existence ────────────────────────────────────────────────────────────
describe('import command file structure', () => {
test('command file exists', () => {
assert.ok(fs.existsSync(CMD_PATH), 'commands/gsd/import.md should exist');
});
test('workflow file exists', () => {
assert.ok(fs.existsSync(WF_PATH), 'get-shit-done/workflows/import.md should exist');
});
});
// ─── Command Frontmatter ───────────────────────────────────────────────────────
describe('import command frontmatter', () => {
const content = fs.readFileSync(CMD_PATH, 'utf-8');
test('has name field', () => {
assert.match(content, /^name:\s*gsd:import$/m);
});
test('has description field', () => {
assert.match(content, /^description:\s*.+$/m);
});
test('has argument-hint with --from', () => {
assert.match(content, /^argument-hint:.*--from/m);
});
});
// ─── Command References Workflow ───────────────────────────────────────────────
describe('import command references', () => {
const content = fs.readFileSync(CMD_PATH, 'utf-8');
test('references the import workflow', () => {
assert.ok(
content.includes('@~/.claude/get-shit-done/workflows/import.md'),
'command should reference the workflow via @~/.claude/get-shit-done/workflows/import.md'
);
});
});
// ─── Workflow Content ──────────────────────────────────────────────────────────
describe('import workflow content', () => {
const content = fs.readFileSync(WF_PATH, 'utf-8');
test('contains --from mode handling', () => {
assert.ok(
content.includes('--from'),
'workflow should contain --from mode handling'
);
});
test('does NOT contain --prd implementation', () => {
// --prd should be mentioned as deferred/future only, not implemented
assert.ok(
content.includes('--prd'),
'workflow should mention --prd exists'
);
assert.ok(
content.includes('not yet implemented') || content.includes('follow-up PR') || content.includes('future release'),
'workflow should defer --prd to a future release'
);
// Should not have a full "Path B: MODE=prd" implementation section
assert.ok(
!content.includes('## Path B: MODE=prd'),
'workflow should NOT have a Path B implementation for --prd'
);
});
test('references path validation for --from argument', () => {
// After fix: inline path check instead of security.cjs CLI invocation
assert.ok(
content.includes('traversal') || content.includes('validatePath') || content.includes('..'),
'workflow should validate the file path'
);
});
test('includes REQUIREMENTS.md in conflict detection context loading', () => {
assert.ok(
content.includes('REQUIREMENTS.md'),
'workflow should load REQUIREMENTS.md for conflict detection'
);
});
test('includes BLOCKER/WARNING/INFO conflict severity model', () => {
assert.ok(content.includes('[BLOCKER]'), 'workflow should include BLOCKER severity');
assert.ok(content.includes('[WARNING]'), 'workflow should include WARNING severity');
assert.ok(content.includes('[INFO]'), 'workflow should include INFO severity');
});
test('includes plan-checker validation gate', () => {
assert.ok(
content.includes('gsd-plan-checker'),
'workflow should delegate validation to gsd-plan-checker'
);
});
test('no-args usage display is present', () => {
assert.ok(
content.includes('Usage: /gsd:import') || content.includes('Usage: /gsd-import'),
'workflow should display usage when no arguments provided'
);
});
});