* refactor(#455): implement typed surfaces to retire grep tests Production surfaces added: - hooks/managed-hooks-registry.cjs: new CJS module exporting MANAGED_HOOKS as a typed array; gsd-check-update-worker.js now requires it instead of declaring an inline array - bin/install.js: elevate inline gsdHooks to module-level GSD_UNINSTALL_HOOKS, export it alongside runtimeMap/allRuntimes (already exported) - scripts/build-hooks.js: export HOOKS_TO_COPY; guard build() behind require.main===module so tests can require the file without triggering a build - get-shit-done/bin/lib/init.cjs: add --json mode to agent-skills command, emitting typed IR { agent_type, block, skills_count } for test assertions - get-shit-done/bin/gsd-tools.cjs: wire --json flag for agent-skills dispatch Category-B source-grep migrations: - tests/managed-hooks.test.cjs: require MANAGED_HOOKS from registry, drop fs.readFileSync+regex - tests/orphaned-hooks.test.cjs: require MANAGED_HOOKS+HOOKS_TO_COPY as typed exports - tests/hooks-opt-in.test.cjs: replace gsdHooks regex-parse with GSD_UNINSTALL_HOOKS import - tests/install-minimal-hooks.test.cjs: replace gsdHooks regex-parse with GSD_UNINSTALL_HOOKS - tests/copilot-install.test.cjs: replace src.includes() checks with typed assertions on runtimeMap, allRuntimes, parseRuntimeInput, buildRuntimePromptText - tests/agent-skills.test.cjs: migrate to --json typed IR assertions pending-migration-to-typed-ir token cleared (87 of 87 files): - 78 files already had source-text-is-the-product; removed duplicate token - 5 files already used typed assertions; reclassified or annotated - 4 files required individual reclassification to source-text-is-the-product or architectural-invariant Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(#455): update workflow-guard test to typed GSD_UNINSTALL_HOOKS import; isolate HOME in runtime-launcher (D) test Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(#455): guard install.js main() behind require.main===module so the typed export is require-safe Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * docs(#455): document --json typed surfaces for agent-skills, progress, validate context Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * docs(#455): add changeset fragment for new --json surfaces Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(#455): complete grep migration for files flagged by lint-tests The branch commit 4e630d99 stripped `allow-test-rule: pending-migration-to-typed-ir` from ~80 test files without replacing their assertions or adding the correct exemption annotation. The files were NOT source-grep tests — they read .md workflow/agent/command/reference files (source-text-is-the-product) or hook source files for structural invariants (structural-regression-guard). No assertion logic was changed; only the correct allow-test-rule annotation was added to each file per CONTRIBUTING.md exception matrix. 73 files: `source-text-is-the-product` — workflow/agent/command/reference .md 7 files: `structural-regression-guard` — hook .js / bin/install.js structural checks Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: CI Rebase Check <ci@gsd-redux> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
141 lines
6.4 KiB
JavaScript
141 lines
6.4 KiB
JavaScript
// allow-test-rule: source-text-is-the-product
|
|
// Workflow .md / agent .md / command .md / reference .md files — their text
|
|
// IS what the runtime loads. Testing text content tests the deployed contract.
|
|
// Per CONTRIBUTING.md exception matrix.
|
|
|
|
/**
|
|
* Tests for modular decomposition of agents/gsd-planner.md
|
|
*
|
|
* Verifies that:
|
|
* 1. gsd-planner.md stays under the 100K agent file threshold
|
|
* 2. gsd-planner.md is under 45K chars (proving the three mode sections were extracted)
|
|
* 3. The three reference files exist
|
|
* 4. gsd-planner.md contains reference pointers to each extracted file
|
|
* 5. Each reference file contains key content from the original mode section
|
|
*/
|
|
'use strict';
|
|
|
|
const { describe, test } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
|
|
const PROJECT_ROOT = path.join(__dirname, '..');
|
|
|
|
// ─── Size thresholds ─────────────────────────────────────────────────────────
|
|
|
|
const AGENT_FILE_SIZE_LIMIT = 100 * 1024; // 100K — appropriate for version-controlled source
|
|
const PLANNER_EXTRACTED_LIMIT = 48 * 1024; // 48K — proves extraction happened
|
|
|
|
// ─── File paths ──────────────────────────────────────────────────────────────
|
|
|
|
const PLANNER_PATH = path.join(PROJECT_ROOT, 'agents', 'gsd-planner.md');
|
|
const GAP_CLOSURE_REF = path.join(PROJECT_ROOT, 'get-shit-done', 'references', 'planner-gap-closure.md');
|
|
const REVISION_REF = path.join(PROJECT_ROOT, 'get-shit-done', 'references', 'planner-revision.md');
|
|
const REVIEWS_REF = path.join(PROJECT_ROOT, 'get-shit-done', 'references', 'planner-reviews.md');
|
|
|
|
// ─── gsd-planner.md size ─────────────────────────────────────────────────────
|
|
|
|
describe('gsd-planner.md size constraints', () => {
|
|
test('planner file exists', () => {
|
|
assert.ok(fs.existsSync(PLANNER_PATH), `Missing: ${PLANNER_PATH}`);
|
|
});
|
|
|
|
test('planner is under 100K chars (agent file threshold)', () => {
|
|
const raw = fs.readFileSync(PLANNER_PATH, 'utf-8');
|
|
// Normalize CRLF → LF before measuring — Windows checkouts inflate length by ~1 char/line
|
|
const content = raw.replace(/\r\n/g, '\n').replace(/\r/g, '\n');
|
|
assert.ok(
|
|
content.length < AGENT_FILE_SIZE_LIMIT,
|
|
`gsd-planner.md is ${content.length} chars, exceeds 100K agent threshold`
|
|
);
|
|
});
|
|
|
|
test('planner is under 45K chars (proves mode sections were extracted)', () => {
|
|
const raw = fs.readFileSync(PLANNER_PATH, 'utf-8');
|
|
// Normalize CRLF → LF before measuring — Windows checkouts inflate length by ~1 char/line
|
|
const content = raw.replace(/\r\n/g, '\n').replace(/\r/g, '\n');
|
|
assert.ok(
|
|
content.length < PLANNER_EXTRACTED_LIMIT,
|
|
`gsd-planner.md is ${content.length} chars, expected < 45K after extracting mode sections`
|
|
);
|
|
});
|
|
});
|
|
|
|
// ─── Reference files exist ───────────────────────────────────────────────────
|
|
|
|
describe('extracted reference files exist', () => {
|
|
test('planner-gap-closure.md exists', () => {
|
|
assert.ok(fs.existsSync(GAP_CLOSURE_REF), `Missing: ${GAP_CLOSURE_REF}`);
|
|
});
|
|
|
|
test('planner-revision.md exists', () => {
|
|
assert.ok(fs.existsSync(REVISION_REF), `Missing: ${REVISION_REF}`);
|
|
});
|
|
|
|
test('planner-reviews.md exists', () => {
|
|
assert.ok(fs.existsSync(REVIEWS_REF), `Missing: ${REVIEWS_REF}`);
|
|
});
|
|
});
|
|
|
|
// ─── gsd-planner.md contains reference pointers ──────────────────────────────
|
|
|
|
describe('gsd-planner.md contains reference pointers to extracted files', () => {
|
|
let plannerContent;
|
|
|
|
test('planner references planner-gap-closure.md', () => {
|
|
plannerContent = plannerContent || fs.readFileSync(PLANNER_PATH, 'utf-8');
|
|
assert.ok(
|
|
plannerContent.includes('planner-gap-closure.md'),
|
|
'gsd-planner.md must reference planner-gap-closure.md'
|
|
);
|
|
});
|
|
|
|
test('planner references planner-revision.md', () => {
|
|
plannerContent = plannerContent || fs.readFileSync(PLANNER_PATH, 'utf-8');
|
|
assert.ok(
|
|
plannerContent.includes('planner-revision.md'),
|
|
'gsd-planner.md must reference planner-revision.md'
|
|
);
|
|
});
|
|
|
|
test('planner references planner-reviews.md', () => {
|
|
plannerContent = plannerContent || fs.readFileSync(PLANNER_PATH, 'utf-8');
|
|
assert.ok(
|
|
plannerContent.includes('planner-reviews.md'),
|
|
'gsd-planner.md must reference planner-reviews.md'
|
|
);
|
|
});
|
|
});
|
|
|
|
// ─── Reference files contain key content ────────────────────────────────────
|
|
|
|
describe('reference files contain key content from original mode sections', () => {
|
|
test('planner-gap-closure.md contains gap closure content', () => {
|
|
const content = fs.readFileSync(GAP_CLOSURE_REF, 'utf-8');
|
|
const hasGapContent = content.toLowerCase().includes('gap_closure') ||
|
|
content.toLowerCase().includes('gap closure') ||
|
|
content.includes('GAP CLOSURE') ||
|
|
content.includes('--gaps');
|
|
assert.ok(hasGapContent, 'planner-gap-closure.md must contain gap closure mode content');
|
|
});
|
|
|
|
test('planner-revision.md contains revision content', () => {
|
|
const content = fs.readFileSync(REVISION_REF, 'utf-8');
|
|
const hasRevisionContent = content.includes('revision') ||
|
|
content.includes('Revision') ||
|
|
content.includes('REVISION') ||
|
|
content.includes('revision_context');
|
|
assert.ok(hasRevisionContent, 'planner-revision.md must contain revision mode content');
|
|
});
|
|
|
|
test('planner-reviews.md contains reviews content', () => {
|
|
const content = fs.readFileSync(REVIEWS_REF, 'utf-8');
|
|
const hasReviewsContent = content.includes('reviews') ||
|
|
content.includes('Reviews') ||
|
|
content.includes('REVIEWS') ||
|
|
content.includes('REVIEWS.md');
|
|
assert.ok(hasReviewsContent, 'planner-reviews.md must contain reviews mode content');
|
|
});
|
|
});
|