Files
msd-core/get-shit-done/workflows/insert-phase.md
Tom Boucher 3d52f5ee46 refactor(tests): consolidate Init Command Module — 7 files → 5 (#3756)
* fix(3687): update insert-phase docs and roadmapper to use --insert flag

Updates stale references in insert-phase.md workflow and
gsd-roadmapper.md agent to use the consolidated /gsd:phase --insert
command syntax instead of the retired /gsd-insert-phase and
/gsd:phase insert forms.

Closes #3687

* refactor(tests): consolidate Init Command Module — 7 files → 5

Closes #3755

Merges `tests/init-manager-deps.test.cjs` (#2267 regression) into
`tests/init-manager.test.cjs` (718 LOC), and
`sdk/src/query/init-progress-precedence.test.ts` (#2674 regression)
into `sdk/src/query/init-complex.test.ts` (788 LOC).

The 800 LOC ceiling prevents further consolidation:
- `tests/init.test.cjs` is pre-existing at 1630 LOC
- `sdk/src/query/init.test.ts` is at 791 LOC
- `sdk/src/query/init-workstream-milestone-op.test.ts` is a distinct
  seam testing initMilestoneOp, roadmapAnalyze, and
  resolveQueryRuntimeContext workstream resolution.

Also adds Init Command Module Glossary entry to CONTEXT.md.

Allowlist update deferred to rebase after #3738 merges (allowlist
file does not exist on origin/main).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix(init): initExecutePhase preserves same-milestone archived phase dir (#3469)

When `phases clear` archives current-milestone phases into
`.planning/milestones/<version>-phases/` but the workflow is still on
that same milestone, `shouldDropArchivedPhaseMatch` was unconditionally
dropping the archived dir match. This caused `phase_dir: null` when the
phase was still executing in the current milestone.

Fix: detect when `phaseInfo.archived === currentMilestone` (read from
STATE.md) and skip the drop. The #2391 regression guard is safe because
that scenario involves archived.version != current milestone.

Also corrects two tests in `initRemoveWorkspace` to expect thrown
GSDError instead of `{ data: { error } }` — the production code was
intentionally changed to throw for CLI non-zero exit propagation.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: arya rizky <aryarizkyardhipratama@gmail.com>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-05-20 20:39:01 -04:00

4.3 KiB

Insert a decimal phase for urgent work discovered mid-milestone between existing integer phases. Uses decimal numbering (72.1, 72.2, etc.) to preserve the logical sequence of planned phases while accommodating urgent insertions without renumbering the entire roadmap.

<required_reading> Read all files referenced by the invoking prompt's execution_context before starting. </required_reading>

Parse the command arguments: - First argument: integer phase number to insert after - Remaining arguments: phase description

Example: /gsd:phase --insert 72 Fix critical auth bug -> after = 72 -> description = "Fix critical auth bug"

If arguments missing:

ERROR: Both phase number and description required
Usage: /gsd:phase --insert <after> <description>
Example: /gsd:phase --insert 72 Fix critical auth bug

Exit.

Validate first argument is an integer.

Load phase operation context:
INIT=$(gsd-sdk query init.phase-op "${after_phase}")
if [[ "$INIT" == @file:* ]]; then INIT=$(cat "${INIT#@file:}"); fi

Check roadmap_exists from init JSON. If false:

ERROR: No roadmap found (.planning/ROADMAP.md)

Exit.

**Delegate the phase insertion to `gsd-sdk query phase.insert`:**
RESULT=$(gsd-sdk query phase.insert "${after_phase}" "${description}")

The CLI handles:

  • Verifying target phase exists in ROADMAP.md
  • Calculating next decimal phase number (checking existing decimals on disk)
  • Generating slug from description
  • Creating the phase directory (.planning/phases/{N.M}-{slug}/)
  • Inserting the phase entry into ROADMAP.md after the target phase with (INSERTED) marker

Extract from result: phase_number, after_phase, name, slug, directory.

Update STATE.md to reflect the inserted phase via SDK handlers (never raw `Edit`/`Write` — projects may ship a `protect-files.sh` PreToolUse hook that blocks direct STATE.md writes):
  1. Update STATE.md's next-phase pointer(s) to the newly inserted phase {decimal_phase}:

    gsd-sdk query state.patch '{"Current Phase":"{decimal_phase}","Next recommended run":"/gsd:plan-phase {decimal_phase}"}'
    

    (Adjust field names to whatever pointers STATE.md exposes — the handler reports which fields it matched.)

  2. Append a Roadmap Evolution entry via the dedicated handler. It creates the ### Roadmap Evolution subsection under ## Accumulated Context if missing and dedupes identical entries:

    gsd-sdk query state.add-roadmap-evolution \
      --phase {decimal_phase} \
      --action inserted \
      --after {after_phase} \
      --note "{description}" \
      --urgent
    

    Expected response shape: { added: true, entry: "- Phase ... (URGENT)" } (or { added: false, reason: "duplicate", entry: ... } on replay).

Present completion summary:
Phase {decimal_phase} inserted after Phase {after_phase}:
- Description: {description}
- Directory: .planning/phases/{decimal-phase}-{slug}/
- Status: Not planned yet
- Marker: (INSERTED) - indicates urgent work

Roadmap updated: .planning/ROADMAP.md
Project state updated: .planning/STATE.md

---

## Next Up

**Phase {decimal_phase}: {description}** -- urgent insertion

`/clear` then:

`/gsd:plan-phase {decimal_phase}`

---

**Also available:**
- Review insertion impact: Check if Phase {next_integer} dependencies still make sense
- Review roadmap

---

<anti_patterns>

  • Don't use this for planned work at end of milestone (use /gsd-add-phase)
  • Don't insert before Phase 1 (decimal 0.1 makes no sense)
  • Don't renumber existing phases
  • Don't modify the target phase content
  • Don't create plans yet (that's /gsd:plan-phase)
  • Don't commit changes (user decides when to commit) </anti_patterns>

<success_criteria> Phase insertion is complete when:

  • gsd-sdk query phase.insert executed successfully
  • Phase directory created
  • Roadmap updated with new phase entry (includes "(INSERTED)" marker)
  • gsd-sdk query state.add-roadmap-evolution ... returned { added: true } or { added: false, reason: "duplicate" }
  • gsd-sdk query state.patch returned matched next-phase pointer field(s)
  • User informed of next steps and dependency implications </success_criteria>