c87f6f358e
* test(#1854): failing-first coverage for user-files-backup restore Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * feat(#1854): offer restore for user-added files backed up on update Adds a restore-custom-files gsd-tools verb and wires it into update.md as a restore_custom_files step: plan, compatibility-check against the newly installed release, then restore only on explicit opt-in. The backup is never deleted, a shipped path is never overwritten, and a single unwritable entry does not abort the rest. Also drops the jq pipe from update-context field extraction (#2589 class, missed by that sweep) and repairs a broken code fence in docs/CLI-TOOLS.md. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(#1854): reject symlinked restore destinations and backup roots Self-review of the restore path found two write-through holes: copyFileSync follows a symlinked destination, so a link planted at the restore target wrote outside the config dir with every ancestor still a real directory; and statSync on the backup root followed a link, letting the walk read arbitrary files and present them as the user's own backup. Both now lstat. Also marks the report's path/detail strings as untrusted data in update.md so the rendered step cannot carry instructions into the runtime model. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * test(#1854): move the update-context jq guard into the #2589 sweep update.md joins the AUDITED list rather than carrying a duplicate assertion in the backup-restore suite, and the guard gains a negative-proof companion so 'no jq pipe' cannot pass by the fields simply no longer being read. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(#1854): validate manifest files map shape before trusting it Security review flagged that Object.keys on a non-plain-object files field yields numeric-index keys matching nothing, so the managed-path check dies silently while manifest_found still reports true. Shape, not just type (ADR-227): an array or scalar files map is now an unusable manifest. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(#1854): size the restore prompt by eligible_count Spec review found the prompt was driven by entries.length, so a backup holding only blocked entries asked "Restore 1 file(s)?" when accepting would restore zero. The question now reads eligible_count, and an all-blocked backup reports its reasons instead of offering a choice that cannot be honored. The decline path names the resolved backup_dir rather than the bare directory name. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * test(#1854): use t.skip on hosts without symlink support A bare return in a node:test body registers as a PASS, so the four symlink guards silently reported green on unprivileged Windows instead of skipping. Adds the dangling-link destination case the security review called out, and moves outside-dir teardown to t.after so a failing assert cannot leak it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(#1854): unfence restore hint, regen goldens, widen install timeout Three gate failures from the c99d612a5 run, all root-caused: 1. capability-registry (3): update.md's decline message put an instructional 'gsd-tools ...' line in an UNTAGGED fence, and the guard treats untagged fences as shell blocks. Retagged both display blocks as text and switched the hint to the resolved 'node <config-dir>/.../gsd-tools.cjs' form users can actually paste. 2. golden-install-parity (19): update.md and gsd-tools.cjs ship, so every runtime fixture moved. Regenerated; the diff is exactly those two hashes per fixture, no other drift. 3. install.test.cjs (5): one real failure, four cascades. The Cursor suite's before hook died on 'spawnSync ETIMEDOUT' at the 60s cap while the node22 lane passed the SAME commit in 12.7s. A full install measures 13-30s idle, so 60s was under 2x headroom and shrinks with every file added to the payload. Raised to 120s, matching the heavy case already in this file. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * chore(#1854): backfill changeset pr number to 2679 --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
94 lines
2.4 KiB
JSON
94 lines
2.4 KiB
JSON
{
|
|
"add-backlog.md": 7176,
|
|
"add-phase.md": 7578,
|
|
"add-tests.md": 17247,
|
|
"add-todo.md": 11020,
|
|
"ai-integration-phase.md": 15356,
|
|
"analyze-dependencies.md": 3887,
|
|
"audit-fix.md": 12329,
|
|
"audit-milestone.md": 19034,
|
|
"audit-uat.md": 7469,
|
|
"autonomous.md": 42468,
|
|
"check-todos.md": 9771,
|
|
"cleanup.md": 10319,
|
|
"code-review-fix.md": 24906,
|
|
"code-review.md": 33110,
|
|
"complete-milestone.md": 31436,
|
|
"debug.md": 20175,
|
|
"diagnose-issues.md": 13444,
|
|
"discovery-phase.md": 13543,
|
|
"discuss-phase-assumptions.md": 28253,
|
|
"discuss-phase-power.md": 11273,
|
|
"discuss-phase.md": 31986,
|
|
"do.md": 10731,
|
|
"docs-update.md": 56494,
|
|
"edit-phase.md": 12927,
|
|
"eval-review.md": 10316,
|
|
"execute-phase.md": 90143,
|
|
"execute-plan.md": 35143,
|
|
"explore.md": 11127,
|
|
"extract-learnings.md": 13762,
|
|
"fast.md": 7613,
|
|
"forensics.md": 12531,
|
|
"graduation.md": 11987,
|
|
"health.md": 12246,
|
|
"help.md": 1722,
|
|
"import.md": 15599,
|
|
"inbox.md": 19299,
|
|
"ingest-docs.md": 19821,
|
|
"insert-phase.md": 8987,
|
|
"list-phase-assumptions.md": 4305,
|
|
"list-seeds.md": 6987,
|
|
"list-workspaces.md": 5699,
|
|
"manager.md": 27751,
|
|
"map-codebase.md": 21888,
|
|
"milestone-summary.md": 11842,
|
|
"mvp-phase.md": 13991,
|
|
"new-milestone.md": 38667,
|
|
"new-project.md": 67055,
|
|
"new-workspace.md": 11584,
|
|
"next.md": 20171,
|
|
"node-repair.md": 4173,
|
|
"note.md": 6563,
|
|
"onboard.md": 8877,
|
|
"pause-work.md": 14441,
|
|
"plan-milestone-gaps.md": 11809,
|
|
"plan-phase.md": 94427,
|
|
"plan-review-convergence.md": 26363,
|
|
"plant-seed.md": 12150,
|
|
"pr-branch.md": 15963,
|
|
"profile-user.md": 21624,
|
|
"progress.md": 32632,
|
|
"quick.md": 52280,
|
|
"reapply-patches.md": 20312,
|
|
"remove-phase.md": 8513,
|
|
"remove-workspace.md": 7916,
|
|
"resume-project.md": 17270,
|
|
"review.md": 54036,
|
|
"scan.md": 8314,
|
|
"secure-phase.md": 14627,
|
|
"session-report.md": 4044,
|
|
"settings-advanced.md": 40019,
|
|
"settings-integrations.md": 16257,
|
|
"settings.md": 33832,
|
|
"ship.md": 29834,
|
|
"sketch-wrap-up.md": 14267,
|
|
"sketch.md": 20369,
|
|
"smart-entry.md": 11489,
|
|
"spec-phase.md": 31987,
|
|
"spike-wrap-up.md": 15136,
|
|
"spike.md": 24939,
|
|
"stats.md": 6762,
|
|
"sync-skills.md": 6125,
|
|
"thread.md": 12508,
|
|
"transition.md": 22070,
|
|
"ui-phase.md": 26925,
|
|
"ui-review.md": 12166,
|
|
"ultraplan-phase.md": 10512,
|
|
"undo.md": 15323,
|
|
"update.md": 26024,
|
|
"validate-phase.md": 11856,
|
|
"verify-phase.md": 40949,
|
|
"verify-work.md": 41318
|
|
}
|