Files
msd-core/sdk/src/query/phase-roadmap-mutation.ts
Tom Boucher aab01f43e9 refactor(tests): consolidate Phase Lifecycle Module — 20 files → 4 (#3741)
* chore(tests): lint rule — cap test files per production module at 2

Adds scripts/lint-test-file-count.cjs with a ratcheted allowlist
(scripts/lint-test-file-count.allowlist.json) capturing today's
30 violating clusters as a ceiling. New entries blocked at PR time;
reductions ratchet automatically.

Wires into .github/workflows/test.yml as a new step in lint-tests.

Refs #3737

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* refactor(tests): consolidate Phase Lifecycle Module — 20 files → 4

- Merge 10 CJS bug-fix test files into tests/phase.test.cjs
- Merge sdk/src/phase-runner-types.test.ts + sdk/src/phase-prompt.test.ts
  into sdk/src/phase-runner.test.ts (97 → 152 tests, 0 failures)
- Rename 4 mis-attributed test files out of phase cluster:
    phase-researcher-app-aware    → gsd-researcher-app-aware
    phase-researcher-flow-diagram → gsd-researcher-flow-diagram
    feat-3023-phase-type-models   → feat-3023-model-phase-types
    phase-6-cjs-sdk-seam-contracts → cjs-sdk-bridge-seam-contracts
- Fix phasePlanIndex (#3430): non-canonical plan filename warning now
  surfaces in data.warnings[] as "Ignored noncanonical plan files: ..."
  instead of a separate singular data.warning field
- Update allowlist: phase ceiling 20 → 4 (closes #3740)
- Add Phase Lifecycle Module glossary entry to CONTEXT.md

Closes #3740

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix(phase-roadmap-mutation): replaceInCurrentMilestone handles active milestone inside <details> block

When the active milestone is wrapped in a <details> block (e.g. user
collapsed it, or milestone transition), the after-</details> slice is
empty or contains only footer text — the pattern never matches and the
replacement is silently dropped.

Fix: when after.replace() produces no change, fall back to replacing
inside the last <details>...</details> block. Shipped-milestone blocks
are untouched because only the last <details> block is targeted.

Closes #2641

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix(changeset): add required type/pr frontmatter to 3740 fragment

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-05-20 20:57:06 -04:00

83 lines
3.1 KiB
TypeScript

import { readFile, writeFile } from 'node:fs/promises';
import { planningPaths } from './helpers.js';
import { acquireStateLock, releaseStateLock } from './state-mutation.js';
/**
* Replace a pattern only in the current milestone section of ROADMAP.md.
*
* Port of replaceInCurrentMilestone from core.cjs lines 1013-1022.
*
* Semantics:
* • No `</details>` in the content → plain `content.replace(pattern, replacement)`.
* • Otherwise → split at the last `</details>` and replace only in the
* content AFTER it.
* • If the after-slice produces no replacement (pattern not found there),
* fall back to replacing inside the last `<details>...</details>` block.
* This handles the case where the active milestone is itself wrapped in
* a `<details>` block (e.g. collapsed by the user or during a milestone
* transition). Earlier shipped-milestone blocks are left untouched because
* only the last `<details>` block is targeted by the fallback.
* (Fixes #2641.)
*/
export function replaceInCurrentMilestone(
content: string,
pattern: string | RegExp,
replacement: string,
): string {
const lastDetailsClose = content.lastIndexOf('</details>');
if (lastDetailsClose === -1) {
return content.replace(pattern, replacement);
}
const offset = lastDetailsClose + '</details>'.length;
const before = content.slice(0, offset);
const after = content.slice(offset);
const afterReplaced = after.replace(pattern, replacement);
if (afterReplaced !== after) {
// Pattern matched in the after-slice (normal case: active milestone is
// outside/after the last </details>).
return before + afterReplaced;
}
// Pattern did not match after the last </details>. Fall back to replacing
// inside the last <details> block (active milestone is wrapped in <details>).
const lastDetailsOpen = content.lastIndexOf('<details>');
if (lastDetailsOpen === -1 || lastDetailsOpen >= lastDetailsClose) {
// Malformed or no proper block — return unchanged.
return content;
}
const blockBefore = content.slice(0, lastDetailsOpen);
const blockInner = content.slice(lastDetailsOpen, offset);
const blockAfter = content.slice(offset);
return blockBefore + blockInner.replace(pattern, replacement) + blockAfter;
}
/**
* Atomic read-modify-write for ROADMAP.md.
*
* Holds a lockfile across the entire read -> transform -> write cycle.
*/
export async function readModifyWriteRoadmapMd(
projectDir: string,
modifier: (content: string) => string | Promise<string>,
workstream?: string,
): Promise<string> {
const roadmapPath = planningPaths(projectDir, workstream).roadmap;
const lockPath = await acquireStateLock(roadmapPath);
try {
let content: string;
try {
content = await readFile(roadmapPath, 'utf-8');
} catch (err) {
if ((err as NodeJS.ErrnoException).code === 'ENOENT') {
content = '';
} else {
throw err;
}
}
const modified = await modifier(content);
await writeFile(roadmapPath, modified, 'utf-8');
return modified;
} finally {
await releaseStateLock(lockPath);
}
}