* chore(#191): migrate gsd-sdk query call sites to gsd-tools query Retiring the gsd-sdk shim. gsd-tools.cjs already accepts `query` as a meta-prefix (gsd-tools query <command>), so this is a behavior-preserving 1:1 swap across the runtime reference prompts, the graphify hook's commit-detection gate, and two bin/lib comment/message references. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * chore(#191): remove vestigial gsd-sdk shim code from installer + projection The gsd-sdk shim was already not wired up (no gsd-sdk bin in package.json; buildWindowsShimTriple had zero call sites). Remove the dead code: - shell-command-projection.cjs: buildWindowsShimTriple + formatSdkPathDiagnostic (+ their now-unused PACKAGE_NAME import) and exports - install.js: the re-export wrappers + imports, the #3406 stale-standalone-sdk detection (detectStaleStandaloneSdk/formatStaleStandaloneSdkWarning + its global-install call site), and the exports Preserved (retained, not gsd-sdk): buildCodexHookWindowsShimIR (#3426) — only its comments referenced the gsd-sdk pattern; reworded. Also kept the homePathCoveredByRc 'reopen your shell' branch in maybeSuggestPathExport — its logic is bin-dir-agnostic, only the message mentioned gsd-sdk; reworded to use the actual bin dir. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * test(#191): update tests for retired gsd-sdk shim - bug-3441/bug-3442: drop the formatSdkPathDiagnostic / buildWindowsShimTriple assertions (functions removed); retained PATH-action + drift-guard tests stay - bug-505: remove the 'still exported' assertions for detectStaleStandaloneSdk / formatStaleStandaloneSdkWarning / the shim contract surface (#505 kept them; #191 removes them) - graphify-auto-update: migrate the hook-dispatch inputs gsd-sdk query commit -> gsd-tools query commit to match the migrated commit hook Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * docs(#191): point active docs at gsd-tools query (gsd-sdk shim retired) Update the user/agent-facing docs (AGENTS, COMMANDS, CONFIGURATION, USER-GUIDE, ship-pr-body-sections) that presented gsd-sdk query as a current command to gsd-tools query. Historical docs (ADRs, PRDs, release notes) left untouched. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * docs(#191): correct state.load vs state.json description for gsd-tools query Adversarial-review (codex) finding: the migrated USER-GUIDE line claimed both 'gsd-tools query state.json' and 'state.load' resolve to the frontmatter-rebuild handler. Verified they don't — state.load returns the CJS load shape (config + state_raw + flags), state.json returns the frontmatter shape. Both are available via gsd-tools query; corrected the text to say so. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * chore(#191): add changeset for gsd-sdk shim retirement Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
75 lines
2.3 KiB
JavaScript
75 lines
2.3 KiB
JavaScript
'use strict';
|
|
|
|
/**
|
|
* Typed flag parser for the /gsd:code-review command.
|
|
*
|
|
* This is the canonical IR for code-review argument parsing. The workflow
|
|
* (code-review.md) delegates flag dispatch logic to this module so that:
|
|
* 1. Tests assert on a structured IR rather than on rendered bash text.
|
|
* 2. The dispatch decision is testable without instantiating the workflow.
|
|
*
|
|
* @typedef {Object} CodeReviewFlags
|
|
* @property {boolean} fix - true when --fix is present in argv
|
|
* @property {boolean} all - true when --all is present in argv (implies fix)
|
|
* @property {boolean} auto - true when --auto is present in argv (implies fix)
|
|
* @property {string} depth - depth override value, or '' if not supplied
|
|
* @property {string} files - files override value, or '' if not supplied
|
|
*/
|
|
|
|
/**
|
|
* Parse code-review flags from an argv array.
|
|
*
|
|
* The first positional argument (phase number) is ignored by this function —
|
|
* phase validation is handled by `gsd-tools query init.phase-op`.
|
|
*
|
|
* @param {string[]} argv - Array of argument strings, e.g. ['2', '--fix', '--all']
|
|
* @returns {CodeReviewFlags}
|
|
*/
|
|
function parseCodeReviewFlags(argv) {
|
|
const flags = {
|
|
fix: false,
|
|
all: false,
|
|
auto: false,
|
|
depth: '',
|
|
files: '',
|
|
};
|
|
|
|
for (const arg of argv) {
|
|
if (arg === '--fix') {
|
|
flags.fix = true;
|
|
} else if (arg === '--all') {
|
|
flags.all = true;
|
|
} else if (arg === '--auto') {
|
|
flags.auto = true;
|
|
} else if (arg.startsWith('--depth=')) {
|
|
flags.depth = arg.slice('--depth='.length);
|
|
} else if (arg.startsWith('--files=')) {
|
|
flags.files = arg.slice('--files='.length);
|
|
}
|
|
}
|
|
|
|
// --all and --auto imply --fix
|
|
if (flags.all || flags.auto) {
|
|
flags.fix = true;
|
|
}
|
|
|
|
return flags;
|
|
}
|
|
|
|
/**
|
|
* Determine which workflow to dispatch based on parsed flags.
|
|
*
|
|
* Returns the workflow filename (relative to workflows/) that the orchestrator
|
|
* should load:
|
|
* - 'code-review-fix.md' when fix=true (--fix, --all, or --auto present)
|
|
* - 'code-review.md' otherwise (review-only pass)
|
|
*
|
|
* @param {CodeReviewFlags} flags
|
|
* @returns {'code-review.md' | 'code-review-fix.md'}
|
|
*/
|
|
function resolveCodeReviewWorkflow(flags) {
|
|
return flags.fix ? 'code-review-fix.md' : 'code-review.md';
|
|
}
|
|
|
|
module.exports = { parseCodeReviewFlags, resolveCodeReviewWorkflow };
|