* feat(#498): generated package-identity seam derived from package.json Introduce a single source for GSD's published-package coordinates: scripts/generate-package-identity.cjs (pure deriveIdentity + formatManualInstall + render) emits the generated get-shit-done/bin/lib/package-identity.cjs with values baked from package.json at build time. Baking is required because the installed tree carries only a synthetic {"type":"commonjs"} package.json, so a runtime require('package.json').name resolves to undefined (#378). Reconciles Wired into npm run build; a parity test fails CI if the committed file drifts from package.json. Refs #498 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#498): repoint update worker + check-latest-version at the seam - check-latest-version.cjs sources PACKAGE_NAME from the package-identity seam instead of a re-typed literal (single source; #2992's constant guarantee is preserved since the seam bakes from package.json). - gsd-check-update-worker.js no longer does require('../package.json').name (resolved to undefined in the installed tree → background update check silently broken, #378). It now delegates the latest-version lookup to checkLatestVersion(), collapsing the duplicated npm-view call onto the single deterministic adapter and inheriting its typed {ok,version,reason} surface. - Move the PR #3102 Windows shell-gate contract test onto execNpm (where the spawn now lives) and assert the worker no longer spawns npm directly. - Rewrite the #378 contract: worker must NOT use require(package.json).name and must delegate; check-latest-version PACKAGE_NAME is single-sourced from the seam. Fixes #378-class runtime breakage. Refs #498 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * chore(#498): changeset for package-identity seam + update-check fix Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * feat(#498): drift-guard lint — value-check GSD coordinate literals against the seam scripts/lint-package-identity-drift.cjs scans the runtime/code surface (bin/, hooks/, scripts/, get-shit-done/) and asserts every GSD package name and GitHub repo slug literal equals the Package Identity seam's current value. Passes today; fails the moment a repoint isn't propagated (rename package.json, regenerate the seam, and stale literals are reported until updated). This is the second adapter that makes the seam real and a repoint mechanically safe. Enforced via tests/issue-498-identity-drift-lint.test.cjs (scanRepo === []) under npm test; also exposed as `npm run check:identity-drift`. Refs #498 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * feat(#498): update-context projection — port update.md resolution to a tested seam Add get-shit-done/bin/lib/update-context.cjs: a pure, injected-fs port of update.md's ~280-line get_installed_version bash. resolveUpdateContext() reproduces the full precedence cascade (preferred fast-path -> local probe -> global probe via env overrides then $HOME -> LOCAL-if-distinct -> scope cascade -> UNKNOWN) and returns the 4-field contract { installedVersion, scope, runtime, gsdDir }. The fs is injected so every branch is finally testable without a live multi-runtime install. Expose it as `gsd-tools update-context [--config-dir <d>] [--runtime <r>] --json`. Purely additive — update.md is unchanged in this commit; the workflow swap follows separately. Refs #498 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * feat(#498): swap update.md resolution to the update-context projection Replace ~280 lines of inline runtime/scope/config-dir bash in update.md's get_installed_version step with a call to `gsd-tools update-context --json` (60 lines: derive PREFERRED_* from execution_context, resolve gsd-tools.cjs, parse the 4-field JSON). Behavior is unchanged — the projection reproduces the same cascade — but the logic is now tested in update-context.cjs instead of untestable bash-in-markdown. Relocate the #3608 antigravity-first-class contract onto the projection (RUNTIME_DIRS order, inferPreferredRuntime, envRuntimeDirs) plus a behavioral test; keep the execution_context path-classification assertion on update.md. Re-point install.test's custom-config-dir assertion (kilo.jsonc/KILO_CONFIG) to update-context.cjs where that detection now lives. Full root suite: 2022 pass / 0 fail. Refs #498 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * docs(#498): record Update Context Module in CONTEXT.md Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#498): CI — avoid bare gsd-tools in update.md; register new CLI modules - update.md update-context invocation: resolve the PATH gsd-tools shim into a variable and call "$GSD_TOOLS" (never a bare `gsd-tools` command) — satisfies the #2851 workflow-bare-gsd-tools guard. - Register package-identity.cjs and update-context.cjs in docs/INVENTORY.md (CLI Modules 76 -> 78 + rows) and regenerate docs/INVENTORY-MANIFEST.json, fixing inventory-counts and inventory-manifest-sync. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * test(#498): make update-context + parity tests OS-agnostic (Windows CI) Two Windows-only test failures, both test-portability (production code is fine — the real-fs CLI integration test passed on Windows): - update-context resolver tests + bug-3608 behavioral test used POSIX path-string keys in their fake fs, but the resolver builds lookups via path.join/resolve (backslash + drive letter on Windows) → keys never matched → everything resolved to UNKNOWN/claude. Normalize fake-fs keys and gsdDir comparisons through path.resolve so they match on both platforms. - package-identity parity test compared render() (LF) to the committed file, which Windows git checks out as CRLF (no .gitattributes eol rule). Normalize line endings before comparing, matching the repo convention (autonomous-decomposition, bug-3707). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#498): update.md backup must use GSD_DIR (adversarial-review finding) The get_installed_version rewrite emits GSD_DIR but dropped the probe-loop variables LOCAL_DIR/GLOBAL_DIR. The backup_custom_files step still read those, so RUNTIME_DIR went empty for every LOCAL/GLOBAL install and detect-custom-files was skipped — and since the update then runs a clean install that wipes managed dirs (commands/gsd, get-shit-done), user-added files could be deleted without the intended backup. Set RUNTIME_DIR="$GSD_DIR" directly (the resolved config dir; empty for UNKNOWN scope, which still skips the backup). Add a structural regression (tests/issue-498-update-backup-runtime-dir.test.cjs). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * test(#503): re-point Antigravity .agent detection at the #498 projection #499 moves the runtime/scope detection cascade out of update.md inline bash into get-shit-done/bin/lib/update-context.cjs. The #503 regression test asserted on the inline RUNTIME_DIRS array, which no longer exists, so it would fail against the projected update.md even though the .agent guarantee is preserved. Rewrite it to verify the surviving surfaces: - behavioral: resolveUpdateContext resolves a LOCAL ./.agent install to the antigravity runtime (the original root cause, now covered by adding ['antigravity', '.agent'] to the projection RUNTIME_DIRS table) - update.md prose classifier still maps /.agent/ -> antigravity - the post-update cache-clear for-dir loop still includes .agent Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#498): finish de-hardcoding consumers + close adversarial-review parity gaps Restore the consumer de-hardcoding that is the point of the seam, and close the parity gaps an adversarial review (codex) found in the update-context projection. De-hardcode the repo slug + install command in the changeset tooling — #516 only single-sourced the package NAME, leaving 'open-gsd/get-shit-done-redux' hardcoded in scripts/changeset/cli.cjs and github-release-notes.cjs. Route both through the seam's repoSlug/packageName so a rename is a regenerate, not a hand edit. The drift-lint real scan now reports zero divergent coordinate literals. Projection parity vs the old inline bash, as ONE consistent rule (trustedVersionAt) applied on every path: - expand a leading ~/ in preferredConfigDir before the fast path (the bash ran expand_home first; a custom --config-dir ~/foo otherwise fell to UNKNOWN) - trust a version only when BOTH VERSION and the update.md marker exist — fast path AND LOCAL/GLOBAL cascade; a partial dir falls to 0.0.0 keeping scope - apply the same same-path dedup to the 0.0.0 fallback so a partial install probed from cwd===home is not misdetected as LOCAL Adds regression tests for tilde expansion, VERSION-only (cascade + fast path), and the cwd===home partial-install dedup. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
210 lines
8.8 KiB
JavaScript
210 lines
8.8 KiB
JavaScript
'use strict';
|
|
|
|
/**
|
|
* Update-context resolver (issue #498, candidate 3).
|
|
*
|
|
* Faithful Node port of the ~280-line `get_installed_version` bash step in
|
|
* `workflows/update.md`. That logic resolved the installed GSD version, the
|
|
* install scope (LOCAL / GLOBAL / UNKNOWN), the target runtime, and the config
|
|
* dir — entirely as inline bash inside an LLM prompt, untestable through its
|
|
* interface. This module makes the same cascade a pure, injected-fs function so
|
|
* the workflow shrinks to: call → compare → confirm → install.
|
|
*
|
|
* The fs is injected ({ exists, readFile }) so every precedence branch is
|
|
* testable without a live multi-runtime install. `loadUpdateContext` wires the
|
|
* real fs for the CLI.
|
|
*/
|
|
|
|
const path = require('node:path');
|
|
|
|
// Runtime -> candidate relative dir. Order matters: it is the probe order, and
|
|
// mirrors the RUNTIME_DIRS array the bash used (a runtime may have several
|
|
// candidate dirs). Kept here, not derived from the installer's getDirName,
|
|
// because update detection probes ALL historical dirs per runtime.
|
|
const RUNTIME_DIRS = [
|
|
['claude', '.claude'],
|
|
['opencode', '.config/opencode'],
|
|
['opencode', '.opencode'],
|
|
['antigravity', '.gemini/antigravity-ide'],
|
|
['antigravity', '.gemini/antigravity-cli'],
|
|
['antigravity', '.gemini/antigravity'],
|
|
['antigravity', '.agent'], // local Antigravity install dir (#503; bin/install.js getDirName('antigravity'))
|
|
['gemini', '.gemini'],
|
|
['kilo', '.config/kilo'],
|
|
['kilo', '.kilo'],
|
|
['codex', '.codex'],
|
|
];
|
|
|
|
const SEMVER_PREFIX = /^\d+\.\d+\.\d+/;
|
|
|
|
function expandHome(p, home) {
|
|
if (!p) return '';
|
|
return p.startsWith('~/') ? path.join(home, p.slice(2)) : p;
|
|
}
|
|
|
|
function versionFile(dir) { return path.join(dir, 'get-shit-done', 'VERSION'); }
|
|
function markerFile(dir) { return path.join(dir, 'get-shit-done', 'workflows', 'update.md'); }
|
|
|
|
// Detection: a dir "has GSD" if it carries a VERSION file or the update.md
|
|
// workflow marker.
|
|
function hasInstall(fs, dir) {
|
|
return fs.exists(versionFile(dir)) || fs.exists(markerFile(dir));
|
|
}
|
|
|
|
// Read VERSION at dir; return a trimmed semver string, or null if missing/invalid.
|
|
function validVersionAt(fs, dir) {
|
|
const raw = fs.readFile(versionFile(dir));
|
|
if (raw == null) return null;
|
|
const trimmed = String(raw).trim();
|
|
return SEMVER_PREFIX.test(trimmed) ? trimmed : null;
|
|
}
|
|
|
|
// A version is TRUSTED only when BOTH the VERSION file and the update.md marker
|
|
// exist (and VERSION is valid semver) — the old inline cascade required both
|
|
// (update.md ~lines 230/241). A VERSION-only or marker-only dir is a partial
|
|
// install, so its version is not trusted (caller treats it as 0.0.0 = reinstall).
|
|
// One rule, applied on every path (fast path + LOCAL/GLOBAL cascade).
|
|
function trustedVersionAt(fs, dir) {
|
|
return dir && fs.exists(markerFile(dir)) ? validVersionAt(fs, dir) : null;
|
|
}
|
|
|
|
// Infer the preferred runtime from preferredConfigDir config files, then env.
|
|
function inferPreferredRuntime({ fs, env, preferredConfigDir }) {
|
|
if (preferredConfigDir) {
|
|
if (fs.exists(path.join(preferredConfigDir, 'kilo.json')) ||
|
|
fs.exists(path.join(preferredConfigDir, 'kilo.jsonc'))) return 'kilo';
|
|
if (fs.exists(path.join(preferredConfigDir, 'opencode.json')) ||
|
|
fs.exists(path.join(preferredConfigDir, 'opencode.jsonc'))) return 'opencode';
|
|
if (fs.exists(path.join(preferredConfigDir, 'config.toml'))) return 'codex';
|
|
}
|
|
if (env.CODEX_HOME) return 'codex';
|
|
if (env.ANTIGRAVITY_CONFIG_DIR) return 'antigravity';
|
|
if (env.GEMINI_CONFIG_DIR) return 'gemini';
|
|
if (env.KILO_CONFIG_DIR || env.KILO_CONFIG) return 'kilo';
|
|
if (env.OPENCODE_CONFIG_DIR || env.OPENCODE_CONFIG) return 'opencode';
|
|
if (env.CLAUDE_CONFIG_DIR) return 'claude';
|
|
return 'claude';
|
|
}
|
|
|
|
// Absolute env-override candidates, mirroring the bash ENV_RUNTIME_DIRS block.
|
|
function envRuntimeDirs({ env, home }) {
|
|
const out = [];
|
|
const ex = (v) => expandHome(v, home);
|
|
if (env.CLAUDE_CONFIG_DIR) out.push(['claude', ex(env.CLAUDE_CONFIG_DIR)]);
|
|
if (env.ANTIGRAVITY_CONFIG_DIR) out.push(['antigravity', ex(env.ANTIGRAVITY_CONFIG_DIR)]);
|
|
if (env.GEMINI_CONFIG_DIR) out.push(['gemini', ex(env.GEMINI_CONFIG_DIR)]);
|
|
if (env.KILO_CONFIG_DIR) out.push(['kilo', ex(env.KILO_CONFIG_DIR)]);
|
|
else if (env.KILO_CONFIG) out.push(['kilo', path.dirname(ex(env.KILO_CONFIG))]);
|
|
else if (env.XDG_CONFIG_HOME) out.push(['kilo', path.join(ex(env.XDG_CONFIG_HOME), 'kilo')]);
|
|
if (env.OPENCODE_CONFIG_DIR) out.push(['opencode', ex(env.OPENCODE_CONFIG_DIR)]);
|
|
else if (env.OPENCODE_CONFIG) out.push(['opencode', path.dirname(ex(env.OPENCODE_CONFIG))]);
|
|
else if (env.XDG_CONFIG_HOME) out.push(['opencode', path.join(ex(env.XDG_CONFIG_HOME), 'opencode')]);
|
|
if (env.CODEX_HOME) out.push(['codex', ex(env.CODEX_HOME)]);
|
|
return out;
|
|
}
|
|
|
|
// Stable reorder: entries whose runtime === preferred first, original order kept.
|
|
function preferFirst(entries, preferred) {
|
|
const pref = entries.filter(([rt]) => rt === preferred);
|
|
const rest = entries.filter(([rt]) => rt !== preferred);
|
|
return [...pref, ...rest];
|
|
}
|
|
|
|
/**
|
|
* Pure resolver. Returns { installedVersion, scope, runtime, gsdDir }.
|
|
*/
|
|
function resolveUpdateContext({ home, cwd, env = {}, fs, preferredConfigDir = '', preferredRuntime = '' }) {
|
|
// Expand a leading `~/` before any probe — the old inline bash ran
|
|
// `expand_home "$PREFERRED_CONFIG_DIR"` first, and a quoted shell path never
|
|
// tilde-expands, so a custom --config-dir like `~/custom-gsd` must resolve
|
|
// here or the fast path below silently misses the install (#498 parity).
|
|
preferredConfigDir = expandHome(preferredConfigDir, home);
|
|
const preferred = preferredRuntime || inferPreferredRuntime({ fs, env, preferredConfigDir });
|
|
|
|
// Fast path: a validated preferredConfigDir (custom --config-dir install).
|
|
if (preferredConfigDir && hasInstall(fs, preferredConfigDir)) {
|
|
const resolvedPref = path.resolve(preferredConfigDir);
|
|
let scope = 'GLOBAL';
|
|
for (const [, reldir] of RUNTIME_DIRS) {
|
|
if (path.resolve(cwd, reldir) === resolvedPref) { scope = 'LOCAL'; break; }
|
|
}
|
|
return {
|
|
installedVersion: trustedVersionAt(fs, preferredConfigDir) || '0.0.0',
|
|
scope,
|
|
runtime: preferred,
|
|
gsdDir: preferredConfigDir,
|
|
};
|
|
}
|
|
|
|
const orderedEnv = preferFirst(envRuntimeDirs({ env, home }), preferred);
|
|
const orderedRuntime = preferFirst(RUNTIME_DIRS, preferred);
|
|
|
|
// LOCAL probe (relative to cwd).
|
|
let localRuntime = '', localDir = '';
|
|
for (const [rt, reldir] of orderedRuntime) {
|
|
const cand = path.resolve(cwd, reldir);
|
|
if (hasInstall(fs, cand)) { localRuntime = rt; localDir = cand; break; }
|
|
}
|
|
|
|
// GLOBAL probe: absolute env candidates first, then $HOME-relative.
|
|
let globalRuntime = '', globalDir = '';
|
|
for (const [rt, absdir] of orderedEnv) {
|
|
if (hasInstall(fs, absdir)) { globalRuntime = rt; globalDir = path.resolve(absdir); break; }
|
|
}
|
|
if (!globalRuntime) {
|
|
for (const [rt, reldir] of orderedRuntime) {
|
|
const cand = path.resolve(home, reldir);
|
|
if (hasInstall(fs, cand)) { globalRuntime = rt; globalDir = cand; break; }
|
|
}
|
|
}
|
|
|
|
const localValid = trustedVersionAt(fs, localDir);
|
|
const isLocal = !!localValid && (!globalDir || localDir !== globalDir);
|
|
|
|
if (isLocal) {
|
|
return { installedVersion: localValid, scope: 'LOCAL', runtime: localRuntime, gsdDir: localDir };
|
|
}
|
|
const globalValid = trustedVersionAt(fs, globalDir);
|
|
if (globalValid) {
|
|
return { installedVersion: globalValid, scope: 'GLOBAL', runtime: globalRuntime, gsdDir: globalDir };
|
|
}
|
|
// A runtime dir was detected (VERSION or marker present) but is not a
|
|
// complete, valid install: keep scope/runtime/dir and report 0.0.0 so the
|
|
// caller re-installs (old inline `elif [ -n "$LOCAL_DIR" ]`). Apply the same
|
|
// same-path dedup as the trusted path so cwd===home does not misdetect as LOCAL.
|
|
if (localRuntime && (!globalDir || localDir !== globalDir)) {
|
|
return { installedVersion: '0.0.0', scope: 'LOCAL', runtime: localRuntime, gsdDir: localDir };
|
|
}
|
|
if (globalRuntime) {
|
|
return { installedVersion: '0.0.0', scope: 'GLOBAL', runtime: globalRuntime, gsdDir: globalDir };
|
|
}
|
|
return { installedVersion: '0.0.0', scope: 'UNKNOWN', runtime: 'claude', gsdDir: '' };
|
|
}
|
|
|
|
/**
|
|
* CLI wiring: resolve against the real filesystem.
|
|
*/
|
|
function loadUpdateContext(opts = {}) {
|
|
const nodeFs = require('node:fs');
|
|
const fs = {
|
|
exists: (p) => nodeFs.existsSync(p),
|
|
readFile: (p) => { try { return nodeFs.readFileSync(p, 'utf8'); } catch (e) { return null; } },
|
|
};
|
|
return resolveUpdateContext({
|
|
home: opts.home || require('node:os').homedir(),
|
|
cwd: opts.cwd || process.cwd(),
|
|
env: opts.env || process.env,
|
|
fs,
|
|
preferredConfigDir: opts.preferredConfigDir || '',
|
|
preferredRuntime: opts.preferredRuntime || '',
|
|
});
|
|
}
|
|
|
|
module.exports = {
|
|
resolveUpdateContext,
|
|
loadUpdateContext,
|
|
RUNTIME_DIRS,
|
|
inferPreferredRuntime,
|
|
envRuntimeDirs,
|
|
};
|