Files
msd-core/tests/analyze-dependencies.test.cjs
Tom Boucher b8c33647d8 refactor(tests): retire output-grep & source-grep via typed surfaces (finish #2974) (#462)
* refactor(#455): implement typed surfaces to retire grep tests

Production surfaces added:
- hooks/managed-hooks-registry.cjs: new CJS module exporting MANAGED_HOOKS
  as a typed array; gsd-check-update-worker.js now requires it instead of
  declaring an inline array
- bin/install.js: elevate inline gsdHooks to module-level GSD_UNINSTALL_HOOKS,
  export it alongside runtimeMap/allRuntimes (already exported)
- scripts/build-hooks.js: export HOOKS_TO_COPY; guard build() behind
  require.main===module so tests can require the file without triggering a build
- get-shit-done/bin/lib/init.cjs: add --json mode to agent-skills command,
  emitting typed IR { agent_type, block, skills_count } for test assertions
- get-shit-done/bin/gsd-tools.cjs: wire --json flag for agent-skills dispatch

Category-B source-grep migrations:
- tests/managed-hooks.test.cjs: require MANAGED_HOOKS from registry, drop fs.readFileSync+regex
- tests/orphaned-hooks.test.cjs: require MANAGED_HOOKS+HOOKS_TO_COPY as typed exports
- tests/hooks-opt-in.test.cjs: replace gsdHooks regex-parse with GSD_UNINSTALL_HOOKS import
- tests/install-minimal-hooks.test.cjs: replace gsdHooks regex-parse with GSD_UNINSTALL_HOOKS
- tests/copilot-install.test.cjs: replace src.includes() checks with typed
  assertions on runtimeMap, allRuntimes, parseRuntimeInput, buildRuntimePromptText
- tests/agent-skills.test.cjs: migrate to --json typed IR assertions

pending-migration-to-typed-ir token cleared (87 of 87 files):
- 78 files already had source-text-is-the-product; removed duplicate token
- 5 files already used typed assertions; reclassified or annotated
- 4 files required individual reclassification to source-text-is-the-product
  or architectural-invariant

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(#455): update workflow-guard test to typed GSD_UNINSTALL_HOOKS import; isolate HOME in runtime-launcher (D) test

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(#455): guard install.js main() behind require.main===module so the typed export is require-safe

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* docs(#455): document --json typed surfaces for agent-skills, progress, validate context

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* docs(#455): add changeset fragment for new --json surfaces

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(#455): complete grep migration for files flagged by lint-tests

The branch commit 4e630d99 stripped `allow-test-rule: pending-migration-to-typed-ir`
from ~80 test files without replacing their assertions or adding the correct
exemption annotation. The files were NOT source-grep tests — they read .md
workflow/agent/command/reference files (source-text-is-the-product) or hook
source files for structural invariants (structural-regression-guard). No
assertion logic was changed; only the correct allow-test-rule annotation was
added to each file per CONTRIBUTING.md exception matrix.

73 files: `source-text-is-the-product` — workflow/agent/command/reference .md
7 files:  `structural-regression-guard` — hook .js / bin/install.js structural checks

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: CI Rebase Check <ci@gsd-redux>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-05-29 11:39:52 -04:00

64 lines
3.3 KiB
JavaScript

// allow-test-rule: source-text-is-the-product
// Workflow .md / agent .md / command .md / reference .md files — their text
// IS what the runtime loads. Testing text content tests the deployed contract.
// Per CONTRIBUTING.md exception matrix.
const { test, describe, beforeEach, afterEach } = require('node:test');
const assert = require('node:assert/strict');
const fs = require('fs');
const path = require('path');
// #2790: analyze-dependencies.md was deleted (dead skill). The workflow still
// exists for direct invocation and is tested below.
describe('analyze-dependencies command', () => {
test('analyze-dependencies command file was consolidated away (deleted in #2790)', () => {
// The standalone /gsd-analyze-dependencies command was removed as a dead skill in #2790.
// The underlying workflow (workflows/analyze-dependencies.md) remains functional.
const deleted = path.join(__dirname, '..', 'commands', 'gsd', 'analyze-dependencies.md');
assert.ok(!fs.existsSync(deleted), 'analyze-dependencies.md should have been deleted in #2790');
});
// Legacy placeholder: was previously a separate test; now just passes trivially.
test('workflow file is sufficient without a standalone command file', () => {
const p = path.join(__dirname, '..', 'get-shit-done', 'workflows', 'analyze-dependencies.md');
assert.ok(fs.existsSync(p), 'workflows/analyze-dependencies.md should still exist');
});
test('workflow file exists', () => {
const p = path.join(__dirname, '..', 'get-shit-done', 'workflows', 'analyze-dependencies.md');
assert.ok(fs.existsSync(p), 'workflows/analyze-dependencies.md should exist');
});
test('workflow describes dependency analysis approach', () => {
const p = path.join(__dirname, '..', 'get-shit-done', 'workflows', 'analyze-dependencies.md');
const content = fs.readFileSync(p, 'utf-8');
assert.ok(content.includes('ROADMAP') || content.includes('phase'),
'workflow should reference ROADMAP.md/phases');
assert.ok(
content.includes('depends') || content.includes('Depends') || content.includes('dependency'),
'workflow should reference dependency detection'
);
});
test('workflow mentions file overlap detection', () => {
const p = path.join(__dirname, '..', 'get-shit-done', 'workflows', 'analyze-dependencies.md');
const content = fs.readFileSync(p, 'utf-8');
assert.ok(
content.includes('file') && (content.includes('overlap') || content.includes('conflict')),
'workflow should mention file overlap/conflict detection'
);
});
test('docs/COMMANDS.md does not document the consolidated-away /gsd-analyze-dependencies entry', () => {
// #2790 deleted the standalone command file. COMMANDS.md must no longer advertise it.
// The underlying capability lives in workflows/analyze-dependencies.md and is invoked
// from consolidated entry points (see gsd-phase / gsd-progress workflow chains).
const p = path.join(__dirname, '..', 'docs', 'COMMANDS.md');
if (!fs.existsSync(p)) return;
const content = fs.readFileSync(p, 'utf-8');
// Look only for the section header form so we tolerate workflow-internal references.
assert.ok(!/^### `\/gsd-analyze-dependencies`/m.test(content),
'COMMANDS.md should not document the removed /gsd-analyze-dependencies command');
});
});