* chore(#191): migrate gsd-sdk query call sites to gsd-tools query Retiring the gsd-sdk shim. gsd-tools.cjs already accepts `query` as a meta-prefix (gsd-tools query <command>), so this is a behavior-preserving 1:1 swap across the runtime reference prompts, the graphify hook's commit-detection gate, and two bin/lib comment/message references. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * chore(#191): remove vestigial gsd-sdk shim code from installer + projection The gsd-sdk shim was already not wired up (no gsd-sdk bin in package.json; buildWindowsShimTriple had zero call sites). Remove the dead code: - shell-command-projection.cjs: buildWindowsShimTriple + formatSdkPathDiagnostic (+ their now-unused PACKAGE_NAME import) and exports - install.js: the re-export wrappers + imports, the #3406 stale-standalone-sdk detection (detectStaleStandaloneSdk/formatStaleStandaloneSdkWarning + its global-install call site), and the exports Preserved (retained, not gsd-sdk): buildCodexHookWindowsShimIR (#3426) — only its comments referenced the gsd-sdk pattern; reworded. Also kept the homePathCoveredByRc 'reopen your shell' branch in maybeSuggestPathExport — its logic is bin-dir-agnostic, only the message mentioned gsd-sdk; reworded to use the actual bin dir. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * test(#191): update tests for retired gsd-sdk shim - bug-3441/bug-3442: drop the formatSdkPathDiagnostic / buildWindowsShimTriple assertions (functions removed); retained PATH-action + drift-guard tests stay - bug-505: remove the 'still exported' assertions for detectStaleStandaloneSdk / formatStaleStandaloneSdkWarning / the shim contract surface (#505 kept them; #191 removes them) - graphify-auto-update: migrate the hook-dispatch inputs gsd-sdk query commit -> gsd-tools query commit to match the migrated commit hook Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * docs(#191): point active docs at gsd-tools query (gsd-sdk shim retired) Update the user/agent-facing docs (AGENTS, COMMANDS, CONFIGURATION, USER-GUIDE, ship-pr-body-sections) that presented gsd-sdk query as a current command to gsd-tools query. Historical docs (ADRs, PRDs, release notes) left untouched. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * docs(#191): correct state.load vs state.json description for gsd-tools query Adversarial-review (codex) finding: the migrated USER-GUIDE line claimed both 'gsd-tools query state.json' and 'state.load' resolve to the frontmatter-rebuild handler. Verified they don't — state.load returns the CJS load shape (config + state_raw + flags), state.json returns the frontmatter shape. Both are available via gsd-tools query; corrected the text to say so. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * chore(#191): add changeset for gsd-sdk shim retirement Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
112 lines
3.6 KiB
JavaScript
112 lines
3.6 KiB
JavaScript
'use strict';
|
|
|
|
process.env.GSD_TEST_MODE = '1';
|
|
|
|
const { describe, test } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const path = require('node:path');
|
|
const fs = require('node:fs');
|
|
const os = require('node:os');
|
|
|
|
const projection = require(path.join(
|
|
__dirname,
|
|
'..',
|
|
'get-shit-done',
|
|
'bin',
|
|
'lib',
|
|
'shell-command-projection.cjs',
|
|
));
|
|
const install = require(path.join(__dirname, '..', 'bin', 'install.js'));
|
|
const { withIsolatedProcessState } = require('./helpers.cjs');
|
|
|
|
function createTempHome() {
|
|
return fs.mkdtempSync(path.join(os.tmpdir(), 'gsd-home-3441-'));
|
|
}
|
|
|
|
function cleanup(dir) {
|
|
fs.rmSync(dir, { recursive: true, force: true });
|
|
}
|
|
|
|
describe('bug #3441: PATH guidance is projected from typed shell action IR', () => {
|
|
test('projection module exports PATH action projection helper', () => {
|
|
assert.equal(typeof projection.projectPathActionProjection, 'function');
|
|
});
|
|
|
|
// (formatSdkPathDiagnostic removed with the gsd-sdk shim, #191 — the PATH
|
|
// action projection it wrapped is still covered by the tests below.)
|
|
|
|
test('persistent PATH export guidance is projected via the same seam', () => {
|
|
const posix = projection.projectPathActionProjection({
|
|
mode: 'persist',
|
|
targetDir: '/tmp/with quote',
|
|
platform: 'linux',
|
|
});
|
|
assert.ok(Array.isArray(posix.shellActions));
|
|
assert.equal(posix.shellActions.length, 2);
|
|
assert.equal(posix.shellActions[0].label, 'zsh');
|
|
assert.equal(posix.shellActions[1].label, 'bash');
|
|
assert.ok(posix.shellActions[0].command.includes('~/.zshrc'));
|
|
assert.ok(posix.shellActions[1].command.includes('~/.bashrc'));
|
|
});
|
|
|
|
test('POSIX repair mode escapes double-quoted shell metacharacters', () => {
|
|
const projected = projection.projectPathActionProjection({
|
|
mode: 'repair',
|
|
targetDir: '/tmp/qa\\"$HOME`tick',
|
|
platform: 'linux',
|
|
});
|
|
assert.equal(projected.shellActions.length, 1);
|
|
assert.equal(
|
|
projected.shellActions[0].command,
|
|
'export PATH="/tmp/qa\\\\\\"\\$HOME\\`tick:$PATH"',
|
|
);
|
|
});
|
|
|
|
test('POSIX persist mode escapes single quotes for rc-file echo commands', () => {
|
|
const projected = projection.projectPathActionProjection({
|
|
mode: 'persist',
|
|
targetDir: "/tmp/O'Neil/bin",
|
|
platform: 'linux',
|
|
});
|
|
assert.equal(projected.shellActions[0].command.includes("/tmp/O'\\''Neil/bin"), true);
|
|
assert.equal(projected.shellActions[1].command.includes("/tmp/O'\\''Neil/bin"), true);
|
|
});
|
|
|
|
test('maybeSuggestPathExport renders commands projected by path-action seam', () => {
|
|
const home = createTempHome();
|
|
try {
|
|
withIsolatedProcessState(() => {
|
|
const globalBin = path.join(home, '.npm-global', 'bin');
|
|
fs.mkdirSync(globalBin, { recursive: true });
|
|
fs.writeFileSync(path.join(home, '.zshrc'), 'export PATH="$HOME/.cargo/bin:$PATH"\n');
|
|
process.env.PATH = '';
|
|
|
|
const expected = projection.projectPathActionProjection({
|
|
mode: 'persist',
|
|
targetDir: globalBin,
|
|
platform: process.platform,
|
|
});
|
|
|
|
const logs = [];
|
|
const originalLog = console.log;
|
|
console.log = (...args) => logs.push(args.join(' '));
|
|
try {
|
|
install.maybeSuggestPathExport(globalBin, home);
|
|
} finally {
|
|
console.log = originalLog;
|
|
}
|
|
|
|
const joined = logs.join('\n');
|
|
for (const action of expected.shellActions) {
|
|
assert.ok(
|
|
joined.includes(action.command),
|
|
`expected installer output to include projected command: ${action.command}\nOutput:\n${joined}`,
|
|
);
|
|
}
|
|
});
|
|
} finally {
|
|
cleanup(home);
|
|
}
|
|
});
|
|
});
|