Files
msd-core/tests/chain-flag-plan-phase.test.cjs
Tom Boucher b8c33647d8 refactor(tests): retire output-grep & source-grep via typed surfaces (finish #2974) (#462)
* refactor(#455): implement typed surfaces to retire grep tests

Production surfaces added:
- hooks/managed-hooks-registry.cjs: new CJS module exporting MANAGED_HOOKS
  as a typed array; gsd-check-update-worker.js now requires it instead of
  declaring an inline array
- bin/install.js: elevate inline gsdHooks to module-level GSD_UNINSTALL_HOOKS,
  export it alongside runtimeMap/allRuntimes (already exported)
- scripts/build-hooks.js: export HOOKS_TO_COPY; guard build() behind
  require.main===module so tests can require the file without triggering a build
- get-shit-done/bin/lib/init.cjs: add --json mode to agent-skills command,
  emitting typed IR { agent_type, block, skills_count } for test assertions
- get-shit-done/bin/gsd-tools.cjs: wire --json flag for agent-skills dispatch

Category-B source-grep migrations:
- tests/managed-hooks.test.cjs: require MANAGED_HOOKS from registry, drop fs.readFileSync+regex
- tests/orphaned-hooks.test.cjs: require MANAGED_HOOKS+HOOKS_TO_COPY as typed exports
- tests/hooks-opt-in.test.cjs: replace gsdHooks regex-parse with GSD_UNINSTALL_HOOKS import
- tests/install-minimal-hooks.test.cjs: replace gsdHooks regex-parse with GSD_UNINSTALL_HOOKS
- tests/copilot-install.test.cjs: replace src.includes() checks with typed
  assertions on runtimeMap, allRuntimes, parseRuntimeInput, buildRuntimePromptText
- tests/agent-skills.test.cjs: migrate to --json typed IR assertions

pending-migration-to-typed-ir token cleared (87 of 87 files):
- 78 files already had source-text-is-the-product; removed duplicate token
- 5 files already used typed assertions; reclassified or annotated
- 4 files required individual reclassification to source-text-is-the-product
  or architectural-invariant

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(#455): update workflow-guard test to typed GSD_UNINSTALL_HOOKS import; isolate HOME in runtime-launcher (D) test

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(#455): guard install.js main() behind require.main===module so the typed export is require-safe

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* docs(#455): document --json typed surfaces for agent-skills, progress, validate context

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* docs(#455): add changeset fragment for new --json surfaces

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(#455): complete grep migration for files flagged by lint-tests

The branch commit 4e630d99 stripped `allow-test-rule: pending-migration-to-typed-ir`
from ~80 test files without replacing their assertions or adding the correct
exemption annotation. The files were NOT source-grep tests — they read .md
workflow/agent/command/reference files (source-text-is-the-product) or hook
source files for structural invariants (structural-regression-guard). No
assertion logic was changed; only the correct allow-test-rule annotation was
added to each file per CONTRIBUTING.md exception matrix.

73 files: `source-text-is-the-product` — workflow/agent/command/reference .md
7 files:  `structural-regression-guard` — hook .js / bin/install.js structural checks

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: CI Rebase Check <ci@gsd-redux>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-05-29 11:39:52 -04:00

85 lines
3.7 KiB
JavaScript

// allow-test-rule: source-text-is-the-product
// Workflow .md / agent .md / command .md / reference .md files — their text
// IS what the runtime loads. Testing text content tests the deployed contract.
// Per CONTRIBUTING.md exception matrix.
/**
* GSD Tools Tests - chain flag preservation in plan-phase
*
* Validates that plan-phase.md correctly handles the --chain flag
* so that discuss→plan→execute auto-advance works without manual
* intervention.
*
* Closes: #1620
*/
const { test, describe } = require('node:test');
const assert = require('node:assert/strict');
const fs = require('fs');
const path = require('path');
describe('plan-phase chain flag preservation (#1620)', () => {
const planPath = path.join(__dirname, '..', 'get-shit-done', 'workflows', 'plan-phase.md');
const discussPath = path.join(__dirname, '..', 'get-shit-done', 'workflows', 'discuss-phase.md');
// After #2551, discuss-phase chain logic moved to modes/chain.md.
const discussChainPath = path.join(__dirname, '..', 'get-shit-done', 'workflows', 'discuss-phase', 'modes', 'chain.md');
const readDiscuss = () => {
// Fail loudly if either source is missing — silent filtering would let a
// regression that deletes modes/chain.md pass this whole suite.
assert.ok(fs.existsSync(discussPath), `discuss-phase.md missing: ${discussPath}`);
assert.ok(fs.existsSync(discussChainPath), `discuss-phase/modes/chain.md missing after #2551 split: ${discussChainPath}`);
return [discussPath, discussChainPath].map(p => fs.readFileSync(p, 'utf8')).join('\n');
};
test('plan-phase sync-flag guard checks both --auto AND --chain', () => {
const content = fs.readFileSync(planPath, 'utf8');
// The guard that clears _auto_chain_active must require BOTH flags to be absent
assert.ok(
content.includes('if [[ ! "$ARGUMENTS" =~ --auto ]] && [[ ! "$ARGUMENTS" =~ --chain ]]; then'),
'plan-phase should check for both --auto and --chain before clearing chain flag'
);
});
test('plan-phase persists chain flag to config before auto-advancing', () => {
const content = fs.readFileSync(planPath, 'utf8');
// Plan-phase must persist the chain flag (config-set workflow._auto_chain_active true)
assert.ok(
content.includes('config-set workflow._auto_chain_active true'),
'plan-phase should persist chain flag via config-set workflow._auto_chain_active true'
);
});
test('plan-phase and discuss-phase use the same guard pattern for clearing _auto_chain_active', () => {
const planContent = fs.readFileSync(planPath, 'utf8');
const discussContent = readDiscuss();
const guardPattern = 'if [[ ! "$ARGUMENTS" =~ --auto ]] && [[ ! "$ARGUMENTS" =~ --chain ]]; then';
assert.ok(
planContent.includes(guardPattern),
'plan-phase should use the dual-flag guard pattern'
);
assert.ok(
discussContent.includes(guardPattern),
'discuss-phase (or discuss-phase/modes/chain.md after #2551 split) should use the dual-flag guard pattern'
);
});
test('plan-phase auto-advance trigger includes --chain flag', () => {
const content = fs.readFileSync(planPath, 'utf8');
// The trigger condition should mention --chain alongside --auto
assert.ok(
content.includes('`--auto` or `--chain` flag present OR `AUTO_CHAIN` is true OR `AUTO_CFG` is true'),
'plan-phase auto-advance trigger should check for --chain flag'
);
});
test('plan-phase parses both --auto and --chain flags', () => {
const content = fs.readFileSync(planPath, 'utf8');
assert.ok(
content.includes('Parse `--auto` and `--chain` flags from $ARGUMENTS'),
'plan-phase step 15 should parse both --auto and --chain flags'
);
});
});