* refactor(#455): implement typed surfaces to retire grep tests Production surfaces added: - hooks/managed-hooks-registry.cjs: new CJS module exporting MANAGED_HOOKS as a typed array; gsd-check-update-worker.js now requires it instead of declaring an inline array - bin/install.js: elevate inline gsdHooks to module-level GSD_UNINSTALL_HOOKS, export it alongside runtimeMap/allRuntimes (already exported) - scripts/build-hooks.js: export HOOKS_TO_COPY; guard build() behind require.main===module so tests can require the file without triggering a build - get-shit-done/bin/lib/init.cjs: add --json mode to agent-skills command, emitting typed IR { agent_type, block, skills_count } for test assertions - get-shit-done/bin/gsd-tools.cjs: wire --json flag for agent-skills dispatch Category-B source-grep migrations: - tests/managed-hooks.test.cjs: require MANAGED_HOOKS from registry, drop fs.readFileSync+regex - tests/orphaned-hooks.test.cjs: require MANAGED_HOOKS+HOOKS_TO_COPY as typed exports - tests/hooks-opt-in.test.cjs: replace gsdHooks regex-parse with GSD_UNINSTALL_HOOKS import - tests/install-minimal-hooks.test.cjs: replace gsdHooks regex-parse with GSD_UNINSTALL_HOOKS - tests/copilot-install.test.cjs: replace src.includes() checks with typed assertions on runtimeMap, allRuntimes, parseRuntimeInput, buildRuntimePromptText - tests/agent-skills.test.cjs: migrate to --json typed IR assertions pending-migration-to-typed-ir token cleared (87 of 87 files): - 78 files already had source-text-is-the-product; removed duplicate token - 5 files already used typed assertions; reclassified or annotated - 4 files required individual reclassification to source-text-is-the-product or architectural-invariant Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(#455): update workflow-guard test to typed GSD_UNINSTALL_HOOKS import; isolate HOME in runtime-launcher (D) test Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(#455): guard install.js main() behind require.main===module so the typed export is require-safe Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * docs(#455): document --json typed surfaces for agent-skills, progress, validate context Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * docs(#455): add changeset fragment for new --json surfaces Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(#455): complete grep migration for files flagged by lint-tests The branch commit 4e630d99 stripped `allow-test-rule: pending-migration-to-typed-ir` from ~80 test files without replacing their assertions or adding the correct exemption annotation. The files were NOT source-grep tests — they read .md workflow/agent/command/reference files (source-text-is-the-product) or hook source files for structural invariants (structural-regression-guard). No assertion logic was changed; only the correct allow-test-rule annotation was added to each file per CONTRIBUTING.md exception matrix. 73 files: `source-text-is-the-product` — workflow/agent/command/reference .md 7 files: `structural-regression-guard` — hook .js / bin/install.js structural checks Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: CI Rebase Check <ci@gsd-redux> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
229 lines
7.0 KiB
JavaScript
229 lines
7.0 KiB
JavaScript
// allow-test-rule: source-text-is-the-product
|
|
// Workflow .md / agent .md / command .md / reference .md files — their text
|
|
// IS what the runtime loads. Testing text content tests the deployed contract.
|
|
// Per CONTRIBUTING.md exception matrix.
|
|
|
|
/**
|
|
* Cursor CLI Reviewer Tests (#1960)
|
|
*
|
|
* Verifies that /gsd-review includes Cursor CLI as a peer reviewer:
|
|
* - review.md workflow contains cursor detection, flag parsing, self-detection, invocation
|
|
* - commands/gsd/review.md command file mentions --cursor flag
|
|
* - help.md lists --cursor in the /gsd-review signature
|
|
* - docs/COMMANDS.md has --cursor flag row
|
|
* - docs/FEATURES.md has Cursor in the review section
|
|
* - i18n docs mirror the same content
|
|
* - REVIEWS.md template includes Cursor Review section
|
|
*/
|
|
|
|
const { test, describe } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
|
|
const ROOT = path.join(__dirname, '..');
|
|
|
|
describe('Cursor CLI reviewer in /gsd-review (#1960)', () => {
|
|
|
|
// --- review.md workflow ---
|
|
|
|
describe('review.md workflow', () => {
|
|
const reviewPath = path.join(ROOT, 'get-shit-done', 'workflows', 'review.md');
|
|
let content;
|
|
|
|
test('review.md exists', () => {
|
|
assert.ok(fs.existsSync(reviewPath), 'review.md should exist');
|
|
content = fs.readFileSync(reviewPath, 'utf-8');
|
|
});
|
|
|
|
test('contains cursor CLI detection via command -v', () => {
|
|
const c = fs.readFileSync(reviewPath, 'utf-8');
|
|
assert.ok(
|
|
c.includes('command -v cursor'),
|
|
'review.md should detect cursor CLI via "command -v cursor"'
|
|
);
|
|
});
|
|
|
|
test('contains --cursor flag parsing', () => {
|
|
const c = fs.readFileSync(reviewPath, 'utf-8');
|
|
assert.ok(
|
|
c.includes('--cursor'),
|
|
'review.md should parse --cursor flag'
|
|
);
|
|
});
|
|
|
|
test('contains CURSOR_SESSION_ID self-detection', () => {
|
|
const c = fs.readFileSync(reviewPath, 'utf-8');
|
|
assert.ok(
|
|
c.includes('CURSOR_SESSION_ID'),
|
|
'review.md should detect self-CLI via CURSOR_SESSION_ID env var'
|
|
);
|
|
});
|
|
|
|
test('contains cursor agent invocation command', () => {
|
|
const c = fs.readFileSync(reviewPath, 'utf-8');
|
|
assert.ok(
|
|
c.includes('cursor agent -p --mode ask --trust'),
|
|
'review.md should invoke cursor via "cursor agent -p --mode ask --trust"'
|
|
);
|
|
});
|
|
|
|
test('contains Cursor Review section in REVIEWS.md template', () => {
|
|
const c = fs.readFileSync(reviewPath, 'utf-8');
|
|
assert.ok(
|
|
c.includes('Cursor Review'),
|
|
'review.md should include a "Cursor Review" section in the REVIEWS.md template'
|
|
);
|
|
});
|
|
|
|
test('lists cursor in the reviewers frontmatter array', () => {
|
|
const c = fs.readFileSync(reviewPath, 'utf-8');
|
|
assert.ok(
|
|
/reviewers:.*cursor/.test(c),
|
|
'review.md should list cursor in the reviewers array'
|
|
);
|
|
});
|
|
});
|
|
|
|
// --- commands/gsd/review.md ---
|
|
|
|
describe('commands/gsd/review.md', () => {
|
|
const cmdPath = path.join(ROOT, 'commands', 'gsd', 'review.md');
|
|
|
|
test('mentions --cursor flag', () => {
|
|
const c = fs.readFileSync(cmdPath, 'utf-8');
|
|
assert.ok(
|
|
c.includes('--cursor'),
|
|
'commands/gsd/review.md should mention --cursor flag'
|
|
);
|
|
});
|
|
|
|
test('mentions Cursor in objective or context', () => {
|
|
const c = fs.readFileSync(cmdPath, 'utf-8');
|
|
assert.ok(
|
|
c.includes('Cursor'),
|
|
'commands/gsd/review.md should mention Cursor'
|
|
);
|
|
});
|
|
});
|
|
|
|
// --- help.md ---
|
|
|
|
describe('help.md', () => {
|
|
// After #3039, help content moved into help/modes/full.md.
|
|
const helpPath = path.join(ROOT, 'get-shit-done', 'workflows', 'help', 'modes', 'full.md');
|
|
|
|
test('lists --cursor in /gsd-review signature', () => {
|
|
const c = fs.readFileSync(helpPath, 'utf-8');
|
|
assert.ok(
|
|
c.includes('--cursor'),
|
|
'help.md should list --cursor in the /gsd-review command signature'
|
|
);
|
|
});
|
|
});
|
|
|
|
// --- docs/COMMANDS.md ---
|
|
|
|
describe('docs/COMMANDS.md', () => {
|
|
const docsPath = path.join(ROOT, 'docs', 'COMMANDS.md');
|
|
|
|
test('has --cursor flag row', () => {
|
|
const c = fs.readFileSync(docsPath, 'utf-8');
|
|
assert.ok(
|
|
c.includes('--cursor'),
|
|
'docs/COMMANDS.md should have a --cursor flag row'
|
|
);
|
|
});
|
|
});
|
|
|
|
// --- docs/FEATURES.md ---
|
|
|
|
describe('docs/FEATURES.md', () => {
|
|
const featPath = path.join(ROOT, 'docs', 'FEATURES.md');
|
|
|
|
test('has --cursor in review command signature', () => {
|
|
const c = fs.readFileSync(featPath, 'utf-8');
|
|
assert.ok(
|
|
c.includes('--cursor'),
|
|
'docs/FEATURES.md should include --cursor in the review command signature'
|
|
);
|
|
});
|
|
|
|
test('mentions Cursor in the review purpose', () => {
|
|
const c = fs.readFileSync(featPath, 'utf-8');
|
|
assert.ok(
|
|
c.includes('Cursor'),
|
|
'docs/FEATURES.md should mention Cursor in the review section'
|
|
);
|
|
});
|
|
});
|
|
|
|
// --- i18n: ja-JP ---
|
|
|
|
describe('docs/ja-JP/COMMANDS.md', () => {
|
|
const jaPath = path.join(ROOT, 'docs', 'ja-JP', 'COMMANDS.md');
|
|
|
|
test('has --cursor flag row', () => {
|
|
const c = fs.readFileSync(jaPath, 'utf-8');
|
|
assert.ok(
|
|
c.includes('--cursor'),
|
|
'docs/ja-JP/COMMANDS.md should have a --cursor flag row'
|
|
);
|
|
});
|
|
});
|
|
|
|
describe('docs/ja-JP/FEATURES.md', () => {
|
|
const jaPath = path.join(ROOT, 'docs', 'ja-JP', 'FEATURES.md');
|
|
|
|
test('has --cursor in review command signature', () => {
|
|
const c = fs.readFileSync(jaPath, 'utf-8');
|
|
assert.ok(
|
|
c.includes('--cursor'),
|
|
'docs/ja-JP/FEATURES.md should include --cursor in the review command signature'
|
|
);
|
|
});
|
|
|
|
test('mentions Cursor in the review section', () => {
|
|
const c = fs.readFileSync(jaPath, 'utf-8');
|
|
assert.ok(
|
|
/Cursor/i.test(fs.readFileSync(jaPath, 'utf-8')),
|
|
'docs/ja-JP/FEATURES.md should mention Cursor in the review section'
|
|
);
|
|
});
|
|
});
|
|
|
|
// --- i18n: ko-KR ---
|
|
|
|
describe('docs/ko-KR/COMMANDS.md', () => {
|
|
const koPath = path.join(ROOT, 'docs', 'ko-KR', 'COMMANDS.md');
|
|
|
|
test('has --cursor flag row', () => {
|
|
const c = fs.readFileSync(koPath, 'utf-8');
|
|
assert.ok(
|
|
c.includes('--cursor'),
|
|
'docs/ko-KR/COMMANDS.md should have a --cursor flag row'
|
|
);
|
|
});
|
|
});
|
|
|
|
describe('docs/ko-KR/FEATURES.md', () => {
|
|
const koPath = path.join(ROOT, 'docs', 'ko-KR', 'FEATURES.md');
|
|
|
|
test('has --cursor in review command signature', () => {
|
|
const c = fs.readFileSync(koPath, 'utf-8');
|
|
assert.ok(
|
|
c.includes('--cursor'),
|
|
'docs/ko-KR/FEATURES.md should include --cursor in the review command signature'
|
|
);
|
|
});
|
|
|
|
test('mentions Cursor in the review section', () => {
|
|
const c = fs.readFileSync(koPath, 'utf-8');
|
|
assert.ok(
|
|
/Cursor/i.test(fs.readFileSync(koPath, 'utf-8')),
|
|
'docs/ko-KR/FEATURES.md should mention Cursor in the review section'
|
|
);
|
|
});
|
|
});
|
|
});
|