* refactor(#455): implement typed surfaces to retire grep tests Production surfaces added: - hooks/managed-hooks-registry.cjs: new CJS module exporting MANAGED_HOOKS as a typed array; gsd-check-update-worker.js now requires it instead of declaring an inline array - bin/install.js: elevate inline gsdHooks to module-level GSD_UNINSTALL_HOOKS, export it alongside runtimeMap/allRuntimes (already exported) - scripts/build-hooks.js: export HOOKS_TO_COPY; guard build() behind require.main===module so tests can require the file without triggering a build - get-shit-done/bin/lib/init.cjs: add --json mode to agent-skills command, emitting typed IR { agent_type, block, skills_count } for test assertions - get-shit-done/bin/gsd-tools.cjs: wire --json flag for agent-skills dispatch Category-B source-grep migrations: - tests/managed-hooks.test.cjs: require MANAGED_HOOKS from registry, drop fs.readFileSync+regex - tests/orphaned-hooks.test.cjs: require MANAGED_HOOKS+HOOKS_TO_COPY as typed exports - tests/hooks-opt-in.test.cjs: replace gsdHooks regex-parse with GSD_UNINSTALL_HOOKS import - tests/install-minimal-hooks.test.cjs: replace gsdHooks regex-parse with GSD_UNINSTALL_HOOKS - tests/copilot-install.test.cjs: replace src.includes() checks with typed assertions on runtimeMap, allRuntimes, parseRuntimeInput, buildRuntimePromptText - tests/agent-skills.test.cjs: migrate to --json typed IR assertions pending-migration-to-typed-ir token cleared (87 of 87 files): - 78 files already had source-text-is-the-product; removed duplicate token - 5 files already used typed assertions; reclassified or annotated - 4 files required individual reclassification to source-text-is-the-product or architectural-invariant Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(#455): update workflow-guard test to typed GSD_UNINSTALL_HOOKS import; isolate HOME in runtime-launcher (D) test Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(#455): guard install.js main() behind require.main===module so the typed export is require-safe Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * docs(#455): document --json typed surfaces for agent-skills, progress, validate context Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * docs(#455): add changeset fragment for new --json surfaces Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(#455): complete grep migration for files flagged by lint-tests The branch commit 4e630d99 stripped `allow-test-rule: pending-migration-to-typed-ir` from ~80 test files without replacing their assertions or adding the correct exemption annotation. The files were NOT source-grep tests — they read .md workflow/agent/command/reference files (source-text-is-the-product) or hook source files for structural invariants (structural-regression-guard). No assertion logic was changed; only the correct allow-test-rule annotation was added to each file per CONTRIBUTING.md exception matrix. 73 files: `source-text-is-the-product` — workflow/agent/command/reference .md 7 files: `structural-regression-guard` — hook .js / bin/install.js structural checks Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: CI Rebase Check <ci@gsd-redux> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
195 lines
8.0 KiB
JavaScript
195 lines
8.0 KiB
JavaScript
// allow-test-rule: source-text-is-the-product
|
|
// Workflow .md / agent .md / command .md / reference .md files — their text
|
|
// IS what the runtime loads. Testing text content tests the deployed contract.
|
|
// Per CONTRIBUTING.md exception matrix.
|
|
'use strict';
|
|
|
|
|
|
const { describe, test } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('node:fs');
|
|
const path = require('node:path');
|
|
|
|
describe('debug session management implementation', () => {
|
|
test('DEBUG.md template contains reasoning_checkpoint field', () => {
|
|
const content = fs.readFileSync(
|
|
path.join(process.cwd(), 'get-shit-done/templates/DEBUG.md'),
|
|
'utf8'
|
|
);
|
|
assert.ok(content.includes('reasoning_checkpoint'), 'DEBUG.md must contain reasoning_checkpoint field');
|
|
});
|
|
|
|
test('DEBUG.md template contains tdd_checkpoint field', () => {
|
|
const content = fs.readFileSync(
|
|
path.join(process.cwd(), 'get-shit-done/templates/DEBUG.md'),
|
|
'utf8'
|
|
);
|
|
assert.ok(content.includes('tdd_checkpoint'), 'DEBUG.md must contain tdd_checkpoint field');
|
|
});
|
|
|
|
test('debug command contains list subcommand logic', () => {
|
|
const content = fs.readFileSync(
|
|
path.join(process.cwd(), 'get-shit-done/workflows/debug.md'),
|
|
'utf8'
|
|
);
|
|
assert.ok(
|
|
content.includes('SUBCMD=list') || content.includes('"list"'),
|
|
'debug.md must contain list subcommand logic'
|
|
);
|
|
});
|
|
|
|
test('debug command contains continue subcommand logic', () => {
|
|
const content = fs.readFileSync(
|
|
path.join(process.cwd(), 'get-shit-done/workflows/debug.md'),
|
|
'utf8'
|
|
);
|
|
assert.ok(
|
|
content.includes('SUBCMD=continue') || content.includes('"continue"'),
|
|
'debug.md must contain continue subcommand logic'
|
|
);
|
|
});
|
|
|
|
test('debug command contains status subcommand logic', () => {
|
|
const content = fs.readFileSync(
|
|
path.join(process.cwd(), 'get-shit-done/workflows/debug.md'),
|
|
'utf8'
|
|
);
|
|
assert.ok(
|
|
content.includes('SUBCMD=status') || content.includes('"status"'),
|
|
'debug.md must contain status subcommand logic'
|
|
);
|
|
});
|
|
|
|
test('debug command contains TDD gate logic', () => {
|
|
const content = fs.readFileSync(
|
|
path.join(process.cwd(), 'get-shit-done/workflows/debug.md'),
|
|
'utf8'
|
|
);
|
|
assert.ok(
|
|
content.includes('TDD_MODE') || content.includes('tdd_mode'),
|
|
'debug.md must contain TDD gate logic'
|
|
);
|
|
});
|
|
|
|
test('debug.md reads tdd_mode via workflow.tdd_mode key (not bare tdd_mode)', () => {
|
|
const content = fs.readFileSync(
|
|
path.join(process.cwd(), 'get-shit-done/workflows/debug.md'),
|
|
'utf8'
|
|
);
|
|
assert.ok(
|
|
!content.includes('config-get tdd_mode'),
|
|
'debug.md must not use bare "tdd_mode" key — use "workflow.tdd_mode" to match every other consumer'
|
|
);
|
|
assert.ok(
|
|
content.includes('config-get workflow.tdd_mode'),
|
|
'debug.md must read tdd_mode via the "workflow.tdd_mode" key'
|
|
);
|
|
});
|
|
|
|
test('debug command contains security hardening', () => {
|
|
const content = fs.readFileSync(
|
|
path.join(process.cwd(), 'get-shit-done/workflows/debug.md'),
|
|
'utf8'
|
|
);
|
|
assert.ok(content.includes('DATA_START'), 'debug.md must contain DATA_START injection boundary marker');
|
|
});
|
|
|
|
test('debug command surfaces next_action before spawn', () => {
|
|
const content = fs.readFileSync(
|
|
path.join(process.cwd(), 'get-shit-done/workflows/debug.md'),
|
|
'utf8'
|
|
);
|
|
assert.ok(
|
|
content.includes('[debug] Next:') || content.includes('next_action'),
|
|
'debug.md must surface next_action before agent spawn'
|
|
);
|
|
});
|
|
|
|
test('gsd-debugger contains structured reasoning checkpoint', () => {
|
|
const content = fs.readFileSync(
|
|
path.join(process.cwd(), 'agents/gsd-debugger.md'),
|
|
'utf8'
|
|
);
|
|
assert.ok(content.includes('reasoning_checkpoint'), 'gsd-debugger.md must contain reasoning_checkpoint');
|
|
});
|
|
|
|
test('gsd-debugger contains TDD checkpoint mode', () => {
|
|
const content = fs.readFileSync(
|
|
path.join(process.cwd(), 'agents/gsd-debugger.md'),
|
|
'utf8'
|
|
);
|
|
assert.ok(content.includes('tdd_mode'), 'gsd-debugger.md must contain tdd_mode');
|
|
assert.ok(content.includes('TDD CHECKPOINT'), 'gsd-debugger.md must contain TDD CHECKPOINT return format');
|
|
});
|
|
|
|
test('gsd-debugger contains delta debugging technique', () => {
|
|
const content = fs.readFileSync(
|
|
path.join(process.cwd(), 'agents/gsd-debugger.md'),
|
|
'utf8'
|
|
);
|
|
assert.ok(content.includes('Delta Debugging'), 'gsd-debugger.md must contain Delta Debugging technique');
|
|
});
|
|
|
|
test('gsd-debugger contains security note about DATA_START', () => {
|
|
const content = fs.readFileSync(
|
|
path.join(process.cwd(), 'agents/gsd-debugger.md'),
|
|
'utf8'
|
|
);
|
|
assert.ok(content.includes('DATA_START'), 'gsd-debugger.md must contain DATA_START security reference');
|
|
});
|
|
});
|
|
|
|
// Tests for #2148 and #2151
|
|
describe('debug skill dispatch and sub-orchestrator (#2148, #2151)', () => {
|
|
test('gsd-debugger ROOT CAUSE FOUND format includes specialist_hint field', () => {
|
|
const content = fs.readFileSync(path.join(process.cwd(), 'agents', 'gsd-debugger.md'), 'utf8');
|
|
assert.ok(content.includes('specialist_hint'), 'gsd-debugger missing specialist_hint in ROOT CAUSE FOUND');
|
|
assert.ok(content.includes('swift_concurrency'), 'gsd-debugger missing specialist_hint derivation guidance');
|
|
});
|
|
|
|
test('debug.md orchestrator has specialist skill dispatch step', () => {
|
|
const content = fs.readFileSync(path.join(process.cwd(), 'get-shit-done/workflows/debug.md'), 'utf8');
|
|
assert.ok(content.includes('specialist_hint'), 'debug.md missing specialist dispatch logic');
|
|
assert.ok(content.includes('typescript-expert'), 'debug.md missing skill dispatch mapping');
|
|
});
|
|
|
|
test('debug.md specialist dispatch prompt uses DATA_START/DATA_END boundaries', () => {
|
|
const content = fs.readFileSync(path.join(process.cwd(), 'get-shit-done/workflows/debug.md'), 'utf8');
|
|
assert.ok(content.includes('DATA_START') && content.includes('DATA_END'),
|
|
'debug.md specialist dispatch prompt missing security boundaries');
|
|
});
|
|
|
|
test('gsd-debug-session-manager agent exists with correct tools', () => {
|
|
const content = fs.readFileSync(path.join(process.cwd(), 'agents', 'gsd-debug-session-manager.md'), 'utf8');
|
|
assert.ok(content.includes('Agent'), 'gsd-debug-session-manager missing Agent tool');
|
|
assert.ok(content.includes('AskUserQuestion'), 'gsd-debug-session-manager missing AskUserQuestion tool');
|
|
});
|
|
|
|
test('gsd-debug-session-manager spawns debugger with Agent() dispatcher', () => {
|
|
const content = fs.readFileSync(path.join(process.cwd(), 'agents', 'gsd-debug-session-manager.md'), 'utf8');
|
|
assert.ok(content.includes('\nAgent('), 'session manager must dispatch debugger with Agent(');
|
|
});
|
|
|
|
test('gsd-debug-session-manager uses DATA_START/DATA_END for checkpoint responses', () => {
|
|
const content = fs.readFileSync(path.join(process.cwd(), 'agents', 'gsd-debug-session-manager.md'), 'utf8');
|
|
assert.ok(content.includes('DATA_START') && content.includes('DATA_END'),
|
|
'gsd-debug-session-manager missing security boundaries on checkpoint responses');
|
|
});
|
|
|
|
test('gsd-debug-session-manager has compact summary output format', () => {
|
|
const content = fs.readFileSync(path.join(process.cwd(), 'agents', 'gsd-debug-session-manager.md'), 'utf8');
|
|
assert.ok(content.includes('DEBUG SESSION COMPLETE'), 'session manager missing compact summary format');
|
|
});
|
|
|
|
test('gsd-debug-session-manager includes anti-heredoc rule', () => {
|
|
const content = fs.readFileSync(path.join(process.cwd(), 'agents', 'gsd-debug-session-manager.md'), 'utf8');
|
|
assert.ok(content.includes('heredoc'), 'session manager missing anti-heredoc rule');
|
|
});
|
|
|
|
test('debug.md delegates to gsd-debug-session-manager', () => {
|
|
const content = fs.readFileSync(path.join(process.cwd(), 'get-shit-done/workflows/debug.md'), 'utf8');
|
|
assert.ok(content.includes('gsd-debug-session-manager'),
|
|
'debug.md does not delegate to session manager');
|
|
});
|
|
});
|