4483300253
model_overrides / models.<phaseType> were silently inert for gsd-assumptions-analyzer,
gsd-code-reviewer, and gsd-code-fixer on Claude Code: resolveModelInternal honors them,
but the workflows spawned these agents with no model= param, so the resolved value
never reached the Agent tool and the agents inherited the session model — no warning.
Fix — thread each agent's resolved model at every spawn site (the established
plan-phase pattern; the architecture-consistent Claude mechanism, since 13 other
agents already thread their model):
- discuss-phase-assumptions.md: `resolve-model gsd-assumptions-analyzer --raw`
→ ANALYZER_MODEL, threaded.
- code-review.md + code-review-fix.md (re-review): `resolve-model gsd-code-reviewer --raw`
→ REVIEWER_MODEL, threaded.
- code-review-fix.md (both fixer spawns): `resolve-model gsd-code-fixer --raw`
→ FIXER_MODEL, threaded (same silently-inert bug, same file — folded in per review).
- quick.md review step: was reusing `{executor_model}` for gsd-code-reviewer (so the
reviewer's own override was ignored); init.quick now resolves `reviewer_model`
(gsd-code-reviewer) and the spawn threads it.
resolve-model --raw returns the bare model string (resolve-execution --raw would
return effort — wrong). The resolver maps these agents to phaseType discuss /
verification / execution, so models.<phaseType> apply too.
Scope: the three agents reachable from the two issue-named workflows + quick.md. The
wider systemic class (other agents in UNTOUCHED workflows with the same pattern) stays
documented on the issue for a maintainer-scoped structural decision (thread-at-source
vs embed-at-install like #2256), not widened here.
Docs: the stale "discuss — reserved, no subagent today" model-profile tables now list
gsd-assumptions-analyzer and the verification row includes gsd-code-reviewer, across
the English docs, the shipped gsd-core/references/model-profiles.md reference, and the
ja-JP / zh-CN / ko-KR / pt-BR locale mirrors.
Tests:
- tests/model-resolver.test.cjs: #2072 acceptance — model_overrides and
models.discuss/verification/execution resolve for all three agents.
- tests/model-routing-spawn-threading.test.cjs: every spawn of the three agents threads
a resolved model (fails pre-fix); a header-precise parity guard fails the suite if a
new un-threaded spawn of any of them regresses.
All 16 golden-install-parity fixtures + the workflow size baseline regenerated for the
changed shipped files (4 workflows + the reference doc); bin/lib is excluded from parity.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
94 lines
2.4 KiB
JSON
94 lines
2.4 KiB
JSON
{
|
|
"add-backlog.md": 7176,
|
|
"add-phase.md": 7247,
|
|
"add-tests.md": 16945,
|
|
"add-todo.md": 8996,
|
|
"ai-integration-phase.md": 14805,
|
|
"analyze-dependencies.md": 3887,
|
|
"audit-fix.md": 11717,
|
|
"audit-milestone.md": 17681,
|
|
"audit-uat.md": 7469,
|
|
"autonomous.md": 42474,
|
|
"check-todos.md": 9475,
|
|
"cleanup.md": 9941,
|
|
"code-review-fix.md": 24320,
|
|
"code-review.md": 31916,
|
|
"complete-milestone.md": 31071,
|
|
"debug.md": 13549,
|
|
"diagnose-issues.md": 12864,
|
|
"discovery-phase.md": 8651,
|
|
"discuss-phase-assumptions.md": 27302,
|
|
"discuss-phase-power.md": 11273,
|
|
"discuss-phase.md": 31986,
|
|
"do.md": 10353,
|
|
"docs-update.md": 55706,
|
|
"edit-phase.md": 12927,
|
|
"eval-review.md": 9967,
|
|
"execute-phase.md": 93132,
|
|
"execute-plan.md": 32655,
|
|
"explore.md": 10541,
|
|
"extract-learnings.md": 12893,
|
|
"fast.md": 4149,
|
|
"forensics.md": 12531,
|
|
"graduation.md": 11622,
|
|
"health.md": 11868,
|
|
"help.md": 1722,
|
|
"import.md": 14648,
|
|
"inbox.md": 14407,
|
|
"ingest-docs.md": 18380,
|
|
"insert-phase.md": 8987,
|
|
"list-phase-assumptions.md": 4305,
|
|
"list-seeds.md": 6987,
|
|
"list-workspaces.md": 5699,
|
|
"manager.md": 27302,
|
|
"map-codebase.md": 20833,
|
|
"milestone-summary.md": 11842,
|
|
"mvp-phase.md": 13626,
|
|
"new-milestone.md": 32888,
|
|
"new-project.md": 66182,
|
|
"new-workspace.md": 11298,
|
|
"next.md": 20138,
|
|
"node-repair.md": 4173,
|
|
"note.md": 6563,
|
|
"onboard.md": 8590,
|
|
"pause-work.md": 14441,
|
|
"plan-milestone-gaps.md": 11809,
|
|
"plan-phase.md": 92251,
|
|
"plan-review-convergence.md": 23512,
|
|
"plant-seed.md": 11785,
|
|
"pr-branch.md": 15963,
|
|
"profile-user.md": 21246,
|
|
"progress.md": 30599,
|
|
"quick.md": 50470,
|
|
"reapply-patches.md": 20312,
|
|
"remove-phase.md": 8513,
|
|
"remove-workspace.md": 7551,
|
|
"resume-project.md": 17270,
|
|
"review.md": 43356,
|
|
"scan.md": 7732,
|
|
"secure-phase.md": 13520,
|
|
"session-report.md": 4044,
|
|
"settings-advanced.md": 39718,
|
|
"settings-integrations.md": 15892,
|
|
"settings.md": 33457,
|
|
"ship.md": 24691,
|
|
"sketch-wrap-up.md": 14267,
|
|
"sketch.md": 20004,
|
|
"smart-entry.md": 11124,
|
|
"spec-phase.md": 31945,
|
|
"spike-wrap-up.md": 15136,
|
|
"spike.md": 24561,
|
|
"stats.md": 6762,
|
|
"sync-skills.md": 6125,
|
|
"thread.md": 12508,
|
|
"transition.md": 22060,
|
|
"ui-phase.md": 15521,
|
|
"ui-review.md": 11216,
|
|
"ultraplan-phase.md": 10512,
|
|
"undo.md": 10431,
|
|
"update.md": 20914,
|
|
"validate-phase.md": 10789,
|
|
"verify-phase.md": 40923,
|
|
"verify-work.md": 38267
|
|
}
|