* chore(#604): rename get-shit-done/ runtime directory to gsd-core/ Renames the installed runtime directory `get-shit-done/` to `gsd-core/` so the on-disk name matches the package (`@opengsd/gsd-core`), repo, and binary (`gsd-tools`). The npm package name and binary are unchanged; npx/npm consumers are unaffected. Mechanical (bulk, ~90% of the diff): - `git mv get-shit-done gsd-core` - Swept path/identifier references across the repo via `perl -pe 's/get-shit-done(?!-\w)/gsd-core/g'`. The negative lookahead preserves the five legitimate slug variants that are NOT the directory: get-shit-done-{OLD,cc,classic,cli,redux} (old package/repo names). - Build/manifest wiring: package.json (bin, files, coverage globs), tsconfig.build.json (outDir), ~86 .gitignore build-output entries, stryker.config.mjs, scan-ignore files, install.js path strings. - Frozen (not rewritten): CHANGELOG.md history; translated docs (README.<locale>.md and docs/{ja-JP,ko-KR,pt-BR,zh-CN}/). New logic (review here): - src/installer-migrations/003-rename-get-shit-done-to-gsd-core.cts: a proper ADR-0008 installer migration. On upgrade it walks the legacy `~/.claude/get-shit-done/` tree, classifies each file via the prior install manifest, and emits remove-managed / backup-and-remove for managed files while PRESERVING unknown user-added files. Symlink-safe (skips a symlinked root and symlinked entries; bounds-checks every path under configDir). The framework rolls back on install failure. Emptied dirs may remain (framework has no recursive dir-removal primitive) — documented. - scripts/lint-legacy-dir-name.cjs: CI regression guard forbidding the bare `get-shit-done` directory token (split token to avoid self-match; case- insensitive; `(?!-\w)` lookahead allows the slug variants; allowlists CHANGELOG, translated docs, and `gsd-allow-legacy-name` marker lines). Wired into the lint-tests CI job. - Restored scripts/lint-package-identity-drift.cjs detection regexes (the mechanical sweep had wrongly rewritten the old-name patterns it exists to detect) and marked them as intentional legacy references. - TDD tests for the migration and the guard; do.md slash-command guard regex tightened so a `/gsd-core/bin` path segment is not mistaken for a command; changeset + docs/installer-migrations.md row added. Breaking: the installed runtime path moves `~/.claude/get-shit-done/` -> `~/.claude/gsd-core/`. Migration 003 removes the stale legacy dir's managed files (preserving user files) on upgrade. Users with custom hooks/configs hardcoding the old path must update them. Closes #604 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): unsweep pending changesets + allowlist injection-example docs CI fixes for the rename PR: - Do not sweep pending .changeset/*.md (ephemeral release-note fragments, like CHANGELOG); reverted those body edits so 5 pre-existing malformed fragments (missing type/pr) no longer enter the PR diff and trip docs-lint. Allowlisted .changeset/ in the legacy-name guard accordingly. - Allowlisted TEST-EXAMPLES.md and docs/explanation/security-model.md in prompt-injection-scan.sh: they contain intentional injection examples / security-model prose; the path-reference rewrites are kept. CodeQL alerts on this PR are pre-existing (alert lines unchanged by this PR; none in the new migration/guard) and are out of scope for the rename. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): resolve CodeQL alerts surfaced on this PR The rename diff touched files carrying pre-existing CodeQL findings; per the no-pre-existing-dismissal rule, fixing every surfaced alert rather than waving them off. All behavior-preserving: - scripts/ci-test-scope.cjs: build the config-path match from string .includes() instead of a RegExp over an arg-derived value (js/regex-injection). - src/profile-output.cts: escape backslashes before pipe-escaping desc/safeName so the table-cell escape is complete (js/incomplete-sanitization). - tests/{bug-2643,bug-2808,docs-parity-live-registry}: two-pass HTML-comment strip so a bare/unclosed `<!--` cannot survive (js/incomplete-multi-character-sanitization). - tests/inline-plan-threshold: drop the no-op `\s`->`\s` identity replace, keep the meaningful POSIX-class conversion (js/identity-replacement). Verified: build:lib green; the touched test files + ci-test-scope + profile-output suites pass; lint:legacy-name clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): correctly resolve remaining CodeQL alerts (regex-injection + sanitization) The prior commit's fixes for two alerts were ineffective: - ci-test-scope.cjs js/regex-injection: the alert is the CLI-arg-derived `file` reaching static regex `.test(file)` calls (not the config rule). Removed ALL regex over file/t — startsWith/includes/=== string checks + an isWindowsHint helper — so there is no regex sink for the tainted value. - js/incomplete-multi-character-sanitization (3 test files): a single `.replace(/<!--...-->/g,'')` can let `<!--` re-form. Replaced with a fixpoint loop (replace until stable) plus a final bare-opener strip. Verified: no regex over file/t remains; ci-test-scope + the 3 test suites pass; lint:legacy-name clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): make ci-test-scope + comment-strippers regex-free to clear CodeQL CodeQL flags the regex PATTERNS syntactically (regex-injection on the --files arg split; incomplete-multi-character-sanitization on the <!--...--> replace), so loop fixes do not satisfy it. Made these paths regex-free: - ci-test-scope.cjs splitFiles: char-by-char separator tokenizer (no /[,\\s]+/). - 3 test files: indexOf/slice HTML-comment stripper (no .replace(/<!--/)). Behavior preserved; ci-test-scope + the 3 suites pass; guard clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): unblock security base64 scan on the large rename diff The security job hit its 10m timeout: base64-scan.sh choked on the binary test fixture tests/feat-3594-parser-property-style.test.cjs (embedded NUL/ non-UTF8 bytes -> thousands of bogus blobs + "ignored null byte" warnings), and the ~800-file rename diff is slow to scan regardless. - scripts/base64-scan.sh: skip binary-by-content files (grep -Iq .) — they can't carry base64-obfuscated *text* and feeding NUL bytes through the per-line scanner is pathologically slow. collect_files already filtered binary *extensions*; this catches binary *content* in text extensions. - .github/workflows/security-scan.yml: raise the security job timeout 10m->30m to accommodate very large diffs (the scan itself is unchanged). Verified locally: scan skips the fixture, 0 "ignored null byte" warnings, 0 findings, exit 0. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): sweep get-shit-done refs introduced by merging next The branch was updated with next (#614/#384/#618 etc.), which reference the get-shit-done/ dir (still named that on next). Swept the stale references in the merged files to gsd-core so the rename stays consistent and lint:legacy-name passes: - commands/gsd/discuss-phase.md (runtime-launcher shim paths) - src/core.cts (getAgentsDir layout comments) - tests/bug-384-agents-runtime-aware.test.cjs (require path to runtime lib) Verified: guard 0 violations; build green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): exclude gsd-core/ path segments from bug-3683 command cross-ref invariant The #614 runtime-launcher shim added to discuss-phase.md references `${_GSD_RUNTIME_ROOT}/gsd-core/bin/...`. bug-3683's REF_PATTERN excluded path-y refs only via lookbehind, but `}` precedes `/gsd-core/` in the shim, so it mis-read the directory path as a dangling `/gsd-core` command ref (same class as the #604 bug-2954 fix). Added a trailing `(?![\w-]*\/)` so `/gsd-<x>/...` path segments are not treated as slash-command references. Verified locally on BOTH platforms before pushing: - mac (node 26) full suite: 0 failures - gsd-test-runner (linux, node22 image) full suite: 0 failures - bug-3683 + bug-2954 pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): lazily resolve findProjectRoot in gsd-tools (harden flaky CI) CI intermittently failed state.test's gsd-tools subprocess with "findProjectRoot is not a function" (flip-flopping across legs; not reproducible on mac full suite, gsd-test linux full suite, test:unit, or state.test x8). findProjectRoot is a re-export from core.cjs (sourced from project-root.cjs); binding it via destructure at module-load can be undefined under a load-ordering edge. Resolve it lazily at call time via a small wrapper so the lookup happens after core.cjs is fully initialized. Verified green on BOTH platforms before pushing: - mac (node 26) full suite: 0 failures - gsd-test-runner (linux, node22) full suite: 0 failures - state.test.cjs: 106/106; gsd-tools loads cleanly. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): allowlist verification-patterns.md placeholder examples in secret scan The rename git-mv'd references/verification-patterns.md into gsd-core/, pulling it into the secret-scan diff. It documents stub/placeholder RED-FLAG env-var examples (illustrative Stripe test-key / database-URL / API-key placeholders) — not real credentials. Added it to .secretscanignore with the strict annotation, mirroring the existing gsd-core/workflows/plan-phase.md exception. Verified locally: secret-scan-lint --strict OK; secret-scan --diff origin/next exits 0 with 0 findings. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
220 lines
7.7 KiB
JavaScript
220 lines
7.7 KiB
JavaScript
#!/usr/bin/env node
|
|
'use strict';
|
|
|
|
/**
|
|
* scripts/mutation-matrix.cjs
|
|
*
|
|
* Single source of truth for the ADR-457 Stryker mutation gate dynamic matrix.
|
|
*
|
|
* Computes which covered modules changed vs a base ref and emits a GitHub
|
|
* Actions matrix JSON so CI can run one Stryker shard per changed module in
|
|
* parallel rather than a single serial run over all modules.
|
|
*
|
|
* Usage:
|
|
* node scripts/mutation-matrix.cjs --base origin/next
|
|
* printf 'src/config-schema.cts\n' | node scripts/mutation-matrix.cjs
|
|
* node scripts/mutation-matrix.cjs --base origin/next --print
|
|
*
|
|
* Output (stdout, default): JSON object
|
|
* {
|
|
* "has_work": "true"|"false",
|
|
* "matrix": {
|
|
* "include": [
|
|
* { "name": "<module>", "mutate": "gsd-core/bin/lib/<module>.cjs", "tests": "<space-joined test files>" },
|
|
* ...
|
|
* ]
|
|
* }
|
|
* }
|
|
*
|
|
* Exit codes: 0 always (empty matrix is not an error, has_work "false").
|
|
*/
|
|
|
|
const { execFileSync } = require('child_process');
|
|
const { readFileSync } = require('fs');
|
|
|
|
// ── Single source of truth: covered modules ───────────────────────────────────
|
|
// Each entry: { cjs: '<built artifact>', tests: ['tests/...', ...] }
|
|
// A module is "covered" iff its tests are wired into the Stryker command runner
|
|
// (stryker.config.mjs commandRunner.command). Mutating an uncovered module can
|
|
// only ever produce survived mutants — so we scope strictly to these 6.
|
|
const COVERED = {
|
|
'context-utilization': {
|
|
cjs: 'gsd-core/bin/lib/context-utilization.cjs',
|
|
tests: [
|
|
'tests/context-utilization.property.test.cjs',
|
|
],
|
|
},
|
|
'prompt-budget': {
|
|
cjs: 'gsd-core/bin/lib/prompt-budget.cjs',
|
|
tests: [
|
|
'tests/prompt-budget.property.test.cjs',
|
|
'tests/prompt-budget.unit.test.cjs',
|
|
],
|
|
},
|
|
frontmatter: {
|
|
cjs: 'gsd-core/bin/lib/frontmatter.cjs',
|
|
tests: [
|
|
'tests/frontmatter.property.test.cjs',
|
|
'tests/frontmatter.unit.test.cjs',
|
|
],
|
|
},
|
|
'adr-parser': {
|
|
cjs: 'gsd-core/bin/lib/adr-parser.cjs',
|
|
tests: [
|
|
'tests/adr-parser.property.test.cjs',
|
|
'tests/adr-parser.test.cjs',
|
|
'tests/adr-parser.unit.test.cjs',
|
|
],
|
|
},
|
|
'config-schema': {
|
|
cjs: 'gsd-core/bin/lib/config-schema.cjs',
|
|
tests: [
|
|
'tests/config-schema.property.test.cjs',
|
|
],
|
|
},
|
|
'active-workstream-store': {
|
|
cjs: 'gsd-core/bin/lib/active-workstream-store.cjs',
|
|
tests: [
|
|
'tests/active-workstream-store.test.cjs',
|
|
'tests/active-workstream-store.unit.test.cjs',
|
|
],
|
|
},
|
|
};
|
|
|
|
// ── Files that, when changed, invalidate ALL modules ─────────────────────────
|
|
// Changes to the Stryker config, this script itself, or any covered test file
|
|
// affect all mutation scores and must force a full re-run.
|
|
const GLOBAL_TRIGGERS = new Set([
|
|
'stryker.config.mjs',
|
|
'scripts/mutation-matrix.cjs',
|
|
]);
|
|
|
|
// Also flag all test files that belong to any covered module as global triggers.
|
|
for (const mod of Object.values(COVERED)) {
|
|
for (const t of mod.tests) {
|
|
GLOBAL_TRIGGERS.add(t);
|
|
}
|
|
}
|
|
|
|
// ── Argument parsing ──────────────────────────────────────────────────────────
|
|
function parseArgs(argv) {
|
|
const out = { base: null, print: false };
|
|
for (let i = 0; i < argv.length; i++) {
|
|
const arg = argv[i];
|
|
if (arg === '--base') {
|
|
out.base = argv[++i];
|
|
if (!out.base || out.base.startsWith('--')) {
|
|
throw new Error('--base requires a value');
|
|
}
|
|
} else if (arg.startsWith('--base=')) {
|
|
out.base = arg.slice('--base='.length);
|
|
if (!out.base) throw new Error('--base requires a value');
|
|
} else if (arg === '--print') {
|
|
out.print = true;
|
|
} else if (arg === '--help' || arg === '-h') {
|
|
console.log([
|
|
'Usage:',
|
|
' node scripts/mutation-matrix.cjs --base <ref> [--print]',
|
|
' printf "src/foo.cts\\n" | node scripts/mutation-matrix.cjs [--print]',
|
|
'',
|
|
'Options:',
|
|
' --base <ref> Git ref to diff against (default: origin/${GITHUB_BASE_REF:-next})',
|
|
' --print Human-readable output instead of JSON',
|
|
].join('\n'));
|
|
process.exit(0);
|
|
} else {
|
|
throw new Error(`unknown argument: ${arg}`);
|
|
}
|
|
}
|
|
return out;
|
|
}
|
|
|
|
// ── Changed-file resolution ───────────────────────────────────────────────────
|
|
function resolveChangedFiles(args) {
|
|
// When --base is provided, always use git diff (regardless of stdin).
|
|
// When --base is absent AND stdin is not a TTY (isTTY is falsy / undefined),
|
|
// read a newline-delimited file list from stdin.
|
|
if (!args.base && process.stdin.isTTY !== true) {
|
|
const raw = readFileSync(process.stdin.fd, 'utf8');
|
|
return raw.split('\n').map(l => l.trim()).filter(Boolean);
|
|
}
|
|
|
|
// Otherwise (--base given, or stdin is a real TTY), diff against the base ref.
|
|
const defaultBase = `origin/${process.env.GITHUB_BASE_REF || 'next'}`;
|
|
const base = args.base || defaultBase;
|
|
const stdout = execFileSync('git', ['diff', '--name-only', `${base}...HEAD`], {
|
|
encoding: 'utf8',
|
|
});
|
|
return stdout.split('\n').map(l => l.trim()).filter(Boolean);
|
|
}
|
|
|
|
// ── Module classification ─────────────────────────────────────────────────────
|
|
function computeMatrix(changedFiles) {
|
|
// Check for global triggers first — if any hit, include every covered module.
|
|
const allModuleNames = Object.keys(COVERED);
|
|
for (const f of changedFiles) {
|
|
if (GLOBAL_TRIGGERS.has(f)) {
|
|
return allModuleNames;
|
|
}
|
|
}
|
|
|
|
// Otherwise find which modules have their src/*.cts changed.
|
|
const changed = new Set();
|
|
for (const f of changedFiles) {
|
|
// Match src/<module>.cts (top-level src/, not nested)
|
|
const m = f.match(/^src\/([^/]+)\.cts$/);
|
|
if (m && COVERED[m[1]]) {
|
|
changed.add(m[1]);
|
|
}
|
|
}
|
|
return [...changed];
|
|
}
|
|
|
|
// ── Output formatting ─────────────────────────────────────────────────────────
|
|
function buildResult(moduleNames) {
|
|
const include = moduleNames.map(name => ({
|
|
name,
|
|
mutate: COVERED[name].cjs,
|
|
tests: COVERED[name].tests.join(' '),
|
|
}));
|
|
|
|
return {
|
|
has_work: include.length > 0 ? 'true' : 'false',
|
|
matrix: { include },
|
|
};
|
|
}
|
|
|
|
function printHuman(result, changedFiles) {
|
|
console.log(`Changed files (${changedFiles.length}):`);
|
|
for (const f of changedFiles) console.log(` ${f}`);
|
|
console.log('');
|
|
console.log(`has_work: ${result.has_work}`);
|
|
console.log(`Shards (${result.matrix.include.length}):`);
|
|
for (const shard of result.matrix.include) {
|
|
console.log(` [${shard.name}]`);
|
|
console.log(` mutate: ${shard.mutate}`);
|
|
console.log(` tests: ${shard.tests}`);
|
|
}
|
|
}
|
|
|
|
// ── Main ──────────────────────────────────────────────────────────────────────
|
|
function main() {
|
|
try {
|
|
const args = parseArgs(process.argv.slice(2));
|
|
const changedFiles = resolveChangedFiles(args);
|
|
const moduleNames = computeMatrix(changedFiles);
|
|
const result = buildResult(moduleNames);
|
|
|
|
if (args.print) {
|
|
printHuman(result, changedFiles);
|
|
} else {
|
|
console.log(JSON.stringify(result, null, 2));
|
|
}
|
|
} catch (err) {
|
|
console.error(`mutation-matrix: ${err.message}`);
|
|
process.exit(2);
|
|
}
|
|
}
|
|
|
|
main();
|