4631923982
* fix(#1569): preserve explicit resolve_model_ids in non-Claude installs The non-Claude finishInstall step keyed its resolve_model_ids:"omit" write on !== "omit", so an explicit true opt-in (resolveModelInternal returns full model IDs) was silently clobbered on every install/upgrade across all 14 non-Claude runtimes, making generated agent manifests inherit the active chat model instead of pinning the resolved model. Now only absent/falsy is defaulted to "omit"; an explicit true (and an existing "omit") is preserved. Regression test parameterizes across codex/opencode/gemini and covers the absent/false/idempotent/ claude/malformed boundaries. * chore(#1569): backfill changeset pr ref to 1653 * fix(#1569): default non-canonical resolve_model_ids values to omit (codex review) Adversarial review (codex, gpt-5.5/high) flagged that the original allowlist-by- enumeration condition (undefined/null/false -> omit) preserved malformed values (0, "", "yes", {}) instead of defaulting them to omit, letting them leak Claude aliases a non-Claude runtime cannot resolve. Switch to an allowlist condition (existing !== true && existing !== 'omit') so only an explicit canonical true opt-in and an existing omit are preserved; everything else defaults to the safe non-Claude omit. Adds a parameterized test over [0, "", "yes", {}].
519 B
519 B
type, pr
| type | pr |
|---|---|
| Fixed | 1653 |
Non-Claude installs no longer rewrite an explicit resolve_model_ids: true to "omit" — Codex, OpenCode, Gemini, and the other non-Claude runtimes were silently clobbering the deliberate opt-in to full materialized model IDs on every install/upgrade, so generated agent manifests inherited the active chat model instead of pinning the resolved model. The finish step now only defaults resolve_model_ids to "omit" when it is absent or falsy; an explicit true is preserved. (#1569)