ba231ecbfc
Pay down pre-existing error→warn lint debt. Removes dead imports/vars, unused functions, redundant regex/string escapes, and stale eslint-disable directives; converts unused `catch (_e)` to optional catch binding (src/*.cts). No behavior change. Lint 345→125 warnings (0 errors); deferred categories (n/no-process-exit, test-sleeps, control-regex) tracked in #732 for follow-up. Full test suite green (0 failures); code-review verified all removals unused and all escape fixes semantics-preserving. Closes #732 Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
90 lines
4.6 KiB
JavaScript
90 lines
4.6 KiB
JavaScript
'use strict';
|
|
// allow-test-rule: reads roadmap.cjs source to verify isPlanFile pattern was adopted — structural contract prevents silent regression to old filter
|
|
|
|
// Regression guard for bug #3128.
|
|
//
|
|
// roadmap.cjs countPhasePlansAndSummaries() used to filter plan files with:
|
|
// f.endsWith('-PLAN.md') || f === 'PLAN.md'
|
|
// This misses the {N}-PLAN-{NN}-{slug}.md layout that gsd-plan-phase
|
|
// actually writes (e.g. 5-PLAN-01-setup-database.md), ending in -database.md.
|
|
// Result: init manager returned plan_count=0 and disk_status='discussed' for
|
|
// fully-planned phases, triggering unnecessary background planner agents.
|
|
//
|
|
// Root cause: same regex flaw as #2893 (fixed in phase.cjs via #2896), but
|
|
// the manager-dashboard path in roadmap.cjs was not updated alongside it.
|
|
//
|
|
// Fix: apply the same looksLikePlanFile logic from phase.cjs to roadmap.cjs.
|
|
|
|
const { describe, test } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('node:fs');
|
|
const path = require('node:path');
|
|
|
|
const ROOT = path.join(__dirname, '..');
|
|
// Require the module under test directly
|
|
const roadmapLib = path.join(ROOT, 'gsd-core', 'bin', 'lib', 'roadmap.cjs');
|
|
const planScanLib = path.join(ROOT, 'gsd-core', 'bin', 'lib', 'plan-scan.cjs');
|
|
|
|
// We test countPhasePlansAndSummaries indirectly via getManagerInfo since
|
|
// it is not exported. We build a real phaseDir on disk and call the full
|
|
// roadmap.cjs init manager path via its exported helper, or fall back to
|
|
// direct filesystem inspection of what the filter would produce.
|
|
// The simplest correct seam: inspect the source for the regex pattern and
|
|
// validate with a synthetic directory that the manager path returns correct counts.
|
|
|
|
|
|
// Import countPhasePlansAndSummaries by monkey-patching: we inline the
|
|
// fixed filter logic and verify it matches the file on disk.
|
|
// Since the function is module-private, we validate via its public caller
|
|
// by using the exported analyzeRoadmap / getPhaseInfo path with a
|
|
// synthetic .planning/ directory tree.
|
|
|
|
describe('bug #3128: roadmap.cjs plan-count for {N}-PLAN-{NN}-{slug}.md layout', () => {
|
|
|
|
test('isPlanFile rejects PLAN-OUTLINE and pre-bounce derivatives', () => {
|
|
// Inlined from fix — mirrors the exact logic in the fix
|
|
const PLAN_OUTLINE_RE = /-PLAN-OUTLINE\.md$/i;
|
|
const PLAN_PRE_BOUNCE_RE = /-PLAN.*\.pre-bounce\.md$/i;
|
|
const isPlanFile = (f) =>
|
|
(f.endsWith('-PLAN.md') || f === 'PLAN.md') ||
|
|
(/\.md$/i.test(f) && /PLAN/i.test(f) && !PLAN_OUTLINE_RE.test(f) && !PLAN_PRE_BOUNCE_RE.test(f));
|
|
|
|
// canonical forms — must match
|
|
assert.ok(isPlanFile('PLAN.md'), 'PLAN.md must match');
|
|
assert.ok(isPlanFile('5-PLAN.md'), '5-PLAN.md must match');
|
|
assert.ok(isPlanFile('05-PLAN.md'), '05-PLAN.md must match');
|
|
|
|
// slug form — was the bug; must now match
|
|
assert.ok(isPlanFile('5-PLAN-01-setup.md'), '5-PLAN-01-setup.md must match');
|
|
assert.ok(isPlanFile('05-PLAN-02-database.md'), '05-PLAN-02-database.md must match');
|
|
assert.ok(isPlanFile('5-PLAN-DELTA-2026-05-05.md'), '5-PLAN-DELTA-2026-05-05.md must match');
|
|
|
|
// derivative files — must NOT match
|
|
assert.ok(!isPlanFile('5-PLAN-OUTLINE.md'), 'PLAN-OUTLINE must not match');
|
|
assert.ok(!isPlanFile('5-PLAN-01.pre-bounce.md'), 'pre-bounce must not match');
|
|
assert.ok(!isPlanFile('CONTEXT.md'), 'CONTEXT.md must not match');
|
|
assert.ok(!isPlanFile('SUMMARY.md'), 'SUMMARY.md must not match');
|
|
assert.ok(!isPlanFile('5-RESEARCH.md'), 'RESEARCH.md must not match');
|
|
});
|
|
|
|
test('roadmap.cjs source uses the extended isPlanFile filter', () => {
|
|
const roadmapSrc = fs.readFileSync(roadmapLib, 'utf8');
|
|
// Verify the fix is in place: the old simple inline filter is gone from roadmap.cjs
|
|
assert.ok(
|
|
!roadmapSrc.includes("phaseFiles.filter(f => f.endsWith('-PLAN.md') || f === 'PLAN.md')"),
|
|
'Old simple plan filter still present in roadmap.cjs — fix not applied',
|
|
);
|
|
// roadmap.cjs now delegates to plan-scan.cjs via require('./plan-scan.cjs')
|
|
assert.ok(
|
|
roadmapSrc.includes('plan-scan.cjs'),
|
|
'roadmap.cjs does not require plan-scan.cjs — delegation not applied',
|
|
);
|
|
// plan-scan.cjs is where the extended plan-file detection logic lives (isRootPlanFile)
|
|
const planScanSrc = fs.readFileSync(planScanLib, 'utf8');
|
|
assert.ok(
|
|
planScanSrc.includes('isRootPlanFile') && planScanSrc.includes('/PLAN/i'),
|
|
'isRootPlanFile with /PLAN/i not found in plan-scan.cjs — canonical helper missing extended filter',
|
|
);
|
|
});
|
|
});
|