4d394a249d
* fix(commands): normalize gsd slash namespace drift * fix(#2855): address CodeRabbit findings on namespace drift PR Three CR findings, all valid: 1. autonomous.md line 783 still had `gsd:discuss-phase` (the PR's own normalization missed this line). Switched to `gsd-discuss-phase` and updated the matching test in autonomous-interactive.test.cjs that was asserting the now-retired colon form. 2. tests/bug-2543-gsd-slash-namespace.test.cjs source-grepped the fix-slash-commands.cjs script with .includes() rather than driving its transform behaviour. Refactored fix-slash-commands.cjs to export a pure transformContent(src, cmdNames) function, kept the CLI behaviour unchanged via require.main, and replaced the source-grep block with five behavioural cases: rewrite, multi-occurrence, idempotence on canonical input, no-op on gsd-sdk/gsd-tools, and word-boundary safety. 3. tests/bug-2808-skill-hyphen-name.test.cjs matched `name:` anywhere in SKILL.md; a stray name: in the body could satisfy the assertion. Scoped the lookup to the YAML frontmatter block via the suggested diff (parse the leading --- ... --- region first, then find name: inside it). Full suite: 5854/5854 passing. * fix(#2855): address remaining CodeRabbit findings on PR #2858 Three structural concerns flagged on the namespace-drift fix PR: 1. scripts/fix-slash-commands.cjs:24 — `buildPattern([])` compiled `/gsd:()(?=[^a-zA-Z0-9_-]|$)/g`. The empty capture group still matches any `/gsd:` token followed by a non-word boundary (whitespace, EOL, punctuation), rewriting it to a stray `/gsd-`. Verified live: `transformContent("/gsd:", [])` → `"/gsd-"`. Added a guard returning null from `buildPattern` on empty input and updated `transformContent` and `processDir` to no-op when the pattern is null. 2. tests/autonomous-interactive.test.cjs:44-47 — assertion was `content.includes('gsd-discuss-phase') && content.includes('INTERACTIVE')`, which would false-pass on any unrelated co-occurrence (e.g. `INTERACTIVE=""` initialization plus a stray `gsd-discuss-phase` prose mention). Replaced with a structural extraction: locate the `**If \`INTERACTIVE\` is set:**` branch, bound it by the next `**If` / `<step>` boundary, and assert the `Skill(skill="gsd-discuss-phase", ...)` invocation lives inside that region. Tolerates whitespace around `(`, `skill`, and `=`. 3. tests/bug-2808-skill-hyphen-name.test.cjs:104 — colon-call regex was `Skill\(skill=...` and missed valid formatting like `Skill(skill = "gsd:cmd")` or `Skill( skill = ...)`. Loosened to `Skill\(\s*skill\s*=\s*...` so reformatting drift can't slip past the namespace guard. Verification: 5854/5854 pass on `npm test` from the rebased branch. * fix(#2855): drop pre-validation filter that hid namespace drift CR finding on tests/bug-2808-skill-hyphen-name.test.cjs:128: the test collected generated skill directories with `.filter(entry => entry.isDirectory() && entry.name.startsWith('gsd-'))`, then validated namespace invariants over that filtered list. Anything that violated the prefix invariant — `gsd:extract-learnings` (colon form), `extract_learnings` without prefix, `Gsd-foo` mis-cased — would silently disappear from the iteration and the test would falsely pass. Drop the `startsWith('gsd-')` filter so every generated directory shows up. Add explicit assertions before the existing per-skill loop: - directory list is non-empty (catches a broken converter that produces nothing) - every directory begins with `gsd-` - every directory contains no `:` - every directory contains no `_` Re-audited the full PR diff for the same anti-pattern: only this one site filtered before validating the namespace; bug-2643 and commands-doc-parity also use `readdirSync().filter()` but only by file extension, which is correct. 5854/5854 on `npm test`. * fix(#2855): address remaining CR findings (1 active + 2 nitpicks) Three findings on PR #2858, all the same root cause: input narrowing before validation lets drift slip past the guards. 1. tests/bug-2808-...:104 (active) — `colonCallRe` captured local names with `[a-z0-9-]+`, which excluded the underscore. A drift like `Skill(skill="gsd:extract_learnings")` (deprecated colon syntax with the old underscore filename) silently slid through. Broadened the capture to `[^'"\s)]+` so any malformed local name is surfaced; surrounding pattern (whitespace tolerance, escape support, flags) unchanged. 2. tests/bug-2643-...:43 (nitpick) — `extractSkillNamesHyphen` and `extractSkillNamesColon` had the same over-strict capture plus relied on a single regex over raw bytes, which the project test- rigor memory bans (`feedback_no_source_grep_tests.md`). Replaced with `extractSkillCalls(content)` — a small structural extractor that walks `Skill(` openers, locates each call's matching `)`, parses the body's `skill = "..."` keyword argument with permissive whitespace + quoting + escape handling, and returns `{ name, raw }` records. The two namespace-form helpers become thin filters over the structured output. Tightened the body class to `[^'"\\]+` so a trailing escape `\` before the closing quote (as in `Skill(skill=\"gsd-foo\", …)` written inside another string context) doesn't get included in the captured name. 3. tests/bug-2543-...:44 (nitpick) — `DOC_SEARCH_FILES` was a hand- curated 7-entry array. Every doc added in the future would silently weaken drift detection until someone remembered to extend the list. Replaced with `discoverDocSearchFiles(ROOT)`: globs every `.md` under `docs/` and adds `README.md` if present. New docs are picked up automatically. Re-audited the diff surface for similar narrowings; no other sites filter or constrain before validating namespace invariants. 5854/5854 on `npm test`. * fix(#2855): recurse docs/ tree so localized translations are scanned too CR finding: discoverDocSearchFiles() stopped at docs/*.md, leaving localized translation trees (docs/ja-JP/, docs/zh-CN/, docs/ko-KR/, docs/pt-BR/) and other nested doc collections (docs/skills/, docs/superpowers/) invisible to the namespace-drift invariant. Verified the gap: docs/ has 6 nested directories with ~30 .md files that the previous top-level-only scan was skipping. None contain /gsd: references today, but a future translation update or new doc subdir could leak drift. Switch to an iterative stack walk so every .md under docs/ is scanned regardless of depth. Stack form (rather than recursion) avoids the risk of running into the call-stack limit on deep doc trees. 5854/5854 on `npm test`. --------- Co-authored-by: Tom Boucher <trekkie@nomorestars.com>
314 lines
7.7 KiB
JSON
314 lines
7.7 KiB
JSON
{
|
|
"generated": "2026-04-27",
|
|
"families": {
|
|
"agents": [
|
|
"gsd-advisor-researcher",
|
|
"gsd-ai-researcher",
|
|
"gsd-assumptions-analyzer",
|
|
"gsd-code-fixer",
|
|
"gsd-code-reviewer",
|
|
"gsd-codebase-mapper",
|
|
"gsd-debug-session-manager",
|
|
"gsd-debugger",
|
|
"gsd-doc-classifier",
|
|
"gsd-doc-synthesizer",
|
|
"gsd-doc-verifier",
|
|
"gsd-doc-writer",
|
|
"gsd-domain-researcher",
|
|
"gsd-eval-auditor",
|
|
"gsd-eval-planner",
|
|
"gsd-executor",
|
|
"gsd-framework-selector",
|
|
"gsd-integration-checker",
|
|
"gsd-intel-updater",
|
|
"gsd-nyquist-auditor",
|
|
"gsd-pattern-mapper",
|
|
"gsd-phase-researcher",
|
|
"gsd-plan-checker",
|
|
"gsd-planner",
|
|
"gsd-project-researcher",
|
|
"gsd-research-synthesizer",
|
|
"gsd-roadmapper",
|
|
"gsd-security-auditor",
|
|
"gsd-ui-auditor",
|
|
"gsd-ui-checker",
|
|
"gsd-ui-researcher",
|
|
"gsd-user-profiler",
|
|
"gsd-verifier"
|
|
],
|
|
"commands": [
|
|
"/gsd-add-backlog",
|
|
"/gsd-add-phase",
|
|
"/gsd-add-tests",
|
|
"/gsd-add-todo",
|
|
"/gsd-ai-integration-phase",
|
|
"/gsd-analyze-dependencies",
|
|
"/gsd-audit-fix",
|
|
"/gsd-audit-milestone",
|
|
"/gsd-audit-uat",
|
|
"/gsd-autonomous",
|
|
"/gsd-check-todos",
|
|
"/gsd-cleanup",
|
|
"/gsd-code-review",
|
|
"/gsd-code-review-fix",
|
|
"/gsd-complete-milestone",
|
|
"/gsd-debug",
|
|
"/gsd-discuss-phase",
|
|
"/gsd-do",
|
|
"/gsd-docs-update",
|
|
"/gsd-edit-phase",
|
|
"/gsd-eval-review",
|
|
"/gsd-execute-phase",
|
|
"/gsd-explore",
|
|
"/gsd-extract-learnings",
|
|
"/gsd-fast",
|
|
"/gsd-forensics",
|
|
"/gsd-from-gsd2",
|
|
"/gsd-graphify",
|
|
"/gsd-health",
|
|
"/gsd-help",
|
|
"/gsd-import",
|
|
"/gsd-inbox",
|
|
"/gsd-ingest-docs",
|
|
"/gsd-insert-phase",
|
|
"/gsd-intel",
|
|
"/gsd-join-discord",
|
|
"/gsd-list-phase-assumptions",
|
|
"/gsd-list-workspaces",
|
|
"/gsd-manager",
|
|
"/gsd-map-codebase",
|
|
"/gsd-milestone-summary",
|
|
"/gsd-new-milestone",
|
|
"/gsd-new-project",
|
|
"/gsd-new-workspace",
|
|
"/gsd-next",
|
|
"/gsd-note",
|
|
"/gsd-pause-work",
|
|
"/gsd-plan-milestone-gaps",
|
|
"/gsd-plan-phase",
|
|
"/gsd-plan-review-convergence",
|
|
"/gsd-plant-seed",
|
|
"/gsd-pr-branch",
|
|
"/gsd-profile-user",
|
|
"/gsd-progress",
|
|
"/gsd-quick",
|
|
"/gsd-reapply-patches",
|
|
"/gsd-remove-phase",
|
|
"/gsd-remove-workspace",
|
|
"/gsd-research-phase",
|
|
"/gsd-resume-work",
|
|
"/gsd-review",
|
|
"/gsd-review-backlog",
|
|
"/gsd-scan",
|
|
"/gsd-secure-phase",
|
|
"/gsd-session-report",
|
|
"/gsd-set-profile",
|
|
"/gsd-settings",
|
|
"/gsd-settings-advanced",
|
|
"/gsd-settings-integrations",
|
|
"/gsd-ship",
|
|
"/gsd-sketch",
|
|
"/gsd-sketch-wrap-up",
|
|
"/gsd-spec-phase",
|
|
"/gsd-spike",
|
|
"/gsd-spike-wrap-up",
|
|
"/gsd-stats",
|
|
"/gsd-sync-skills",
|
|
"/gsd-thread",
|
|
"/gsd-ui-phase",
|
|
"/gsd-ui-review",
|
|
"/gsd-ultraplan-phase",
|
|
"/gsd-undo",
|
|
"/gsd-update",
|
|
"/gsd-validate-phase",
|
|
"/gsd-verify-work",
|
|
"/gsd-workstreams"
|
|
],
|
|
"workflows": [
|
|
"add-phase.md",
|
|
"add-tests.md",
|
|
"add-todo.md",
|
|
"ai-integration-phase.md",
|
|
"analyze-dependencies.md",
|
|
"audit-fix.md",
|
|
"audit-milestone.md",
|
|
"audit-uat.md",
|
|
"autonomous.md",
|
|
"check-todos.md",
|
|
"cleanup.md",
|
|
"code-review-fix.md",
|
|
"code-review.md",
|
|
"complete-milestone.md",
|
|
"diagnose-issues.md",
|
|
"discovery-phase.md",
|
|
"discuss-phase-assumptions.md",
|
|
"discuss-phase-power.md",
|
|
"discuss-phase.md",
|
|
"do.md",
|
|
"docs-update.md",
|
|
"edit-phase.md",
|
|
"eval-review.md",
|
|
"execute-phase.md",
|
|
"execute-plan.md",
|
|
"explore.md",
|
|
"extract_learnings.md",
|
|
"fast.md",
|
|
"forensics.md",
|
|
"graduation.md",
|
|
"health.md",
|
|
"help.md",
|
|
"import.md",
|
|
"inbox.md",
|
|
"ingest-docs.md",
|
|
"insert-phase.md",
|
|
"list-phase-assumptions.md",
|
|
"list-workspaces.md",
|
|
"manager.md",
|
|
"map-codebase.md",
|
|
"milestone-summary.md",
|
|
"new-milestone.md",
|
|
"new-project.md",
|
|
"new-workspace.md",
|
|
"next.md",
|
|
"node-repair.md",
|
|
"note.md",
|
|
"pause-work.md",
|
|
"plan-milestone-gaps.md",
|
|
"plan-phase.md",
|
|
"plan-review-convergence.md",
|
|
"plant-seed.md",
|
|
"pr-branch.md",
|
|
"profile-user.md",
|
|
"progress.md",
|
|
"quick.md",
|
|
"remove-phase.md",
|
|
"remove-workspace.md",
|
|
"research-phase.md",
|
|
"resume-project.md",
|
|
"review.md",
|
|
"scan.md",
|
|
"secure-phase.md",
|
|
"session-report.md",
|
|
"settings-advanced.md",
|
|
"settings-integrations.md",
|
|
"settings.md",
|
|
"ship.md",
|
|
"sketch-wrap-up.md",
|
|
"sketch.md",
|
|
"spec-phase.md",
|
|
"spike-wrap-up.md",
|
|
"spike.md",
|
|
"stats.md",
|
|
"sync-skills.md",
|
|
"transition.md",
|
|
"ui-phase.md",
|
|
"ui-review.md",
|
|
"ultraplan-phase.md",
|
|
"undo.md",
|
|
"update.md",
|
|
"validate-phase.md",
|
|
"verify-phase.md",
|
|
"verify-work.md"
|
|
],
|
|
"references": [
|
|
"agent-contracts.md",
|
|
"ai-evals.md",
|
|
"ai-frameworks.md",
|
|
"artifact-types.md",
|
|
"autonomous-smart-discuss.md",
|
|
"checkpoints.md",
|
|
"common-bug-patterns.md",
|
|
"context-budget.md",
|
|
"continuation-format.md",
|
|
"debugger-philosophy.md",
|
|
"decimal-phase-calculation.md",
|
|
"doc-conflict-engine.md",
|
|
"domain-probes.md",
|
|
"executor-examples.md",
|
|
"gate-prompts.md",
|
|
"gates.md",
|
|
"git-integration.md",
|
|
"git-planning-commit.md",
|
|
"ios-scaffold.md",
|
|
"mandatory-initial-read.md",
|
|
"model-profile-resolution.md",
|
|
"model-profiles.md",
|
|
"phase-argument-parsing.md",
|
|
"planner-antipatterns.md",
|
|
"planner-chunked.md",
|
|
"planner-gap-closure.md",
|
|
"planner-reviews.md",
|
|
"planner-revision.md",
|
|
"planner-source-audit.md",
|
|
"planning-config.md",
|
|
"project-skills-discovery.md",
|
|
"questioning.md",
|
|
"revision-loop.md",
|
|
"scout-codebase.md",
|
|
"sketch-interactivity.md",
|
|
"sketch-theme-system.md",
|
|
"sketch-tooling.md",
|
|
"sketch-variant-patterns.md",
|
|
"tdd.md",
|
|
"thinking-models-debug.md",
|
|
"thinking-models-execution.md",
|
|
"thinking-models-planning.md",
|
|
"thinking-models-research.md",
|
|
"thinking-models-verification.md",
|
|
"thinking-partner.md",
|
|
"ui-brand.md",
|
|
"universal-anti-patterns.md",
|
|
"user-profiling.md",
|
|
"verification-overrides.md",
|
|
"verification-patterns.md",
|
|
"workstream-flag.md"
|
|
],
|
|
"cli_modules": [
|
|
"artifacts.cjs",
|
|
"audit.cjs",
|
|
"commands.cjs",
|
|
"config-schema.cjs",
|
|
"config.cjs",
|
|
"core.cjs",
|
|
"decisions.cjs",
|
|
"docs.cjs",
|
|
"drift.cjs",
|
|
"frontmatter.cjs",
|
|
"gap-checker.cjs",
|
|
"graphify.cjs",
|
|
"gsd2-import.cjs",
|
|
"init.cjs",
|
|
"install-profiles.cjs",
|
|
"intel.cjs",
|
|
"learnings.cjs",
|
|
"milestone.cjs",
|
|
"model-profiles.cjs",
|
|
"phase.cjs",
|
|
"profile-output.cjs",
|
|
"profile-pipeline.cjs",
|
|
"roadmap.cjs",
|
|
"schema-detect.cjs",
|
|
"secrets.cjs",
|
|
"security.cjs",
|
|
"state.cjs",
|
|
"template.cjs",
|
|
"uat.cjs",
|
|
"verify.cjs",
|
|
"workstream.cjs"
|
|
],
|
|
"hooks": [
|
|
"gsd-check-update-worker.js",
|
|
"gsd-check-update.js",
|
|
"gsd-context-monitor.js",
|
|
"gsd-phase-boundary.sh",
|
|
"gsd-prompt-guard.js",
|
|
"gsd-read-guard.js",
|
|
"gsd-read-injection-scanner.js",
|
|
"gsd-session-state.sh",
|
|
"gsd-statusline.js",
|
|
"gsd-validate-commit.sh",
|
|
"gsd-workflow-guard.js"
|
|
]
|
|
}
|
|
}
|