Files
msd-core/sdk/src/query/check-verification-status.ts
Rezolv c5b1445529 feat(sdk): golden parity harness and query handler CJS alignment (#2302 Track A) (#2341)
* feat(sdk): golden parity harness and query handler CJS alignment (#2302 Track A)

Golden/read-only parity tests and registry alignment, query handler fixes
(check-completion, state-mutation, commit, validate, summary, etc.), and
WAITING.json dual-write for .gsd/.planning readers.

Refs gsd-build/get-shit-done#2341

* fix(sdk): getMilestoneInfo matches GSD ROADMAP (🟡, last bold, STATE fallback)

- Recognize in-flight 🟡 milestone bullets like 🚧.
- Derive from last **vX.Y Title** before ## Phases when emoji absent.
- Fall back to STATE.md milestone when ROADMAP is missing; use last bare vX.Y
  in cleaned text instead of first (avoids v1.0 from shipped list).
- Fixes init.execute-phase milestone_version and buildStateFrontmatter after
  state.begin-phase (syncStateFrontmatter).

* feat(sdk): phase list, plan task structure, requirements extract handlers

- Register phase.list-plans, phase.list-artifacts, plan.task-structure,
  requirements.extract-from-plans (SDK-only; golden-policy exceptions).
- Add unit tests; document in QUERY-HANDLERS.md.
- writeProfile: honor --output, render dimensions, return profile_path and dimensions_scored.

* feat(sdk): centralize getGsdAgentsDir in query helpers

Extract agent directory resolution to helpers (GSD_AGENTS_DIR, primary
~/.claude/agents, legacy path). Use from init and docs-init init bundles.

docs(15): add 15-CONTEXT for autonomous phase-15 run.

* feat(sdk): query CLI CJS fallback and session correlation

- createRegistry(eventStream, sessionId) threads correlation into mutation events
- gsd-sdk query falls back to gsd-tools.cjs when no native handler matches
  (disable with GSD_QUERY_FALLBACK=off); stderr bridge warnings
- Export createRegistry from @gsd-build/sdk; add sdk/README.md
- Update QUERY-HANDLERS.md and registry module docs for fallback + sessionId
- Agents: prefer node dist/cli.js query over cat/grep for STATE and plans

* fix(sdk): init phase_found parity, docs-init agents path, state field extract

- Normalize findPhase not-found to null before roadmap fallback (matches findPhaseInternal)

- docs-init: use detectRuntime + resolveAgentsDir for checkAgentsInstalled

- state.cjs stateExtractField: horizontal whitespace only after colon (YAML progress guard)

- Tests: commit_docs default true; config-get golden uses temp config; golden integration green

Refs: #2302

* refactor(sdk): share SessionJsonlRecord in profile-extract-messages

CodeRabbit nit: dedupe JSONL record shape for isGenuineUserMessage and streamExtractMessages.

* fix(sdk): address CodeRabbit major threads (paths, gates, audit, verify)

- Resolve @file: and CLI JSON indirection relative to projectDir; guard empty normalized query command

- plan.task-structure + intel extract/patch-meta: resolvePathUnderProject containment

- check.config-gates: safe string booleans; plan_checker alias precedence over plan_check default

- state.validate/sync: phaseTokenMatches + comparePhaseNum ordering

- verify.schema-drift: token match phase dirs; files_modified from parsed frontmatter

- audit-open: has_scan_errors, unreadable rows, human report when scans fail

- requirements PLANNED key PLAN for root PLAN.md; gsd-tools timeout note

- ingest-docs: repo-root path containment; classifier output slug-hash

Golden parity test strips has_scan_errors until CJS adds field.

* fix: Resolve CodeRabbit security and quality findings
- Secure intel.ts and cli.ts against path traversal
- Catch and validate git add status in commit.ts
- Expand roadmap milestone marker extraction
- Fix parsing array-of-objects in frontmatter YAML
- Fix unhandled config evaluations
- Improve coverage test parity mapping

* test: raise planner character extraction limit to 48K

* fix(sdk): resolve TS build error in docs-init passing config
2026-04-20 18:09:02 -04:00

161 lines
5.2 KiB
TypeScript

/**
* VERIFICATION.md parser (`check.verification-status`).
*
* Replaces VERIFICATION.md grep/parse branches in `execute-phase.md`,
* `autonomous.md`, `progress.md` with a structured query.
* See `.planning/research/decision-routing-audit.md` §3.8.
*/
import { readFile } from 'node:fs/promises';
import { existsSync, readdirSync } from 'node:fs';
import { join } from 'node:path';
import { GSDError, ErrorClassification } from '../errors.js';
import { normalizePhaseName } from './helpers.js';
import { findPhase } from './phase.js';
import type { QueryHandler } from './utils.js';
const NOT_FOUND_RESULT = {
status: 'missing' as const,
score: null,
gaps: [] as string[],
human_items: [] as string[],
deferred: [] as string[],
};
// ─── Markdown table parser ─────────────────────────────────────────────────
interface TableRow {
cells: string[];
raw: string;
}
function parseTableRows(content: string): TableRow[] {
return content
.split('\n')
.filter(line => {
const trimmed = line.trim();
return trimmed.startsWith('|') && trimmed.endsWith('|') && !/^\|[-: |]+\|$/.test(trimmed);
})
.map(line => ({
cells: line
.split('|')
.slice(1, -1)
.map(c => c.trim()),
raw: line.trim(),
}));
}
/**
* Find the column index that matches a header predicate, falling back to -1.
*/
function findColIndex(headerRow: TableRow, predicate: (cell: string) => boolean): number {
return headerRow.cells.findIndex(c => predicate(c));
}
export const checkVerificationStatus: QueryHandler = async (args, projectDir) => {
const raw = args[0];
if (!raw) {
throw new GSDError('phase number required for check verification-status', ErrorClassification.Validation);
}
normalizePhaseName(raw); // validate format
const phaseRes = await findPhase([raw], projectDir);
const pdata = phaseRes.data as Record<string, unknown>;
if (!pdata.found || !pdata.directory) {
return { data: NOT_FOUND_RESULT };
}
const phaseDirFull = join(projectDir, pdata.directory as string);
// Locate VERIFICATION.md — may be prefixed
let verPath: string | null = null;
if (existsSync(phaseDirFull)) {
try {
const files = readdirSync(phaseDirFull) as string[];
const verFile = files.find(f => f.endsWith('-VERIFICATION.md') || f === 'VERIFICATION.md');
if (verFile) verPath = join(phaseDirFull, verFile);
} catch {
return { data: NOT_FOUND_RESULT };
}
}
if (!verPath) return { data: NOT_FOUND_RESULT };
let content: string;
try {
content = await readFile(verPath, 'utf-8');
} catch {
return { data: NOT_FOUND_RESULT };
}
const rows = parseTableRows(content);
if (rows.length === 0) {
// No table rows — check frontmatter status field only
const statusMatch = content.match(/^status:\s*(\S+)/im);
const status = statusMatch ? statusMatch[1].toLowerCase() : 'missing';
return { data: { ...NOT_FOUND_RESULT, status: status === 'missing' ? 'missing' : status } };
}
// Detect header row — heuristic: first row typically has column names
const firstRow = rows[0];
const isHeader = firstRow.cells.some(c =>
/^(id|status|description|type|notes)$/i.test(c),
);
const dataRows = isHeader ? rows.slice(1) : rows;
const headerRow = isHeader ? firstRow : null;
// Determine column indices
let statusCol = headerRow ? findColIndex(headerRow, c => /^status$/i.test(c)) : -1;
let typeCol = headerRow ? findColIndex(headerRow, c => /^type$/i.test(c)) : -1;
let notesCol = headerRow ? findColIndex(headerRow, c => /^notes$/i.test(c)) : -1;
let descCol = headerRow ? findColIndex(headerRow, c => /^description$/i.test(c)) : -1;
// Fallbacks for tables without headers or unusual column orders
if (statusCol === -1) statusCol = 2; // typical: | ID | Description | Status |
if (descCol === -1) descCol = 1;
let passCount = 0;
let totalCount = 0;
const gaps: string[] = [];
const human_items: string[] = [];
const deferred: string[] = [];
for (const row of dataRows) {
const statusVal = (row.cells[statusCol] ?? '').toUpperCase();
const typeVal = typeCol >= 0 ? (row.cells[typeCol] ?? '').toLowerCase() : '';
const notesVal = notesCol >= 0 ? (row.cells[notesCol] ?? '').toLowerCase() : '';
const descVal = row.cells[descCol] ?? row.cells[0] ?? row.raw;
if (statusVal === 'PASS' || statusVal === 'FAIL') totalCount++;
if (statusVal === 'PASS') passCount++;
if (statusVal === 'FAIL') gaps.push(descVal);
if (typeVal.includes('human')) human_items.push(descVal);
if (notesVal.includes('deferred')) deferred.push(descVal);
}
const score = totalCount > 0 ? `${passCount}/${totalCount}` : null;
let status: string;
if (gaps.length > 0) {
status = 'fail';
} else if (passCount === totalCount && totalCount > 0) {
status = 'pass';
} else {
// Check frontmatter status as tiebreaker
const statusMatch = content.match(/^status:\s*(\S+)/im);
status = statusMatch ? statusMatch[1].toLowerCase() : 'partial';
}
return {
data: {
status,
score,
gaps,
human_items,
deferred,
},
};
};