84e9888d25
The GENERATED_CJS_IGNORES array in eslint.config.mjs wrongly listed 12 hand-written bin/lib/*.cjs modules as "generated" and excluded them from linting. Genuinely-generated artifacts are already covered by the **/*.generated.cjs glob and the ADR-457 semver-compare.cjs entry, so the array only created a coverage gap. Remove it so the 12 modules are linted under the existing get-shit-done/bin/**/*.cjs ruleset. Linting them surfaces two dormant dead-code findings, both removed here: - phase-lifecycle.cjs: stale `eslint-disable-next-line no-cond-assign` directive — the loop already uses the parenthesized-assignment form the rule permits by default, so it suppressed nothing. - state-document.cjs: vestigial `tempField`/`tempDefaults` locals (and their comment) left over from a refactor to an inline `.some(...)` check. Pure dead-code/lint-config cleanup; no user-facing behavior change. Closes #552 Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
80 lines
3.0 KiB
JavaScript
80 lines
3.0 KiB
JavaScript
'use strict';
|
|
|
|
/**
|
|
* Phase Lifecycle Pure Helpers — pure-computation functions extracted from
|
|
* the phase-lifecycle SDK handler.
|
|
*
|
|
* I/O adapter pattern (ADR-3524 Section 4): each side supplies its own I/O
|
|
* (sync readFileSync for CJS, async readFile for SDK); the pure computation
|
|
* logic is shared via this generated artifact.
|
|
*
|
|
* Scope:
|
|
* - deriveProgressFromRoadmap(roadmapContent): count Complete rows => idempotent
|
|
* - clampPercent(completed, total): percent with 100 ceiling
|
|
*
|
|
* These two functions are the root-cause fix for issue #4.
|
|
*
|
|
* References:
|
|
* - ADR-3524 (docs/adr/3524-cjs-sdk-hard-seam.md)
|
|
* - Issue #4 (open-gsd/gsd-core)
|
|
*/
|
|
|
|
/**
|
|
* Derive completed_phases, total_phases, and total_plans from ROADMAP content.
|
|
* Root cause fix for issue #4 — see gen-phase-lifecycle.mjs for full documentation.
|
|
*/
|
|
function deriveProgressFromRoadmap(roadmapContent) {
|
|
let completedPhases = null;
|
|
let totalPhases = null;
|
|
let totalPlans = null;
|
|
|
|
try {
|
|
// Count Complete rows in the progress table (Status column = "Complete").
|
|
// Pattern: row where the phase cell starts with a digit (data row, not header),
|
|
// followed by any cell content, then a "Complete" status cell.
|
|
// Handles both short form ("| 4. |") and long form ("| 01. Foundation |").
|
|
// See phase-lifecycle.ts ~line 1655 for the original SDK pattern.
|
|
const tableCompletePattern = /\|\s*\d+[^|]*\|\s*[^|]*\|\s*Complete\s*\|/gi;
|
|
const completeMatches = roadmapContent.match(tableCompletePattern);
|
|
completedPhases = completeMatches ? completeMatches.length : null;
|
|
|
|
// Count total phase rows in the progress table.
|
|
// Identify the table by looking for Phase|...|Status|...|Completed header.
|
|
const progressTableMatch = roadmapContent.match(
|
|
/\|\s*Phase\s*\|[^|]*\|[^|]*Status[^|]*\|[^|]*Completed[^|]*\|[\s\S]*?(?=\n\n|\n##|$)/i,
|
|
);
|
|
if (progressTableMatch) {
|
|
const tableText = progressTableMatch[0];
|
|
// Count data rows (rows starting with pipe then a phase number)
|
|
const dataRowPattern = /^\|\s*\d+/gm;
|
|
const dataRows = tableText.match(dataRowPattern);
|
|
totalPhases = dataRows ? dataRows.length : null;
|
|
}
|
|
|
|
// Sum plan counts from M/N columns in progress table
|
|
let totalPlansSum = 0;
|
|
const planCellPattern = /\|\s*\d+[^|]*\|\s*(\d+)\/(\d+)\s*\|/gi;
|
|
let pm;
|
|
while ((pm = planCellPattern.exec(roadmapContent)) !== null) {
|
|
totalPlansSum += parseInt(pm[2], 10);
|
|
}
|
|
if (totalPlansSum > 0) totalPlans = totalPlansSum;
|
|
} catch { /* intentionally empty — fall through to existing values */ }
|
|
|
|
return { completedPhases, totalPhases, totalPlans };
|
|
}
|
|
|
|
/**
|
|
* Compute progress percent clamped to 100.
|
|
* Root cause fix for issue #4 — see gen-phase-lifecycle.mjs for full documentation.
|
|
*/
|
|
function clampPercent(completed, total) {
|
|
if (!total || total <= 0) return 0;
|
|
return Math.min(100, Math.round((completed / total) * 100));
|
|
}
|
|
|
|
module.exports = {
|
|
deriveProgressFromRoadmap,
|
|
clampPercent,
|
|
};
|