Part 2 of 2 of the n/no-process-exit cleanup (completes umbrella #738; part 1 was #739/scripts). Converts the 20 flagged process.exit() calls in the three hand-written gsd-core/bin CLI entrypoints and flips n/no-process-exit to error. - New src/cli-exit.cts -> gsd-core/bin/lib/cli-exit.cjs (ExitError + runMain), the gsd-core-side equivalent of scripts/lib/cli-exit.cjs; registered in .gitignore, eslint ignores, and the inventory manifest like its siblings. - gsd-tools.cjs: 13 apply-prompt-budget exits -> throw ExitError; main()->runMain. - verify-reapply-patches.cjs: 6 exits -> throw ExitError / return verdict; runMain. - check-latest-version.cjs: 1 exit -> return verdict; runMain. - eslint.config.mjs: n/no-process-exit warn -> error. Scope note: the gsd-core/bin/lib/*.cjs modules (core, state, profile-pipeline, roadmap-command-router, adr-parser, ui-safety-gate) are tsc-generated and eslint-ignored (ADR-457), so their process.exit calls were never flagged and are intentionally left untouched. Only the linted hand-written entrypoints are in scope. Exit codes verified unchanged for all three entrypoints. Closes #738 Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
108 lines
3.7 KiB
JavaScript
Executable File
108 lines
3.7 KiB
JavaScript
Executable File
#!/usr/bin/env node
|
|
'use strict';
|
|
|
|
/**
|
|
* Deterministic latest-version check for /gsd-update (#2992).
|
|
*
|
|
* The /gsd-update workflow's check_latest_version step was previously
|
|
* prescribed in LLM-driven prose ("run `npm view gsd-core
|
|
* version`"). The executing model could shortcut the prescription and
|
|
* invent npm queries against wrong-shaped names (`@gsd-core/cli`,
|
|
* `get-shit-done-cli`, `gsd`), all of which 404 or — worse — return an
|
|
* unrelated typosquat package.
|
|
*
|
|
* This script makes the package name a CONSTANT in code, not a free
|
|
* choice at execution time. The workflow calls it via `npm run
|
|
* check-latest-version -- --json` and parses the structured response.
|
|
*
|
|
* Tests assert on the typed CHECK_REASON enum and the structured result
|
|
* record, never on console prose. See CONTRIBUTING.md "Prohibited: Raw
|
|
* Text Matching on Test Outputs".
|
|
*/
|
|
|
|
const { execNpm } = require('./lib/shell-command-projection.cjs');
|
|
const { runMain } = require('./lib/cli-exit.cjs');
|
|
|
|
// Sourced from the single Package Identity seam (#498), not re-typed. The seam
|
|
// bakes the value from package.json at build time, so it is a code constant —
|
|
// still NOT a runtime choice for the caller (#2992) — and a rename propagates
|
|
// from one place (#378). The drift-guard lint forbids re-introducing a literal.
|
|
const { packageName: PACKAGE_NAME } = require('./lib/package-identity.cjs');
|
|
|
|
const CHECK_REASON = Object.freeze({
|
|
OK: 'ok',
|
|
FAIL_NPM_FAILED: 'fail_npm_failed',
|
|
FAIL_INVALID_OUTPUT: 'fail_invalid_output',
|
|
});
|
|
|
|
const SEMVER_RE = /^\d+\.\d+\.\d+(?:[-+][0-9A-Za-z.-]+)?$/;
|
|
|
|
/**
|
|
* Pure-ish: takes an injected spawn function so tests don't actually run npm.
|
|
* In production, defaults to execNpm() from the shell-projection seam.
|
|
*/
|
|
function checkLatestVersion(opts = {}) {
|
|
// Default path routes through the shell-projection seam (execNpm owns the
|
|
// Windows shell-flag policy and timeout default). The injection point
|
|
// remains spawnSync-shaped for test compatibility — the adapter below
|
|
// translates { exitCode } → { status } so the consumer logic is unchanged.
|
|
// Bounded at 15s so a hung registry doesn't block /gsd-update (#2993 CR).
|
|
const defaultSpawn = () => {
|
|
const r = execNpm(['view', PACKAGE_NAME, 'version'], { timeout: 15_000 });
|
|
return {
|
|
status: r.exitCode,
|
|
stdout: r.stdout,
|
|
stderr: r.stderr,
|
|
signal: r.signal,
|
|
error: r.error,
|
|
};
|
|
};
|
|
const spawn = opts.spawn || defaultSpawn;
|
|
|
|
const r = spawn();
|
|
if (!r || r.status !== 0) {
|
|
// Distinguish timeout (status null, signal set, stderr empty) from a
|
|
// genuine npm failure. Without this, both surfaced as "npm exited
|
|
// non-zero" and the operator couldn't tell which (#2993 CR).
|
|
let detail;
|
|
if (r && r.signal) {
|
|
detail = `npm timed out (signal: ${r.signal})`;
|
|
} else if (r && r.stderr) {
|
|
detail = r.stderr.trim();
|
|
} else {
|
|
detail = 'npm exited non-zero';
|
|
}
|
|
return {
|
|
ok: false,
|
|
reason: CHECK_REASON.FAIL_NPM_FAILED,
|
|
detail,
|
|
};
|
|
}
|
|
const version = (r.stdout || '').trim();
|
|
if (!SEMVER_RE.test(version)) {
|
|
return {
|
|
ok: false,
|
|
reason: CHECK_REASON.FAIL_INVALID_OUTPUT,
|
|
detail: version || '(empty)',
|
|
};
|
|
}
|
|
return { ok: true, version, reason: CHECK_REASON.OK };
|
|
}
|
|
|
|
function main() {
|
|
const json = process.argv.includes('--json');
|
|
const r = checkLatestVersion();
|
|
if (json) {
|
|
process.stdout.write(JSON.stringify(r) + '\n');
|
|
} else if (r.ok) {
|
|
process.stdout.write(r.version + '\n');
|
|
} else {
|
|
process.stderr.write(`check-latest-version: ${r.reason}: ${r.detail}\n`);
|
|
}
|
|
return r.ok ? 0 : 1;
|
|
}
|
|
|
|
if (require.main === module) runMain(main);
|
|
|
|
module.exports = { checkLatestVersion, CHECK_REASON, PACKAGE_NAME };
|