f5276b36b3
* fix(#1369): refresh wave manifest and re-check base before each wave in execute-phase Two compounding issues caused wave N+1 worktrees to fork from the stale pre-wave-N commit, immediately tripping the worktree_branch_check FATAL guard in every executor: 1. worktree.base-check auto-degrade only ran once at initialize time. After wave N merges advanced orchestrator HEAD past origin/HEAD, new worktrees were still forked from origin/HEAD (Claude Code "fresh" base). 2. WAVE_WORKTREE_MANIFEST was never unset between waves, so wave N+1 reused the consumed wave-N manifest file, which would have blocked the step 5.5 manifest guard (#3384) on subsequent waves. Fix: add two safeguards in execute-phase.md — - Step 0.5 (start of each wave): re-runs worktree.base-check; auto-degrades USE_WORKTREES=false for that wave when HEAD has diverged from origin/HEAD. - Step 7c (end of each wave): unsets WAVE_WORKTREE_MANIFEST so wave N+1 creates a fresh per-wave manifest; re-asserts worktree.set-baseref (idempotent) and re-evaluates base degradation after wave merges land. 17 regression tests added in tests/bug-1369-wave-stale-base.test.cjs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(#1369): rename test to fix-NNN convention; update workflow size baseline Rename tests/bug-1369-wave-stale-base.test.cjs → tests/fix-1369-wave-stale-base.test.cjs to satisfy the lint-regression-test-names gate (new files cannot use bug-NNN prefix). Update tests/workflow-size-baseline.json for execute-phase.md: 93157 → 97393 (LF-normalized byte count after adding step 0.5 inter-wave base re-check and step 7c between-wave manifest reset). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(#1369): add issue reference to allow-test-rule comment Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(#1369): extract new execute-phase steps to references; satisfy ADR-857 cap Step 0.5 (inter-wave worktree base re-check) and steps 7b–7c (pre-wave dependency check + between-wave manifest reset/base refresh) added by this PR grew execute-phase.md to 97393 bytes, violating the ADR-857 phase-6 architectural mandate that host-loop bodies remain strictly below the pre-phase-6 baseline of 93166 bytes. Extract both new blocks into dedicated reference files: - gsd-core/references/execute-phase-wave-guard.md (step 0.5) - gsd-core/references/execute-phase-between-wave-reset.md (steps 7b + 7c) Replace inline prose with @-reference pointers. File now measures 92851 bytes (LF-normalized), satisfying the ADR-857 capstone conformance gate. Also update tests/workflow-size-baseline.json to 92851 and add both new reference files to docs/INVENTORY-MANIFEST.json. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(#1369): update regression tests to read from extracted reference files Steps 0.5 and 7b+7c were moved to reference files to satisfy the ADR-857 size cap on execute-phase.md. Tests now check @-reference pointers in the workflow for ordering and read content assertions from the reference files. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
91 lines
2.3 KiB
JSON
91 lines
2.3 KiB
JSON
{
|
|
"add-backlog.md": 7132,
|
|
"add-phase.md": 7203,
|
|
"add-tests.md": 16901,
|
|
"add-todo.md": 8952,
|
|
"ai-integration-phase.md": 14761,
|
|
"analyze-dependencies.md": 3887,
|
|
"audit-fix.md": 10988,
|
|
"audit-milestone.md": 17637,
|
|
"audit-uat.md": 7425,
|
|
"autonomous.md": 42263,
|
|
"check-todos.md": 9431,
|
|
"cleanup.md": 9897,
|
|
"code-review-fix.md": 23890,
|
|
"code-review.md": 31602,
|
|
"complete-milestone.md": 29987,
|
|
"debug.md": 13505,
|
|
"diagnose-issues.md": 12425,
|
|
"discovery-phase.md": 8651,
|
|
"discuss-phase-assumptions.md": 26984,
|
|
"discuss-phase-power.md": 11273,
|
|
"discuss-phase.md": 31990,
|
|
"do.md": 10068,
|
|
"docs-update.md": 55662,
|
|
"edit-phase.md": 12883,
|
|
"eval-review.md": 9923,
|
|
"execute-phase.md": 92851,
|
|
"execute-plan.md": 31365,
|
|
"explore.md": 10497,
|
|
"extract-learnings.md": 12849,
|
|
"fast.md": 4149,
|
|
"forensics.md": 12463,
|
|
"graduation.md": 11578,
|
|
"health.md": 11824,
|
|
"help.md": 1722,
|
|
"import.md": 14604,
|
|
"inbox.md": 14407,
|
|
"ingest-docs.md": 18336,
|
|
"insert-phase.md": 8943,
|
|
"list-phase-assumptions.md": 4305,
|
|
"list-workspaces.md": 5655,
|
|
"manager.md": 25937,
|
|
"map-codebase.md": 20789,
|
|
"milestone-summary.md": 11774,
|
|
"mvp-phase.md": 13582,
|
|
"new-milestone.md": 32422,
|
|
"new-project.md": 61802,
|
|
"new-workspace.md": 11254,
|
|
"next.md": 20094,
|
|
"node-repair.md": 4173,
|
|
"note.md": 6563,
|
|
"pause-work.md": 14397,
|
|
"plan-milestone-gaps.md": 11765,
|
|
"plan-phase.md": 93166,
|
|
"plan-review-convergence.md": 23468,
|
|
"plant-seed.md": 11741,
|
|
"pr-branch.md": 9561,
|
|
"profile-user.md": 20650,
|
|
"progress.md": 29387,
|
|
"quick.md": 48435,
|
|
"reapply-patches.md": 20393,
|
|
"remove-phase.md": 8469,
|
|
"remove-workspace.md": 7507,
|
|
"resume-project.md": 17226,
|
|
"review.md": 38031,
|
|
"scan.md": 7688,
|
|
"secure-phase.md": 12282,
|
|
"session-report.md": 4044,
|
|
"settings-advanced.md": 39666,
|
|
"settings-integrations.md": 15848,
|
|
"settings.md": 33413,
|
|
"ship.md": 24388,
|
|
"sketch-wrap-up.md": 14223,
|
|
"sketch.md": 19960,
|
|
"spec-phase.md": 30921,
|
|
"spike-wrap-up.md": 15092,
|
|
"spike.md": 24517,
|
|
"stats.md": 6718,
|
|
"sync-skills.md": 6125,
|
|
"thread.md": 12400,
|
|
"transition.md": 21787,
|
|
"ui-phase.md": 15477,
|
|
"ui-review.md": 11289,
|
|
"ultraplan-phase.md": 10468,
|
|
"undo.md": 10431,
|
|
"update.md": 21053,
|
|
"validate-phase.md": 10745,
|
|
"verify-phase.md": 37821,
|
|
"verify-work.md": 31157
|
|
}
|