f954bb4cac
* refactor(#1679): ADR-1239 Phase B — collapse is<Runtime> flag blocks into runtimeFlags [AC2 slice 3] Phase 2 AC2 slice 3. Collapses the four duplicated 'const isX = runtime === x' declaration blocks in bin/install.js (uninstall / writeManifest / install / a fourth helper — 48 of the 101 remaining runtime=== branches) into a single runtimeFlags(runtime) helper in src/runtime-name-policy.cts, sibling to getDirName / getRuntimeLabel / getGlobalConfigHomeFragment. The purest add-a-host tax: a new runtime meant remembering to add ~12 flag lines to each of four functions. Now it is one entry in RUNTIME_FLAG_IDS. - src/runtime-name-policy.cts: RUNTIME_FLAG_IDS + runtimeFlags(runtime) -> frozen map of is<Runtime> booleans (single runtime=== source, via loop). - bin/install.js: import runtimeFlags; replace the 4 declaration blocks with one destructure each. ZERO usage-site churn (flag names preserved; install.js's eslint block has no no-unused-vars rule so destructure-all is clean). - tests/runtime-flags.test.cjs: 4 tests (each runtime sets exactly its flag, claude/unknown/empty -> all false, all 15 flags present + frozen, drift guard). runtime === count: 101 -> 53 (-48). golden-install-parity 16/16 byte-identical (behavior-identical collapse). AC2 data-collapse now substantially complete; ADR-1235 agent-loop tail + per-runtime semantic residue remain (separate). * chore(changeset): add Changed fragment for runtimeFlags collapse (#1679)
751 B
751 B
type, pr
| type | pr |
|---|---|
| Changed | 1811 |
Internal: the installer's per-function is<Runtime> flag-declaration blocks are now a single runtimeFlags lookup — the four duplicated const isX = runtime === 'x' blocks in bin/install.js (uninstall / writeManager / install / a fourth helper — 48 branches) are collapsed into one runtimeFlags(runtime) helper in runtime-name-policy.cts (ADR-1239 Phase B / #1679 AC2 slice 3). The add-a-host tax for flags is removed (one RUNTIME_FLAG_IDS entry, not four declaration blocks). Install output is byte-identical for all 16 runtimes (golden-parity asserted); runtime === count in bin/install.js: 101 → 53. No user-facing change.