Files
msd-core/sdk/src/query/config-query.test.ts
Rezolv c5b1445529 feat(sdk): golden parity harness and query handler CJS alignment (#2302 Track A) (#2341)
* feat(sdk): golden parity harness and query handler CJS alignment (#2302 Track A)

Golden/read-only parity tests and registry alignment, query handler fixes
(check-completion, state-mutation, commit, validate, summary, etc.), and
WAITING.json dual-write for .gsd/.planning readers.

Refs gsd-build/get-shit-done#2341

* fix(sdk): getMilestoneInfo matches GSD ROADMAP (🟡, last bold, STATE fallback)

- Recognize in-flight 🟡 milestone bullets like 🚧.
- Derive from last **vX.Y Title** before ## Phases when emoji absent.
- Fall back to STATE.md milestone when ROADMAP is missing; use last bare vX.Y
  in cleaned text instead of first (avoids v1.0 from shipped list).
- Fixes init.execute-phase milestone_version and buildStateFrontmatter after
  state.begin-phase (syncStateFrontmatter).

* feat(sdk): phase list, plan task structure, requirements extract handlers

- Register phase.list-plans, phase.list-artifacts, plan.task-structure,
  requirements.extract-from-plans (SDK-only; golden-policy exceptions).
- Add unit tests; document in QUERY-HANDLERS.md.
- writeProfile: honor --output, render dimensions, return profile_path and dimensions_scored.

* feat(sdk): centralize getGsdAgentsDir in query helpers

Extract agent directory resolution to helpers (GSD_AGENTS_DIR, primary
~/.claude/agents, legacy path). Use from init and docs-init init bundles.

docs(15): add 15-CONTEXT for autonomous phase-15 run.

* feat(sdk): query CLI CJS fallback and session correlation

- createRegistry(eventStream, sessionId) threads correlation into mutation events
- gsd-sdk query falls back to gsd-tools.cjs when no native handler matches
  (disable with GSD_QUERY_FALLBACK=off); stderr bridge warnings
- Export createRegistry from @gsd-build/sdk; add sdk/README.md
- Update QUERY-HANDLERS.md and registry module docs for fallback + sessionId
- Agents: prefer node dist/cli.js query over cat/grep for STATE and plans

* fix(sdk): init phase_found parity, docs-init agents path, state field extract

- Normalize findPhase not-found to null before roadmap fallback (matches findPhaseInternal)

- docs-init: use detectRuntime + resolveAgentsDir for checkAgentsInstalled

- state.cjs stateExtractField: horizontal whitespace only after colon (YAML progress guard)

- Tests: commit_docs default true; config-get golden uses temp config; golden integration green

Refs: #2302

* refactor(sdk): share SessionJsonlRecord in profile-extract-messages

CodeRabbit nit: dedupe JSONL record shape for isGenuineUserMessage and streamExtractMessages.

* fix(sdk): address CodeRabbit major threads (paths, gates, audit, verify)

- Resolve @file: and CLI JSON indirection relative to projectDir; guard empty normalized query command

- plan.task-structure + intel extract/patch-meta: resolvePathUnderProject containment

- check.config-gates: safe string booleans; plan_checker alias precedence over plan_check default

- state.validate/sync: phaseTokenMatches + comparePhaseNum ordering

- verify.schema-drift: token match phase dirs; files_modified from parsed frontmatter

- audit-open: has_scan_errors, unreadable rows, human report when scans fail

- requirements PLANNED key PLAN for root PLAN.md; gsd-tools timeout note

- ingest-docs: repo-root path containment; classifier output slug-hash

Golden parity test strips has_scan_errors until CJS adds field.

* fix: Resolve CodeRabbit security and quality findings
- Secure intel.ts and cli.ts against path traversal
- Catch and validate git add status in commit.ts
- Expand roadmap milestone marker extraction
- Fix parsing array-of-objects in frontmatter YAML
- Fix unhandled config evaluations
- Improve coverage test parity mapping

* test: raise planner character extraction limit to 48K

* fix(sdk): resolve TS build error in docs-init passing config
2026-04-20 18:09:02 -04:00

162 lines
6.5 KiB
TypeScript

/**
* Unit tests for config-get and resolve-model query handlers.
*/
import { describe, it, expect, beforeEach, afterEach } from 'vitest';
import { mkdtemp, writeFile, mkdir, rm } from 'node:fs/promises';
import { join } from 'node:path';
import { tmpdir } from 'node:os';
import { GSDError } from '../errors.js';
// ─── Test setup ─────────────────────────────────────────────────────────────
let tmpDir: string;
beforeEach(async () => {
tmpDir = await mkdtemp(join(tmpdir(), 'gsd-cfg-'));
await mkdir(join(tmpDir, '.planning'), { recursive: true });
});
afterEach(async () => {
await rm(tmpDir, { recursive: true, force: true });
});
// ─── configGet ──────────────────────────────────────────────────────────────
describe('configGet', () => {
it('returns raw config value for top-level key', async () => {
const { configGet } = await import('./config-query.js');
await writeFile(
join(tmpDir, '.planning', 'config.json'),
JSON.stringify({ model_profile: 'quality' }),
);
const result = await configGet(['model_profile'], tmpDir);
expect(result.data).toBe('quality');
});
it('traverses dot-notation for nested keys', async () => {
const { configGet } = await import('./config-query.js');
await writeFile(
join(tmpDir, '.planning', 'config.json'),
JSON.stringify({ workflow: { auto_advance: true } }),
);
const result = await configGet(['workflow.auto_advance'], tmpDir);
expect(result.data).toBe(true);
});
it('throws GSDError when no key provided', async () => {
const { configGet } = await import('./config-query.js');
await expect(configGet([], tmpDir)).rejects.toThrow(GSDError);
});
it('throws GSDError for nonexistent key', async () => {
const { configGet } = await import('./config-query.js');
await writeFile(
join(tmpDir, '.planning', 'config.json'),
JSON.stringify({ model_profile: 'quality' }),
);
await expect(configGet(['nonexistent.key'], tmpDir)).rejects.toThrow(GSDError);
});
it('reads raw config without merging defaults', async () => {
const { configGet } = await import('./config-query.js');
// Write config with only model_profile -- no workflow section
await writeFile(
join(tmpDir, '.planning', 'config.json'),
JSON.stringify({ model_profile: 'balanced' }),
);
// Accessing workflow should fail (not merged with defaults)
await expect(configGet(['workflow.auto_advance'], tmpDir)).rejects.toThrow(GSDError);
});
});
// ─── resolveModel ───────────────────────────────────────────────────────────
describe('resolveModel', () => {
it('returns model and profile for known agent', async () => {
const { resolveModel } = await import('./config-query.js');
await writeFile(
join(tmpDir, '.planning', 'config.json'),
JSON.stringify({ model_profile: 'balanced' }),
);
const result = await resolveModel(['gsd-planner'], tmpDir);
const data = result.data as Record<string, unknown>;
expect(data).toHaveProperty('model');
expect(data).toHaveProperty('profile', 'balanced');
expect(data).not.toHaveProperty('unknown_agent');
});
it('returns unknown_agent flag for unknown agent', async () => {
const { resolveModel } = await import('./config-query.js');
await writeFile(
join(tmpDir, '.planning', 'config.json'),
JSON.stringify({ model_profile: 'balanced' }),
);
const result = await resolveModel(['unknown-agent'], tmpDir);
const data = result.data as Record<string, unknown>;
expect(data).toHaveProperty('model', 'sonnet');
expect(data).toHaveProperty('unknown_agent', true);
});
it('throws GSDError when no agent type provided', async () => {
const { resolveModel } = await import('./config-query.js');
await expect(resolveModel([], tmpDir)).rejects.toThrow(GSDError);
});
it('respects model_overrides from config', async () => {
const { resolveModel } = await import('./config-query.js');
await writeFile(
join(tmpDir, '.planning', 'config.json'),
JSON.stringify({
model_profile: 'balanced',
model_overrides: { 'gsd-planner': 'openai/gpt-5.4' },
}),
);
const result = await resolveModel(['gsd-planner'], tmpDir);
const data = result.data as Record<string, unknown>;
expect(data).toHaveProperty('model', 'openai/gpt-5.4');
});
it('returns empty model when resolve_model_ids is omit', async () => {
const { resolveModel } = await import('./config-query.js');
await writeFile(
join(tmpDir, '.planning', 'config.json'),
JSON.stringify({
model_profile: 'balanced',
resolve_model_ids: 'omit',
}),
);
const result = await resolveModel(['gsd-planner'], tmpDir);
const data = result.data as Record<string, unknown>;
expect(data).toHaveProperty('model', '');
});
});
// ─── MODEL_PROFILES ─────────────────────────────────────────────────────────
describe('MODEL_PROFILES', () => {
it('contains all 18 agent entries (sync with model-profiles.cjs)', async () => {
const { MODEL_PROFILES } = await import('./config-query.js');
expect(Object.keys(MODEL_PROFILES)).toHaveLength(18);
});
it('has quality/balanced/budget/adaptive for each agent', async () => {
const { MODEL_PROFILES } = await import('./config-query.js');
for (const agent of Object.keys(MODEL_PROFILES)) {
expect(MODEL_PROFILES[agent]).toHaveProperty('quality');
expect(MODEL_PROFILES[agent]).toHaveProperty('balanced');
expect(MODEL_PROFILES[agent]).toHaveProperty('budget');
expect(MODEL_PROFILES[agent]).toHaveProperty('adaptive');
}
});
});
// ─── VALID_PROFILES ─────────────────────────────────────────────────────────
describe('VALID_PROFILES', () => {
it('contains the four profile names', async () => {
const { VALID_PROFILES } = await import('./config-query.js');
expect(VALID_PROFILES).toEqual(['quality', 'balanced', 'budget', 'adaptive']);
});
});