5ad9a36f35
`review-lane plan` resolved every cross-AI reviewer lane's reasoning effort by spawning `query resolve-execution gsd-plan-checker --host <slug>`. The agent id was a hardcoded literal, so `--host` chose only the argv RENDERING while the LEVEL always came from the installed plan-checker's frontmatter — `low` under every shipped model profile. Every prompt-fed lane therefore ran at a fast structural verifier's effort, and because the rendered argument is a CLI config override it silently beat the effort the operator had configured for that CLI. At `low` a large source-grounded prompt makes a model end its turn with no final message, so the lane came back empty and its stub read as a crash. Effort is a property of the review, so the lane declares it. Two new fields on ReviewerLane — `effortConfigKey` (`review.effort.<slug>`) and `defaultEffort` — carried through each capability manifest and the generated registry, set on the three lanes with an argv effort channel and null on the other nine. A new pure `resolveLaneEffort()` resolves config key -> lane default -> nothing, where "nothing" emits no effort argument at all and the reviewer CLI's own configuration decides; `inherit` selects that path explicitly and an unrecognized level falls back to the lane default rather than being forwarded to a CLI that would reject it. The host's negotiated effortSurface still gates the rendering, so ADR-1239/#2481's trust boundary holds on this path too. Resolving in-process also removes up to twelve subprocess spawns per review. The empty-output stub now names the effort the lane ran at and distinguishes a clean exit from a timeout kill, a non-zero exit, and a process that never ran — `status` is null for both a timeout and a signal, so those were indistinguishable before. The hint is hedged: a clean empty exit is most often a model stopping short, but it is also consistent with a CLI writing its output elsewhere. Also: the capability validator now knows both fields, rejects a malformed key or an out-of-vocabulary default, and rejects a default declared without a config key (a level the operator could never override). An existing end-to-end row in tests/effort-surface-axis.test.cjs asserted the old coupling; it now configures the lane's own key and pins the decoupling in the same real spawn, with the agent execution tier set to a level that must not appear. Emitted-Drift-Ack-Growth: review.md — the effort/model resolution-order table this fix adds. The workflow is where an operator looks to find out which knob set a lane's model and effort; leaving the new key undocumented there is the same invisibility that made the plan-checker coupling survive this long. Emitted-Drift-Ack-Growth: review.md — the effort/model resolution-order table this fix adds. The workflow is where an operator looks to find out which knob set a lane's model and effort, so leaving the new key undocumented there is the same invisibility that let the plan-checker coupling survive. Claude-Session: https://claude.ai/code/session_01CRMEuzNMWn3gs5uUW2ghcF Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com> Co-authored-by: Tom Boucher <trekkie@nomorestars.com>
177 lines
5.1 KiB
JSON
177 lines
5.1 KiB
JSON
{
|
|
"id": "codex",
|
|
"role": "runtime",
|
|
"version": "1.12.0",
|
|
"title": "OpenAI Codex CLI",
|
|
"description": "OpenAI Codex CLI — shell-var command style; per-agent sandbox tiers; config.toml + hooks.json hook surface; tier-1 support.",
|
|
"tier": "core",
|
|
"requires": [],
|
|
"engines": {
|
|
"gsd": ">=1.6.0"
|
|
},
|
|
"runtime": {
|
|
"configHome": {
|
|
"kind": "dot-home",
|
|
"name": ".codex",
|
|
"env": [
|
|
"CODEX_HOME"
|
|
]
|
|
},
|
|
"localConfigDir": ".codex",
|
|
"configFormat": "toml",
|
|
"artifactLayout": {
|
|
"global": [
|
|
{
|
|
"kind": "skills",
|
|
"destSubpath": "skills",
|
|
"prefix": "gsd-",
|
|
"nesting": "flat",
|
|
"recursive": false,
|
|
"converter": "convertClaudeCommandToCodexSkill",
|
|
"home": ".agents"
|
|
},
|
|
{
|
|
"kind": "agents",
|
|
"destSubpath": "agents",
|
|
"prefix": "gsd-",
|
|
"nesting": "flat",
|
|
"recursive": false,
|
|
"converter": "convertClaudeAgentToCodexAgent"
|
|
}
|
|
],
|
|
"local": [
|
|
{
|
|
"kind": "skills",
|
|
"destSubpath": "skills",
|
|
"prefix": "gsd-",
|
|
"nesting": "flat",
|
|
"recursive": false,
|
|
"converter": "convertClaudeCommandToCodexSkill"
|
|
},
|
|
{
|
|
"kind": "agents",
|
|
"destSubpath": "agents",
|
|
"prefix": "gsd-",
|
|
"nesting": "flat",
|
|
"recursive": false,
|
|
"converter": "convertClaudeAgentToCodexAgent"
|
|
}
|
|
]
|
|
},
|
|
"triggerPrecedence": [
|
|
"skills",
|
|
"commands"
|
|
],
|
|
"commandStyle": "shell-var",
|
|
"hooksSurface": "codex-hooks-json",
|
|
"hookEvents": "claude",
|
|
"sandboxTier": "codex-agent-sandbox",
|
|
"supportTier": 1,
|
|
"installSurface": "codex-toml",
|
|
"writesSharedSettings": false,
|
|
"permissionWriter": null,
|
|
"extendedHookEvents": [
|
|
"SubagentStop",
|
|
"Stop",
|
|
"PreCompact"
|
|
],
|
|
"hostIntegration": {
|
|
"embeddingMode": "declarative",
|
|
"commandSurface": "slash-file",
|
|
"dispatch": {
|
|
"namedDispatch": true,
|
|
"nested": true,
|
|
"maxDepth": 1,
|
|
"background": true,
|
|
"subagentToolkit": "full",
|
|
"backgroundDispatch": true,
|
|
"isolation": "orchestrator-worktree",
|
|
"maxConcurrency": "undocumented"
|
|
},
|
|
"modelMode": "passive",
|
|
"hookBus": "host",
|
|
"stateIO": "filesystem",
|
|
"transport": "mcp",
|
|
"runtime": "node",
|
|
"effortSurface": "argv"
|
|
},
|
|
"orchestratorExec": {
|
|
"command": "codex",
|
|
"args": [
|
|
"exec"
|
|
],
|
|
"cwdFlag": "--cd",
|
|
"promptFlag": null,
|
|
"modelFlag": "--model"
|
|
},
|
|
"hostBehaviors": {
|
|
"reapplyCommand": "$gsd-update --reapply",
|
|
"tomlConfigInstall": true,
|
|
"cleanupSkillSidecars": true,
|
|
"agentTomlFiles": true,
|
|
"frontmatterDialect": "codex"
|
|
}
|
|
},
|
|
"reviewer": {
|
|
"slug": "codex",
|
|
"flags": [
|
|
"--codex"
|
|
],
|
|
"transport": "spawn",
|
|
"probe": {
|
|
"kind": "command-exists",
|
|
"binary": "codex"
|
|
},
|
|
"invoke": {
|
|
"binary": "codex",
|
|
"args": [
|
|
"exec",
|
|
"--ephemeral",
|
|
"{{model}}",
|
|
"{{effort}}",
|
|
"--skip-git-repo-check",
|
|
"{{output}}",
|
|
"-"
|
|
],
|
|
"promptChannel": "stdin",
|
|
"outputChannel": "file-arg",
|
|
"outputArg": "-o",
|
|
"modelArg": "--model",
|
|
"effortChannel": "argv"
|
|
},
|
|
"timeoutFloorMs": 1200000,
|
|
"timeoutConfigKey": "review.timeouts.codex",
|
|
"emptyOutput": "stub-with-stderr",
|
|
"reviewsSection": "Codex",
|
|
"evidenceClass": "source-grounded",
|
|
"requiresBinaries": [],
|
|
"promptBudgetKey": "review.max_prompt_tokens_per_reviewer.codex",
|
|
"modelConfigKey": "review.models.codex",
|
|
"effortConfigKey": "review.effort.codex",
|
|
"defaultEffort": "high",
|
|
"handler": null
|
|
},
|
|
"config": {
|
|
"review.models.codex": {
|
|
"type": "string",
|
|
"default": "",
|
|
"description": "Model passed to the Codex reviewer lane."
|
|
},
|
|
"review.max_prompt_tokens_per_reviewer.codex": {
|
|
"type": "number",
|
|
"default": -1,
|
|
"description": "Prompt-token budget for the Codex reviewer lane. Unset is -1, a sentinel: 0 is a legitimate value meaning \"do not trim this lane\", so it cannot double as \"not configured\"."
|
|
},
|
|
"review.timeouts.codex": {
|
|
"type": "number",
|
|
"default": -1,
|
|
"description": "Outer wall-clock timeout override (seconds) for the Codex reviewer lane. Unset is -1, a sentinel: 0 or a negative number is also treated as unset (a timeout has no legitimate zero/negative value), so no second sentinel is needed. Falls back to the lane's built-in timeoutFloorMs when unset."
|
|
},
|
|
"review.effort.codex": {
|
|
"type": "string",
|
|
"default": "",
|
|
"description": "Reasoning effort for the Codex reviewer lane: minimal, low, medium, high, xhigh, max, or inherit. Unset falls back to the lane's declared review default (high); inherit emits no effort argument so the CLI's own configuration decides. An unrecognized value falls back to the lane default rather than being forwarded."
|
|
}
|
|
}
|
|
}
|