* refactor(#455): implement typed surfaces to retire grep tests Production surfaces added: - hooks/managed-hooks-registry.cjs: new CJS module exporting MANAGED_HOOKS as a typed array; gsd-check-update-worker.js now requires it instead of declaring an inline array - bin/install.js: elevate inline gsdHooks to module-level GSD_UNINSTALL_HOOKS, export it alongside runtimeMap/allRuntimes (already exported) - scripts/build-hooks.js: export HOOKS_TO_COPY; guard build() behind require.main===module so tests can require the file without triggering a build - get-shit-done/bin/lib/init.cjs: add --json mode to agent-skills command, emitting typed IR { agent_type, block, skills_count } for test assertions - get-shit-done/bin/gsd-tools.cjs: wire --json flag for agent-skills dispatch Category-B source-grep migrations: - tests/managed-hooks.test.cjs: require MANAGED_HOOKS from registry, drop fs.readFileSync+regex - tests/orphaned-hooks.test.cjs: require MANAGED_HOOKS+HOOKS_TO_COPY as typed exports - tests/hooks-opt-in.test.cjs: replace gsdHooks regex-parse with GSD_UNINSTALL_HOOKS import - tests/install-minimal-hooks.test.cjs: replace gsdHooks regex-parse with GSD_UNINSTALL_HOOKS - tests/copilot-install.test.cjs: replace src.includes() checks with typed assertions on runtimeMap, allRuntimes, parseRuntimeInput, buildRuntimePromptText - tests/agent-skills.test.cjs: migrate to --json typed IR assertions pending-migration-to-typed-ir token cleared (87 of 87 files): - 78 files already had source-text-is-the-product; removed duplicate token - 5 files already used typed assertions; reclassified or annotated - 4 files required individual reclassification to source-text-is-the-product or architectural-invariant Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(#455): update workflow-guard test to typed GSD_UNINSTALL_HOOKS import; isolate HOME in runtime-launcher (D) test Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(#455): guard install.js main() behind require.main===module so the typed export is require-safe Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * docs(#455): document --json typed surfaces for agent-skills, progress, validate context Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * docs(#455): add changeset fragment for new --json surfaces Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(#455): complete grep migration for files flagged by lint-tests The branch commit 4e630d99 stripped `allow-test-rule: pending-migration-to-typed-ir` from ~80 test files without replacing their assertions or adding the correct exemption annotation. The files were NOT source-grep tests — they read .md workflow/agent/command/reference files (source-text-is-the-product) or hook source files for structural invariants (structural-regression-guard). No assertion logic was changed; only the correct allow-test-rule annotation was added to each file per CONTRIBUTING.md exception matrix. 73 files: `source-text-is-the-product` — workflow/agent/command/reference .md 7 files: `structural-regression-guard` — hook .js / bin/install.js structural checks Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: CI Rebase Check <ci@gsd-redux> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
120 lines
5.4 KiB
JavaScript
120 lines
5.4 KiB
JavaScript
// allow-test-rule: source-text-is-the-product
|
|
// Workflow .md / agent .md / command .md / reference .md files — their text
|
|
// IS what the runtime loads. Testing text content tests the deployed contract.
|
|
// Per CONTRIBUTING.md exception matrix.
|
|
|
|
/**
|
|
* GSD Tools Tests - autonomous --interactive flag
|
|
*
|
|
* Validates that the autonomous workflow and command definition
|
|
* correctly document and support the --interactive flag.
|
|
*
|
|
* Closes: #1413
|
|
*/
|
|
|
|
const { test, describe } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
|
|
describe('autonomous --interactive flag (#1413)', () => {
|
|
const workflowPath = path.join(__dirname, '..', 'get-shit-done', 'workflows', 'autonomous.md');
|
|
const commandPath = path.join(__dirname, '..', 'commands', 'gsd', 'autonomous.md');
|
|
|
|
test('command definition includes --interactive in argument-hint', () => {
|
|
const content = fs.readFileSync(commandPath, 'utf8');
|
|
assert.ok(content.includes('--interactive'), 'command should document --interactive flag');
|
|
assert.ok(content.includes('argument-hint:') && content.includes('--interactive'),
|
|
'argument-hint should include --interactive');
|
|
});
|
|
|
|
test('command definition describes interactive mode behavior', () => {
|
|
const content = fs.readFileSync(commandPath, 'utf8');
|
|
assert.ok(content.includes('discuss') && content.includes('inline'),
|
|
'command should describe discuss running inline');
|
|
assert.ok(content.includes('background'),
|
|
'command should mention background agents for plan+execute');
|
|
});
|
|
|
|
test('workflow parses --interactive flag', () => {
|
|
const content = fs.readFileSync(workflowPath, 'utf8');
|
|
assert.ok(content.includes("--interactive") && content.includes('INTERACTIVE'),
|
|
'workflow should parse --interactive into INTERACTIVE variable');
|
|
});
|
|
|
|
test('workflow uses discuss-phase skill in interactive mode', () => {
|
|
// Per #2697 the user-facing form is the hyphen invariant gsd-discuss-phase;
|
|
// the colon form was retired and is enforced absent by bug-2543 tests.
|
|
//
|
|
// Don't `.includes()` against the full file — both tokens could appear in
|
|
// unrelated sections (e.g. INTERACTIVE="" initialization + a stray
|
|
// gsd-discuss-phase mention in prose) and falsely pass. Instead, isolate
|
|
// the structural region that gates on INTERACTIVE and assert the Skill
|
|
// invocation lives inside it.
|
|
const content = fs.readFileSync(workflowPath, 'utf8');
|
|
const interactiveMarker = '**If `INTERACTIVE` is set:**';
|
|
const branchStart = content.indexOf(interactiveMarker);
|
|
assert.notStrictEqual(
|
|
branchStart, -1,
|
|
`workflow must define an explicit '${interactiveMarker}' branch`,
|
|
);
|
|
// Bound the branch by the next "**If `..." prose marker (the non-interactive
|
|
// sibling) or, failing that, the next `<step ...>`/`</step>` boundary.
|
|
const afterStart = branchStart + interactiveMarker.length;
|
|
const candidates = [
|
|
content.indexOf('**If `INTERACTIVE` is NOT set', afterStart),
|
|
content.indexOf('**If `', afterStart),
|
|
content.indexOf('</step>', afterStart),
|
|
content.indexOf('<step ', afterStart),
|
|
].filter((i) => i !== -1);
|
|
assert.ok(candidates.length > 0, 'INTERACTIVE branch must have a closing boundary');
|
|
const branchEnd = Math.min(...candidates);
|
|
const branch = content.slice(branchStart, branchEnd);
|
|
|
|
// The branch must invoke the hyphen-form Skill. Tolerate whitespace
|
|
// around `(`, `skill`, and `=` so harmless reformatting doesn't break this.
|
|
const skillCall = /Skill\(\s*skill\s*=\s*['"]gsd-discuss-phase['"]/.test(branch);
|
|
assert.ok(
|
|
skillCall,
|
|
`INTERACTIVE branch must invoke Skill(skill="gsd-discuss-phase"). Got branch:\n${branch}`,
|
|
);
|
|
});
|
|
|
|
test('workflow dispatches plan as background agent in interactive mode', () => {
|
|
const content = fs.readFileSync(workflowPath, 'utf8');
|
|
// Should have Agent() with run_in_background for plan
|
|
assert.ok(
|
|
content.includes('run_in_background') && content.includes('plan-phase'),
|
|
'workflow should dispatch plan-phase as background agent in interactive mode'
|
|
);
|
|
});
|
|
|
|
test('workflow dispatches execute as background agent in interactive mode', () => {
|
|
const content = fs.readFileSync(workflowPath, 'utf8');
|
|
assert.ok(
|
|
content.includes('run_in_background') && content.includes('execute-phase'),
|
|
'workflow should dispatch execute-phase as background agent in interactive mode'
|
|
);
|
|
});
|
|
|
|
test('workflow describes pipeline parallelism in interactive mode', () => {
|
|
const content = fs.readFileSync(workflowPath, 'utf8');
|
|
assert.ok(
|
|
content.includes('pipeline parallelism') || content.includes('Phase N+1'),
|
|
'workflow should describe overlapping discuss/execute between phases'
|
|
);
|
|
});
|
|
|
|
test('success criteria include --interactive requirements', () => {
|
|
const content = fs.readFileSync(workflowPath, 'utf8');
|
|
const criteriaMatch = content.match(/<success_criteria>([\s\S]*?)<\/success_criteria>/);
|
|
const criteria = criteriaMatch ? criteriaMatch[1] : '';
|
|
assert.ok(criteria.includes('--interactive'),
|
|
'success criteria should include --interactive requirements');
|
|
assert.ok(criteria.includes('discuss inline'),
|
|
'success criteria should mention discuss inline');
|
|
assert.ok(criteria.includes('background agents'),
|
|
'success criteria should mention background agents');
|
|
});
|
|
});
|