Files
msd-core/sdk/src/query/check-completion.test.ts
Rezolv c5b1445529 feat(sdk): golden parity harness and query handler CJS alignment (#2302 Track A) (#2341)
* feat(sdk): golden parity harness and query handler CJS alignment (#2302 Track A)

Golden/read-only parity tests and registry alignment, query handler fixes
(check-completion, state-mutation, commit, validate, summary, etc.), and
WAITING.json dual-write for .gsd/.planning readers.

Refs gsd-build/get-shit-done#2341

* fix(sdk): getMilestoneInfo matches GSD ROADMAP (🟡, last bold, STATE fallback)

- Recognize in-flight 🟡 milestone bullets like 🚧.
- Derive from last **vX.Y Title** before ## Phases when emoji absent.
- Fall back to STATE.md milestone when ROADMAP is missing; use last bare vX.Y
  in cleaned text instead of first (avoids v1.0 from shipped list).
- Fixes init.execute-phase milestone_version and buildStateFrontmatter after
  state.begin-phase (syncStateFrontmatter).

* feat(sdk): phase list, plan task structure, requirements extract handlers

- Register phase.list-plans, phase.list-artifacts, plan.task-structure,
  requirements.extract-from-plans (SDK-only; golden-policy exceptions).
- Add unit tests; document in QUERY-HANDLERS.md.
- writeProfile: honor --output, render dimensions, return profile_path and dimensions_scored.

* feat(sdk): centralize getGsdAgentsDir in query helpers

Extract agent directory resolution to helpers (GSD_AGENTS_DIR, primary
~/.claude/agents, legacy path). Use from init and docs-init init bundles.

docs(15): add 15-CONTEXT for autonomous phase-15 run.

* feat(sdk): query CLI CJS fallback and session correlation

- createRegistry(eventStream, sessionId) threads correlation into mutation events
- gsd-sdk query falls back to gsd-tools.cjs when no native handler matches
  (disable with GSD_QUERY_FALLBACK=off); stderr bridge warnings
- Export createRegistry from @gsd-build/sdk; add sdk/README.md
- Update QUERY-HANDLERS.md and registry module docs for fallback + sessionId
- Agents: prefer node dist/cli.js query over cat/grep for STATE and plans

* fix(sdk): init phase_found parity, docs-init agents path, state field extract

- Normalize findPhase not-found to null before roadmap fallback (matches findPhaseInternal)

- docs-init: use detectRuntime + resolveAgentsDir for checkAgentsInstalled

- state.cjs stateExtractField: horizontal whitespace only after colon (YAML progress guard)

- Tests: commit_docs default true; config-get golden uses temp config; golden integration green

Refs: #2302

* refactor(sdk): share SessionJsonlRecord in profile-extract-messages

CodeRabbit nit: dedupe JSONL record shape for isGenuineUserMessage and streamExtractMessages.

* fix(sdk): address CodeRabbit major threads (paths, gates, audit, verify)

- Resolve @file: and CLI JSON indirection relative to projectDir; guard empty normalized query command

- plan.task-structure + intel extract/patch-meta: resolvePathUnderProject containment

- check.config-gates: safe string booleans; plan_checker alias precedence over plan_check default

- state.validate/sync: phaseTokenMatches + comparePhaseNum ordering

- verify.schema-drift: token match phase dirs; files_modified from parsed frontmatter

- audit-open: has_scan_errors, unreadable rows, human report when scans fail

- requirements PLANNED key PLAN for root PLAN.md; gsd-tools timeout note

- ingest-docs: repo-root path containment; classifier output slug-hash

Golden parity test strips has_scan_errors until CJS adds field.

* fix: Resolve CodeRabbit security and quality findings
- Secure intel.ts and cli.ts against path traversal
- Catch and validate git add status in commit.ts
- Expand roadmap milestone marker extraction
- Fix parsing array-of-objects in frontmatter YAML
- Fix unhandled config evaluations
- Improve coverage test parity mapping

* test: raise planner character extraction limit to 48K

* fix(sdk): resolve TS build error in docs-init passing config
2026-04-20 18:09:02 -04:00

114 lines
4.7 KiB
TypeScript

/**
* Unit tests for `check.completion` (decision-routing audit §3.7).
*/
import { describe, it, expect, beforeEach, afterEach } from 'vitest';
import { mkdir, writeFile, rm } from 'node:fs/promises';
import { join } from 'node:path';
import { tmpdir } from 'node:os';
import { checkCompletion } from './check-completion.js';
describe('checkCompletion', () => {
let projectDir: string;
beforeEach(async () => {
projectDir = join(tmpdir(), `gsd-check-completion-${Date.now()}-${Math.random().toString(36).slice(2)}`);
await mkdir(join(projectDir, '.planning', 'phases'), { recursive: true });
});
afterEach(async () => {
await rm(projectDir, { recursive: true, force: true });
});
it('throws when scope arg is missing', async () => {
await expect(checkCompletion([], projectDir)).rejects.toThrow();
});
it('throws when scope is invalid', async () => {
await expect(checkCompletion(['invalid', '1'], projectDir)).rejects.toThrow();
});
it('throws when phase number is missing for phase scope', async () => {
await expect(checkCompletion(['phase'], projectDir)).rejects.toThrow();
});
describe('phase scope', () => {
it('returns complete true when all plans have summaries', async () => {
const phaseDir = join(projectDir, '.planning', 'phases', '01-foundation');
await mkdir(phaseDir, { recursive: true });
await writeFile(join(phaseDir, '01-01-PLAN.md'), '---\nphase: 1\n---\n', 'utf-8');
await writeFile(join(phaseDir, '01-02-PLAN.md'), '---\nphase: 1\n---\n', 'utf-8');
await writeFile(join(phaseDir, '01-01-SUMMARY.md'), '# Summary', 'utf-8');
await writeFile(join(phaseDir, '01-02-SUMMARY.md'), '# Summary', 'utf-8');
const { data } = await checkCompletion(['phase', '1'], projectDir);
const d = data as Record<string, unknown>;
expect(d.complete).toBe(true);
expect(d.plans_total).toBe(2);
expect(d.plans_with_summaries).toBe(2);
expect((d.missing_summaries as string[]).length).toBe(0);
});
it('returns complete false when not all plans have summaries', async () => {
const phaseDir = join(projectDir, '.planning', 'phases', '02-core');
await mkdir(phaseDir, { recursive: true });
await writeFile(join(phaseDir, '02-01-PLAN.md'), '---\nphase: 2\n---\n', 'utf-8');
await writeFile(join(phaseDir, '02-02-PLAN.md'), '---\nphase: 2\n---\n', 'utf-8');
await writeFile(join(phaseDir, '02-01-SUMMARY.md'), '# Summary', 'utf-8');
const { data } = await checkCompletion(['phase', '2'], projectDir);
const d = data as Record<string, unknown>;
expect(d.complete).toBe(false);
expect(d.plans_total).toBe(2);
expect(d.plans_with_summaries).toBe(1);
expect((d.missing_summaries as string[]).length).toBe(1);
});
it('includes debt rollup fields', async () => {
const phaseDir = join(projectDir, '.planning', 'phases', '03-api');
await mkdir(phaseDir, { recursive: true });
const { data } = await checkCompletion(['phase', '3'], projectDir);
const d = data as Record<string, unknown>;
const debt = d.debt as Record<string, unknown>;
expect(debt).toBeDefined();
expect(typeof debt.uat_gaps).toBe('number');
expect(typeof debt.verification_failures).toBe('number');
expect(typeof debt.human_needed).toBe('boolean');
});
it('returns verification_status from VERIFICATION.md when present', async () => {
const phaseDir = join(projectDir, '.planning', 'phases', '04-ui');
await mkdir(phaseDir, { recursive: true });
await writeFile(join(phaseDir, '04-01-PLAN.md'), '---\nphase: 4\n---\n', 'utf-8');
await writeFile(join(phaseDir, '04-01-SUMMARY.md'), '# Summary', 'utf-8');
await writeFile(
join(phaseDir, 'VERIFICATION.md'),
'---\nstatus: passed\n---\n\n| ID | Description | Status |\n|---|---|---|\n| T-01 | Auth works | PASS |',
'utf-8',
);
const { data } = await checkCompletion(['phase', '4'], projectDir);
const d = data as Record<string, unknown>;
expect(d.verification_status).not.toBeNull();
});
});
describe('milestone scope', () => {
it('returns milestone completion fields', async () => {
await writeFile(
join(projectDir, '.planning', 'ROADMAP.md'),
'# Roadmap\n\n## Phase 01: Foundation\n\n## Phase 02: Core\n',
'utf-8',
);
const { data } = await checkCompletion(['milestone', 'v1.0'], projectDir);
const d = data as Record<string, unknown>;
expect(typeof d.complete).toBe('boolean');
expect(typeof d.phase_count).toBe('number');
expect(typeof d.phases_complete).toBe('number');
expect(Array.isArray(d.phases_incomplete)).toBe(true);
});
});
});