* chore(#604): rename get-shit-done/ runtime directory to gsd-core/ Renames the installed runtime directory `get-shit-done/` to `gsd-core/` so the on-disk name matches the package (`@opengsd/gsd-core`), repo, and binary (`gsd-tools`). The npm package name and binary are unchanged; npx/npm consumers are unaffected. Mechanical (bulk, ~90% of the diff): - `git mv get-shit-done gsd-core` - Swept path/identifier references across the repo via `perl -pe 's/get-shit-done(?!-\w)/gsd-core/g'`. The negative lookahead preserves the five legitimate slug variants that are NOT the directory: get-shit-done-{OLD,cc,classic,cli,redux} (old package/repo names). - Build/manifest wiring: package.json (bin, files, coverage globs), tsconfig.build.json (outDir), ~86 .gitignore build-output entries, stryker.config.mjs, scan-ignore files, install.js path strings. - Frozen (not rewritten): CHANGELOG.md history; translated docs (README.<locale>.md and docs/{ja-JP,ko-KR,pt-BR,zh-CN}/). New logic (review here): - src/installer-migrations/003-rename-get-shit-done-to-gsd-core.cts: a proper ADR-0008 installer migration. On upgrade it walks the legacy `~/.claude/get-shit-done/` tree, classifies each file via the prior install manifest, and emits remove-managed / backup-and-remove for managed files while PRESERVING unknown user-added files. Symlink-safe (skips a symlinked root and symlinked entries; bounds-checks every path under configDir). The framework rolls back on install failure. Emptied dirs may remain (framework has no recursive dir-removal primitive) — documented. - scripts/lint-legacy-dir-name.cjs: CI regression guard forbidding the bare `get-shit-done` directory token (split token to avoid self-match; case- insensitive; `(?!-\w)` lookahead allows the slug variants; allowlists CHANGELOG, translated docs, and `gsd-allow-legacy-name` marker lines). Wired into the lint-tests CI job. - Restored scripts/lint-package-identity-drift.cjs detection regexes (the mechanical sweep had wrongly rewritten the old-name patterns it exists to detect) and marked them as intentional legacy references. - TDD tests for the migration and the guard; do.md slash-command guard regex tightened so a `/gsd-core/bin` path segment is not mistaken for a command; changeset + docs/installer-migrations.md row added. Breaking: the installed runtime path moves `~/.claude/get-shit-done/` -> `~/.claude/gsd-core/`. Migration 003 removes the stale legacy dir's managed files (preserving user files) on upgrade. Users with custom hooks/configs hardcoding the old path must update them. Closes #604 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): unsweep pending changesets + allowlist injection-example docs CI fixes for the rename PR: - Do not sweep pending .changeset/*.md (ephemeral release-note fragments, like CHANGELOG); reverted those body edits so 5 pre-existing malformed fragments (missing type/pr) no longer enter the PR diff and trip docs-lint. Allowlisted .changeset/ in the legacy-name guard accordingly. - Allowlisted TEST-EXAMPLES.md and docs/explanation/security-model.md in prompt-injection-scan.sh: they contain intentional injection examples / security-model prose; the path-reference rewrites are kept. CodeQL alerts on this PR are pre-existing (alert lines unchanged by this PR; none in the new migration/guard) and are out of scope for the rename. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): resolve CodeQL alerts surfaced on this PR The rename diff touched files carrying pre-existing CodeQL findings; per the no-pre-existing-dismissal rule, fixing every surfaced alert rather than waving them off. All behavior-preserving: - scripts/ci-test-scope.cjs: build the config-path match from string .includes() instead of a RegExp over an arg-derived value (js/regex-injection). - src/profile-output.cts: escape backslashes before pipe-escaping desc/safeName so the table-cell escape is complete (js/incomplete-sanitization). - tests/{bug-2643,bug-2808,docs-parity-live-registry}: two-pass HTML-comment strip so a bare/unclosed `<!--` cannot survive (js/incomplete-multi-character-sanitization). - tests/inline-plan-threshold: drop the no-op `\s`->`\s` identity replace, keep the meaningful POSIX-class conversion (js/identity-replacement). Verified: build:lib green; the touched test files + ci-test-scope + profile-output suites pass; lint:legacy-name clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): correctly resolve remaining CodeQL alerts (regex-injection + sanitization) The prior commit's fixes for two alerts were ineffective: - ci-test-scope.cjs js/regex-injection: the alert is the CLI-arg-derived `file` reaching static regex `.test(file)` calls (not the config rule). Removed ALL regex over file/t — startsWith/includes/=== string checks + an isWindowsHint helper — so there is no regex sink for the tainted value. - js/incomplete-multi-character-sanitization (3 test files): a single `.replace(/<!--...-->/g,'')` can let `<!--` re-form. Replaced with a fixpoint loop (replace until stable) plus a final bare-opener strip. Verified: no regex over file/t remains; ci-test-scope + the 3 test suites pass; lint:legacy-name clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): make ci-test-scope + comment-strippers regex-free to clear CodeQL CodeQL flags the regex PATTERNS syntactically (regex-injection on the --files arg split; incomplete-multi-character-sanitization on the <!--...--> replace), so loop fixes do not satisfy it. Made these paths regex-free: - ci-test-scope.cjs splitFiles: char-by-char separator tokenizer (no /[,\\s]+/). - 3 test files: indexOf/slice HTML-comment stripper (no .replace(/<!--/)). Behavior preserved; ci-test-scope + the 3 suites pass; guard clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): unblock security base64 scan on the large rename diff The security job hit its 10m timeout: base64-scan.sh choked on the binary test fixture tests/feat-3594-parser-property-style.test.cjs (embedded NUL/ non-UTF8 bytes -> thousands of bogus blobs + "ignored null byte" warnings), and the ~800-file rename diff is slow to scan regardless. - scripts/base64-scan.sh: skip binary-by-content files (grep -Iq .) — they can't carry base64-obfuscated *text* and feeding NUL bytes through the per-line scanner is pathologically slow. collect_files already filtered binary *extensions*; this catches binary *content* in text extensions. - .github/workflows/security-scan.yml: raise the security job timeout 10m->30m to accommodate very large diffs (the scan itself is unchanged). Verified locally: scan skips the fixture, 0 "ignored null byte" warnings, 0 findings, exit 0. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): sweep get-shit-done refs introduced by merging next The branch was updated with next (#614/#384/#618 etc.), which reference the get-shit-done/ dir (still named that on next). Swept the stale references in the merged files to gsd-core so the rename stays consistent and lint:legacy-name passes: - commands/gsd/discuss-phase.md (runtime-launcher shim paths) - src/core.cts (getAgentsDir layout comments) - tests/bug-384-agents-runtime-aware.test.cjs (require path to runtime lib) Verified: guard 0 violations; build green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): exclude gsd-core/ path segments from bug-3683 command cross-ref invariant The #614 runtime-launcher shim added to discuss-phase.md references `${_GSD_RUNTIME_ROOT}/gsd-core/bin/...`. bug-3683's REF_PATTERN excluded path-y refs only via lookbehind, but `}` precedes `/gsd-core/` in the shim, so it mis-read the directory path as a dangling `/gsd-core` command ref (same class as the #604 bug-2954 fix). Added a trailing `(?![\w-]*\/)` so `/gsd-<x>/...` path segments are not treated as slash-command references. Verified locally on BOTH platforms before pushing: - mac (node 26) full suite: 0 failures - gsd-test-runner (linux, node22 image) full suite: 0 failures - bug-3683 + bug-2954 pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): lazily resolve findProjectRoot in gsd-tools (harden flaky CI) CI intermittently failed state.test's gsd-tools subprocess with "findProjectRoot is not a function" (flip-flopping across legs; not reproducible on mac full suite, gsd-test linux full suite, test:unit, or state.test x8). findProjectRoot is a re-export from core.cjs (sourced from project-root.cjs); binding it via destructure at module-load can be undefined under a load-ordering edge. Resolve it lazily at call time via a small wrapper so the lookup happens after core.cjs is fully initialized. Verified green on BOTH platforms before pushing: - mac (node 26) full suite: 0 failures - gsd-test-runner (linux, node22) full suite: 0 failures - state.test.cjs: 106/106; gsd-tools loads cleanly. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): allowlist verification-patterns.md placeholder examples in secret scan The rename git-mv'd references/verification-patterns.md into gsd-core/, pulling it into the secret-scan diff. It documents stub/placeholder RED-FLAG env-var examples (illustrative Stripe test-key / database-URL / API-key placeholders) — not real credentials. Added it to .secretscanignore with the strict annotation, mirroring the existing gsd-core/workflows/plan-phase.md exception. Verified locally: secret-scan-lint --strict OK; secret-scan --diff origin/next exits 0 with 0 findings. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
272 lines
9.4 KiB
JavaScript
272 lines
9.4 KiB
JavaScript
// allow-test-rule: source-text-is-the-product
|
|
// Workflow .md / agent .md / command .md / reference .md files — their text
|
|
// IS what the runtime loads. Testing text content tests the deployed contract.
|
|
// Per CONTRIBUTING.md exception matrix.
|
|
|
|
/**
|
|
* GSD Forensics Tests
|
|
*
|
|
* Validates the forensics command and workflow files exist,
|
|
* follow expected patterns, and cover all anomaly detection types.
|
|
*/
|
|
|
|
const { test, describe, beforeEach, afterEach } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
const os = require('os');
|
|
const { cleanup } = require('./helpers.cjs');
|
|
|
|
const repoRoot = path.resolve(__dirname, '..');
|
|
const commandPath = path.join(repoRoot, 'commands', 'gsd', 'forensics.md');
|
|
const workflowPath = path.join(repoRoot, 'gsd-core', 'workflows', 'forensics.md');
|
|
|
|
describe('forensics command', () => {
|
|
test('command file exists', () => {
|
|
assert.ok(fs.existsSync(commandPath), 'commands/gsd/forensics.md should exist');
|
|
});
|
|
|
|
test('command has correct frontmatter', () => {
|
|
const content = fs.readFileSync(commandPath, 'utf-8');
|
|
assert.ok(content.includes('name: gsd:forensics'), 'should have correct command name');
|
|
assert.ok(content.includes('type: prompt'), 'should have type: prompt');
|
|
assert.ok(content.includes('argument-hint'), 'should have argument-hint');
|
|
});
|
|
|
|
test('command references workflow in execution_context', () => {
|
|
const content = fs.readFileSync(commandPath, 'utf-8');
|
|
assert.ok(
|
|
content.includes('workflows/forensics.md'),
|
|
'should reference the forensics workflow'
|
|
);
|
|
});
|
|
|
|
test('command has success_criteria section', () => {
|
|
const content = fs.readFileSync(commandPath, 'utf-8');
|
|
assert.ok(content.includes('<success_criteria>'), 'should have success_criteria');
|
|
});
|
|
|
|
test('command has critical_rules section', () => {
|
|
const content = fs.readFileSync(commandPath, 'utf-8');
|
|
assert.ok(content.includes('<critical_rules>'), 'should have critical_rules');
|
|
});
|
|
|
|
test('command enforces read-only investigation', () => {
|
|
const content = fs.readFileSync(commandPath, 'utf-8');
|
|
assert.ok(
|
|
content.toLowerCase().includes('read-only') || content.toLowerCase().includes('do not modify'),
|
|
'should enforce read-only investigation'
|
|
);
|
|
});
|
|
|
|
test('command requires evidence-grounded findings', () => {
|
|
const content = fs.readFileSync(commandPath, 'utf-8');
|
|
assert.ok(
|
|
content.includes('Ground findings') || content.includes('cite specific'),
|
|
'should require evidence-grounded analysis'
|
|
);
|
|
});
|
|
});
|
|
|
|
describe('forensics workflow', () => {
|
|
test('workflow file exists', () => {
|
|
assert.ok(fs.existsSync(workflowPath), 'workflows/forensics.md should exist');
|
|
});
|
|
|
|
test('workflow gathers evidence from all data sources', () => {
|
|
const content = fs.readFileSync(workflowPath, 'utf-8');
|
|
const sources = [
|
|
'git log',
|
|
'git status',
|
|
'STATE.md',
|
|
'ROADMAP.md',
|
|
'PLAN.md',
|
|
'SUMMARY.md',
|
|
'VERIFICATION.md',
|
|
'SESSION_REPORT',
|
|
'worktree',
|
|
];
|
|
for (const source of sources) {
|
|
assert.ok(
|
|
content.includes(source),
|
|
`workflow should reference data source: ${source}`
|
|
);
|
|
}
|
|
});
|
|
|
|
test('workflow detects all 6 anomaly types', () => {
|
|
const content = fs.readFileSync(workflowPath, 'utf-8');
|
|
const anomalies = [
|
|
'Stuck Loop',
|
|
'Missing Artifact',
|
|
'Abandoned Work',
|
|
'Crash',
|
|
'Scope Drift',
|
|
'Test Regression',
|
|
];
|
|
for (const anomaly of anomalies) {
|
|
assert.ok(
|
|
content.includes(anomaly),
|
|
`workflow should detect anomaly: ${anomaly}`
|
|
);
|
|
}
|
|
});
|
|
|
|
test('workflow writes report to forensics directory', () => {
|
|
const content = fs.readFileSync(workflowPath, 'utf-8');
|
|
assert.ok(
|
|
content.includes('.planning/forensics/report-'),
|
|
'should write to .planning/forensics/'
|
|
);
|
|
});
|
|
|
|
test('workflow includes redaction rules', () => {
|
|
const content = fs.readFileSync(workflowPath, 'utf-8');
|
|
assert.ok(
|
|
content.includes('Redaction') || content.includes('redact'),
|
|
'should include data redaction rules'
|
|
);
|
|
});
|
|
|
|
test('workflow offers interactive investigation', () => {
|
|
const content = fs.readFileSync(workflowPath, 'utf-8');
|
|
assert.ok(
|
|
content.includes('dig deeper') || content.includes('Interactive'),
|
|
'should offer interactive follow-up'
|
|
);
|
|
});
|
|
|
|
test('workflow offers GitHub issue creation', () => {
|
|
const content = fs.readFileSync(workflowPath, 'utf-8');
|
|
assert.ok(
|
|
content.includes('gh issue create'),
|
|
'should offer to create GitHub issue from findings'
|
|
);
|
|
});
|
|
|
|
test('workflow submits issues to open-gsd/gsd-core, not the current repo', () => {
|
|
const content = fs.readFileSync(workflowPath, 'utf-8');
|
|
// Scope check to the gh issue create invocation — a whole-file search would
|
|
// pass even if gh issue create lacked --repo, because gh label list also
|
|
// contains the repo string.
|
|
assert.match(
|
|
content,
|
|
/gh issue create[\s\S]{0,250}--repo\s+open-gsd\/gsd-core/,
|
|
'gh issue create must use --repo open-gsd/gsd-core to avoid submitting to the user\'s current project repo'
|
|
);
|
|
});
|
|
|
|
test('workflow checks bug label in open-gsd/gsd-core, not the current repo', () => {
|
|
const content = fs.readFileSync(workflowPath, 'utf-8');
|
|
// Regex is more robust than a fixed-length slice to formatting changes
|
|
assert.match(
|
|
content,
|
|
/gh label list[\s\S]{0,250}--repo\s+open-gsd\/gsd-core/,
|
|
'gh label list must target open-gsd/gsd-core'
|
|
);
|
|
});
|
|
|
|
test('workflow updates STATE.md', () => {
|
|
const content = fs.readFileSync(workflowPath, 'utf-8');
|
|
assert.ok(
|
|
content.includes('state record-session') || content.includes('state.record-session'),
|
|
'should update STATE.md via state record-session (CJS or gsd-sdk query)'
|
|
);
|
|
});
|
|
|
|
test('workflow has confidence levels for anomalies', () => {
|
|
const content = fs.readFileSync(workflowPath, 'utf-8');
|
|
assert.ok(
|
|
content.includes('HIGH') && content.includes('MEDIUM') && content.includes('LOW'),
|
|
'anomalies should have confidence levels'
|
|
);
|
|
});
|
|
});
|
|
|
|
describe('forensics report structure', () => {
|
|
test('report template has all required sections', () => {
|
|
const content = fs.readFileSync(workflowPath, 'utf-8');
|
|
const sections = [
|
|
'Evidence Summary',
|
|
'Git Activity',
|
|
'Planning State',
|
|
'Artifact Completeness',
|
|
'Anomalies Detected',
|
|
'Root Cause Hypothesis',
|
|
'Recommended Actions',
|
|
];
|
|
for (const section of sections) {
|
|
assert.ok(
|
|
content.includes(section),
|
|
`report should include section: "${section}"`
|
|
);
|
|
}
|
|
});
|
|
|
|
test('report includes artifact completeness table', () => {
|
|
const content = fs.readFileSync(workflowPath, 'utf-8');
|
|
assert.ok(
|
|
content.includes('PLAN') && content.includes('CONTEXT') && content.includes('RESEARCH') &&
|
|
content.includes('SUMMARY') && content.includes('VERIFICATION'),
|
|
'artifact table should check all 5 artifact types'
|
|
);
|
|
});
|
|
});
|
|
|
|
describe('forensics fixture-based tests', () => {
|
|
let tmpDir;
|
|
|
|
beforeEach(() => {
|
|
tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'gsd-forensics-test-'));
|
|
});
|
|
|
|
afterEach(() => {
|
|
cleanup(tmpDir);
|
|
});
|
|
|
|
test('detects missing artifacts in phase structure', () => {
|
|
// Phase 1: complete
|
|
const phase1 = path.join(tmpDir, '.planning', 'phases', '01-setup');
|
|
fs.mkdirSync(phase1, { recursive: true });
|
|
fs.writeFileSync(path.join(phase1, '01-PLAN-A.md'), 'plan');
|
|
fs.writeFileSync(path.join(phase1, '01-SUMMARY.md'), 'summary');
|
|
fs.writeFileSync(path.join(phase1, '01-VERIFICATION.md'), 'verification');
|
|
|
|
// Phase 2: missing SUMMARY and VERIFICATION (anomaly)
|
|
const phase2 = path.join(tmpDir, '.planning', 'phases', '02-core');
|
|
fs.mkdirSync(phase2, { recursive: true });
|
|
fs.writeFileSync(path.join(phase2, '02-PLAN-A.md'), 'plan');
|
|
|
|
// Verify detection
|
|
const p1Files = fs.readdirSync(phase1);
|
|
const p2Files = fs.readdirSync(phase2);
|
|
|
|
assert.ok(p1Files.some(f => f.includes('SUMMARY')), 'phase 1 has SUMMARY');
|
|
assert.ok(p1Files.some(f => f.includes('VERIFICATION')), 'phase 1 has VERIFICATION');
|
|
assert.ok(!p2Files.some(f => f.includes('SUMMARY')), 'phase 2 missing SUMMARY (anomaly)');
|
|
assert.ok(!p2Files.some(f => f.includes('VERIFICATION')), 'phase 2 missing VERIFICATION (anomaly)');
|
|
});
|
|
|
|
test('forensics report directory can be created', () => {
|
|
const forensicsDir = path.join(tmpDir, '.planning', 'forensics');
|
|
fs.mkdirSync(forensicsDir, { recursive: true });
|
|
const reportPath = path.join(forensicsDir, 'report-20260321-150000.md');
|
|
fs.writeFileSync(reportPath, '# Forensic Report\n');
|
|
|
|
assert.ok(fs.existsSync(reportPath), 'report file should be created');
|
|
const content = fs.readFileSync(reportPath, 'utf-8');
|
|
assert.ok(content.includes('Forensic Report'), 'report should have header');
|
|
});
|
|
|
|
test('handles project with no .planning directory', () => {
|
|
// No .planning/ at all
|
|
const planningExists = fs.existsSync(path.join(tmpDir, '.planning'));
|
|
assert.strictEqual(planningExists, false, 'no .planning/ should exist');
|
|
|
|
// Forensics should still work with git data
|
|
const forensicsDir = path.join(tmpDir, '.planning', 'forensics');
|
|
fs.mkdirSync(forensicsDir, { recursive: true });
|
|
assert.ok(fs.existsSync(forensicsDir), 'forensics dir created on demand');
|
|
});
|
|
});
|