5b5d473e13
Phase 1 of #3464. Removes the `// allow-test-rule:` marker from 22 test files where it is provably vestigial, and tightens the ratchet ceiling in scripts/lint-allow-test-rule-refs.ceiling.json from 305 to 285. Eligibility is decided by two independent AST discriminators, both conservative (any doubt => keep): (a) Read-target type. Every readFileSync/readFile call in the file resolves statically to a prose/config extension (.md/.json/.yml/.yaml/.toml/.txt), or the file performs no reads at all. Any read of a source extension (.cjs/.js/.mjs/.ts/.cts/.mts/.jsx/.tsx), any dynamic/unresolvable path, and any other extension all disqualify the file. (b) Marker context. Every `allow-test-rule:` occurrence is a genuine comment node, never string- or template-literal payload. A marker that lives inside a RuleTester `code:` fixture is test DATA, not a suppression directive; stripping it corrupts the test. tests/eslint-rules.test.cjs is the one such fixture host and is deliberately untouched. An earlier attempt at this phase classified markers by "strip it and see if local/no-source-grep still passes" and was reverted in full before commit. That oracle is unsound: the rule only fires on a literal .cjs/.js/.ts path containing a quoted bin/lib/gsd-core/src segment, tracked one hop from the binding, so files that genuinely source-grep real JavaScript pass it silently -- tests/no-unbounded-spawn-allowlist.test.cjs (reads test sources through a listTestFiles() walk) and tests/claude-imperative-reference.test.cjs (matches bin/install.js through an intermediate variable) both cleared it while being real source-greps. The rule's implementation is narrower than its intent, so it cannot adjudicate whether an exemption is load-bearing. Scope is limited to comment deletions: the diff over the test tree is 100% line removals with zero insertions, and no executable line is altered. On the ceiling value. The measured count at this HEAD is 283, so 285 leaves 2 slack -- deliberate, and well inside the documented grace band of 3. Pinning the ceiling to the exact count makes this change effectively unmergeable: any concurrent PR that lands one marker-bearing test file re-reds it. That race fired twice while preparing this branch (once mid-rebase taking the count 304->305 on next, once between rebase and the verification run taking it 282->283), and it is the same race that broke next in #3461. A ceiling of actual+2 preserves a merge window while still ratcheting 305 -> 285. Known limit, disclosed rather than papered over: this clears 22 of 303 markers and does not reach #3464's trend-to-zero goal. Most of the remaining markers sit on dynamic-path reads, commonly a hoisted `const p = path.join(tmpDir, 'STATE.md')` whose target is prose but is unresolvable to this classifier. A stricter one-hop const resolution would flip an estimated 95 more; that is deliberately left to a follow-up so it can be reviewed on its own evidence. Marker discovery reads bytes rather than shelling out to grep: tests/security-prompt-injection.security.test.cjs carries a literal NUL byte (an intentional injection fixture) that makes grep treat it as binary and skip it, which is why the true marked-file count is 303 and not the 302 a shell scan reports. Closes #3465 Co-authored-by: sim <sim@local> Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
75 lines
2.6 KiB
JavaScript
75 lines
2.6 KiB
JavaScript
// ~/.gsd/defaults.json is machine-wide. The `runtime` key is host-specific
|
|
// (written by whichever installer ran last). It must NOT be copied into project
|
|
// configs — on a machine with 2+ runtimes, it poisons every new project.
|
|
|
|
'use strict';
|
|
|
|
const { describe, test, beforeEach, afterEach } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('node:fs');
|
|
const path = require('node:path');
|
|
const { runGsdTools, createTempDir, cleanup } = require('./helpers.cjs');
|
|
|
|
describe('#2840 — runtime from defaults.json must not poison project config', () => {
|
|
let tmpDir;
|
|
|
|
beforeEach(() => {
|
|
tmpDir = createTempDir('cfg-runtime-');
|
|
fs.mkdirSync(path.join(tmpDir, '.planning'), { recursive: true });
|
|
});
|
|
|
|
afterEach(() => {
|
|
cleanup(tmpDir);
|
|
});
|
|
|
|
test('runtime key in defaults.json is NOT copied into the new project config', () => {
|
|
// Create ~/.gsd/defaults.json with a runtime key + a legitimate key
|
|
fs.mkdirSync(path.join(tmpDir, '.gsd'), { recursive: true });
|
|
fs.writeFileSync(
|
|
path.join(tmpDir, '.gsd', 'defaults.json'),
|
|
JSON.stringify({ runtime: 'codex', model_profile: 'opus' }),
|
|
);
|
|
|
|
const result = runGsdTools('config-ensure-section', tmpDir, {
|
|
HOME: tmpDir,
|
|
USERPROFILE: tmpDir,
|
|
});
|
|
assert.ok(result.success, `Command failed: ${result.error}`);
|
|
|
|
const config = JSON.parse(
|
|
fs.readFileSync(path.join(tmpDir, '.planning', 'config.json'), 'utf8'),
|
|
);
|
|
// runtime must NOT be in the project config — it's host-specific.
|
|
assert.ok(
|
|
!('runtime' in config),
|
|
`runtime must not be copied from defaults.json into the project config; got: ${JSON.stringify({ runtime: config.runtime })}`,
|
|
);
|
|
// Other defaults must still be copied.
|
|
assert.strictEqual(
|
|
config.model_profile,
|
|
'opus',
|
|
'legitimate defaults (model_profile) must still be copied from defaults.json',
|
|
);
|
|
});
|
|
|
|
test('defaults.json without a runtime key works normally', () => {
|
|
fs.mkdirSync(path.join(tmpDir, '.gsd'), { recursive: true });
|
|
fs.writeFileSync(
|
|
path.join(tmpDir, '.gsd', 'defaults.json'),
|
|
JSON.stringify({ model_profile: 'haiku' }),
|
|
);
|
|
|
|
const result = runGsdTools('config-ensure-section', tmpDir, {
|
|
HOME: tmpDir,
|
|
USERPROFILE: tmpDir,
|
|
});
|
|
assert.ok(result.success, `Command failed: ${result.error}`);
|
|
|
|
const config = JSON.parse(
|
|
fs.readFileSync(path.join(tmpDir, '.planning', 'config.json'), 'utf8'),
|
|
);
|
|
assert.strictEqual(config.model_profile, 'haiku');
|
|
assert.ok(!('runtime' in config), 'runtime should not appear when defaults.json lacks it');
|
|
});
|
|
});
|