Files
msd-core/tests/progress-mvp-display.test.cjs
Tom Boucher 69e7afd0c7 chore(#3212): bounded quantifiers over document content — prohibition with teeth — Phase 4 (#3441)
* feat(#3415): ship local/no-unbounded-quantifier, burn down ReDoS class

Phase 4 of epic #3212 (ADR-3212 §5/§7, the final phase). New rule flags
an unbounded */+/{n,} quantifier over a broad character class
([\s\S], dotAll ., or a 1-2-unit negated class like [^\n]/[^)\n] — the
exact #2128-fixed shape) applied to a regex whose match target is
data-flow-traced to readFileSync content.

eslint-rules/lib/readfilesync-trace.cjs extracts the data-flow tracer
shared with no-crlf-fragile-split (Phase 2) rather than a second copy
— no-crlf-fragile-split refactored onto it with zero behavior change,
parity-tested.

Real triage, not 798 mechanical edits: the ADR's census (2026-08-08)
screened every unbounded quantifier in the tree unscoped. Correctly
scoped to readFileSync-derived content (matching Phase 2's own G2/G3
scoping), the rule found 162 real hits across two detection waves — the
second wave (93) surfaced only after a genuine off-by-one bug in this
rule's own first draft was caught while writing its RuleTester tests
and fixed (the bug silently missed every directly-quantified [\s\S]*
with no gap before the quantifier — exactly the class this rule exists
to catch). 3 hits landed in production src/ (commands.cts, milestone.cts,
roadmap.cts) and were each empirically timed against adversarial input
(matching #2128's own measured-not-assumed precedent) — all confirmed
linear-time/benign, left unbounded with a measured-evidence comment
rather than mechanically bounded. The remaining 159 are test-file
fixture parsing (test-author-controlled, fixed-size content, not
adversarial input) — each suppressed with a specific, non-generic
reason. Zero functional behavior changed anywhere in this diff.

tests/no-pending-3212-markers.test.cjs locks the epic's own closing
invariant (ADR §7: "assert zero pending #3212 markers remain") — ground
truth confirmed trivially true today (no phase left any such marker
behind), now regression-locked going forward.

Design: .gsd/phase/chore-3415-prohibition-with-teeth/40-design.md
Test matrix: .gsd/phase/chore-3415-prohibition-with-teeth/50-test-matrix.md

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

* fix(#3415): correct rule category mislabel, add CI test-scope entry

An orthogonal Standards-axis review found eslint-rules/no-unbounded-quantifier.cjs
mistakenly carried meta.docs.category: 'Portability', copied from a sibling
rule without realizing what that implied: docs/contributing/cross-platform-
portability-rules.md governs an ADR-1703 rule family under a hard "zero
escape hatches" contract (tests/portability-rule-disable-ban.test.cjs's
PROTECTED_RULES bans eslint-disable for those rules entirely). This rule is
not part of that family — it's ADR-3212 (ReDoS/CWE-1333), a different epic —
and its eslint-disable-next-line suppressions (159 of them, added earlier
this same phase after empirical benign-verification) are an intentional,
correct design, not a bypass. Corrected to category: 'Best Practices',
matching the actual precedent (no-adhoc-regex-escape.cjs, Phase 1 of the
same epic, which is also correctly outside PROTECTED_RULES), and the rule's
own docstring now states this explicitly so a future reader doesn't have to
re-derive it.

Also registers a new scripts/ci-test-scope.cjs bucket so editing this rule
or the shared eslint-rules/lib/readfilesync-trace.cjs helper re-runs their
own test suites under targeted CI selection — was previously unregistered
and invisible to that fast-path (this PR's own gsd-test checkpoint runs the
full suite regardless, so this only affects future narrowly-scoped PRs).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

* fix(#3415): bound no-unbounded-quantifier's own scanner (CWE-1333, ironic)

Security review found the rule meant to catch algorithmic-complexity bugs
had one of its own: hasUnboundedBroadQuantifier's negated-class inner
scan walked from each `[^` occurrence to the next `]` (or EOF) with no
bound, while the outer loop only ever advanced by one character — O(n²)
total work on a pattern with many unclosed `[^` runs. Runs unconditionally
inside checkPattern on any `new RegExp('literal string')` argument in any
linted file, before the (cheap) readFileSync data-flow gate — so a single
crafted string literal, no valid regex syntax required, could make
`npm run lint` / CI hang.

Empirically confirmed both the bug and the fix: pre-fix, n=4000/8000/
16000/32000 chars took 30.8/115.6/463.8/1874.3ms (~4x work per 2x n,
quadratic); extrapolated, the 300000-char repro from the finding would
run ~165s. Post-fix (bail the inner scan once units exceeds the rule's
own 1-2-unit scope, rather than continuing to hunt for a closing `]`),
the same 300000-char input runs in 8.7ms via the real rule module,
independently reconfirmed at 18ms via a fresh Linter.verify() call.

New regression row in tests/no-unbounded-quantifier.rule.test.cjs
asserts the RuleTester run on a 50000-char adversarial pattern
completes and returns a defined result — no wall-clock assertion
(CLAUDE.md Clock Seams / local/no-elapsed-assertion).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

* fix(#3415): triage 3 new sites, re-raise ceiling after upstream batch

next merged 12 more PRs during this PR's review. Two consequences:

- tests/edit-phase.test.cjs (fix #3262, unrelated) added 3 new
  content.match(/<tag>([\s\S]*?)<\/tag>/) reads of this repo's own
  workflow .md content — the same Class A pattern as the ~159 sites
  already triaged elsewhere in this PR. Suppressed with the same
  established reason.
- lint-allow-test-rule-refs' ratchet ceiling needed re-raising again
  (301 -> 303) for the same reason as the two prior bumps: organic
  growth from unrelated, already-reviewed PRs landing concurrently,
  not a defect in this branch's own diff.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

---------

Co-authored-by: sim <sim@local>
Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
2026-08-14 10:02:28 -04:00

148 lines
5.9 KiB
JavaScript

/**
* progress workflow — MVP mode display contract test
*/
const { test, describe } = require('node:test');
const assert = require('node:assert/strict');
const fs = require('fs');
const path = require('path');
const WORKFLOW = path.join(__dirname, '..', 'gsd-core', 'workflows', 'progress.md');
const PROGRESS_STEPS_DIR = path.join(__dirname, '..', 'gsd-core', 'workflows', 'progress', 'steps');
/**
* progress.md was fragmented (#2994) into gsd-core/workflows/progress/steps/*.md.
* The mvp_display step (and its MVP-mode display contract) now lives in
* progress/steps/mvp-display.md, only read at all when state:phase-mvp-mode is
* true. Read host + every step file combined so this contract guard keeps
* seeing the full picture regardless of which file the content physically
* lives in.
*/
function readProgressCombined() {
let combined = fs.readFileSync(WORKFLOW, 'utf8');
if (fs.existsSync(PROGRESS_STEPS_DIR)) {
for (const entry of fs.readdirSync(PROGRESS_STEPS_DIR).sort()) {
if (entry.endsWith('.md')) {
combined += '\n' + fs.readFileSync(path.join(PROGRESS_STEPS_DIR, entry), 'utf8');
}
}
}
return combined;
}
function parseProgressContract(content) {
const lines = content.split(/\r?\n/);
const lowerLines = lines.map(line => line.toLowerCase());
return {
hasMvpModeVariable: lowerLines.some(line => line.includes('mvp_mode')),
usesPhaseMvpVerb: lowerLines.some(line => line.includes('phase.mvp-mode')),
sourcesPlanTasks: lowerLines.some(line => line.includes('plan.md') && line.includes('task')),
usesUserFlowLanguage: lowerLines.some(line => line.includes('user-flow') || line.includes('user-visible')),
hasStandardFallback: lowerLines.some(line =>
(line.includes('mode') && (line.includes('null') || line.includes('absent') || line.includes('not mvp'))) ||
(line.includes('standard') && line.includes('display'))
),
};
}
describe('progress — MVP mode display', () => {
const contract = parseProgressContract(readProgressCombined());
test('workflow declares MVP_MODE branch', () => {
assert.ok(contract.hasMvpModeVariable, 'must declare MVP_MODE');
assert.ok(contract.usesPhaseMvpVerb, 'must resolve MVP mode via the centralized phase.mvp-mode verb');
});
test('MVP display sources user-flow status from PLAN.md task names', () => {
assert.ok(contract.sourcesPlanTasks, 'must source user-flow status from PLAN.md tasks');
assert.ok(contract.usesUserFlowLanguage, 'must use user-flow framing');
});
test('falls back to standard display when mode null', () => {
assert.ok(contract.hasStandardFallback, 'must specify fallback when mode is not mvp');
});
});
// ────────────────────────────────────────────────────────────────────────
// Folded from tests/bug-14-progress-auto-flag-dropped.test.cjs — consolidation epic #1969 (B3 #1972)
// ────────────────────────────────────────────────────────────────────────
{
const { describe: __foldDescribe } = require('node:test');
__foldDescribe("folded:bug-14-progress-auto-flag-dropped (consolidation epic #1969 B3 #1972)", () => {
// allow-test-rule: source-text-is-the-product (see #14)
// The command markdown is loaded directly by runtime prompt assembly.
// This test verifies that --auto is documented in progress.md and handled in next.md.
'use strict';
const { test, describe } = require('node:test');
const assert = require('node:assert/strict');
const fs = require('node:fs');
const path = require('node:path');
const ROOT = path.join(__dirname, '..');
describe('#14: /gsd:progress --next --auto flag must be documented and propagated', () => {
test('progress.md <flags> section documents --auto flag', () => {
const command = fs.readFileSync(
path.join(ROOT, 'commands', 'gsd', 'progress.md'),
'utf8'
);
assert.ok(
command.includes('--auto'),
'progress.md must document the --auto flag in the <flags> section'
);
});
test('progress.md <process> block explicitly passes --auto through to next workflow', () => {
const command = fs.readFileSync(
path.join(ROOT, 'commands', 'gsd', 'progress.md'),
'utf8'
);
// Extract only the <process>…</process> block so this assertion is
// scoped to the handoff wiring, not just any occurrence in the file.
// eslint-disable-next-line local/no-unbounded-quantifier -- parses this repo's own command .md content, fixed-size author-controlled content
const processMatch = command.match(/<process>([\s\S]*?)<\/process>/);
assert.ok(
processMatch,
'progress.md must contain a <process> block'
);
const processBlock = processMatch[1];
assert.ok(
processBlock.includes('--auto'),
'progress.md <process> block must explicitly mention --auto so it is not silently stripped at the --next handoff'
);
});
test('next.md show_and_execute step handles --auto to chain steps', () => {
const workflow = fs.readFileSync(
path.join(ROOT, 'gsd-core', 'workflows', 'next.md'),
'utf8'
);
assert.ok(
workflow.includes('--auto'),
'next.md must handle the --auto flag to chain step invocations automatically'
);
});
test('next.md --auto chaining re-invokes /gsd:progress --next after step completion', () => {
const workflow = fs.readFileSync(
path.join(ROOT, 'gsd-core', 'workflows', 'next.md'),
'utf8'
);
// The workflow must contain instructions to re-invoke /gsd:progress --next --auto
// after the determined step completes, enabling the chain.
assert.ok(
workflow.includes('--next --auto'),
'next.md must instruct re-invocation of /gsd:progress --next --auto after step completion to enable chaining'
);
});
});
});
}