7dd9e59f6b
An allow-test-rule annotation citing a category that does not apply is worse than no annotation, because it reads as reviewed. Eight were confirmed by reading the assertions each one covered, and auditing the rest found five more plus one refutation — a converter test whose wording described the wrong mechanism while the covered assertion genuinely was deployed-text. The instructive one used the CANONICAL string for the same mistake: STATE.md command output labelled as a deployed artifact. A canonical string is not evidence the category fits, which is why normalising strings alone would have laundered the problem rather than fixed it. Every mapping the audit had inferred rather than code-verified was spot-checked before rewriting, and the ones that turned out not to fit were re-annotated rather than relabelled. Fourteen STATE.md assertions had a typed extractor available all along and now use it; their annotations came out because nothing needs exempting. Eight assertions genuinely need a production change first — CLI stdout and stderr with no structured mode — and are tagged pending-migration-to-typed-ir citing #3090, which is what that category is for. It had zero real uses before this, while one file carried a real citation to migration issue #2974 under a non-canonical tag. Six annotations covered assertions that do no text matching at all. An exemption for a violation that does not exist is noise that makes the real ones harder to audit; those are removed. atomic-write-coverage gains the annotation it always warranted — its own docstring describes a structural-regression-guard while the file carried none. Fifty-nine non-canonical strings across roughly thirty files are normalised, and the allow-test-rule allowlist is regenerated to match. 472 annotations became 463: every one now uses a canonical category, and the two remaining non-canonical strings are ESLint RuleTester fixtures, not annotations. Refs #3057 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
71 lines
2.9 KiB
JavaScript
71 lines
2.9 KiB
JavaScript
/**
|
|
* Regression (#498, adversarial-review finding): the custom-file backup step in
|
|
* update.md must derive RUNTIME_DIR from GSD_DIR.
|
|
*
|
|
* The get_installed_version step was rewritten to call `gsd-tools update-context`
|
|
* and now emits GSD_DIR (the resolved config dir) instead of the old probe-loop
|
|
* variables LOCAL_DIR / GLOBAL_DIR. The backup_custom_files step still read
|
|
* LOCAL_DIR / GLOBAL_DIR, which are no longer assigned anywhere — so RUNTIME_DIR
|
|
* went empty for every LOCAL/GLOBAL install and detect-custom-files was skipped.
|
|
* Because the update then runs a clean install that wipes managed dirs
|
|
* (commands/gsd, gsd-core), user-added files inside those dirs could be
|
|
* deleted without the intended backup.
|
|
*
|
|
* This locks the fix: RUNTIME_DIR comes from GSD_DIR, and the dead LOCAL_DIR /
|
|
* GLOBAL_DIR references are gone.
|
|
*
|
|
* Source-text-is-the-product: update.md's bash blocks ARE the deployed /gsd:update
|
|
* program; asserting their shape is asserting on the deployed contract.
|
|
*/
|
|
|
|
// allow-test-rule: source-text-is-the-product
|
|
// update.md's bash blocks ARE the deployed /gsd:update program; asserting
|
|
// their shape is asserting on the deployed contract. The data-loss behavior
|
|
// only manifests against a real install during a clean reinstall, which CI
|
|
// does not perform.
|
|
|
|
'use strict';
|
|
|
|
const { describe, test } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('node:fs');
|
|
const path = require('node:path');
|
|
|
|
const UPDATE_MD = path.join(__dirname, '..', 'gsd-core', 'workflows', 'update.md');
|
|
|
|
function codeOnly(file) {
|
|
// Strip fenced-block prose is unnecessary here; we assert on the whole doc
|
|
// but ignore markdown comment prose by only matching shell-assignment forms.
|
|
return fs.readFileSync(file, 'utf8');
|
|
}
|
|
|
|
describe('#498 regression: update.md backup uses GSD_DIR, not the removed LOCAL_DIR/GLOBAL_DIR', () => {
|
|
const src = codeOnly(UPDATE_MD);
|
|
|
|
test('RUNTIME_DIR is assigned from GSD_DIR', () => {
|
|
assert.match(
|
|
src,
|
|
/RUNTIME_DIR="\$GSD_DIR"/,
|
|
'backup_custom_files must set RUNTIME_DIR="$GSD_DIR" (the resolved config dir from update-context)',
|
|
);
|
|
});
|
|
|
|
test('no shell assignment reads the removed LOCAL_DIR/GLOBAL_DIR probe variables', () => {
|
|
// The get_installed_version rewrite no longer assigns LOCAL_DIR/GLOBAL_DIR.
|
|
// Any RUNTIME_DIR="$LOCAL_DIR" / "$GLOBAL_DIR" would silently resolve to empty.
|
|
assert.doesNotMatch(
|
|
src,
|
|
/="\$(LOCAL_DIR|GLOBAL_DIR)"/,
|
|
'update.md still reads LOCAL_DIR/GLOBAL_DIR, which get_installed_version no longer sets — backup will be skipped',
|
|
);
|
|
});
|
|
|
|
test('detect-custom-files stays gated on a non-empty RUNTIME_DIR', () => {
|
|
assert.match(
|
|
src,
|
|
/\[ -n "\$RUNTIME_DIR" \][\s\S]*?detect-custom-files --config-dir "\$RUNTIME_DIR"/,
|
|
'backup must still skip when RUNTIME_DIR is empty (UNKNOWN scope)',
|
|
);
|
|
});
|
|
});
|