Files
msd-core/tests/next-up-clear-order.test.cjs
Tom Boucher 2c32e8d890 test(#1973): consolidate 48 workflow regression tests into workflow-aspect suites
Fold 48 issue-named workflow-markdown regression files into the canonical test
that owns each workflow aspect (execute-phase-*, plan-phase-*, quick-*, discuss-*,
worktree-cleanup, secure-phase, verify, update, settings, etc.), across 32 existing
suites. Verbatim block-scoped describe wrappers; 281 subtests conserved 1:1. No new
test files. Host-env pre-check: only gsd-settings-advanced spawns CLI and it sets no
GSD_WORKSTREAM/GSD_PROJECT value — no leak risk.

Regenerates regression-name allowlist (222->181), ratchets file-count allowlist
(verify 11->10), makes 30 relocated allow-test-rule exemptions issue-ref-compliant
(ADR-456; prunes 30 stale ids). lint:ci green.

Part of epic #1969. Closes #1973.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-03 09:17:32 -04:00

207 lines
7.3 KiB
JavaScript

// allow-test-rule: source-text-is-the-product
// Workflow .md / agent .md / command .md / reference .md files — their text
// IS what the runtime loads. Testing text content tests the deployed contract.
// Per CONTRIBUTING.md exception matrix.
'use strict';
/**
* Next Up /clear Order Tests (#1623)
*
* Validates that /clear always appears BEFORE the command in Next Up blocks,
* not as a <sub> footnote after the command. Users should see /clear first
* so they run it before copy-pasting the actual command.
*/
const { test, describe } = require('node:test');
const assert = require('node:assert/strict');
const fs = require('fs');
const path = require('path');
const GSD_ROOT = path.join(__dirname, '..', 'gsd-core');
const UI_BRAND = path.join(GSD_ROOT, 'references', 'ui-brand.md');
const CONTINUATION_FORMAT = path.join(GSD_ROOT, 'references', 'continuation-format.md');
const WORKFLOWS_DIR = path.join(GSD_ROOT, 'workflows');
/**
* Recursively collect all .md files in a directory.
*/
function collectMarkdownFiles(dir) {
const results = [];
if (!fs.existsSync(dir)) return results;
for (const entry of fs.readdirSync(dir, { withFileTypes: true })) {
const full = path.join(dir, entry.name);
if (entry.isDirectory()) {
results.push(...collectMarkdownFiles(full));
} else if (entry.name.endsWith('.md')) {
results.push(full);
}
}
return results;
}
describe('ui-brand.md — Next Up template has /clear before command', () => {
const content = fs.readFileSync(UI_BRAND, 'utf-8');
test('Next Up block template does not use <sub>/clear pattern', () => {
const subClearPattern = /<sub>[^<]*\/clear[^<]*<\/sub>/gi;
const matches = content.match(subClearPattern);
assert.strictEqual(
matches,
null,
'ui-brand.md must not contain <sub>/clear</sub> pattern — /clear should appear before the command'
);
});
test('Next Up block template shows /clear then: before {copy-paste command}', () => {
// Extract the Next Up Block section
const nextUpSection = content.slice(
content.indexOf('## Next Up Block'),
content.indexOf('## Error Box')
);
assert.ok(nextUpSection.length > 0, 'Should find Next Up Block section');
const clearIndex = nextUpSection.indexOf('/clear');
const commandIndex = nextUpSection.indexOf('{copy-paste command}');
assert.ok(clearIndex > -1, 'Should contain /clear');
assert.ok(commandIndex > -1, 'Should contain {copy-paste command}');
assert.ok(
clearIndex < commandIndex,
`/clear (at ${clearIndex}) must appear before {copy-paste command} (at ${commandIndex})`
);
});
});
describe('continuation-format.md — Next Up examples have /clear before commands', () => {
const content = fs.readFileSync(CONTINUATION_FORMAT, 'utf-8');
test('no <sub>/clear patterns remain', () => {
const subClearPattern = /<sub>[^<]*\/clear[^<]*<\/sub>/gi;
const matches = content.match(subClearPattern);
assert.strictEqual(
matches,
null,
'continuation-format.md must not contain <sub>/clear</sub> pattern'
);
});
});
describe('workflow files — no <sub>/clear patterns in Next Up blocks', () => {
const workflowFiles = collectMarkdownFiles(WORKFLOWS_DIR);
test('found workflow .md files to scan', () => {
assert.ok(
workflowFiles.length > 0,
`Expected workflow .md files in ${WORKFLOWS_DIR}`
);
});
test('no workflow file contains <sub> with /clear', () => {
const subClearPattern = /<sub>[^<]*\/clear[^<]*<\/sub>/gi;
const failures = [];
for (const filePath of workflowFiles) {
const content = fs.readFileSync(filePath, 'utf-8');
const matches = content.match(subClearPattern);
if (matches) {
failures.push({
file: path.relative(GSD_ROOT, filePath),
matches: matches.length,
examples: matches.slice(0, 3),
});
}
}
assert.strictEqual(
failures.length,
0,
`Found <sub>/clear</sub> pattern in ${failures.length} workflow file(s):\n` +
failures
.map(
(f) =>
` ${f.file}: ${f.matches} match(es) — e.g. ${f.examples[0]}`
)
.join('\n')
);
});
});
describe('reference files — no <sub>/clear patterns', () => {
const referencesDir = path.join(GSD_ROOT, 'references');
const refFiles = collectMarkdownFiles(referencesDir);
test('found reference .md files to scan', () => {
assert.ok(
refFiles.length > 0,
`Expected reference .md files in ${referencesDir}`
);
});
test('no reference file contains <sub> with /clear', () => {
const subClearPattern = /<sub>[^<]*\/clear[^<]*<\/sub>/gi;
const failures = [];
for (const filePath of refFiles) {
const content = fs.readFileSync(filePath, 'utf-8');
const matches = content.match(subClearPattern);
if (matches) {
failures.push({
file: path.relative(GSD_ROOT, filePath),
matches: matches.length,
examples: matches.slice(0, 3),
});
}
}
assert.strictEqual(
failures.length,
0,
`Found <sub>/clear</sub> pattern in ${failures.length} reference file(s):\n` +
failures
.map(
(f) =>
` ${f.file}: ${f.matches} match(es) — e.g. ${f.examples[0]}`
)
.join('\n')
);
});
});
// ────────────────────────────────────────────────────────────────────────
// Folded from tests/bug-3083-resume-route-clear.test.cjs — consolidation epic #1969 (B4 #1973)
// ────────────────────────────────────────────────────────────────────────
{
const { describe: __foldDescribe } = require('node:test');
__foldDescribe("folded:bug-3083-resume-route-clear (consolidation epic #1969 B4 #1973)", () => {
'use strict';
const { test, describe } = require('node:test');
const assert = require('node:assert/strict');
const fs = require('node:fs');
const path = require('node:path');
describe('bug #3083: resume-project next-step routing should not include /clear then:', () => {
test('route_to_workflow block omits /clear then: in resume templates', () => {
const workflowPath = path.join(__dirname, '..', 'gsd-core', 'workflows', 'resume-project.md');
const content = fs.readFileSync(workflowPath, 'utf-8');
const routeStart = content.indexOf('<step name="route_to_workflow">');
const routeEnd = content.indexOf('</step>', routeStart);
const routeBlock = content.slice(routeStart, routeEnd);
assert.equal(routeBlock.includes('/clear` then:'), false, 'resume route templates must not include `/clear` then:');
});
test('route_to_workflow block includes exception note explaining resume behavior', () => {
const workflowPath = path.join(__dirname, '..', 'gsd-core', 'workflows', 'resume-project.md');
const content = fs.readFileSync(workflowPath, 'utf-8');
const routeStart = content.indexOf('<step name="route_to_workflow">');
const routeEnd = content.indexOf('</step>', routeStart);
const routeBlock = content.slice(routeStart, routeEnd);
assert.match(routeBlock, /resume.*exception|exception.*resume/i);
});
});
});
}