Files
msd-core/tests/planner-decomposition.test.cjs
Tom Boucher 46d9c26158 fix(agents): modular decomposition of gsd-planner.md to solve 50K char limit (#1612)
* test: add failing tests for planner modular decomposition

- Assert gsd-planner.md is under 45K after extraction (currently ~50K)
- Assert three reference files exist (gap-closure, revision, reviews)
- Assert planner contains reference pointers to each extracted file
- Assert each reference file contains key content from the original mode

* feat(agents): modular decomposition of gsd-planner.md to fix 50K char limit

Extracts three non-standard mode sections from gsd-planner.md into dedicated
reference files loaded on-demand, and calibrates the security scanner to use
a per-file-type threshold (100K for agent source files vs 50K for user input).

Structural changes:
- Extract <gap_closure_mode> → get-shit-done/references/planner-gap-closure.md
- Extract <revision_mode> → get-shit-done/references/planner-revision.md
- Extract <reviews_mode> → get-shit-done/references/planner-reviews.md
- Add <load_mode_context> step in execution_flow (conditional lazy loading)
- gsd-planner.md: 50,112 → 45,352 chars (well under new 45K target)

Security scanner fix:
- Split agent file check: injection patterns (unchanged) + separate 100K size limit
- The 50K strict-mode limit was designed for user-supplied input, not trusted source files
- Agent files still have a size guard to catch accidental bloat

Partially addresses #1495

* fix(tests): normalize CRLF before measuring planner file size

Windows git checkouts add \r per line, inflating String.length by ~1150 chars
for a 1,400-line file. The 45K threshold test failed on windows-latest because
45,352 chars (Linux) became 46,507 chars (Windows). Apply the same CRLF
normalization pattern used in tests/reachability-check.test.cjs.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-04-03 13:32:05 -04:00

136 lines
6.2 KiB
JavaScript

/**
* Tests for modular decomposition of agents/gsd-planner.md
*
* Verifies that:
* 1. gsd-planner.md stays under the 100K agent file threshold
* 2. gsd-planner.md is under 45K chars (proving the three mode sections were extracted)
* 3. The three reference files exist
* 4. gsd-planner.md contains reference pointers to each extracted file
* 5. Each reference file contains key content from the original mode section
*/
'use strict';
const { describe, test } = require('node:test');
const assert = require('node:assert/strict');
const fs = require('fs');
const path = require('path');
const PROJECT_ROOT = path.join(__dirname, '..');
// ─── Size thresholds ─────────────────────────────────────────────────────────
const AGENT_FILE_SIZE_LIMIT = 100 * 1024; // 100K — appropriate for version-controlled source
const PLANNER_EXTRACTED_LIMIT = 45 * 1024; // 45K — proves extraction happened
// ─── File paths ──────────────────────────────────────────────────────────────
const PLANNER_PATH = path.join(PROJECT_ROOT, 'agents', 'gsd-planner.md');
const GAP_CLOSURE_REF = path.join(PROJECT_ROOT, 'get-shit-done', 'references', 'planner-gap-closure.md');
const REVISION_REF = path.join(PROJECT_ROOT, 'get-shit-done', 'references', 'planner-revision.md');
const REVIEWS_REF = path.join(PROJECT_ROOT, 'get-shit-done', 'references', 'planner-reviews.md');
// ─── gsd-planner.md size ─────────────────────────────────────────────────────
describe('gsd-planner.md size constraints', () => {
test('planner file exists', () => {
assert.ok(fs.existsSync(PLANNER_PATH), `Missing: ${PLANNER_PATH}`);
});
test('planner is under 100K chars (agent file threshold)', () => {
const raw = fs.readFileSync(PLANNER_PATH, 'utf-8');
// Normalize CRLF → LF before measuring — Windows checkouts inflate length by ~1 char/line
const content = raw.replace(/\r\n/g, '\n').replace(/\r/g, '\n');
assert.ok(
content.length < AGENT_FILE_SIZE_LIMIT,
`gsd-planner.md is ${content.length} chars, exceeds 100K agent threshold`
);
});
test('planner is under 45K chars (proves mode sections were extracted)', () => {
const raw = fs.readFileSync(PLANNER_PATH, 'utf-8');
// Normalize CRLF → LF before measuring — Windows checkouts inflate length by ~1 char/line
const content = raw.replace(/\r\n/g, '\n').replace(/\r/g, '\n');
assert.ok(
content.length < PLANNER_EXTRACTED_LIMIT,
`gsd-planner.md is ${content.length} chars, expected < 45K after extracting mode sections`
);
});
});
// ─── Reference files exist ───────────────────────────────────────────────────
describe('extracted reference files exist', () => {
test('planner-gap-closure.md exists', () => {
assert.ok(fs.existsSync(GAP_CLOSURE_REF), `Missing: ${GAP_CLOSURE_REF}`);
});
test('planner-revision.md exists', () => {
assert.ok(fs.existsSync(REVISION_REF), `Missing: ${REVISION_REF}`);
});
test('planner-reviews.md exists', () => {
assert.ok(fs.existsSync(REVIEWS_REF), `Missing: ${REVIEWS_REF}`);
});
});
// ─── gsd-planner.md contains reference pointers ──────────────────────────────
describe('gsd-planner.md contains reference pointers to extracted files', () => {
let plannerContent;
test('planner references planner-gap-closure.md', () => {
plannerContent = plannerContent || fs.readFileSync(PLANNER_PATH, 'utf-8');
assert.ok(
plannerContent.includes('planner-gap-closure.md'),
'gsd-planner.md must reference planner-gap-closure.md'
);
});
test('planner references planner-revision.md', () => {
plannerContent = plannerContent || fs.readFileSync(PLANNER_PATH, 'utf-8');
assert.ok(
plannerContent.includes('planner-revision.md'),
'gsd-planner.md must reference planner-revision.md'
);
});
test('planner references planner-reviews.md', () => {
plannerContent = plannerContent || fs.readFileSync(PLANNER_PATH, 'utf-8');
assert.ok(
plannerContent.includes('planner-reviews.md'),
'gsd-planner.md must reference planner-reviews.md'
);
});
});
// ─── Reference files contain key content ────────────────────────────────────
describe('reference files contain key content from original mode sections', () => {
test('planner-gap-closure.md contains gap closure content', () => {
const content = fs.readFileSync(GAP_CLOSURE_REF, 'utf-8');
const hasGapContent = content.toLowerCase().includes('gap_closure') ||
content.toLowerCase().includes('gap closure') ||
content.includes('GAP CLOSURE') ||
content.includes('--gaps');
assert.ok(hasGapContent, 'planner-gap-closure.md must contain gap closure mode content');
});
test('planner-revision.md contains revision content', () => {
const content = fs.readFileSync(REVISION_REF, 'utf-8');
const hasRevisionContent = content.includes('revision') ||
content.includes('Revision') ||
content.includes('REVISION') ||
content.includes('revision_context');
assert.ok(hasRevisionContent, 'planner-revision.md must contain revision mode content');
});
test('planner-reviews.md contains reviews content', () => {
const content = fs.readFileSync(REVIEWS_REF, 'utf-8');
const hasReviewsContent = content.includes('reviews') ||
content.includes('Reviews') ||
content.includes('REVIEWS') ||
content.includes('REVIEWS.md');
assert.ok(hasReviewsContent, 'planner-reviews.md must contain reviews mode content');
});
});