40ce95f882
* fix(#2358): scope review workflow temp files to a per-run mktemp dir /gsd-review wrote every prompt/section/output temp file to a hardcoded /tmp path keyed only on the phase number, so two GSD projects sharing a small phase number collide on the exact same path and a crashed run's leftover file becomes bait a later, unrelated run can silently read. ship.md's external peer-review stderr capture was strictly worse — one shared, unqualified path across every project/phase/run. Thread a single mktemp -d "${TMPDIR:-/tmp}/gsd-review.XXXXXX" run directory through every review.md temp path (67 sites) via a new {run_dir}/$RUN_DIR placeholder, mirroring the existing {phase} substitution mechanism, and clean it up at the end of the run. Route ship.md's stderr capture through a per-run mktemp file the same way. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * chore(#2358): regenerate fixtures + lint gate-prep * fix(#2358): repair failing tests after gate verification * fix(#2358): thread RUN_DIR scoping into reviewer-instances.md (#1517) review.md's own invoke_reviewers step lazily loads gsd-core/references/reviewer-instances.md for the review.reviewer_instances codepath, but that doc was missed when review.md and ship.md were moved to the run-scoped {run_dir} temp directory. It still read the combined prompt from the old /tmp/gsd-review-prompt-{phase}.md (which build_prompt no longer writes, breaking reviewer-instances functionality outright) and wrote each instance's output to the old unscoped /tmp/gsd-review-${INSTANCE_NAME}-{phase}.md, leaving the exact cross-project temp-file collision bug open for that code path. Both paths now thread through {run_dir}, matching every other reviewer block in review.md. Extends the existing #2358 regression test with assertions pinning reviewer-instances.md's prompt read and output write to {run_dir}, and adds the Fixed changeset fragment. Regenerated the golden-install-parity content hashes for reviewer-instances.md via `npm run gen:golden` (paths unchanged; only the modified file's hash moved). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * chore(#2358): backfill changeset pr (#2433) --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
94 lines
2.4 KiB
JSON
94 lines
2.4 KiB
JSON
{
|
|
"add-backlog.md": 7176,
|
|
"add-phase.md": 7578,
|
|
"add-tests.md": 16961,
|
|
"add-todo.md": 10734,
|
|
"ai-integration-phase.md": 15134,
|
|
"analyze-dependencies.md": 3887,
|
|
"audit-fix.md": 11723,
|
|
"audit-milestone.md": 18448,
|
|
"audit-uat.md": 7469,
|
|
"autonomous.md": 42474,
|
|
"check-todos.md": 9475,
|
|
"cleanup.md": 9941,
|
|
"code-review-fix.md": 24320,
|
|
"code-review.md": 32504,
|
|
"complete-milestone.md": 31071,
|
|
"debug.md": 19031,
|
|
"diagnose-issues.md": 12864,
|
|
"discovery-phase.md": 8651,
|
|
"discuss-phase-assumptions.md": 27302,
|
|
"discuss-phase-power.md": 11273,
|
|
"discuss-phase.md": 31986,
|
|
"do.md": 10353,
|
|
"docs-update.md": 55706,
|
|
"edit-phase.md": 12927,
|
|
"eval-review.md": 9967,
|
|
"execute-phase.md": 93376,
|
|
"execute-plan.md": 34262,
|
|
"explore.md": 10541,
|
|
"extract-learnings.md": 12893,
|
|
"fast.md": 7613,
|
|
"forensics.md": 12531,
|
|
"graduation.md": 11622,
|
|
"health.md": 11868,
|
|
"help.md": 1722,
|
|
"import.md": 14648,
|
|
"inbox.md": 14407,
|
|
"ingest-docs.md": 18380,
|
|
"insert-phase.md": 8987,
|
|
"list-phase-assumptions.md": 4305,
|
|
"list-seeds.md": 6987,
|
|
"list-workspaces.md": 5699,
|
|
"manager.md": 27302,
|
|
"map-codebase.md": 20833,
|
|
"milestone-summary.md": 11842,
|
|
"mvp-phase.md": 13626,
|
|
"new-milestone.md": 37581,
|
|
"new-project.md": 66182,
|
|
"new-workspace.md": 11298,
|
|
"next.md": 20138,
|
|
"node-repair.md": 4173,
|
|
"note.md": 6563,
|
|
"onboard.md": 8590,
|
|
"pause-work.md": 14441,
|
|
"plan-milestone-gaps.md": 11809,
|
|
"plan-phase.md": 94387,
|
|
"plan-review-convergence.md": 23713,
|
|
"plant-seed.md": 11785,
|
|
"pr-branch.md": 15963,
|
|
"profile-user.md": 21246,
|
|
"progress.md": 31789,
|
|
"quick.md": 50699,
|
|
"reapply-patches.md": 20312,
|
|
"remove-phase.md": 8513,
|
|
"remove-workspace.md": 7551,
|
|
"resume-project.md": 17270,
|
|
"review.md": 50497,
|
|
"scan.md": 7732,
|
|
"secure-phase.md": 13622,
|
|
"session-report.md": 4044,
|
|
"settings-advanced.md": 40019,
|
|
"settings-integrations.md": 15892,
|
|
"settings.md": 33467,
|
|
"ship.md": 25555,
|
|
"sketch-wrap-up.md": 14267,
|
|
"sketch.md": 20004,
|
|
"smart-entry.md": 11124,
|
|
"spec-phase.md": 31987,
|
|
"spike-wrap-up.md": 15136,
|
|
"spike.md": 24561,
|
|
"stats.md": 6762,
|
|
"sync-skills.md": 6125,
|
|
"thread.md": 12508,
|
|
"transition.md": 22070,
|
|
"ui-phase.md": 26054,
|
|
"ui-review.md": 11216,
|
|
"ultraplan-phase.md": 10512,
|
|
"undo.md": 10431,
|
|
"update.md": 20914,
|
|
"validate-phase.md": 10849,
|
|
"verify-phase.md": 40929,
|
|
"verify-work.md": 40247
|
|
}
|